23766 2009-02-05 12:42:16 -0800 CanvasRenderingContext2D::setShadow needs else for other platforms 2009-02-05 15:41:11 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 0 sky webkit-unassigned oldest_to_newest 108480 0 sky 2009-02-05 12:42:16 -0800 The CMYK variant of CanvasRenderingContext2D::setShadow only updates the GraphicsContext if the platform is GC. There should be an else case for other platforms. 108481 1 27356 sky 2009-02-05 12:47:51 -0800 Created attachment 27356 v1 of patch 108484 2 27356 darin 2009-02-05 12:51:40 -0800 Comment on attachment 27356 v1 of patch I don't like this trend of keeping CG as a special case when making all the other platforms share code. Can we find a way to make the code the same for all the platforms without hurting the rendering quality in CG? 108496 3 27356 eric 2009-02-05 13:22:20 -0800 Comment on attachment 27356 v1 of patch Yeah, this is an OK solution for platforms w/o CYMK support, but it would be bad if used on platforms which did. I feel like this may need a FIXME to note that this should use a smarter color class some day. (We should be able to pass a CYMK color along to graphics context directly w/o having to convert it to RGB here.) The patch looks fine though. 108497 4 sky 2009-02-05 13:22:50 -0800 I'm not a WebKit expert by any means, so take this with a grain of salt. Could we do the following: . Change Color to wrap either an RGBA or CMYKA type ala a union. . Change rgb() such that if the type is cmyka we use makeRGBAFromCMYKA. . For platforms that support CMYK they could test the type, then convert as necessary. 108498 5 27356 eric 2009-02-05 13:22:57 -0800 Comment on attachment 27356 v1 of patch Actually, never mind about the FIXME. When we fix this, we'll just remove the CG code, and everyone will use the path you just added... we'll just make that path not be lossy like it is today. :) 108539 6 dglazkov 2009-02-05 15:41:11 -0800 Landed as http://trac.webkit.org/changeset/40693. 27356 2009-02-05 12:47:51 -0800 2009-02-05 13:22:20 -0800 v1 of patch 23766.patch text/plain 1721 sky SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MDY3NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMDktMDItMDUgIFNjb3R0IFZpb2xldCAgPHNreUBnb29nbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyAy Mzc2NjogQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEOjpzZXRTaGFkb3cgbmVlZHMgZWxzZSBmb3Ig b3RoZXIgcGxhdGZvcm1zCisgICAgICAgIDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjM3NjY+CisKKyAgICAgICAgSW1wbGVtZW50cyB0aGUgQ01ZSyB2YXJpYW50IG9m IENhbnZhc1JlbmRlcmluZ0NvbnRleHQyRDo6c2V0U2hhZG93IGZvcgorICAgICAgICBvdGhlciBw bGF0Zm9ybXMgdXNpbmcgdGhlIENNWUsgY29sb3IgY29uc3RydWN0b3IuCisKKyAgICAgICAgVGhp cyBpcyBjb3ZlcmVkIGJ5IGV4aXN0aW5nIGxheW91dCB0ZXN0cy4KKworICAgICAgICAqIGh0bWwv Q2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNhbnZhc1Jl bmRlcmluZ0NvbnRleHQyRDo6c2V0U2hhZG93KToKKwogMjAwOS0wMi0wNSAgU2FtIFdlaW5pZyAg PHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRl eDogV2ViQ29yZS9odG1sL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyRC5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS9odG1sL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyRC5jcHAJKHJldmlzaW9uIDQw NjczKQorKysgV2ViQ29yZS9odG1sL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyRC5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTg2Nyw3ICs4NjcsNiBAQCB2b2lkIENhbnZhc1JlbmRlcmluZ0NvbnRleHQy RDo6c2V0U2hhZG93CiAgICAgR3JhcGhpY3NDb250ZXh0KiBkYyA9IGRyYXdpbmdDb250ZXh0KCk7 CiAgICAgaWYgKCFkYykKICAgICAgICAgcmV0dXJuOwotICAgIC8vIEZJWE1FOiBEbyB0aGlzIHRo cm91Z2ggcGxhdGZvcm0taW5kZXBlbmRlbnQgR3JhcGhpY3NDb250ZXh0IEFQSS4KICNpZiBQTEFU Rk9STShDRykKICAgICBjb25zdCBDR0Zsb2F0IGNvbXBvbmVudHNbNV0gPSB7IGMsIG0sIHksIGss IGEgfTsKICAgICBDR0NvbG9yU3BhY2VSZWYgY29sb3JTcGFjZSA9IENHQ29sb3JTcGFjZUNyZWF0 ZURldmljZUNNWUsoKTsKQEAgLTg3NSw2ICs4NzQsOCBAQCB2b2lkIENhbnZhc1JlbmRlcmluZ0Nv bnRleHQyRDo6c2V0U2hhZG93CiAgICAgQ0dDb2xvclNwYWNlUmVsZWFzZShjb2xvclNwYWNlKTsK ICAgICBDR0NvbnRleHRTZXRTaGFkb3dXaXRoQ29sb3IoZGMtPnBsYXRmb3JtQ29udGV4dCgpLCBh ZGp1c3RlZFNoYWRvd1NpemUod2lkdGgsIC1oZWlnaHQpLCBibHVyLCBzaGFkb3dDb2xvcik7CiAg ICAgQ0dDb2xvclJlbGVhc2Uoc2hhZG93Q29sb3IpOworI2Vsc2UKKyAgICBkYy0+c2V0U2hhZG93 KEludFNpemUod2lkdGgsIC1oZWlnaHQpLCBibHVyLCBDb2xvcihjLCBtLCB5LCBrLCBhKSk7CiAj ZW5kaWYKIH0KIAo=