237651 2022-03-09 05:27:20 -0800 [web-animations] increase the max number of animatable properties 2022-03-09 05:45:17 -0800 1 1 1 Unclassified WebKit Animations WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 graouts graouts dino graouts koivisto webkit-bug-importer oldest_to_newest 1849650 0 graouts 2022-03-09 05:27:20 -0800 [web-animations] increase the max number of animatable properties 1849651 1 454230 graouts 2022-03-09 05:28:09 -0800 Created attachment 454230 Patch 1849653 2 454230 koivisto 2022-03-09 05:29:57 -0800 Comment on attachment 454230 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454230&action=review > Source/WebCore/animation/CSSPropertyAnimation.cpp:2896 > + COMPILE_ASSERT(animatableLonghandPropertiesCount + animatableShorthandPropertiesCount < USHRT_MAX, numberOfAnimatablePropertiesMustBeLessThanUShrtMax); more modern C++ would say std::numeric_limits<unsigned short>::max() 1849659 3 graouts 2022-03-09 05:44:34 -0800 Committed r291047 (248221@trunk): <https://commits.webkit.org/248221@trunk> 1849661 4 graouts 2022-03-09 05:45:10 -0800 (In reply to Antti Koivisto from comment #2) > Comment on attachment 454230 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=454230&action=review > > > Source/WebCore/animation/CSSPropertyAnimation.cpp:2896 > > + COMPILE_ASSERT(animatableLonghandPropertiesCount + animatableShorthandPropertiesCount < USHRT_MAX, numberOfAnimatablePropertiesMustBeLessThanUShrtMax); > > more modern C++ would say std::numeric_limits<unsigned short>::max() Used that in the commit. Thank you! 1849662 5 webkit-bug-importer 2022-03-09 05:45:17 -0800 <rdar://problem/90026878> 454230 2022-03-09 05:28:09 -0800 2022-03-09 05:29:57 -0800 Patch bug-237651-20220309142808.patch text/plain 2651 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjkxMDQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGRmNzIxMzA3NDY2ZTM0 ZDJmNzFlNjU2ODk3ZjBkZGYxZWJjZTA1Yy4uOTlkYTFiMDkwYzU2YmJjMWM1ZGQ0NzYwNzI3Y2Iz MjgwZjJhZjhmMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIyLTAzLTA5ICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0B3ZWJraXQub3JnPgorCisgICAgICAgIFt3ZWItYW5pbWF0aW9u c10gaW5jcmVhc2UgdGhlIG1heCBudW1iZXIgb2YgYW5pbWF0YWJsZSBwcm9wZXJ0aWVzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzc2NTEKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSd2ZSBydW4gb3V0 IG9mIHNwYWNlIGluIG1fcHJvcGVydHlUb0lkTWFwLCB0aGUgbGltaXQgd2FzIDI1NS4KKworICAg ICAgICAqIGFuaW1hdGlvbi9DU1NQcm9wZXJ0eUFuaW1hdGlvbi5jcHA6CisgICAgICAgIChXZWJD b3JlOjpDU1NQcm9wZXJ0eUFuaW1hdGlvbldyYXBwZXJNYXA6OkNTU1Byb3BlcnR5QW5pbWF0aW9u V3JhcHBlck1hcCk6CisKIDIwMjItMDMtMDkgIEFudG9pbmUgUXVpbnQgIDxncmFvdXRzQHdlYmtp dC5vcmc+CiAKICAgICAgICAgW3dlYi1hbmltYXRpb25zXSBjb2xvci1pbnRlcnBvbGF0aW9uLWZp bHRlcnMgc2hvdWxkIHN1cHBvcnQgZGlzY3JldGUgYW5pbWF0aW9uCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9hbmltYXRpb24vQ1NTUHJvcGVydHlBbmltYXRpb24uY3BwIGIvU291cmNlL1dl YkNvcmUvYW5pbWF0aW9uL0NTU1Byb3BlcnR5QW5pbWF0aW9uLmNwcAppbmRleCA4NDMwMjExNTIw YTNiOGVjZjRmYzczMDc1NThjZDJhNTAwOGU3ZmQwLi5jMTVjODBmZjk1OTA2Y2M3NGY1MmJkZjRi MWFjNTdmY2EwMTIzYjBlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hbmltYXRpb24vQ1NT UHJvcGVydHlBbmltYXRpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2FuaW1hdGlvbi9DU1NQ cm9wZXJ0eUFuaW1hdGlvbi5jcHAKQEAgLTI1NTAsMTUgKzI1NTAsMTUgQEAgcHJpdmF0ZToKICAg ICBDU1NQcm9wZXJ0eUFuaW1hdGlvbldyYXBwZXJNYXAoKTsKICAgICB+Q1NTUHJvcGVydHlBbmlt YXRpb25XcmFwcGVyTWFwKCkgPSBkZWxldGU7CiAKLSAgICB1bnNpZ25lZCBjaGFyJiBpbmRleEZy b21Qcm9wZXJ0eUlEKENTU1Byb3BlcnR5SUQgcHJvcGVydHlJRCkKKyAgICB1bnNpZ25lZCBzaG9y dCYgaW5kZXhGcm9tUHJvcGVydHlJRChDU1NQcm9wZXJ0eUlEIHByb3BlcnR5SUQpCiAgICAgewog ICAgICAgICByZXR1cm4gbV9wcm9wZXJ0eVRvSWRNYXBbcHJvcGVydHlJRCAtIGZpcnN0Q1NTUHJv cGVydHldOwogICAgIH0KIAogICAgIFZlY3RvcjxzdGQ6OnVuaXF1ZV9wdHI8QW5pbWF0aW9uUHJv cGVydHlXcmFwcGVyQmFzZT4+IG1fcHJvcGVydHlXcmFwcGVyczsKLSAgICB1bnNpZ25lZCBjaGFy IG1fcHJvcGVydHlUb0lkTWFwW251bUNTU1Byb3BlcnRpZXNdOworICAgIHVuc2lnbmVkIHNob3J0 IG1fcHJvcGVydHlUb0lkTWFwW251bUNTU1Byb3BlcnRpZXNdOwogCi0gICAgc3RhdGljIGNvbnN0 IHVuc2lnbmVkIGNoYXIgY0ludmFsaWRQcm9wZXJ0eVdyYXBwZXJJbmRleCA9IFVDSEFSX01BWDsK KyAgICBzdGF0aWMgY29uc3QgdW5zaWduZWQgc2hvcnQgY0ludmFsaWRQcm9wZXJ0eVdyYXBwZXJJ bmRleCA9IFVTSFJUX01BWDsKIAogICAgIGZyaWVuZCBjbGFzcyBXVEY6Ok5ldmVyRGVzdHJveWVk PENTU1Byb3BlcnR5QW5pbWF0aW9uV3JhcHBlck1hcD47CiB9OwpAQCAtMjg5Myw3ICsyODkzLDcg QEAgQ1NTUHJvcGVydHlBbmltYXRpb25XcmFwcGVyTWFwOjpDU1NQcm9wZXJ0eUFuaW1hdGlvbldy YXBwZXJNYXAoKQogICAgIGZvciAoaW50IGkgPSAwOyBpIDwgbnVtQ1NTUHJvcGVydGllczsgKytp KQogICAgICAgICBtX3Byb3BlcnR5VG9JZE1hcFtpXSA9IGNJbnZhbGlkUHJvcGVydHlXcmFwcGVy SW5kZXg7CiAKLSAgICBDT01QSUxFX0FTU0VSVChhbmltYXRhYmxlTG9uZ2hhbmRQcm9wZXJ0aWVz Q291bnQgKyBhbmltYXRhYmxlU2hvcnRoYW5kUHJvcGVydGllc0NvdW50IDwgVUNIQVJfTUFYLCBu dW1iZXJPZkFuaW1hdGFibGVQcm9wZXJ0aWVzTXVzdEJlTGVzc1RoYW5VQ2hhck1heCk7CisgICAg Q09NUElMRV9BU1NFUlQoYW5pbWF0YWJsZUxvbmdoYW5kUHJvcGVydGllc0NvdW50ICsgYW5pbWF0 YWJsZVNob3J0aGFuZFByb3BlcnRpZXNDb3VudCA8IFVTSFJUX01BWCwgbnVtYmVyT2ZBbmltYXRh YmxlUHJvcGVydGllc011c3RCZUxlc3NUaGFuVVNocnRNYXgpOwogICAgIG1fcHJvcGVydHlXcmFw cGVycy5yZXNlcnZlSW5pdGlhbENhcGFjaXR5KGFuaW1hdGFibGVMb25naGFuZFByb3BlcnRpZXND b3VudCArIGFuaW1hdGFibGVTaG9ydGhhbmRQcm9wZXJ0aWVzQ291bnQpOwogCiAgICAgLy8gRmly c3Qgd2UgcHV0IHRoZSBub24tc2hvcnRoYW5kIHByb3BlcnR5IHdyYXBwZXJzIGludG8gdGhlIG1h cCwgc28gdGhlIHNob3J0aGFuZC1idWlsZGluZwo=