237627 2022-03-08 16:09:56 -0800 Combine Lookup and Define. 2022-03-09 23:06:19 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 megan_gardner megan_gardner thorton webkit-bug-importer oldest_to_newest 1849460 0 megan_gardner 2022-03-08 16:09:56 -0800 Combine Lookup and Define. 1849461 1 454169 megan_gardner 2022-03-08 16:10:49 -0800 Created attachment 454169 Patch 1849462 2 megan_gardner 2022-03-08 16:10:54 -0800 <rdar://problem/26205225> 1849463 3 454169 thorton 2022-03-08 16:14:34 -0800 Comment on attachment 454169 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454169&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:-4243 > - MCProfileConnection *connection = [PAL::getMCProfileConnectionClass() sharedConnection]; > - if ([connection effectiveBoolValueForSetting:PAL::get_ManagedConfiguration_MCFeatureDefinitionLookupAllowed()] == MCRestrictedBoolExplicitNo) Funny that I don't see equivalent code in _lookupForWebView. Still, since this was dead code until a recent change, we should be OK. Maybe Lookup does it internally? 1849978 4 ews-feeder 2022-03-09 23:06:17 -0800 Committed r291091 (248253@main): <https://commits.webkit.org/248253@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454169. 454169 2022-03-08 16:10:49 -0800 2022-03-09 23:06:18 -0800 Patch bug-237627-20220308161048.patch text/plain 1750 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwOTU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGE1NDU3NDQzYWJmMzRjMGFk NzUxZDkyYzY5YmM5MjMxY2ZmNDhlM2EuLjNlYjFjZWRiODkxOGUwZTk4MzBmZjkxOTkwYzE3MzRl NGU0MGNkZDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjItMDMtMDggIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBDb21iaW5lIExvb2t1 cCBhbmQgRGVmaW5lLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjM3NjI3CisgICAgICAgIHJkYXI6Ly8yNjIwNTIyNQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRW aWV3SW50ZXJhY3Rpb24ubW06CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgX2RlZmluZUZvcldl YlZpZXc6XSk6CisKIDIwMjItMDMtMDcgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4K IAogICAgICAgICBhbGxvdy1jdXN0b20tcHJvdG9jb2xzLW5hdmlnYXRpb24gc2FuZGJveCBmbGFn LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJ bnRlcmFjdGlvbi5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3 SW50ZXJhY3Rpb24ubW0KaW5kZXggOTNmMDkzN2UxY2I5YjgyYjllZTUxNWEzNDg5NmY0NWE3ZDJm NzQ4YS4uZWZkZDUwMzQ3NTg5ZDQ0MTc0MzA2MWM4YmRhN2JlOTlmOWU5N2ExMCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5t bQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0 aW9uLm1tCkBAIC00MjM4LDE5ICs0MjM4LDcgQEAgV0VCQ09SRV9DT01NQU5EX0ZPUl9XRUJWSUVX KHBhc3RlQW5kTWF0Y2hTdHlsZSk7CiAKIC0gKHZvaWQpX2RlZmluZUZvcldlYlZpZXc6KGlkKXNl bmRlcgogewotI2lmICFQTEFURk9STShNQUNDQVRBTFlTVCkKLSAgICBNQ1Byb2ZpbGVDb25uZWN0 aW9uICpjb25uZWN0aW9uID0gW1BBTDo6Z2V0TUNQcm9maWxlQ29ubmVjdGlvbkNsYXNzKCkgc2hh cmVkQ29ubmVjdGlvbl07Ci0gICAgaWYgKFtjb25uZWN0aW9uIGVmZmVjdGl2ZUJvb2xWYWx1ZUZv clNldHRpbmc6UEFMOjpnZXRfTWFuYWdlZENvbmZpZ3VyYXRpb25fTUNGZWF0dXJlRGVmaW5pdGlv bkxvb2t1cEFsbG93ZWQoKV0gPT0gTUNSZXN0cmljdGVkQm9vbEV4cGxpY2l0Tm8pCi0gICAgICAg IHJldHVybjsKLSNlbmRpZgotCi0gICAgUmV0YWluUHRyPFdLQ29udGVudFZpZXc+IHZpZXcgPSBz ZWxmOwotICAgIF9wYWdlLT5nZXRTZWxlY3Rpb25PckNvbnRlbnRzQXNTdHJpbmcoW3ZpZXddKGNv bnN0IFN0cmluZyYgc3RyaW5nKSB7Ci0gICAgICAgIGlmICghc3RyaW5nKQotICAgICAgICAgICAg cmV0dXJuOwotCi0gICAgICAgIFt2aWV3IF9zaG93RGljdGlvbmFyeTpzdHJpbmddOwotICAgIH0p OworICAgIFtzZWxmIF9sb29rdXBGb3JXZWJWaWV3OnNlbmRlcl07CiB9CiAKIC0gKHZvaWQpYWNj ZXNzaWJpbGl0eVJldHJpZXZlU3BlYWtTZWxlY3Rpb25Db250ZW50Cg==