<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>237620</bug_id>
          
          <creation_ts>2022-03-08 15:05:32 -0800</creation_ts>
          <short_desc>Enable CFPrefs direct mode in adattributiond</short_desc>
          <delta_ts>2022-03-08 16:54:21 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Alex Christensen">achristensen</reporter>
          <assigned_to name="Alex Christensen">achristensen</assigned_to>
          <cc>pvollan</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1849413</commentid>
    <comment_count>0</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2022-03-08 15:05:32 -0800</bug_when>
    <thetext>Enable CFPrefs direct mode in adattributiond</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1849416</commentid>
    <comment_count>1</comment_count>
      <attachid>454155</attachid>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2022-03-08 15:08:46 -0800</bug_when>
    <thetext>Created attachment 454155
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1849417</commentid>
    <comment_count>2</comment_count>
      <attachid>454155</attachid>
    <who name="Per Arne Vollan">pvollan</who>
    <bug_when>2022-03-08 15:11:55 -0800</bug_when>
    <thetext>Comment on attachment 454155
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454155&amp;action=review

Nice! R=me.

&gt; Source/WebKit/Shared/EntryPointUtilities/Cocoa/Daemon/PCMDaemonEntryPoint.mm:135
&gt; +        _CFPrefsSetDirectModeEnabled(YES);

You could also enable CF prefs read only mode (_CFPrefsSetReadOnly). Have the CF prefs services already been removed from the sandbox?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1849421</commentid>
    <comment_count>3</comment_count>
      <attachid>454156</attachid>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2022-03-08 15:15:05 -0800</bug_when>
    <thetext>Created attachment 454156
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1849431</commentid>
    <comment_count>4</comment_count>
      <attachid>454156</attachid>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2022-03-08 15:23:45 -0800</bug_when>
    <thetext>Comment on attachment 454156
Patch

They were never added to the sandbox, which is how I found this problem.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1849479</commentid>
    <comment_count>5</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2022-03-08 16:54:00 -0800</bug_when>
    <thetext>Committed r291021 (248195@main): &lt;https://commits.webkit.org/248195@main&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454156.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1849480</commentid>
    <comment_count>6</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-03-08 16:54:21 -0800</bug_when>
    <thetext>&lt;rdar://problem/89998171&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>454155</attachid>
            <date>2022-03-08 15:08:46 -0800</date>
            <delta_ts>2022-03-08 15:15:01 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-237620-20220308150846.patch</filename>
            <type>text/plain</type>
            <size>1963</size>
            <attacher name="Alex Christensen">achristensen</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjkxMDEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGQ5ODYzZWE3NDBjZTJiMDk0
NjlhNGQxYTI1ZmQzYzk2YThkM2ZjNGQuLjY3NWE0ZTBiN2IzMTIwNjcwYmEwY2Y3NmFiNmMzOTI1
NjcwNTdmODkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjItMDMtMDggIEFsZXggQ2hy
aXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBFbmFibGUgQ0ZQ
cmVmcyBkaXJlY3QgbW9kZSBpbiBhZGF0dHJpYnV0aW9uZAorICAgICAgICBodHRwczovL2J1Z3Mu
d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM3NjIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBtYWtlcyBpdCBub3QgdHJ5IHRvIGNvbm5l
Y3QgdG8gY2ZwcmVmc2QsIHdoaWNoIGlzIG5vdCBhbGxvd2VkIGJ5IHRoZSBzYW5kYm94LgorCisg
ICAgICAgICogU2hhcmVkL0VudHJ5UG9pbnRVdGlsaXRpZXMvQ29jb2EvRGFlbW9uL1BDTURhZW1v
bkVudHJ5UG9pbnQubW06CisgICAgICAgIChXZWJLaXQ6OlBDTURhZW1vbk1haW4pOgorCiAyMDIy
LTAzLTA4ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAg
ICBVbnJldmlld2VkLCByZXZlcnRpbmcgcjI5MTAwNi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL
aXQvU2hhcmVkL0VudHJ5UG9pbnRVdGlsaXRpZXMvQ29jb2EvRGFlbW9uL1BDTURhZW1vbkVudHJ5
UG9pbnQubW0gYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9FbnRyeVBvaW50VXRpbGl0aWVzL0NvY29h
L0RhZW1vbi9QQ01EYWVtb25FbnRyeVBvaW50Lm1tCmluZGV4IDEyZWQwMTk0MWE5OTgxNjA1Y2Zh
MDRmMDU0MjgxODY4NTZhNjYyYzIuLjQwNjRiYmVhYjgwODAxNDM1NzViZTRlNDdhODM2ZmI3YmY2
NDYzMjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL0VudHJ5UG9pbnRVdGlsaXRp
ZXMvQ29jb2EvRGFlbW9uL1BDTURhZW1vbkVudHJ5UG9pbnQubW0KKysrIGIvU291cmNlL1dlYktp
dC9TaGFyZWQvRW50cnlQb2ludFV0aWxpdGllcy9Db2NvYS9EYWVtb24vUENNRGFlbW9uRW50cnlQ
b2ludC5tbQpAQCAtMzMsNiArMzMsNyBAQAogI2ltcG9ydCAiUHJpdmF0ZUNsaWNrTWVhc3VyZW1l
bnRNYW5hZ2VySW50ZXJmYWNlLmgiCiAjaW1wb3J0ICJQcml2YXRlQ2xpY2tNZWFzdXJlbWVudFhQ
Q1V0aWxpdGllcy5oIgogI2ltcG9ydCA8Rm91bmRhdGlvbi9Gb3VuZGF0aW9uLmg+CisjaW1wb3J0
IDxwYWwvc3BpL2NmL0NGVXRpbGl0aWVzU1BJLmg+CiAjaW1wb3J0IDx3dGYvQ29tcGxldGlvbkhh
bmRsZXIuaD4KICNpbXBvcnQgPHd0Zi9GaWxlU3lzdGVtLmg+CiAjaW1wb3J0IDx3dGYvSGFzaFNl
dC5oPgpAQCAtMTMwLDYgKzEzMSw5IEBAIGludCBQQ01EYWVtb25NYWluKGludCBhcmdjLCBjb25z
dCBjaGFyKiogYXJndikKICAgICBib29sIHN0YXJ0QWN0aXZpdHkgPSBhcmdjID4gNSAmJiAhc3Ry
Y21wKGFyZ3ZbNV0sICItLXN0YXJ0QWN0aXZpdHkiKTsKIAogICAgIEBhdXRvcmVsZWFzZXBvb2wg
eworI2lmIEVOQUJMRShDRlBSRUZTX0RJUkVDVF9NT0RFKQorICAgICAgICBfQ0ZQcmVmc1NldERp
cmVjdE1vZGVFbmFibGVkKFlFUyk7CisjZW5kaWYKICAgICAgICAgZW50ZXJTYW5kYm94KCk7CiAg
ICAgICAgIHN0YXJ0TGlzdGVuaW5nRm9yTWFjaFNlcnZpY2VDb25uZWN0aW9ucyhtYWNoU2Vydmlj
ZU5hbWUsICJjb20uYXBwbGUucHJpdmF0ZS53ZWJraXQuYWRhdHRyaWJ1dGlvbmQiLCBjb25uZWN0
aW9uQWRkZWQsIGNvbm5lY3Rpb25SZW1vdmVkLCBjb25uZWN0aW9uRXZlbnRIYW5kbGVyKTsKICAg
ICAgICAgaWYgKHN0YXJ0QWN0aXZpdHkpCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>454156</attachid>
            <date>2022-03-08 15:15:05 -0800</date>
            <delta_ts>2022-03-08 16:54:02 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-237620-20220308151504.patch</filename>
            <type>text/plain</type>
            <size>2042</size>
            <attacher name="Alex Christensen">achristensen</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjkxMDEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGQ5ODYzZWE3NDBjZTJiMDk0
NjlhNGQxYTI1ZmQzYzk2YThkM2ZjNGQuLmFhYjIxNGEwOTgyYWI2MjI1M2FkOTJmZTVjYTAzZDM0
ZjA2OGVlNTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjItMDMtMDggIEFsZXggQ2hy
aXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBFbmFibGUgQ0ZQ
cmVmcyBkaXJlY3QgbW9kZSBpbiBhZGF0dHJpYnV0aW9uZAorICAgICAgICBodHRwczovL2J1Z3Mu
d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM3NjIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
UGVyIEFybmUgVm9sbGFuLgorCisgICAgICAgIFRoaXMgbWFrZXMgaXQgbm90IHRyeSB0byBjb25u
ZWN0IHRvIGNmcHJlZnNkLCB3aGljaCBpcyBub3QgYWxsb3dlZCBieSB0aGUgc2FuZGJveC4KKwor
ICAgICAgICAqIFNoYXJlZC9FbnRyeVBvaW50VXRpbGl0aWVzL0NvY29hL0RhZW1vbi9QQ01EYWVt
b25FbnRyeVBvaW50Lm1tOgorICAgICAgICAoV2ViS2l0OjpQQ01EYWVtb25NYWluKToKKwogMjAy
Mi0wMy0wOCAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAg
ICAgVW5yZXZpZXdlZCwgcmV2ZXJ0aW5nIHIyOTEwMDYuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi
S2l0L1NoYXJlZC9FbnRyeVBvaW50VXRpbGl0aWVzL0NvY29hL0RhZW1vbi9QQ01EYWVtb25FbnRy
eVBvaW50Lm1tIGIvU291cmNlL1dlYktpdC9TaGFyZWQvRW50cnlQb2ludFV0aWxpdGllcy9Db2Nv
YS9EYWVtb24vUENNRGFlbW9uRW50cnlQb2ludC5tbQppbmRleCAxMmVkMDE5NDFhOTk4MTYwNWNm
YTA0ZjA1NDI4MTg2ODU2YTY2MmMyLi4yMGY4YWEzZTg5N2FhMjAyNzJiYTA3ZDk1YWVlMjE1Mzc1
MzgzNDNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9FbnRyeVBvaW50VXRpbGl0
aWVzL0NvY29hL0RhZW1vbi9QQ01EYWVtb25FbnRyeVBvaW50Lm1tCisrKyBiL1NvdXJjZS9XZWJL
aXQvU2hhcmVkL0VudHJ5UG9pbnRVdGlsaXRpZXMvQ29jb2EvRGFlbW9uL1BDTURhZW1vbkVudHJ5
UG9pbnQubW0KQEAgLTMzLDYgKzMzLDcgQEAKICNpbXBvcnQgIlByaXZhdGVDbGlja01lYXN1cmVt
ZW50TWFuYWdlckludGVyZmFjZS5oIgogI2ltcG9ydCAiUHJpdmF0ZUNsaWNrTWVhc3VyZW1lbnRY
UENVdGlsaXRpZXMuaCIKICNpbXBvcnQgPEZvdW5kYXRpb24vRm91bmRhdGlvbi5oPgorI2ltcG9y
dCA8cGFsL3NwaS9jZi9DRlV0aWxpdGllc1NQSS5oPgogI2ltcG9ydCA8d3RmL0NvbXBsZXRpb25I
YW5kbGVyLmg+CiAjaW1wb3J0IDx3dGYvRmlsZVN5c3RlbS5oPgogI2ltcG9ydCA8d3RmL0hhc2hT
ZXQuaD4KQEAgLTEzMCw2ICsxMzEsMTIgQEAgaW50IFBDTURhZW1vbk1haW4oaW50IGFyZ2MsIGNv
bnN0IGNoYXIqKiBhcmd2KQogICAgIGJvb2wgc3RhcnRBY3Rpdml0eSA9IGFyZ2MgPiA1ICYmICFz
dHJjbXAoYXJndls1XSwgIi0tc3RhcnRBY3Rpdml0eSIpOwogCiAgICAgQGF1dG9yZWxlYXNlcG9v
bCB7CisjaWYgRU5BQkxFKENGUFJFRlNfRElSRUNUX01PREUpCisgICAgICAgIF9DRlByZWZzU2V0
RGlyZWN0TW9kZUVuYWJsZWQoWUVTKTsKKyNlbmRpZgorI2lmIEhBVkUoQ0ZfUFJFRlNfU0VUX1JF
QURfT05MWSkKKyAgICAgICAgX0NGUHJlZnNTZXRSZWFkT25seShZRVMpOworI2VuZGlmCiAgICAg
ICAgIGVudGVyU2FuZGJveCgpOwogICAgICAgICBzdGFydExpc3RlbmluZ0Zvck1hY2hTZXJ2aWNl
Q29ubmVjdGlvbnMobWFjaFNlcnZpY2VOYW1lLCAiY29tLmFwcGxlLnByaXZhdGUud2Via2l0LmFk
YXR0cmlidXRpb25kIiwgY29ubmVjdGlvbkFkZGVkLCBjb25uZWN0aW9uUmVtb3ZlZCwgY29ubmVj
dGlvbkV2ZW50SGFuZGxlcik7CiAgICAgICAgIGlmIChzdGFydEFjdGl2aXR5KQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>