237606 2022-03-08 08:17:14 -0800 REGRESSION(r290506): [GTK] GBM dependency breaks build 2022-10-20 09:55:55 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=237886 https://bugs.webkit.org/show_bug.cgi?id=246812 P2 Normal --- 237649 1 jmason webkit-unassigned alex aperez bugs-noreply cgarcia fujii zan zdobersek oldest_to_newest 1849271 0 jmason 2022-03-08 08:17:14 -0800 Building on X11/nVIDIA, USE_ANGLE_WEBGL=OFF I don't have libgbm, and building webkit for me has always succeeded without it. GL seems to work fine; for example, I can run the tanks demo. Now my build fails because GBM does not exist on my system. After removing the GBM dependency introduced by r290506, webkit still builds and runs fine. Is this going to be a hard dependency going forward, because (older) nVIDIA drivers maybe don't have it. 1849406 1 aperez 2022-03-08 14:21:33 -0800 (In reply to Jim Mason from comment #0) > Building on X11/nVIDIA, USE_ANGLE_WEBGL=OFF > > I don't have libgbm, and building webkit for me has always succeeded without > it. GL seems to work fine; for example, I can run the tanks demo. Now my > build fails because GBM does not exist on my system. > > After removing the GBM dependency introduced by r290506, webkit still builds > and runs fine. > > Is this going to be a hard dependency going forward, because (older) nVIDIA > drivers maybe don't have it. There has been some talk internally about making GBM unneeded at build time, and relying on dlopening() it where needed/available at runtime. I wonder if we could make the GBM dependency optional with USE_ANGLE_WEBGL disabled in the meantime, though 🤔️ 1849545 2 zan 2022-03-08 22:41:32 -0800 No, because it will be used outside of ANGLE too. 1849554 3 alex 2022-03-09 00:01:39 -0800 Thanks for the report! In the patch we forgot to add the ` if (USE_ANGLE_WEBGL) ` around the find_package option, but the compilation is correctly guarded. That is why it stops when the library is not found in the system but it compiles and works correctly if you remove the find_package manually, the not ANGLE solution does not require gbm. This was fixed in a commit later here: https://trac.webkit.org/changeset/289575/webkit Just try to update to that commit and it should work. Anyway, As Zan is explaining we are planning to make ANGLE/GBM solution the default one in the near future and focus on working/supporting just that technology for the future. We will maintain the old solution for some time though. 1849557 4 alex 2022-03-09 00:08:34 -0800 (In reply to Alejandro G. Castro from comment #3) > Thanks for the report! > > In the patch we forgot to add the ` if (USE_ANGLE_WEBGL) ` around the > find_package option, but the compilation is correctly guarded. That is why > it stops when the library is not found in the system but it compiles and > works correctly if you remove the find_package manually, the not ANGLE > solution does not require gbm. This was fixed in a commit later here: > > https://trac.webkit.org/changeset/289575/webkit > Oops sorry, this commit was previous to that one :-), so yep, you have to move back to the previous commit because we are already moving to use the technology outside ANGLE. Sorry again for the confusion. I'm keeping the bug open to check more comments about the situation in your configuration for the new solutions. Thanks again! 1849637 5 cgarcia 2022-03-09 04:48:44 -0800 We can't add required packages like r290506. New dependencies should be optional. 1849649 6 zan 2022-03-09 05:25:20 -0800 Even if it makes video playback and WebGL optional down the line? 1849660 7 zan 2022-03-09 05:44:57 -0800 (In reply to Adrian Perez from comment #1) > (In reply to Jim Mason from comment #0) > > Building on X11/nVIDIA, USE_ANGLE_WEBGL=OFF > > > > I don't have libgbm, and building webkit for me has always succeeded without > > it. GL seems to work fine; for example, I can run the tanks demo. Now my > > build fails because GBM does not exist on my system. > > > > After removing the GBM dependency introduced by r290506, webkit still builds > > and runs fine. > > > > Is this going to be a hard dependency going forward, because (older) nVIDIA > > drivers maybe don't have it. > > There has been some talk internally about making GBM unneeded at build > time, and relying on dlopening() it where needed/available at runtime. > This is the end goal but hasn't been started yet. The two libraries were added as deps to not block the ongoing work. 1849663 8 zan 2022-03-09 05:45:48 -0800 (In reply to Zan Dobersek from comment #6) > Even if it makes video playback and WebGL optional down the line? With dlopen()-y solution these two would end up being optional at runtime. 1849664 9 cgarcia 2022-03-09 05:48:20 -0800 (In reply to Zan Dobersek from comment #6) > Even if it makes video playback and WebGL optional down the line? No, that would be a regression. 1851412 10 alex 2022-03-15 11:45:30 -0700 I've commented in the other bug but I'll add it here too to make sure everyone is updated, this week we discussed the way to move forward with the new buffer sharing architecture and we are going to add a new define to guard the gbm code. This will allow to compile without it using the current architecture. 1854088 11 zan 2022-03-23 02:42:18 -0700 Resolved with changes in bug #237974. 1854152 12 jmason 2022-03-23 07:01:58 -0700 (In reply to Zan Dobersek from comment #11) > Resolved with changes in bug #237974. Confirmed, thanks! 1904428 13 jmason 2022-10-10 01:46:59 -0700 This has returned because of this commit: https://commits.webkit.org/254947@main 1907003 14 alex 2022-10-20 02:17:47 -0700 (In reply to Jim Mason from comment #13) > This has returned because of this commit: > > https://commits.webkit.org/254947@main Thanks for reporting! Would you mind creating a different bug and closing this one, it is better for us to handle it that way because it is a different problem added later. 1907083 15 jmason 2022-10-20 09:55:55 -0700 Reopening in new issue as requested.