237565 2022-03-07 16:19:17 -0800 REGRESSION (r290853): CrashTracer: com.apple.WebKit.WebContent.Development at com.apple.WebCore: WebCore::FrameLoader::clear 2022-03-08 08:57:28 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 katherine_cheney katherine_cheney bfulgham cdumez ddkilzer ews-watchlist japhet webkit-bug-importer oldest_to_newest 1849016 0 katherine_cheney 2022-03-07 16:19:17 -0800 REGRESSION (r290853): CrashTracer: com.apple.WebKit.WebContent.Development at com.apple.WebCore: WebCore::FrameLoader::clear 1849021 1 454048 katherine_cheney 2022-03-07 16:24:36 -0800 Created attachment 454048 Patch 1849032 2 454048 ddkilzer 2022-03-07 16:43:15 -0800 Comment on attachment 454048 Patch r=me, but might want an expert in FrameLoader code to review this as well. 1849033 3 ddkilzer 2022-03-07 16:44:20 -0800 <rdar://89923867> 1849037 4 454048 cdumez 2022-03-07 16:58:41 -0800 Comment on attachment 454048 Patch I feel it would have been less risky to change the parameter to use a RefPtr<Document>&& instead of a Document*. 1849057 5 454057 katherine_cheney 2022-03-07 18:18:45 -0800 Created attachment 454057 Patch 1849059 6 454057 cdumez 2022-03-07 18:22:38 -0800 Comment on attachment 454057 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454057&action=review > Source/WebCore/loader/FrameLoader.cpp:623 > +void FrameLoader::clear(RefPtr<Document> newDocument, bool clearWindowProperties, bool clearScriptObjects, bool clearFrameView, Function<void()>&& handleDOMWindowCreation) We should avoid passing parameters my values as much as possible. As suggested on Slack, I think this should be a Ref<Document>&&. > Source/WebCore/loader/FrameLoader.h:155 > + void clear(RefPtr<Document> newDocument, bool clearWindowProperties = true, bool clearScriptObjects = true, bool clearFrameView = true, Function<void()>&& handleDOMWindowCreation = nullptr); ditto. 1849064 7 cdumez 2022-03-07 18:29:54 -0800 (In reply to Chris Dumez from comment #6) > Comment on attachment 454057 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=454057&action=review > > > Source/WebCore/loader/FrameLoader.cpp:623 > > +void FrameLoader::clear(RefPtr<Document> newDocument, bool clearWindowProperties, bool clearScriptObjects, bool clearFrameView, Function<void()>&& handleDOMWindowCreation) > > We should avoid passing parameters my values as much as possible. As > suggested on Slack, I think this should be a Ref<Document>&&. > > > Source/WebCore/loader/FrameLoader.h:155 > > + void clear(RefPtr<Document> newDocument, bool clearWindowProperties = true, bool clearScriptObjects = true, bool clearFrameView = true, Function<void()>&& handleDOMWindowCreation = nullptr); > > ditto. I looked at the call sites, it doesn't look like any can be updated to "move" the RefPtr in and avoid ref-counting churn. That said, I still think it is good practice to take in a Ref<Document>&& as it could potentially be leveraged in the future and there is no cost/drawback. 1849071 8 454057 cdumez 2022-03-07 19:10:13 -0800 Comment on attachment 454057 Patch r=me with the change to Ref<>&& 1849237 9 katherine_cheney 2022-03-08 06:41:57 -0800 (In reply to Chris Dumez from comment #7) > (In reply to Chris Dumez from comment #6) > > Comment on attachment 454057 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=454057&action=review > > > > > Source/WebCore/loader/FrameLoader.cpp:623 > > > +void FrameLoader::clear(RefPtr<Document> newDocument, bool clearWindowProperties, bool clearScriptObjects, bool clearFrameView, Function<void()>&& handleDOMWindowCreation) > > > > We should avoid passing parameters my values as much as possible. As > > suggested on Slack, I think this should be a Ref<Document>&&. > > > > > Source/WebCore/loader/FrameLoader.h:155 > > > + void clear(RefPtr<Document> newDocument, bool clearWindowProperties = true, bool clearScriptObjects = true, bool clearFrameView = true, Function<void()>&& handleDOMWindowCreation = nullptr); > > > > ditto. > > I looked at the call sites, it doesn't look like any can be updated to > "move" the RefPtr in and avoid ref-counting churn. That said, I still think > it is good practice to take in a Ref<Document>&& as it could potentially be > leveraged in the future and there is no cost/drawback. Ah ok, that's why I ended up not using && but you're right about future leveraging. 1849238 10 katherine_cheney 2022-03-08 06:43:35 -0800 (In reply to Chris Dumez from comment #6) > Comment on attachment 454057 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=454057&action=review > > > Source/WebCore/loader/FrameLoader.cpp:623 > > +void FrameLoader::clear(RefPtr<Document> newDocument, bool clearWindowProperties, bool clearScriptObjects, bool clearFrameView, Function<void()>&& handleDOMWindowCreation) > > We should avoid passing parameters my values as much as possible. As > suggested on Slack, I think this should be a Ref<Document>&&. > Assuming you mean RefPtr<Document>&& 1849239 11 454116 katherine_cheney 2022-03-08 06:45:10 -0800 Created attachment 454116 Patch 1849246 12 cdumez 2022-03-08 07:07:55 -0800 (In reply to Kate Cheney from comment #10) > (In reply to Chris Dumez from comment #6) > > Comment on attachment 454057 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=454057&action=review > > > > > Source/WebCore/loader/FrameLoader.cpp:623 > > > +void FrameLoader::clear(RefPtr<Document> newDocument, bool clearWindowProperties, bool clearScriptObjects, bool clearFrameView, Function<void()>&& handleDOMWindowCreation) > > > > We should avoid passing parameters my values as much as possible. As > > suggested on Slack, I think this should be a Ref<Document>&&. > > > > Assuming you mean RefPtr<Document>&& Totally :) 1849291 13 ews-feeder 2022-03-08 08:57:24 -0800 Committed r290994 (248172@main): <https://commits.webkit.org/248172@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454116. 454048 2022-03-07 16:24:36 -0800 2022-03-07 18:18:42 -0800 Patch bug-237565-20220307162435.patch text/plain 2496 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwODMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDgxMTZjY2NjNmNjNDRk ODkwN2RlNGYwNzFmYjY2NGFjNjdjMTRhNi4uZDBlYzBkNDNjMDUxYTdhYTJlZWQ1ZjRkMzllNWI3 ZmIyNmYzMzEwOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIyLTAzLTA3ICBLYXRl IENoZW5leSAgPGthdGhlcmluZV9jaGVuZXlAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJ T04gKHIyOTA4NTMpOiBDcmFzaFRyYWNlcjogY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50LkRl dmVsb3BtZW50IGF0IGNvbS5hcHBsZS5XZWJDb3JlOiBXZWJDb3JlOjpGcmFtZUxvYWRlcjo6Y2xl YXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNzU2 NQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vODgzNTYwNzQ+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBGaXhlcyBjcmFzaGlu ZyB0ZXN0OiBhY2Nlc3NpYmlsaXR5L21hYy92YWx1ZS1jaGFuZ2UvdmFsdWUtY2hhbmdlLXVzZXIt aW5mby10ZXh0YXJlYS5odG1sIAorCisgICAgICAgIG5ld0RvY3VtZW50IG1heSBiZSB0aGUgZnJh bWUncyBkb2N1bWVudC4gV2Ugc2hvdWxkIG5vdCB1c2UgaXQgYWZ0ZXIgc2V0dGluZyB0aGUgZnJh bWUncyBkb2N1bWVudCB0byBudWxscHRyLgorCisgICAgICAgICogbG9hZGVyL0ZyYW1lTG9hZGVy LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9hZGVyOjpjbGVhcik6CisKIDIwMjItMDMt MDQgIEthdGUgQ2hlbmV5ICA8a2F0aGVyaW5lX2NoZW5leUBhcHBsZS5jb20+CiAKICAgICAgICAg YWJvdXQ6YmxhbmsgaWZyYW1lcyBkbyBub3QgYWx3YXlzIGluaGVyaXQgcGFyZW50IENTUApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAKaW5kZXggYjJlN2Y2OGI3MmI3Y2I4Yzc5NWQw ZWZiZmMxYjdhMzE0NWZjN2FiOC4uMmFiZjgwZmYwMDE1ZjQ1MjliMmZhN2ZkNWUyOWY4NTE5M2Y0 NjgzZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCkBAIC02NTUsMjMgKzY1 NSwyMyBAQCB2b2lkIEZyYW1lTG9hZGVyOjpjbGVhcihEb2N1bWVudCogbmV3RG9jdW1lbnQsIGJv b2wgY2xlYXJXaW5kb3dQcm9wZXJ0aWVzLCBib29sCiAgICAgaWYgKGNsZWFyRnJhbWVWaWV3ICYm IG1fZnJhbWUudmlldygpKQogICAgICAgICBtX2ZyYW1lLnZpZXcoKS0+Y2xlYXIoKTsKIAotICAg IC8vIERvIG5vdCBkcm9wIHRoZSBkb2N1bWVudCBiZWZvcmUgdGhlIFNjcmlwdENvbnRyb2xsZXIg YW5kIHZpZXcgYXJlIGNsZWFyZWQKLSAgICAvLyBhcyBzb21lIGRlc3RydWN0b3JzIG1pZ2h0IHN0 aWxsIHRyeSB0byBhY2Nlc3MgdGhlIGRvY3VtZW50LgotICAgIG1fZnJhbWUuc2V0RG9jdW1lbnQo bnVsbHB0cik7Ci0KICAgICBzdWJmcmFtZUxvYWRlcigpLmNsZWFyKCk7CiAKICAgICBpZiAoY2xl YXJXaW5kb3dQcm9wZXJ0aWVzKQogICAgICAgICBtX2ZyYW1lLndpbmRvd1Byb3h5KCkuc2V0RE9N V2luZG93KG5ld0RvY3VtZW50LT5kb21XaW5kb3coKSk7CiAKLSAgICBpZiAoY2xlYXJTY3JpcHRP YmplY3RzKQotICAgICAgICBtX2ZyYW1lLnNjcmlwdCgpLmNsZWFyU2NyaXB0T2JqZWN0cygpOwot CiAgICAgaWYgKG5ld0RvY3VtZW50LT5jb250ZW50U2VjdXJpdHlQb2xpY3koKSAmJiAhbmV3RG9j dW1lbnQtPmNvbnRlbnRTZWN1cml0eVBvbGljeSgpLT5ldmFsRXJyb3JNZXNzYWdlKCkuaXNOdWxs KCkpCiAgICAgICAgIG1fZnJhbWUuc2NyaXB0KCkuZW5hYmxlRXZhbChmYWxzZSwgbmV3RG9jdW1l bnQtPmNvbnRlbnRTZWN1cml0eVBvbGljeSgpLT5ldmFsRXJyb3JNZXNzYWdlKCkpOwogICAgIGVs c2UKICAgICAgICAgbV9mcmFtZS5zY3JpcHQoKS5lbmFibGVFdmFsKHRydWUpOwogCisgICAgLy8g RG8gbm90IGRyb3AgdGhlIGRvY3VtZW50IGJlZm9yZSB0aGUgU2NyaXB0Q29udHJvbGxlciBhbmQg dmlldyBhcmUgY2xlYXJlZAorICAgIC8vIGFzIHNvbWUgZGVzdHJ1Y3RvcnMgbWlnaHQgc3RpbGwg dHJ5IHRvIGFjY2VzcyB0aGUgZG9jdW1lbnQuCisgICAgbV9mcmFtZS5zZXREb2N1bWVudChudWxs cHRyKTsKKworICAgIGlmIChjbGVhclNjcmlwdE9iamVjdHMpCisgICAgICAgIG1fZnJhbWUuc2Ny aXB0KCkuY2xlYXJTY3JpcHRPYmplY3RzKCk7CisKICAgICBtX2ZyYW1lLm5hdmlnYXRpb25TY2hl ZHVsZXIoKS5jbGVhcigpOwogCiAgICAgbV9jaGVja1RpbWVyLnN0b3AoKTsK 454057 2022-03-07 18:18:45 -0800 2022-03-08 06:45:07 -0800 Patch bug-237565-20220307181844.patch text/plain 2928 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwODMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDgxMTZjY2NjNmNjNDRk ODkwN2RlNGYwNzFmYjY2NGFjNjdjMTRhNi4uNTQ4MjEyOWZkNTdkMDgyYTJmMjYzN2Q4MWZjMTc2 OGI0ZDE3NjNmYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIyLTAzLTA3ICBLYXRl IENoZW5leSAgPGthdGhlcmluZV9jaGVuZXlAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJ T04gKHIyOTA4NTMpOiBDcmFzaFRyYWNlcjogY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50LkRl dmVsb3BtZW50IGF0IGNvbS5hcHBsZS5XZWJDb3JlOiBXZWJDb3JlOjpGcmFtZUxvYWRlcjo6Y2xl YXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNzU2 NQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vODgzNTYwNzQ+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBGaXhlcyBjcmFzaGlu ZyB0ZXN0OiBhY2Nlc3NpYmlsaXR5L21hYy92YWx1ZS1jaGFuZ2UvdmFsdWUtY2hhbmdlLXVzZXIt aW5mby10ZXh0YXJlYS5odG1sIAorCisgICAgICAgIG5ld0RvY3VtZW50IG1heSBiZSB0aGUgZnJh bWUncyBkb2N1bWVudC4gV2Ugc2hvdWxkIG1ha2UgaXQgYSBSZWZQdHIKKyAgICAgICAgYmVjYXVz ZSBpdCBjb3VsZCBnZXQgc2V0IHRvIG51bGwgaW4gdGhpcyBmdW5jdGlvbi4KKworICAgICAgICAq IGxvYWRlci9GcmFtZUxvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlcjo6 Y2xlYXIpOgorICAgICAgICAqIGxvYWRlci9GcmFtZUxvYWRlci5oOgorCiAyMDIyLTAzLTA0ICBL YXRlIENoZW5leSAgPGthdGhlcmluZV9jaGVuZXlAYXBwbGUuY29tPgogCiAgICAgICAgIGFib3V0 OmJsYW5rIGlmcmFtZXMgZG8gbm90IGFsd2F5cyBpbmhlcml0IHBhcmVudCBDU1AKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCmluZGV4IGIyZTdmNjhiNzJiN2NiOGM3OTVkMGVmYmZj MWI3YTMxNDVmYzdhYjguLjI0YjJlMDJjNmYzNmM2ODg5NjZhNTYxODdiNTZiMTJiYmRkYzNkOGIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcApAQCAtNjIwLDcgKzYyMCw3IEBA IHN0YXRpYyBpbmxpbmUgYm9vbCBzaG91bGRDbGVhcldpbmRvd05hbWUoY29uc3QgRnJhbWUmIGZy YW1lLCBjb25zdCBEb2N1bWVudCYgbmV3CiAgICAgcmV0dXJuICFuZXdEb2N1bWVudC5zZWN1cml0 eU9yaWdpbigpLmlzU2FtZU9yaWdpbkFzKGZyYW1lLmRvY3VtZW50KCktPnNlY3VyaXR5T3JpZ2lu KCkpOwogfQogCi12b2lkIEZyYW1lTG9hZGVyOjpjbGVhcihEb2N1bWVudCogbmV3RG9jdW1lbnQs IGJvb2wgY2xlYXJXaW5kb3dQcm9wZXJ0aWVzLCBib29sIGNsZWFyU2NyaXB0T2JqZWN0cywgYm9v bCBjbGVhckZyYW1lVmlldywgRnVuY3Rpb248dm9pZCgpPiYmIGhhbmRsZURPTVdpbmRvd0NyZWF0 aW9uKQordm9pZCBGcmFtZUxvYWRlcjo6Y2xlYXIoUmVmUHRyPERvY3VtZW50PiBuZXdEb2N1bWVu dCwgYm9vbCBjbGVhcldpbmRvd1Byb3BlcnRpZXMsIGJvb2wgY2xlYXJTY3JpcHRPYmplY3RzLCBi b29sIGNsZWFyRnJhbWVWaWV3LCBGdW5jdGlvbjx2b2lkKCk+JiYgaGFuZGxlRE9NV2luZG93Q3Jl YXRpb24pCiB7CiAgICAgYm9vbCBuZWVkZWRDbGVhciA9IG1fbmVlZHNDbGVhcjsKICAgICBtX25l ZWRzQ2xlYXIgPSBmYWxzZTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFt ZUxvYWRlci5oIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmgKaW5kZXggOGNh MGM2NDc0MTJlZDE2NzY0YzMzYzllMDRjODJjYjk2ODExOGJjYi4uZjE3NjFkYTllODVkZjc5ZGZh NTFjMzY0NzgzZGM1YTg0ODYwMTM5YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVy L0ZyYW1lTG9hZGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmgK QEAgLTE1Miw3ICsxNTIsNyBAQCBwdWJsaWM6CiAgICAgdm9pZCBzdG9wTG9hZGluZyhVbmxvYWRF dmVudFBvbGljeSk7CiAgICAgdm9pZCBjbG9zZVVSTCgpOwogICAgIC8vIEZJWE1FOiBjbGVhcigp IGlzIHRyeWluZyB0byBkbyB0b28gbWFueSB0aGluZ3MuIFdlIHNob3VsZCBicmVhayBpdCBkb3du IGludG8gc21hbGxlciBmdW5jdGlvbnMgKGlkZWFsbHkgd2l0aCBmZXdlciByYXcgQm9vbGVhbiBw YXJhbWV0ZXJzKS4KLSAgICB2b2lkIGNsZWFyKERvY3VtZW50KiBuZXdEb2N1bWVudCwgYm9vbCBj bGVhcldpbmRvd1Byb3BlcnRpZXMgPSB0cnVlLCBib29sIGNsZWFyU2NyaXB0T2JqZWN0cyA9IHRy dWUsIGJvb2wgY2xlYXJGcmFtZVZpZXcgPSB0cnVlLCBGdW5jdGlvbjx2b2lkKCk+JiYgaGFuZGxl RE9NV2luZG93Q3JlYXRpb24gPSBudWxscHRyKTsKKyAgICB2b2lkIGNsZWFyKFJlZlB0cjxEb2N1 bWVudD4gbmV3RG9jdW1lbnQsIGJvb2wgY2xlYXJXaW5kb3dQcm9wZXJ0aWVzID0gdHJ1ZSwgYm9v bCBjbGVhclNjcmlwdE9iamVjdHMgPSB0cnVlLCBib29sIGNsZWFyRnJhbWVWaWV3ID0gdHJ1ZSwg RnVuY3Rpb248dm9pZCgpPiYmIGhhbmRsZURPTVdpbmRvd0NyZWF0aW9uID0gbnVsbHB0cik7CiAK ICAgICBib29sIGlzTG9hZGluZygpIGNvbnN0OwogICAgIFdFQkNPUkVfRVhQT1JUIGJvb2wgZnJh bWVIYXNMb2FkZWQoKSBjb25zdDsK 454116 2022-03-08 06:45:10 -0800 2022-03-08 08:57:26 -0800 Patch bug-237565-20220308064509.patch text/plain 2929 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwODMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDgxMTZjY2NjNmNjNDRk ODkwN2RlNGYwNzFmYjY2NGFjNjdjMTRhNi4uNzQwNTQyZGRkOGFkYzYyN2UwZjcwYzAyM2E1NzIx NDYzMTAzZGMwNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIyLTAzLTA3ICBLYXRl IENoZW5leSAgPGthdGhlcmluZV9jaGVuZXlAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJ T04gKHIyOTA4NTMpOiBDcmFzaFRyYWNlcjogY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50LkRl dmVsb3BtZW50IGF0IGNvbS5hcHBsZS5XZWJDb3JlOiBXZWJDb3JlOjpGcmFtZUxvYWRlcjo6Y2xl YXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNzU2 NQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vODgzNTYwNzQ+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgQ2hyaXMgRHVtZXouCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBGaXhlcyBjcmFzaGluZyB0 ZXN0OiBhY2Nlc3NpYmlsaXR5L21hYy92YWx1ZS1jaGFuZ2UvdmFsdWUtY2hhbmdlLXVzZXItaW5m by10ZXh0YXJlYS5odG1sIAorCisgICAgICAgIG5ld0RvY3VtZW50IG1heSBiZSB0aGUgZnJhbWUn cyBkb2N1bWVudC4gV2Ugc2hvdWxkIG1ha2UgaXQgYSBSZWZQdHIKKyAgICAgICAgYmVjYXVzZSBp dCBjb3VsZCBnZXQgc2V0IHRvIG51bGwgaW4gdGhpcyBmdW5jdGlvbi4KKworICAgICAgICAqIGxv YWRlci9GcmFtZUxvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlcjo6Y2xl YXIpOgorICAgICAgICAqIGxvYWRlci9GcmFtZUxvYWRlci5oOgorCiAyMDIyLTAzLTA0ICBLYXRl IENoZW5leSAgPGthdGhlcmluZV9jaGVuZXlAYXBwbGUuY29tPgogCiAgICAgICAgIGFib3V0OmJs YW5rIGlmcmFtZXMgZG8gbm90IGFsd2F5cyBpbmhlcml0IHBhcmVudCBDU1AKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9s b2FkZXIvRnJhbWVMb2FkZXIuY3BwCmluZGV4IGIyZTdmNjhiNzJiN2NiOGM3OTVkMGVmYmZjMWI3 YTMxNDVmYzdhYjguLmY4YWI0NWRlOWFmM2VlMGMwMzQ2NGNmM2M5ODhhODg4YTRmNGFkODUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcApAQCAtNjIwLDcgKzYyMCw3IEBAIHN0 YXRpYyBpbmxpbmUgYm9vbCBzaG91bGRDbGVhcldpbmRvd05hbWUoY29uc3QgRnJhbWUmIGZyYW1l LCBjb25zdCBEb2N1bWVudCYgbmV3CiAgICAgcmV0dXJuICFuZXdEb2N1bWVudC5zZWN1cml0eU9y aWdpbigpLmlzU2FtZU9yaWdpbkFzKGZyYW1lLmRvY3VtZW50KCktPnNlY3VyaXR5T3JpZ2luKCkp OwogfQogCi12b2lkIEZyYW1lTG9hZGVyOjpjbGVhcihEb2N1bWVudCogbmV3RG9jdW1lbnQsIGJv b2wgY2xlYXJXaW5kb3dQcm9wZXJ0aWVzLCBib29sIGNsZWFyU2NyaXB0T2JqZWN0cywgYm9vbCBj bGVhckZyYW1lVmlldywgRnVuY3Rpb248dm9pZCgpPiYmIGhhbmRsZURPTVdpbmRvd0NyZWF0aW9u KQordm9pZCBGcmFtZUxvYWRlcjo6Y2xlYXIoUmVmUHRyPERvY3VtZW50PiYmIG5ld0RvY3VtZW50 LCBib29sIGNsZWFyV2luZG93UHJvcGVydGllcywgYm9vbCBjbGVhclNjcmlwdE9iamVjdHMsIGJv b2wgY2xlYXJGcmFtZVZpZXcsIEZ1bmN0aW9uPHZvaWQoKT4mJiBoYW5kbGVET01XaW5kb3dDcmVh dGlvbikKIHsKICAgICBib29sIG5lZWRlZENsZWFyID0gbV9uZWVkc0NsZWFyOwogICAgIG1fbmVl ZHNDbGVhciA9IGZhbHNlOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1l TG9hZGVyLmggYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuaAppbmRleCA4Y2Ew YzY0NzQxMmVkMTY3NjRjMzNjOWUwNGM4MmNiOTY4MTE4YmNiLi5jM2E1ZDNlZjBjMWM0MDYwMmQw MjZiNzc1MTcxNzIxNjNiMjFjM2Q0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIv RnJhbWVMb2FkZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuaApA QCAtMTUyLDcgKzE1Miw3IEBAIHB1YmxpYzoKICAgICB2b2lkIHN0b3BMb2FkaW5nKFVubG9hZEV2 ZW50UG9saWN5KTsKICAgICB2b2lkIGNsb3NlVVJMKCk7CiAgICAgLy8gRklYTUU6IGNsZWFyKCkg aXMgdHJ5aW5nIHRvIGRvIHRvbyBtYW55IHRoaW5ncy4gV2Ugc2hvdWxkIGJyZWFrIGl0IGRvd24g aW50byBzbWFsbGVyIGZ1bmN0aW9ucyAoaWRlYWxseSB3aXRoIGZld2VyIHJhdyBCb29sZWFuIHBh cmFtZXRlcnMpLgotICAgIHZvaWQgY2xlYXIoRG9jdW1lbnQqIG5ld0RvY3VtZW50LCBib29sIGNs ZWFyV2luZG93UHJvcGVydGllcyA9IHRydWUsIGJvb2wgY2xlYXJTY3JpcHRPYmplY3RzID0gdHJ1 ZSwgYm9vbCBjbGVhckZyYW1lVmlldyA9IHRydWUsIEZ1bmN0aW9uPHZvaWQoKT4mJiBoYW5kbGVE T01XaW5kb3dDcmVhdGlvbiA9IG51bGxwdHIpOworICAgIHZvaWQgY2xlYXIoUmVmUHRyPERvY3Vt ZW50PiYmIG5ld0RvY3VtZW50LCBib29sIGNsZWFyV2luZG93UHJvcGVydGllcyA9IHRydWUsIGJv b2wgY2xlYXJTY3JpcHRPYmplY3RzID0gdHJ1ZSwgYm9vbCBjbGVhckZyYW1lVmlldyA9IHRydWUs IEZ1bmN0aW9uPHZvaWQoKT4mJiBoYW5kbGVET01XaW5kb3dDcmVhdGlvbiA9IG51bGxwdHIpOwog CiAgICAgYm9vbCBpc0xvYWRpbmcoKSBjb25zdDsKICAgICBXRUJDT1JFX0VYUE9SVCBib29sIGZy YW1lSGFzTG9hZGVkKCkgY29uc3Q7Cg==