237556 2022-03-07 14:13:40 -0800 Fix Release builds for sanitizers by defining RELEASE_WITHOUT_OPTIMIZATIONS 2022-03-07 19:01:57 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ddkilzer ddkilzer katherine_cheney webkit-bug-importer oldest_to_newest 1848961 0 ddkilzer 2022-03-07 14:13:40 -0800 Fix Release builds for sanitizers by defining RELEASE_WITHOUT_OPTIMIZATIONS. If this is not defined, errors like this occur when building Release with lower optimization levels: Source/WTF/wtf/Compiler.h:103:2: error: "Building release without compiler optimizations: WebKit will be slow. Set -DRELEASE_WITHOUT_OPTIMIZATIONS if this is intended." 1848962 1 webkit-bug-importer 2022-03-07 14:13:57 -0800 <rdar://problem/89929061> 1848964 2 454034 ddkilzer 2022-03-07 14:15:11 -0800 Created attachment 454034 Patch v1 1849029 3 454034 ddkilzer 2022-03-07 16:40:45 -0800 Comment on attachment 454034 Patch v1 cq+ since this doesn't affect non-sanitizer builds. 1849069 4 ews-feeder 2022-03-07 19:01:52 -0800 Committed r290970 (248149@main): <https://commits.webkit.org/248149@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454034. 454034 2022-03-07 14:15:11 -0800 2022-03-07 19:01:55 -0800 Patch v1 bug-237556-20220307141510.patch text/plain 1774 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwMTQ2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMWUwMzgwNmU4MTBlMGFjYTAzZTA4NTk2NzA1MTMxMDUw YzhiYWMwMC4uMjkyMzk1YmUzZjFiMjgyODExZTAxNjIwMTA1MWFjZWJiZDg4NjFmZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDIyLTAzLTA3ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAg ICAgICAgRml4IFJlbGVhc2UgYnVpbGRzIGZvciBzYW5pdGl6ZXJzIGJ5IGRlZmluaW5nIFJFTEVB U0VfV0lUSE9VVF9PUFRJTUlaQVRJT05TCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8y Mzc1NTY+CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84OTkyOTA2MT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHNhbml0aXplci9zYW5pdGl6ZXIu eGNjb25maWc6CisgICAgICAgIChPVEhFUl9DRkxBR1MpOiBBZGQgYC1EUkVMRUFTRV9XSVRIT1VU X09QVElNSVpBVElPTlNgIHNvIFJlbGVhc2UKKyAgICAgICAgYnVpbGRzIGF0IGxvd2VyIG9wdGlt aXphdGlvbiBsZXZlbHMgZG9uJ3QgZmFpbC4KKwogMjAyMi0wMi0xOCAgQnJhZHkgRWlkc29uICA8 YmVpZHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIGFuIEluc3RhbGxDb29yZGluYXRpb24g d2VicHVzaGQgYmFja2VuZApkaWZmIC0tZ2l0IGEvVG9vbHMvc2FuaXRpemVyL3Nhbml0aXplci54 Y2NvbmZpZyBiL1Rvb2xzL3Nhbml0aXplci9zYW5pdGl6ZXIueGNjb25maWcKaW5kZXggMjExNzIy ZGMyYTRlZDc3YTZiNDZlNjljNDVkZjBjNzYwODliMjg3NS4uOTIzNDA0YzI1NmZhYTVhOTBiZTk5 Njg4Y2ZkNzIwYWZjOTA3M2QyZCAxMDA2NDQKLS0tIGEvVG9vbHMvc2FuaXRpemVyL3Nhbml0aXpl ci54Y2NvbmZpZworKysgYi9Ub29scy9zYW5pdGl6ZXIvc2FuaXRpemVyLnhjY29uZmlnCkBAIC0z LDcgKzMsNyBAQCBHQ0NfT1BUSU1JWkFUSU9OX0xFVkVMX0RlYnVnID0gMDsKIEdDQ19PUFRJTUla QVRJT05fTEVWRUxfUHJvZHVjdGlvbiA9IDE7CiBHQ0NfT1BUSU1JWkFUSU9OX0xFVkVMX1JlbGVh c2UgPSAxOwogCi1PVEhFUl9DRkxBR1MgPSAkKGluaGVyaXRlZCkgLWZuby1vbWl0LWZyYW1lLXBv aW50ZXIgLWcgJChXS19BRERSRVNTX1NBTklUSVpFUl9PVEhFUl9DRkxBR1NfJChXS19FTkFCTEVf QUREUkVTU19TQU5JVElaRVIpKSAkKFdLX1VOREVGSU5FRF9CRUhBVklPUl9TQU5JVElaRVJfT1RI RVJfQ0ZMQUdTXyQoV0tfRU5BQkxFX1VOREVGSU5FRF9CRUhBVklPUl9TQU5JVElaRVIpKTsKK09U SEVSX0NGTEFHUyA9ICQoaW5oZXJpdGVkKSAtRFJFTEVBU0VfV0lUSE9VVF9PUFRJTUlaQVRJT05T IC1mbm8tb21pdC1mcmFtZS1wb2ludGVyIC1nICQoV0tfQUREUkVTU19TQU5JVElaRVJfT1RIRVJf Q0ZMQUdTXyQoV0tfRU5BQkxFX0FERFJFU1NfU0FOSVRJWkVSKSkgJChXS19VTkRFRklORURfQkVI QVZJT1JfU0FOSVRJWkVSX09USEVSX0NGTEFHU18kKFdLX0VOQUJMRV9VTkRFRklORURfQkVIQVZJ T1JfU0FOSVRJWkVSKSk7CiBPVEhFUl9DUExVU1BMVVNGTEFHUyA9ICQoaW5oZXJpdGVkKSAkKFdL X0FERFJFU1NfU0FOSVRJWkVSX09USEVSX0NQTFVTUExVU0ZMQUdTXyQoV0tfRU5BQkxFX0FERFJF U1NfU0FOSVRJWkVSKSk7CiAKIC8vIFdvcmthcm91bmQgZm9yIDxyZGFyOi8vcHJvYmxlbS80OTQ5 ODA5Mj4uCg==