237550 2022-03-07 13:00:33 -0800 WebSocket requests should include Sec-Fetch-Mode=websocket for FetchMetadata 2022-11-10 04:25:45 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=204744 InRadar P2 Normal --- 247696 246508 1 pgriffis youennf annevk webkit-bug-importer oldest_to_newest 1848912 0 pgriffis 2022-03-07 13:00:33 -0800 As part of the FetchMetadata spec they don't use the normal request modes they have a distinct one. I plan on working on this soon. 1850170 1 webkit-bug-importer 2022-03-10 10:22:16 -0800 <rdar://problem/90106854> 1856094 2 456044 pgriffis 2022-03-29 11:03:08 -0700 Created attachment 456044 Test case 1856095 3 pgriffis 2022-03-29 11:04:16 -0700 Attached is a test case for this, however running it Chromium does not attach any metadata to the websocket handshake request, the same as our current behavior. Firefox *does* attach metadata for this so there is an inconsistency there. 1905558 4 annevk 2022-10-14 01:24:27 -0700 Per Fetch they should be included. The handshake goes through the normal fetch algorithm after all and there's no special casing for setting these request headers. 1911228 5 youennf 2022-11-09 03:37:29 -0800 Pull request: https://github.com/WebKit/WebKit/pull/6296 1911504 6 ews-feeder 2022-11-10 04:25:42 -0800 Committed 256527@main (f05061a1e830): <https://commits.webkit.org/256527@main> Reviewed commits have been landed. Closing PR #6296 and removing active labels. 456044 2022-03-29 11:03:08 -0700 2022-03-29 12:30:17 -0700 Test case bug-237550-20220329130307.patch text/plain 1329 pgriffis U3VidmVyc2lvbiBSZXZpc2lvbjogMjkxNjE3CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRw L3dwdC9mZXRjaC9mZXRjaC1tZXRhZGF0YS13ZWJzb2NrZXQuaHRtbCBiL0xheW91dFRlc3RzL2h0 dHAvd3B0L2ZldGNoL2ZldGNoLW1ldGFkYXRhLXdlYnNvY2tldC5odG1sCm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjJk NDM3NmQwZjg5ZmIzNzg5ZDE2ODBhNTllMDcyZGVlYWVjN2MwOWYKLS0tIC9kZXYvbnVsbAorKysg Yi9MYXlvdXRUZXN0cy9odHRwL3dwdC9mZXRjaC9mZXRjaC1tZXRhZGF0YS13ZWJzb2NrZXQuaHRt bApAQCAtMCwwICsxLDI3IEBACis8IURPQ1RZUEUgaHRtbD4KKworPGxpbmsgcmVsPSJhdXRob3Ii IGhyZWY9Im10cnpvc0Bnb29nbGUuY29tIiB0aXRsZT0iTWFjaWVrIFRyem9zIj4KKzxzY3JpcHQg c3JjPS9yZXNvdXJjZXMvdGVzdGhhcm5lc3MuanM+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0vcmVz b3VyY2VzL3Rlc3RoYXJuZXNzcmVwb3J0LmpzPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9L2ZldGNo L21ldGFkYXRhL3Jlc291cmNlcy9oZWxwZXIuanM+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0vY29t bW9uL3V0aWxzLmpzPjwvc2NyaXB0PgorPGJvZHk+PC9ib2R5PgorPHNjcmlwdD4KKyAgbGV0IG5v bmNlID0gdG9rZW4oKTsKKworICBwcm9taXNlX3Rlc3QodCA9PiB7CisgICAgcmV0dXJuIG5ldyBQ cm9taXNlKChyZXNvbHZlLCByZWplY3QpID0+IHsKKyAgICAgIGxldCBrZXkgPSAid2Vic29ja2V0 LSIgKyBub25jZTsKKworICAgICAgbGV0IHdzID0gbmV3IFdlYlNvY2tldCgid3M6Ly9sb2NhbGhv c3Q6ODgwMC9mZXRjaC9tZXRhZGF0YS9yZXNvdXJjZXMvcmVjb3JkLWhlYWRlci5weT9maWxlPSIg KyBrZXkpOworICAgICAgbGV0IGV4cGVjdGVkID0geyJzaXRlIjogInNhbWUtb3JpZ2luIiwgInVz ZXIiOiAiIiwgIm1vZGUiOiAid2Vic29ja2V0IiwgImRlc3QiOiAid2Vic29ja2V0In07CisKKyAg ICAgIC8vIFRoaXMgaXMgZXhwZWN0ZWQgdG8gZmFpbCBidXQgd2lsbCBzdGlsbCByZWNvcmQgdGhl IGhlYWRlcnMgZnJvbSB0aGUgaGFuZHNoYWtlLgorICAgICAgd3MuYWRkRXZlbnRMaXN0ZW5lcigi ZXJyb3IiLCBlID0+IHsKKyAgICAgICAgdmFsaWRhdGVfZXhwZWN0YXRpb25zKGtleSwgZXhwZWN0 ZWQpCisgICAgICAgICAgLnRoZW4oXyA9PiByZXNvbHZlKCkpCisgICAgICAgICAgLmNhdGNoKGUg PT4gcmVqZWN0KGUpKTsKKyAgICAgIH0pOworICAgIH0pCisgIH0sICJXZWJzb2NrZXQgSGFuZHNo YWtlIik7Cis8L3NjcmlwdD4K