237546 2022-03-07 12:17:48 -0800 skip scheduling lazy UA shadow tree creation if already created or not needed 2022-03-08 19:00:14 -0800 1 1 1 Unclassified WebKit Forms WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 heycam heycam akeerthi cdumez changseok esprehn+autocc ews-watchlist gyuyoung.kim mifenton webkit-bug-importer wenson_hsieh oldest_to_newest 1848884 0 heycam 2022-03-07 12:17:48 -0800 Bug 236747 made <input> element UA shadow trees get created lazily. HTMLInputElement::insertedIntoAncestor now schedules the UA shadow tree to be created the next time style is flushed. We currently do this every time an <input> element is inserted into the document, but there's only a need to do this if the particular input type needs a shadow tree and we haven't already created it. 1848888 1 webkit-bug-importer 2022-03-07 12:19:18 -0800 <rdar://problem/89922896> 1849352 2 454140 heycam 2022-03-08 12:02:19 -0800 Created attachment 454140 Patch 1849360 3 454140 akeerthi 2022-03-08 12:11:38 -0800 Comment on attachment 454140 Patch Might be helpful to put your comment in the bug description in the ChangeLog file. 1849362 4 454142 heycam 2022-03-08 12:15:15 -0800 Created attachment 454142 Patch 1849521 5 ews-feeder 2022-03-08 19:00:09 -0800 Committed r291028 (248202@main): <https://commits.webkit.org/248202@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454142. 454140 2022-03-08 12:02:19 -0800 2022-03-08 12:15:11 -0800 Patch bug-237546-20220309070218.patch text/plain 1604 heycam U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwOTAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmFhZjdmMTYwYWQxNmE0 NmVkMTY2ZmUwZjNhYTZhMmJiMzU2MDE5NC4uMzFkMTU2OTU1OTczMDAwZWNiZjU1MjE2NTIzYWJi YTAxYzE1M2JhNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIyLTAzLTA3ICBDYW1l cm9uIE1jQ29ybWFjayAgPGhleWNhbUBhcHBsZS5jb20+CisKKyAgICAgICAgU2tpcCBzY2hlZHVs aW5nIGxhenkgVUEgc2hhZG93IHRyZWUgY3JlYXRpb24gaWYgYWxyZWFkeSBjcmVhdGVkIG9yIG5v dCBuZWVkZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIzNzU0NgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vODk5MjI4OTY+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBodG1sL0hUTUxJbnB1dEVsZW1l bnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTElucHV0RWxlbWVudDo6aW5zZXJ0ZWRJbnRv QW5jZXN0b3IpOgorCiAyMDIyLTAzLTA3ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+ CiAKICAgICAgICAgTWFrZSAidHJ1ZSIgY291bnQgYXMgdHJ1dGh5IGluIHdpbmRvdy5vcGVuKCkn cyBib29sZWFuIGZlYXR1cmVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJ bnB1dEVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNw cAppbmRleCBiY2Q2YzhhMGViNzA5OTIyNjk1NGFiZDdkOWUwZDU0YmViNTdkZWVhLi4wZGU3YTEy MTM4NDUxOTk0YmVhYjE0OGZmYmYzZGFiZTBiZTY2MTIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwv SFRNTElucHV0RWxlbWVudC5jcHAKQEAgLTE1NzQsNyArMTU3NCw3IEBAIE5vZGU6Okluc2VydGVk SW50b0FuY2VzdG9yUmVzdWx0IEhUTUxJbnB1dEVsZW1lbnQ6Omluc2VydGVkSW50b0FuY2VzdG9y KEluc2VydGlvCiAjZW5kaWYKICAgICBpZiAoaXNSYWRpb0J1dHRvbigpKQogICAgICAgICB1cGRh dGVWYWxpZGl0eSgpOwotICAgIGlmIChpbnNlcnRpb25UeXBlLmNvbm5lY3RlZFRvRG9jdW1lbnQg JiYgIW1faGFzUGVuZGluZ1VzZXJBZ2VudFNoYWRvd1RyZWVVcGRhdGUpIHsKKyAgICBpZiAoaW5z ZXJ0aW9uVHlwZS5jb25uZWN0ZWRUb0RvY3VtZW50ICYmIG1faW5wdXRUeXBlLT5uZWVkc1NoYWRv d1N1YnRyZWUoKSAmJiAhbV9pbnB1dFR5cGUtPmhhc0NyZWF0ZWRTaGFkb3dTdWJ0cmVlKCkgJiYg IW1faGFzUGVuZGluZ1VzZXJBZ2VudFNoYWRvd1RyZWVVcGRhdGUpIHsKICAgICAgICAgZG9jdW1l bnQoKS5hZGRFbGVtZW50V2l0aFBlbmRpbmdVc2VyQWdlbnRTaGFkb3dUcmVlVXBkYXRlKCp0aGlz KTsKICAgICAgICAgbV9oYXNQZW5kaW5nVXNlckFnZW50U2hhZG93VHJlZVVwZGF0ZSA9IHRydWU7 CiAgICAgfQo= 454142 2022-03-08 12:15:15 -0800 2022-03-08 19:00:12 -0800 Patch bug-237546-20220309071514.patch text/plain 2047 heycam U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwOTAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmFhZjdmMTYwYWQxNmE0 NmVkMTY2ZmUwZjNhYTZhMmJiMzU2MDE5NC4uNmQyYTg0YTNjMTQ5MDY1MWE2Mjg0Yzk0NDkwMzYw MThhZGIyMDFjZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIyLTAzLTA3ICBDYW1l cm9uIE1jQ29ybWFjayAgPGhleWNhbUBhcHBsZS5jb20+CisKKyAgICAgICAgU2tpcCBzY2hlZHVs aW5nIGxhenkgVUEgc2hhZG93IHRyZWUgY3JlYXRpb24gaWYgYWxyZWFkeSBjcmVhdGVkIG9yIG5v dCBuZWVkZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIzNzU0NgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vODk5MjI4OTY+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgQWRpdHlhIEtlZXJ0aGkuCisKKyAgICAgICAgQnVnIDIzNjc0NyBtYWRlIDxpbnB1 dD4gZWxlbWVudCBVQSBzaGFkb3cgdHJlZXMgZ2V0IGNyZWF0ZWQgbGF6aWx5LgorICAgICAgICBI VE1MSW5wdXRFbGVtZW50OjppbnNlcnRlZEludG9BbmNlc3RvciBub3cgc2NoZWR1bGVzIHRoZSBV QSBzaGFkb3cgdHJlZQorICAgICAgICB0byBiZSBjcmVhdGVkIHRoZSBuZXh0IHRpbWUgc3R5bGUg aXMgZmx1c2hlZC4gV2UgY3VycmVudGx5IGRvIHRoaXMgZXZlcnkKKyAgICAgICAgdGltZSBhbiA8 aW5wdXQ+IGVsZW1lbnQgaXMgaW5zZXJ0ZWQgaW50byB0aGUgZG9jdW1lbnQsIGJ1dCB0aGVyZSdz IG9ubHkKKyAgICAgICAgYSBuZWVkIHRvIGRvIHRoaXMgaWYgdGhlIHBhcnRpY3VsYXIgaW5wdXQg dHlwZSBuZWVkcyBhIHNoYWRvdyB0cmVlIGFuZAorICAgICAgICB3ZSBoYXZlbid0IGFscmVhZHkg Y3JlYXRlZCBpdC4KKworICAgICAgICAqIGh0bWwvSFRNTElucHV0RWxlbWVudC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpIVE1MSW5wdXRFbGVtZW50OjppbnNlcnRlZEludG9BbmNlc3Rvcik6CisK IDIwMjItMDMtMDcgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBN YWtlICJ0cnVlIiBjb3VudCBhcyB0cnV0aHkgaW4gd2luZG93Lm9wZW4oKSdzIGJvb2xlYW4gZmVh dHVyZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwCmluZGV4IGJjZDZj OGEwZWI3MDk5MjI2OTU0YWJkN2Q5ZTBkNTRiZWI1N2RlZWEuLjBkZTdhMTIxMzg0NTE5OTRiZWFi MTQ4ZmZiZjNkYWJlMGJlNjYxMjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRN TElucHV0RWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVt ZW50LmNwcApAQCAtMTU3NCw3ICsxNTc0LDcgQEAgTm9kZTo6SW5zZXJ0ZWRJbnRvQW5jZXN0b3JS ZXN1bHQgSFRNTElucHV0RWxlbWVudDo6aW5zZXJ0ZWRJbnRvQW5jZXN0b3IoSW5zZXJ0aW8KICNl bmRpZgogICAgIGlmIChpc1JhZGlvQnV0dG9uKCkpCiAgICAgICAgIHVwZGF0ZVZhbGlkaXR5KCk7 Ci0gICAgaWYgKGluc2VydGlvblR5cGUuY29ubmVjdGVkVG9Eb2N1bWVudCAmJiAhbV9oYXNQZW5k aW5nVXNlckFnZW50U2hhZG93VHJlZVVwZGF0ZSkgeworICAgIGlmIChpbnNlcnRpb25UeXBlLmNv bm5lY3RlZFRvRG9jdW1lbnQgJiYgbV9pbnB1dFR5cGUtPm5lZWRzU2hhZG93U3VidHJlZSgpICYm ICFtX2lucHV0VHlwZS0+aGFzQ3JlYXRlZFNoYWRvd1N1YnRyZWUoKSAmJiAhbV9oYXNQZW5kaW5n VXNlckFnZW50U2hhZG93VHJlZVVwZGF0ZSkgewogICAgICAgICBkb2N1bWVudCgpLmFkZEVsZW1l bnRXaXRoUGVuZGluZ1VzZXJBZ2VudFNoYWRvd1RyZWVVcGRhdGUoKnRoaXMpOwogICAgICAgICBt X2hhc1BlbmRpbmdVc2VyQWdlbnRTaGFkb3dUcmVlVXBkYXRlID0gdHJ1ZTsKICAgICB9Cg==