<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>237540</bug_id>
          
          <creation_ts>2022-03-07 10:53:17 -0800</creation_ts>
          <short_desc>Add early return for empty path in makeAllDirectories</short_desc>
          <delta_ts>2022-03-08 00:07:26 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Sihui Liu">sihui_liu</reporter>
          <assigned_to name="Sihui Liu">sihui_liu</assigned_to>
          <cc>benjamin</cc>
    
    <cc>cdumez</cc>
    
    <cc>cmarcelo</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1848827</commentid>
    <comment_count>0</comment_count>
    <who name="Sihui Liu">sihui_liu</who>
    <bug_when>2022-03-07 10:53:17 -0800</bug_when>
    <thetext>...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1848830</commentid>
    <comment_count>1</comment_count>
      <attachid>454002</attachid>
    <who name="Sihui Liu">sihui_liu</who>
    <bug_when>2022-03-07 10:58:12 -0800</bug_when>
    <thetext>Created attachment 454002
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1848832</commentid>
    <comment_count>2</comment_count>
    <who name="Sihui Liu">sihui_liu</who>
    <bug_when>2022-03-07 10:59:15 -0800</bug_when>
    <thetext>rdar://89901536</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1848843</commentid>
    <comment_count>3</comment_count>
      <attachid>454002</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2022-03-07 11:08:40 -0800</bug_when>
    <thetext>Comment on attachment 454002
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454002&amp;action=review

&gt; Source/WTF/ChangeLog:8
&gt; +        * wtf/posix/FileSystemPOSIX.cpp:

Why no API test?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1848854</commentid>
    <comment_count>4</comment_count>
      <attachid>454005</attachid>
    <who name="Sihui Liu">sihui_liu</who>
    <bug_when>2022-03-07 11:19:35 -0800</bug_when>
    <thetext>Created attachment 454005
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1848855</commentid>
    <comment_count>5</comment_count>
    <who name="Sihui Liu">sihui_liu</who>
    <bug_when>2022-03-07 11:21:41 -0800</bug_when>
    <thetext>(In reply to Chris Dumez from comment #3)
&gt; Comment on attachment 454002 [details]
&gt; Patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=454002&amp;action=review
&gt; 
&gt; &gt; Source/WTF/ChangeLog:8
&gt; &gt; +        * wtf/posix/FileSystemPOSIX.cpp:
&gt; 
&gt; Why no API test?

Added</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1848895</commentid>
    <comment_count>6</comment_count>
      <attachid>454005</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2022-03-07 12:31:34 -0800</bug_when>
    <thetext>Comment on attachment 454005
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454005&amp;action=review

&gt; Source/WTF/wtf/posix/FileSystemPOSIX.cpp:280
&gt; +    if (!length)

Why aren&apos;t we replacing the `fullPath.isNull()` early return above with a `fullPath.isEmpty()` instead? Is there a reason we want to do the access() call in between?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1848905</commentid>
    <comment_count>7</comment_count>
    <who name="Sihui Liu">sihui_liu</who>
    <bug_when>2022-03-07 12:55:26 -0800</bug_when>
    <thetext>(In reply to Chris Dumez from comment #6)
&gt; Comment on attachment 454005 [details]
&gt; Patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=454005&amp;action=review
&gt; 
&gt; &gt; Source/WTF/wtf/posix/FileSystemPOSIX.cpp:280
&gt; &gt; +    if (!length)
&gt; 
&gt; Why aren&apos;t we replacing the `fullPath.isNull()` early return above with a
&gt; `fullPath.isEmpty()` instead? Is there a reason we want to do the access()
&gt; call in between?

We can replace it there; this is safety net before accessing fullPath&apos;s content, so I added it here</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1848907</commentid>
    <comment_count>8</comment_count>
      <attachid>454005</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2022-03-07 12:56:17 -0800</bug_when>
    <thetext>Comment on attachment 454005
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454005&amp;action=review

&gt;&gt;&gt; Source/WTF/wtf/posix/FileSystemPOSIX.cpp:280
&gt;&gt;&gt; +    if (!length)
&gt;&gt; 
&gt;&gt; Why aren&apos;t we replacing the `fullPath.isNull()` early return above with a `fullPath.isEmpty()` instead? Is there a reason we want to do the access() call in between?
&gt; 
&gt; We can replace it there; this is safety net before accessing fullPath&apos;s content, so I added it here

Ok, then I&apos;d prefer we do the check earlier like I suggested. r=me with that change.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1848910</commentid>
    <comment_count>9</comment_count>
      <attachid>454018</attachid>
    <who name="Sihui Liu">sihui_liu</who>
    <bug_when>2022-03-07 12:59:09 -0800</bug_when>
    <thetext>Created attachment 454018
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1848950</commentid>
    <comment_count>10</comment_count>
      <attachid>454030</attachid>
    <who name="Sihui Liu">sihui_liu</who>
    <bug_when>2022-03-07 14:00:04 -0800</bug_when>
    <thetext>Created attachment 454030
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1849132</commentid>
    <comment_count>11</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2022-03-08 00:07:21 -0800</bug_when>
    <thetext>Committed r290978 (248156@main): &lt;https://commits.webkit.org/248156@main&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454030.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>454002</attachid>
            <date>2022-03-07 10:58:12 -0800</date>
            <delta_ts>2022-03-07 11:19:31 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-237540-20220307105811.patch</filename>
            <type>text/plain</type>
            <size>1327</size>
            <attacher name="Sihui Liu">sihui_liu</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwODkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n
ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGYyZGM0ODMzNTA2MzNiNWEyYzJhNjFk
ZWVkZDY3ODE5NWIxMjlhYzEuLjRlNGNiOTYzZDM0YzQwYzQyYmUxNjZiNDQyODg5MWM2ZDIwMzQ0
MjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjItMDMtMDcgIFNpaHVpIExpdSAgPHNpaHVpX2xp
dUBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIGVhcmx5IHJldHVybiBmb3IgZW1wdHkgcGF0aCBp
biBtYWtlQWxsRGlyZWN0b3JpZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTIzNzU0MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp
LgorCisgICAgICAgICogd3RmL3Bvc2l4L0ZpbGVTeXN0ZW1QT1NJWC5jcHA6CisgICAgICAgIChX
VEY6OkZpbGVTeXN0ZW1JbXBsOjptYWtlQWxsRGlyZWN0b3JpZXMpOgorCiAyMDIyLTAzLTA0ICBT
aWh1aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBudWxsIGNoZWNr
IGZvciBwYXRoIGluIG1ha2VBbGxEaXJlY3RvcmllcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93
dGYvcG9zaXgvRmlsZVN5c3RlbVBPU0lYLmNwcCBiL1NvdXJjZS9XVEYvd3RmL3Bvc2l4L0ZpbGVT
eXN0ZW1QT1NJWC5jcHAKaW5kZXggYWUwYTcwNmY1NjUxZDUxYjgzOWIxODlhZGRmNDg1ZjA0NDE0
N2ZlOS4uMjNkOTg3ZGQwNmVhM2U1YmQxMWQ2OWZkNGU1NzZlMjdkZWQ5MmM5ZiAxMDA2NDQKLS0t
IGEvU291cmNlL1dURi93dGYvcG9zaXgvRmlsZVN5c3RlbVBPU0lYLmNwcAorKysgYi9Tb3VyY2Uv
V1RGL3d0Zi9wb3NpeC9GaWxlU3lzdGVtUE9TSVguY3BwCkBAIC0yNzYsOCArMjc2LDExIEBAIGJv
b2wgbWFrZUFsbERpcmVjdG9yaWVzKGNvbnN0IFN0cmluZyYgcGF0aCkKICAgICBpZiAoIWFjY2Vz
cyhmdWxsUGF0aC5kYXRhKCksIEZfT0spKQogICAgICAgICByZXR1cm4gdHJ1ZTsKIAotICAgIGNo
YXIqIHAgPSBmdWxsUGF0aC5tdXRhYmxlRGF0YSgpICsgMTsKICAgICBpbnQgbGVuZ3RoID0gZnVs
bFBhdGgubGVuZ3RoKCk7CisgICAgaWYgKCFsZW5ndGgpCisgICAgICAgIHJldHVybiBmYWxzZTsK
KworICAgIGNoYXIqIHAgPSBmdWxsUGF0aC5tdXRhYmxlRGF0YSgpICsgMTsKICAgICBpZiAocFts
ZW5ndGggLSAxXSA9PSAnLycpCiAgICAgICAgIHBbbGVuZ3RoIC0gMV0gPSAnXDAnOwogICAgIGZv
ciAoOyAqcDsgKytwKSB7Cg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>454005</attachid>
            <date>2022-03-07 11:19:35 -0800</date>
            <delta_ts>2022-03-07 12:59:06 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-237540-20220307111933.patch</filename>
            <type>text/plain</type>
            <size>2602</size>
            <attacher name="Sihui Liu">sihui_liu</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwODkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n
ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGYyZGM0ODMzNTA2MzNiNWEyYzJhNjFk
ZWVkZDY3ODE5NWIxMjlhYzEuLmM3MDBmZjI3MWVjYjVjNmQwNTdmNjUyMzY0Y2NjN2IxMDg3ZWEy
NjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjItMDMtMDcgIFNpaHVpIExpdSAgPHNpaHVpX2xp
dUBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIGVhcmx5IHJldHVybiBmb3IgZW1wdHkgcGF0aCBp
biBtYWtlQWxsRGlyZWN0b3JpZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTIzNzU0MAorICAgICAgICByZGFyOi8vODk5MDE1MzYKKworICAgICAgICBS
ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9wb3NpeC9GaWxlU3lz
dGVtUE9TSVguY3BwOgorICAgICAgICAoV1RGOjpGaWxlU3lzdGVtSW1wbDo6bWFrZUFsbERpcmVj
dG9yaWVzKToKKwogMjAyMi0wMy0wNCAgU2lodWkgTGl1ICA8c2lodWlfbGl1QGFwcGxlLmNvbT4K
IAogICAgICAgICBBZGQgbnVsbCBjaGVjayBmb3IgcGF0aCBpbiBtYWtlQWxsRGlyZWN0b3JpZXMK
ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL3Bvc2l4L0ZpbGVTeXN0ZW1QT1NJWC5jcHAgYi9T
b3VyY2UvV1RGL3d0Zi9wb3NpeC9GaWxlU3lzdGVtUE9TSVguY3BwCmluZGV4IGFlMGE3MDZmNTY1
MWQ1MWI4MzliMTg5YWRkZjQ4NWYwNDQxNDdmZTkuLjIzZDk4N2RkMDZlYTNlNWJkMTFkNjlmZDRl
NTc2ZTI3ZGVkOTJjOWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL3Bvc2l4L0ZpbGVTeXN0
ZW1QT1NJWC5jcHAKKysrIGIvU291cmNlL1dURi93dGYvcG9zaXgvRmlsZVN5c3RlbVBPU0lYLmNw
cApAQCAtMjc2LDggKzI3NiwxMSBAQCBib29sIG1ha2VBbGxEaXJlY3Rvcmllcyhjb25zdCBTdHJp
bmcmIHBhdGgpCiAgICAgaWYgKCFhY2Nlc3MoZnVsbFBhdGguZGF0YSgpLCBGX09LKSkKICAgICAg
ICAgcmV0dXJuIHRydWU7CiAKLSAgICBjaGFyKiBwID0gZnVsbFBhdGgubXV0YWJsZURhdGEoKSAr
IDE7CiAgICAgaW50IGxlbmd0aCA9IGZ1bGxQYXRoLmxlbmd0aCgpOworICAgIGlmICghbGVuZ3Ro
KQorICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICBjaGFyKiBwID0gZnVsbFBhdGgubXV0YWJs
ZURhdGEoKSArIDE7CiAgICAgaWYgKHBbbGVuZ3RoIC0gMV0gPT0gJy8nKQogICAgICAgICBwW2xl
bmd0aCAtIDFdID0gJ1wwJzsKICAgICBmb3IgKDsgKnA7ICsrcCkgewpkaWZmIC0tZ2l0IGEvVG9v
bHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDIwYmY4NmM3MGI4MTE1YTY3ZDM3
MDk5MDA2M2Y0ZTkzMGM0Nzk5NGMuLjA2MjBmNjQ0ZTAxNDQ0ZjU4M2Y0NmQ4YzUxZmFmMWJjNDYy
Njg4YzUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cK
QEAgLTEsMyArMSwxNCBAQAorMjAyMi0wMy0wNyAgU2lodWkgTGl1ICA8c2lodWlfbGl1QGFwcGxl
LmNvbT4KKworICAgICAgICBBZGQgZWFybHkgcmV0dXJuIGZvciBlbXB0eSBwYXRoIGluIG1ha2VB
bGxEaXJlY3RvcmllcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9MjM3NTQwCisgICAgICAgIHJkYXI6Ly84OTkwMTUzNgorCisgICAgICAgIFJldmlld2Vk
IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYv
RmlsZVN5c3RlbS5jcHA6CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpURVNUX0YpOgorCiAyMDIy
LTAzLTA3ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KIAogICAgICAgICBb
d2Via2l0YnVnc3B5XSBBbGxvdyBjcmVhdGlvbiBvZiBuZXcgaXNzdWVzCmRpZmYgLS1naXQgYS9U
b29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9GaWxlU3lzdGVtLmNwcCBiL1Rvb2xzL1Rlc3RX
ZWJLaXRBUEkvVGVzdHMvV1RGL0ZpbGVTeXN0ZW0uY3BwCmluZGV4IGIxOTJlZDg3YjAzMDllYWE4
NDI2MTM1NzUxYWVmZDJhNmY3MDRlMzIuLjVmOTZiNzU2ZDM5NmUwZDk5MjE4Y2RiNDE0ZjkzOGM5
NmQ5OTQ2YTkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL0ZpbGVT
eXN0ZW0uY3BwCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL0ZpbGVTeXN0ZW0u
Y3BwCkBAIC00ODksNiArNDg5LDcgQEAgVEVTVF9GKEZpbGVTeXN0ZW1UZXN0LCBtYWtlQWxsRGly
ZWN0b3JpZXMpCiAgICAgaW52YWxpZEZvbGRlclBhdGguYXBwZW5kKCdcMCcpOwogICAgIGludmFs
aWRGb2xkZXJQYXRoLmFwcGVuZCgnYScpOwogICAgIEVYUEVDVF9GQUxTRShGaWxlU3lzdGVtOjpt
YWtlQWxsRGlyZWN0b3JpZXMoaW52YWxpZEZvbGRlclBhdGgpKTsKKyAgICBFWFBFQ1RfRkFMU0Uo
RmlsZVN5c3RlbTo6bWFrZUFsbERpcmVjdG9yaWVzKGVtcHR5U3RyaW5nKCkpKTsKIH0KIAogVEVT
VF9GKEZpbGVTeXN0ZW1UZXN0LCB2b2x1bWVGcmVlU3BhY2UpCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>454018</attachid>
            <date>2022-03-07 12:59:09 -0800</date>
            <delta_ts>2022-03-07 14:24:00 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-237540-20220307125908.patch</filename>
            <type>text/plain</type>
            <size>2678</size>
            <attacher name="Sihui Liu">sihui_liu</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwOTAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n
ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGRiNGUyODUzNDM4ZTM2MDk2MDkxZjU4
Mjg3YTZkN2E1YmI0YTI2MmYuLmFiZjRmMmVlMTM0NTU1MTkxZDIxMjEyOGUzYWE3YjkxMDRhYTVj
NDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjItMDMtMDcgIFNpaHVpIExpdSAgPHNpaHVpX2xp
dUBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIGVhcmx5IHJldHVybiBmb3IgZW1wdHkgcGF0aCBp
biBtYWtlQWxsRGlyZWN0b3JpZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTIzNzU0MAorICAgICAgICByZGFyOi8vODk5MDE1MzYKKworICAgICAgICBS
ZXZpZXdlZCBieSBDaHJpcyBEdW1lei4KKworICAgICAgICAqIHd0Zi9wb3NpeC9GaWxlU3lzdGVt
UE9TSVguY3BwOgorICAgICAgICAoV1RGOjpGaWxlU3lzdGVtSW1wbDo6bWFrZUFsbERpcmVjdG9y
aWVzKToKKwogMjAyMi0wMy0wNyAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAg
ICAgICAgIE9wdGltaXplIHRoZSBwYXNzaW5nIG9mIGRhdGEgYWNyb3NzIHRocmVhZHMKZGlmZiAt
LWdpdCBhL1NvdXJjZS9XVEYvd3RmL3Bvc2l4L0ZpbGVTeXN0ZW1QT1NJWC5jcHAgYi9Tb3VyY2Uv
V1RGL3d0Zi9wb3NpeC9GaWxlU3lzdGVtUE9TSVguY3BwCmluZGV4IGFlMGE3MDZmNTY1MWQ1MWI4
MzliMTg5YWRkZjQ4NWYwNDQxNDdmZTkuLjFlYjc0YzdmOWFhOTAyYmRiODE5MWVmNWE4MGQwNmFm
ZjQxY2I1NDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL3Bvc2l4L0ZpbGVTeXN0ZW1QT1NJ
WC5jcHAKKysrIGIvU291cmNlL1dURi93dGYvcG9zaXgvRmlsZVN5c3RlbVBPU0lYLmNwcApAQCAt
MjcwLDE0ICsyNzAsMTMgQEAgYm9vbCBkZWxldGVGaWxlKGNvbnN0IFN0cmluZyYgcGF0aCkKIGJv
b2wgbWFrZUFsbERpcmVjdG9yaWVzKGNvbnN0IFN0cmluZyYgcGF0aCkKIHsKICAgICBhdXRvIGZ1
bGxQYXRoID0gZmlsZVN5c3RlbVJlcHJlc2VudGF0aW9uKHBhdGgpOwotICAgIGlmIChmdWxsUGF0
aC5pc051bGwoKSkKKyAgICBpZiAoZnVsbFBhdGguaXNFbXB0eSgpKQogICAgICAgICByZXR1cm4g
ZmFsc2U7CiAKICAgICBpZiAoIWFjY2VzcyhmdWxsUGF0aC5kYXRhKCksIEZfT0spKQogICAgICAg
ICByZXR1cm4gdHJ1ZTsKIAogICAgIGNoYXIqIHAgPSBmdWxsUGF0aC5tdXRhYmxlRGF0YSgpICsg
MTsKLSAgICBpbnQgbGVuZ3RoID0gZnVsbFBhdGgubGVuZ3RoKCk7CiAgICAgaWYgKHBbbGVuZ3Ro
IC0gMV0gPT0gJy8nKQogICAgICAgICBwW2xlbmd0aCAtIDFdID0gJ1wwJzsKICAgICBmb3IgKDsg
KnA7ICsrcCkgewpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9n
CmluZGV4IGRlNTM4ZGFlMjE1NDhiNTVhMDM4YTFjZjNjYWVjNTVlM2ZjMzJjM2IuLmY0NDQyNzU1
NTE3NmU1NGQ1ODhjODljNTk3MDliYmVlYzY0OWM5ZWIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5n
ZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAyMi0wMy0wNyAg
U2lodWkgTGl1ICA8c2lodWlfbGl1QGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgZWFybHkgcmV0
dXJuIGZvciBlbXB0eSBwYXRoIGluIG1ha2VBbGxEaXJlY3RvcmllcworICAgICAgICBodHRwczov
L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM3NTQwCisgICAgICAgIHJkYXI6Ly84
OTkwMTUzNgorCisgICAgICAgIFJldmlld2VkIGJ5IENocmlzIER1bWV6LgorCisgICAgICAgICog
VGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvRmlsZVN5c3RlbS5jcHA6CisgICAgICAgIChUZXN0V2Vi
S2l0QVBJOjpURVNUX0YpOgorCiAyMDIyLTAzLTA3ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBs
ZS5jb20+CiAKICAgICAgICAgT3B0aW1pemUgdGhlIHBhc3Npbmcgb2YgZGF0YSBhY3Jvc3MgdGhy
ZWFkcwpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvRmlsZVN5c3Rl
bS5jcHAgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9GaWxlU3lzdGVtLmNwcAppbmRl
eCBiMTkyZWQ4N2IwMzA5ZWFhODQyNjEzNTc1MWFlZmQyYTZmNzA0ZTMyLi41Zjk2Yjc1NmQzOTZl
MGQ5OTIxOGNkYjQxNGY5MzhjOTZkOTk0NmE5IDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0
QVBJL1Rlc3RzL1dURi9GaWxlU3lzdGVtLmNwcAorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rl
c3RzL1dURi9GaWxlU3lzdGVtLmNwcApAQCAtNDg5LDYgKzQ4OSw3IEBAIFRFU1RfRihGaWxlU3lz
dGVtVGVzdCwgbWFrZUFsbERpcmVjdG9yaWVzKQogICAgIGludmFsaWRGb2xkZXJQYXRoLmFwcGVu
ZCgnXDAnKTsKICAgICBpbnZhbGlkRm9sZGVyUGF0aC5hcHBlbmQoJ2EnKTsKICAgICBFWFBFQ1Rf
RkFMU0UoRmlsZVN5c3RlbTo6bWFrZUFsbERpcmVjdG9yaWVzKGludmFsaWRGb2xkZXJQYXRoKSk7
CisgICAgRVhQRUNUX0ZBTFNFKEZpbGVTeXN0ZW06Om1ha2VBbGxEaXJlY3RvcmllcyhlbXB0eVN0
cmluZygpKSk7CiB9CiAKIFRFU1RfRihGaWxlU3lzdGVtVGVzdCwgdm9sdW1lRnJlZVNwYWNlKQo=
</data>
<flag name="commit-queue"
          id="481591"
          type_id="3"
          status="-"
          setter="ews-feeder"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>454030</attachid>
            <date>2022-03-07 14:00:04 -0800</date>
            <delta_ts>2022-03-08 00:07:24 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-237540-20220307140003.patch</filename>
            <type>text/plain</type>
            <size>2704</size>
            <attacher name="Sihui Liu">sihui_liu</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwOTAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n
ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGRiNGUyODUzNDM4ZTM2MDk2MDkxZjU4
Mjg3YTZkN2E1YmI0YTI2MmYuLmFiZjRmMmVlMTM0NTU1MTkxZDIxMjEyOGUzYWE3YjkxMDRhYTVj
NDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjItMDMtMDcgIFNpaHVpIExpdSAgPHNpaHVpX2xp
dUBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIGVhcmx5IHJldHVybiBmb3IgZW1wdHkgcGF0aCBp
biBtYWtlQWxsRGlyZWN0b3JpZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTIzNzU0MAorICAgICAgICByZGFyOi8vODk5MDE1MzYKKworICAgICAgICBS
ZXZpZXdlZCBieSBDaHJpcyBEdW1lei4KKworICAgICAgICAqIHd0Zi9wb3NpeC9GaWxlU3lzdGVt
UE9TSVguY3BwOgorICAgICAgICAoV1RGOjpGaWxlU3lzdGVtSW1wbDo6bWFrZUFsbERpcmVjdG9y
aWVzKToKKwogMjAyMi0wMy0wNyAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAg
ICAgICAgIE9wdGltaXplIHRoZSBwYXNzaW5nIG9mIGRhdGEgYWNyb3NzIHRocmVhZHMKZGlmZiAt
LWdpdCBhL1NvdXJjZS9XVEYvd3RmL3Bvc2l4L0ZpbGVTeXN0ZW1QT1NJWC5jcHAgYi9Tb3VyY2Uv
V1RGL3d0Zi9wb3NpeC9GaWxlU3lzdGVtUE9TSVguY3BwCmluZGV4IGFlMGE3MDZmNTY1MWQ1MWI4
MzliMTg5YWRkZjQ4NWYwNDQxNDdmZTkuLmI3NDljYjE5MzZjZjJmZmU2MDcyNjEzZGQ5YzRlZjUw
OGZkNWQyMjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL3Bvc2l4L0ZpbGVTeXN0ZW1QT1NJ
WC5jcHAKKysrIGIvU291cmNlL1dURi93dGYvcG9zaXgvRmlsZVN5c3RlbVBPU0lYLmNwcApAQCAt
MjcwLDE0ICsyNzAsMTQgQEAgYm9vbCBkZWxldGVGaWxlKGNvbnN0IFN0cmluZyYgcGF0aCkKIGJv
b2wgbWFrZUFsbERpcmVjdG9yaWVzKGNvbnN0IFN0cmluZyYgcGF0aCkKIHsKICAgICBhdXRvIGZ1
bGxQYXRoID0gZmlsZVN5c3RlbVJlcHJlc2VudGF0aW9uKHBhdGgpOwotICAgIGlmIChmdWxsUGF0
aC5pc051bGwoKSkKKyAgICBpbnQgbGVuZ3RoID0gZnVsbFBhdGgubGVuZ3RoKCk7CisgICAgaWYg
KCFsZW5ndGgpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgIGlmICghYWNjZXNzKGZ1bGxQ
YXRoLmRhdGEoKSwgRl9PSykpCiAgICAgICAgIHJldHVybiB0cnVlOwogCiAgICAgY2hhciogcCA9
IGZ1bGxQYXRoLm11dGFibGVEYXRhKCkgKyAxOwotICAgIGludCBsZW5ndGggPSBmdWxsUGF0aC5s
ZW5ndGgoKTsKICAgICBpZiAocFtsZW5ndGggLSAxXSA9PSAnLycpCiAgICAgICAgIHBbbGVuZ3Ro
IC0gMV0gPSAnXDAnOwogICAgIGZvciAoOyAqcDsgKytwKSB7CmRpZmYgLS1naXQgYS9Ub29scy9D
aGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZGU1MzhkYWUyMTU0OGI1NWEwMzhhMWNm
M2NhZWM1NWUzZmMzMmMzYi4uZjQ0NDI3NTU1MTc2ZTU0ZDU4OGM4OWM1OTcwOWJiZWVjNjQ5Yzll
YiAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAt
MSwzICsxLDE0IEBACisyMDIyLTAzLTA3ICBTaWh1aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUuY29t
PgorCisgICAgICAgIEFkZCBlYXJseSByZXR1cm4gZm9yIGVtcHR5IHBhdGggaW4gbWFrZUFsbERp
cmVjdG9yaWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD0yMzc1NDAKKyAgICAgICAgcmRhcjovLzg5OTAxNTM2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Q2hyaXMgRHVtZXouCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9GaWxlU3lz
dGVtLmNwcDoKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OlRFU1RfRik6CisKIDIwMjItMDMtMDcg
IENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBPcHRpbWl6ZSB0aGUg
cGFzc2luZyBvZiBkYXRhIGFjcm9zcyB0aHJlYWRzCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2Vi
S2l0QVBJL1Rlc3RzL1dURi9GaWxlU3lzdGVtLmNwcCBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVz
dHMvV1RGL0ZpbGVTeXN0ZW0uY3BwCmluZGV4IGIxOTJlZDg3YjAzMDllYWE4NDI2MTM1NzUxYWVm
ZDJhNmY3MDRlMzIuLjVmOTZiNzU2ZDM5NmUwZDk5MjE4Y2RiNDE0ZjkzOGM5NmQ5OTQ2YTkgMTAw
NjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL0ZpbGVTeXN0ZW0uY3BwCisr
KyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL0ZpbGVTeXN0ZW0uY3BwCkBAIC00ODks
NiArNDg5LDcgQEAgVEVTVF9GKEZpbGVTeXN0ZW1UZXN0LCBtYWtlQWxsRGlyZWN0b3JpZXMpCiAg
ICAgaW52YWxpZEZvbGRlclBhdGguYXBwZW5kKCdcMCcpOwogICAgIGludmFsaWRGb2xkZXJQYXRo
LmFwcGVuZCgnYScpOwogICAgIEVYUEVDVF9GQUxTRShGaWxlU3lzdGVtOjptYWtlQWxsRGlyZWN0
b3JpZXMoaW52YWxpZEZvbGRlclBhdGgpKTsKKyAgICBFWFBFQ1RfRkFMU0UoRmlsZVN5c3RlbTo6
bWFrZUFsbERpcmVjdG9yaWVzKGVtcHR5U3RyaW5nKCkpKTsKIH0KIAogVEVTVF9GKEZpbGVTeXN0
ZW1UZXN0LCB2b2x1bWVGcmVlU3BhY2UpCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>