237522 2022-03-07 04:17:51 -0800 ANGLE display cache does not work with explicit device ids 2022-03-09 06:35:32 -0800 1 1 1 Unclassified WebKit WebGL WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 236487 1 kkinnunen kkinnunen dino ews-watchlist geofflang gman jonahr kbr kkinnunen kondapallykalyan kpiddington webkit-bug-importer oldest_to_newest 1848681 0 kkinnunen 2022-03-07 04:17:51 -0800 ANGLE display cache does not work with explicit device ids 1848685 1 453964 kkinnunen 2022-03-07 04:30:55 -0800 Created attachment 453964 Patch 1848686 2 ews-watchlist 2022-03-07 04:32:37 -0800 Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE 1848901 3 453964 kbr 2022-03-07 12:53:02 -0800 Comment on attachment 453964 Patch Looks good to me. r+ The win EWS bot failure is unrelated flakiness. Please upstream this as soon as possible to avoid duplicate work and reduce the chance of conflicts being introduced. Thanks. 1849123 4 453964 kkinnunen 2022-03-07 23:37:41 -0800 Comment on attachment 453964 Patch thanks! 1849219 5 ews-feeder 2022-03-08 05:43:21 -0800 Committed r290987 (248165@main): <https://commits.webkit.org/248165@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453964. 1849221 6 webkit-bug-importer 2022-03-08 05:44:16 -0800 <rdar://problem/89963372> 1849671 7 kkinnunen 2022-03-09 06:35:32 -0800 https://bugs.chromium.org/p/angleproject/issues/detail?id=7087 453964 2022-03-07 04:30:55 -0800 2022-03-08 05:43:23 -0800 Patch bug-237522-20220307143053.patch text/plain 5319 kkinnunen U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwODE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggY2Y1M2YxOWQyZDUxZjAxY2I3N2NmMjMwNzBiOWQwY2JkYmJkZGJlMS4uMjQ3Yjc3ZjQxMjlh OTkzNDdhZmFmNjRlM2Y4ODRjNmMzOTc2ZjZkMiAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDIxIEBACisyMDIyLTAzLTA3ICBLaW1tbyBLaW5udW5lbiAgPGtraW5udW5l bkBhcHBsZS5jb20+CisKKyAgICAgICAgQU5HTEUgZGlzcGxheSBjYWNoZSBkb2VzIG5vdCB3b3Jr IHdpdGggZXhwbGljaXQgZGV2aWNlIGlkcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjM3NTIyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisgICAgICAgIEFkZCBFR0xfUExBVEZPUk1fQU5HTEVfREVWSUNFX0lEX0hJR0hfQU5H TEUsIEVHTF9QTEFURk9STV9BTkdMRV9ERVZJQ0VfSURfTE9XX0FOR0xFCisgICAgICAgIHRvIHRo ZSBkaXNwbGF5IGNhY2hlIGtleSwgc28gdGhhdCBhIHJlcXVlc3QgZm9yIGEgZGlzcGxheSB3aXRo IGFuIGV4cGxpY2l0IGRldmljZSBkb2VzCisgICAgICAgIG5vdCBnZXQgcmVzb2x2ZWQgd2l0aCBh IGRpc3BsYXkgd2l0aG91dCBleHBsaWNpdCBkZXZpY2Ugb3Igd2l0aCBhIGRpc3BsYXkgd2l0aCBh bm90aGVyCisgICAgICAgIGV4cGxpY2l0IGRldmljZS4KKworICAgICAgICBXZWJLaXQgdGVzdHMg d2lsbCBiZSBhZGRlZCBvbmNlIHRoaXMgd2lsbCBiZSB1c2VkLgorICAgICAgICBBTkdMRSB0ZXN0 cyB3aWxsIGJlIGFkZGVkIG9uY2UgdXBzdHJlYW1lZC4KKworICAgICAgICAqIHNyYy9saWJBTkdM RS9EaXNwbGF5LmNwcDoKKyAgICAgICAgKGVnbDo6RGlzcGxheTo6R2V0RGlzcGxheUZyb21OYXRp dmVEaXNwbGF5KToKKyAgICAgICAgKGVnbDo6RGlzcGxheTo6fkRpc3BsYXkpOgorCiAyMDIyLTAz LTAyICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgogCiAgICAgICAgIENvcHkg V2ViS2l0IGZyYW1ld29ya3MgYW5kIFhQQyBwcm9jZXNzZXMgdG8gU2Vjb25kYXJ5IFBhdGgKZGlm ZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdMRS9EaXNwbGF5LmNw cCBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdMRS9EaXNwbGF5LmNwcAppbmRl eCA3ZGY1Yjc0MzZmZmI4NzgwYzFmZDdiZDZlY2M5NjkzMzAxYjg4MTM3Li5iNTNjNzBjNzNhOTll NjY1M2MwODcyYTUxN2E2ZThlZDEzMDg2NGUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9zcmMvbGliQU5HTEUvRGlzcGxheS5jcHAKKysrIGIvU291cmNlL1RoaXJkUGFydHkv QU5HTEUvc3JjL2xpYkFOR0xFL0Rpc3BsYXkuY3BwCkBAIC0xMDQsMjQgKzEwNCwyOCBAQCBzdHJ1 Y3QgQU5HTEVQbGF0Zm9ybURpc3BsYXkKICAgICBBTkdMRVBsYXRmb3JtRGlzcGxheSgpID0gZGVm YXVsdDsKIAogICAgIEFOR0xFUGxhdGZvcm1EaXNwbGF5KEVHTE5hdGl2ZURpc3BsYXlUeXBlIG5h dGl2ZURpc3BsYXlUeXBlKQotICAgICAgICA6IG5hdGl2ZURpc3BsYXlUeXBlKG5hdGl2ZURpc3Bs YXlUeXBlKSwKLSAgICAgICAgICBwb3dlclByZWZlcmVuY2UoRUdMX0xPV19QT1dFUl9BTkdMRSks Ci0gICAgICAgICAgcGxhdGZvcm1BTkdMRVR5cGUoRUdMX1BMQVRGT1JNX0FOR0xFX1RZUEVfREVG QVVMVF9BTkdMRSkKKyAgICAgICAgOiBuYXRpdmVEaXNwbGF5VHlwZShuYXRpdmVEaXNwbGF5VHlw ZSkKICAgICB7fQogCiAgICAgQU5HTEVQbGF0Zm9ybURpc3BsYXkoRUdMTmF0aXZlRGlzcGxheVR5 cGUgbmF0aXZlRGlzcGxheVR5cGUsCiAgICAgICAgICAgICAgICAgICAgICAgICAgRUdMQXR0cmli IHBvd2VyUHJlZmVyZW5jZSwKLSAgICAgICAgICAgICAgICAgICAgICAgICBFR0xBdHRyaWIgcGxh dGZvcm1BTkdMRVR5cGUpCisgICAgICAgICAgICAgICAgICAgICAgICAgRUdMQXR0cmliIHBsYXRm b3JtQU5HTEVUeXBlLAorICAgICAgICAgICAgICAgICAgICAgICAgIEVHTEF0dHJpYiBkZXZpY2VJ ZEhpZ2gsCisgICAgICAgICAgICAgICAgICAgICAgICAgRUdMQXR0cmliIGRldmljZUlkTG93KQog ICAgICAgICA6IG5hdGl2ZURpc3BsYXlUeXBlKG5hdGl2ZURpc3BsYXlUeXBlKSwKICAgICAgICAg ICBwb3dlclByZWZlcmVuY2UocG93ZXJQcmVmZXJlbmNlKSwKLSAgICAgICAgICBwbGF0Zm9ybUFO R0xFVHlwZShwbGF0Zm9ybUFOR0xFVHlwZSkKKyAgICAgICAgICBwbGF0Zm9ybUFOR0xFVHlwZShw bGF0Zm9ybUFOR0xFVHlwZSksCisgICAgICAgICAgZGV2aWNlSWRIaWdoKGRldmljZUlkSGlnaCks CisgICAgICAgICAgZGV2aWNlSWRMb3coZGV2aWNlSWRMb3cpCiAgICAge30KIAotICAgIGF1dG8g dGllKCkgY29uc3QgeyByZXR1cm4gc3RkOjp0aWUobmF0aXZlRGlzcGxheVR5cGUsIHBvd2VyUHJl ZmVyZW5jZSwgcGxhdGZvcm1BTkdMRVR5cGUpOyB9CisgICAgYXV0byB0aWUoKSBjb25zdCB7IHJl dHVybiBzdGQ6OnRpZShuYXRpdmVEaXNwbGF5VHlwZSwgcG93ZXJQcmVmZXJlbmNlLCBwbGF0Zm9y bUFOR0xFVHlwZSwgZGV2aWNlSWRIaWdoLCBkZXZpY2VJZExvdyk7IH0KIAotICAgIEVHTE5hdGl2 ZURpc3BsYXlUeXBlIG5hdGl2ZURpc3BsYXlUeXBlOwotICAgIEVHTEF0dHJpYiBwb3dlclByZWZl cmVuY2U7Ci0gICAgRUdMQXR0cmliIHBsYXRmb3JtQU5HTEVUeXBlOworICAgIEVHTE5hdGl2ZURp c3BsYXlUeXBlIG5hdGl2ZURpc3BsYXlUeXBlIHsgRUdMX0RFRkFVTFRfRElTUExBWSB9OworICAg IEVHTEF0dHJpYiBwb3dlclByZWZlcmVuY2UgeyBFR0xfTE9XX1BPV0VSX0FOR0xFIH07CisgICAg RUdMQXR0cmliIHBsYXRmb3JtQU5HTEVUeXBlIHsgRUdMX1BMQVRGT1JNX0FOR0xFX1RZUEVfREVG QVVMVF9BTkdMRSB9OworICAgIEVHTEF0dHJpYiBkZXZpY2VJZEhpZ2ggeyAwIH07CisgICAgRUdM QXR0cmliIGRldmljZUlkTG93IHsgMCB9OwogfTsKIAogaW5saW5lIGJvb2wgb3BlcmF0b3I8KGNv bnN0IEFOR0xFUGxhdGZvcm1EaXNwbGF5ICZhLCBjb25zdCBBTkdMRVBsYXRmb3JtRGlzcGxheSAm YikKQEAgLTY4Niw5ICs2OTAsMTEgQEAgRGlzcGxheSAqRGlzcGxheTo6R2V0RGlzcGxheUZyb21O YXRpdmVEaXNwbGF5KEVHTE5hdGl2ZURpc3BsYXlUeXBlIG5hdGl2ZURpc3BsYXkKICAgICAgICAg dXBkYXRlZEF0dHJpYk1hcC5nZXQoRUdMX1BPV0VSX1BSRUZFUkVOQ0VfQU5HTEUsIEVHTF9MT1df UE9XRVJfQU5HTEUpOwogICAgIEVHTEF0dHJpYiBwbGF0Zm9ybUFOR0xFVHlwZSA9CiAgICAgICAg IHVwZGF0ZWRBdHRyaWJNYXAuZ2V0KEVHTF9QTEFURk9STV9BTkdMRV9UWVBFX0FOR0xFLCBFR0xf UExBVEZPUk1fQU5HTEVfVFlQRV9ERUZBVUxUX0FOR0xFKTsKKyAgICBFR0xBdHRyaWIgZGV2aWNl SWRIaWdoID0gdXBkYXRlZEF0dHJpYk1hcC5nZXQoRUdMX1BMQVRGT1JNX0FOR0xFX0RFVklDRV9J RF9ISUdIX0FOR0xFLCAwKTsKKyAgICBFR0xBdHRyaWIgZGV2aWNlSWRMb3cgID0gdXBkYXRlZEF0 dHJpYk1hcC5nZXQoRUdMX1BMQVRGT1JNX0FOR0xFX0RFVklDRV9JRF9MT1dfQU5HTEUsIDApOwog ICAgIEFOR0xFUGxhdGZvcm1EaXNwbGF5TWFwICpkaXNwbGF5cyA9IEdldEFOR0xFUGxhdGZvcm1E aXNwbGF5TWFwKCk7Ci0gICAgY29uc3QgYXV0byAmaXRlciA9Ci0gICAgICAgIGRpc3BsYXlzLT5m aW5kKEFOR0xFUGxhdGZvcm1EaXNwbGF5KG5hdGl2ZURpc3BsYXksIHBvd2VyUHJlZmVyZW5jZSwg cGxhdGZvcm1BTkdMRVR5cGUpKTsKKyAgICBBTkdMRVBsYXRmb3JtRGlzcGxheSBkaXNwbGF5S2V5 KG5hdGl2ZURpc3BsYXksIHBvd2VyUHJlZmVyZW5jZSwgcGxhdGZvcm1BTkdMRVR5cGUsIGRldmlj ZUlkSGlnaCwgZGV2aWNlSWRMb3cpOworICAgIGNvbnN0IGF1dG8gJml0ZXIgPSBkaXNwbGF5cy0+ ZmluZChkaXNwbGF5S2V5KTsKICAgICBpZiAoaXRlciAhPSBkaXNwbGF5cy0+ZW5kKCkpCiAgICAg ewogICAgICAgICBkaXNwbGF5ID0gaXRlci0+c2Vjb25kOwpAQCAtNzAzLDggKzcwOSw3IEBAIERp c3BsYXkgKkRpc3BsYXk6OkdldERpc3BsYXlGcm9tTmF0aXZlRGlzcGxheShFR0xOYXRpdmVEaXNw bGF5VHlwZSBuYXRpdmVEaXNwbGF5CiAgICAgICAgIH0KIAogICAgICAgICBkaXNwbGF5ID0gbmV3 IERpc3BsYXkoRUdMX1BMQVRGT1JNX0FOR0xFX0FOR0xFLCBuYXRpdmVEaXNwbGF5LCBudWxscHRy KTsKLSAgICAgICAgZGlzcGxheXMtPmluc2VydChzdGQ6Om1ha2VfcGFpcigKLSAgICAgICAgICAg IEFOR0xFUGxhdGZvcm1EaXNwbGF5KG5hdGl2ZURpc3BsYXksIHBvd2VyUHJlZmVyZW5jZSwgcGxh dGZvcm1BTkdMRVR5cGUpLCBkaXNwbGF5KSk7CisgICAgICAgIGRpc3BsYXlzLT5pbnNlcnQoc3Rk OjptYWtlX3BhaXIoZGlzcGxheUtleSwgZGlzcGxheSkpOwogICAgIH0KICAgICAvLyBBcHBseSBu ZXcgYXR0cmlidXRlcyBpZiB0aGUgZGlzcGxheSBpcyBub3QgaW5pdGlhbGl6ZWQgeWV0LgogICAg IGlmICghZGlzcGxheS0+aXNJbml0aWFsaXplZCgpKQpAQCAtODU2LDcgKzg2MSw5IEBAIERpc3Bs YXk6On5EaXNwbGF5KCkKICAgICAgICAgQU5HTEVQbGF0Zm9ybURpc3BsYXlNYXA6Oml0ZXJhdG9y IGl0ZXIgPSBkaXNwbGF5cy0+ZmluZChBTkdMRVBsYXRmb3JtRGlzcGxheSgKICAgICAgICAgICAg IG1TdGF0ZS5kaXNwbGF5SWQsIG1BdHRyaWJ1dGVNYXAuZ2V0KEVHTF9QT1dFUl9QUkVGRVJFTkNF X0FOR0xFLCBFR0xfTE9XX1BPV0VSX0FOR0xFKSwKICAgICAgICAgICAgIG1BdHRyaWJ1dGVNYXAu Z2V0KEVHTF9QTEFURk9STV9BTkdMRV9UWVBFX0FOR0xFLAotICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgRUdMX1BMQVRGT1JNX0FOR0xFX1RZUEVfREVGQVVMVF9BTkdMRSkpKTsKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIEVHTF9QTEFURk9STV9BTkdMRV9UWVBFX0RFRkFVTFRf QU5HTEUpLAorICAgICAgICAgICAgbUF0dHJpYnV0ZU1hcC5nZXQoRUdMX1BMQVRGT1JNX0FOR0xF X0RFVklDRV9JRF9ISUdIX0FOR0xFLCAwKSwKKyAgICAgICAgICAgIG1BdHRyaWJ1dGVNYXAuZ2V0 KEVHTF9QTEFURk9STV9BTkdMRV9ERVZJQ0VfSURfTE9XX0FOR0xFLCAwKSkpOwogICAgICAgICBp ZiAoaXRlciAhPSBkaXNwbGF5cy0+ZW5kKCkpCiAgICAgICAgIHsKICAgICAgICAgICAgIGRpc3Bs YXlzLT5lcmFzZShpdGVyKTsK