237519 2022-03-07 03:08:49 -0800 [GTK][WPE] Do not add new modules under ThirdParty to the tarball 2022-03-08 01:19:26 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned aperez bugs-noreply mcatanzaro oldest_to_newest 1848666 0 cgarcia 2022-03-07 03:08:49 -0800 We currently include ThirdParty and exclude individually what we don't want in the tarball. That means every time something new is added to ThirdParty we have to manually exclude it. It's better to exclude ThirdParty and manually add what we need instead. 1848667 1 453956 cgarcia 2022-03-07 03:10:27 -0800 Created attachment 453956 Patch 1848688 2 453956 aperez 2022-03-07 04:41:26 -0800 Comment on attachment 453956 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453956&action=review > Tools/wpe/manifest.txt.in:-50 > -exclude Source/ThirdParty/capstone We may want to keep the capstone subdirectory because the JSCOnly uses it unconditionally, and removing it would make it impossible to build JSCOnly from our release tarballs. OTOH, many Linux distributions have packages for Capstone, so we may be able to link against system libraries and avoid the bundling 🤔️ 1848695 3 cgarcia 2022-03-07 05:17:41 -0800 I guess nobody have ever tried to build jsconly from a tarball then. In any case, I think it's better not to change the behavior in this patch. 1848737 4 453956 mcatanzaro 2022-03-07 06:55:36 -0800 Comment on attachment 453956 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453956&action=review > Tools/gtk/manifest.txt.in:62 > +directory Source/ThirdParty/gtest Another random note: I'm not sure this actually works from tarball builds. The tests that use gtest probably require other stuff that's not in the tarballs. Investigating that has been on my TODO for years. :P I agree it's best not to change behavior in this patch, though. 1848744 5 aperez 2022-03-07 07:11:01 -0800 (In reply to Carlos Garcia Campos from comment #3) > I guess nobody have ever tried to build jsconly from a tarball then. In any > case, I think it's better not to change the behavior in this patch. I built JSCOnly a few times in the past (around the 2.30.x - 2.32.x series) and it used to work, but I haven't tried in a while. 1848753 6 aperez 2022-03-07 07:44:16 -0800 (In reply to Adrian Perez from comment #5) > (In reply to Carlos Garcia Campos from comment #3) > > I guess nobody have ever tried to build jsconly from a tarball then. In any > > case, I think it's better not to change the behavior in this patch. > > I built JSCOnly a few times in the past (around the 2.30.x - 2.32.x series) > and it used to work, but I haven't tried in a while. I just tried building JSCOnly using the sources from the WPE WebKit 2.34.6 release tarball and it worked fine :] OTOH we never had made the promise that this would work, so ¯\_(ツ)_/¯ 1849153 7 cgarcia 2022-03-08 01:13:38 -0800 Committed r290982 (248160@trunk): <https://commits.webkit.org/248160@trunk> 453956 2022-03-07 03:10:27 -0800 2022-03-08 01:19:26 -0800 Patch wk-third-party-tarballs.diff text/plain 2801 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA5MDEx MjczZTVmNDAuLjJlOTZhYmI1NThjMSAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBi L1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIyLTAzLTA3ICBDYXJsb3MgR2Fy Y2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXVtXUEVdIERv IG5vdCBhZGQgbmV3IG1vZHVsZXMgdW5kZXIgVGhpcmRQYXJ0eSB0byB0aGUgdGFyYmFsbAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM3NTE5CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgY3VycmVudGx5 IGluY2x1ZGUgVGhpcmRQYXJ0eSBhbmQgZXhjbHVkZSBpbmRpdmlkdWFsbHkgd2hhdCB3ZSBkb24n dCB3YW50IGluIHRoZSB0YXJiYWxsLiBUaGF0IG1lYW5zIGV2ZXJ5CisgICAgICAgIHRpbWUgc29t ZXRoaW5nIG5ldyBpcyBhZGRlZCB0byBUaGlyZFBhcnR5IHdlIGhhdmUgdG8gbWFudWFsbHkgZXhj bHVkZSBpdC4gSXQncyBiZXR0ZXIgdG8gZXhjbHVkZSBUaGlyZFBhcnR5IGFuZAorICAgICAgICBt YW51YWxseSBhZGQgd2hhdCB3ZSBuZWVkIGluc3RlYWQuCisKKyAgICAgICAgKiBndGsvbWFuaWZl c3QudHh0LmluOgorICAgICAgICAqIHdwZS9tYW5pZmVzdC50eHQuaW46CisKIDIwMjItMDMtMDcg IENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtH VEtdW1dQRV0gQWRkIGluaXRpYWwgc3VwcG9ydCBmb3IgUERGIGRvY3VtZW50cyB1c2luZyBQREYu anMKZGlmZiAtLWdpdCBhL1Rvb2xzL2d0ay9tYW5pZmVzdC50eHQuaW4gYi9Ub29scy9ndGsvbWFu aWZlc3QudHh0LmluCmluZGV4IGIwYTk4MGY4MDE3OS4uMjc4ZDJlZGI2Yzg3IDEwMDY0NAotLS0g YS9Ub29scy9ndGsvbWFuaWZlc3QudHh0LmluCisrKyBiL1Rvb2xzL2d0ay9tYW5pZmVzdC50eHQu aW4KQEAgLTQ3LDEwICs0Nyw2IEBAIGV4Y2x1ZGUgLipcLyhDb25maWd1cmF0aW9uc3xtYWN8aW9z fGNmfGNnfGNvY29hfENvY29hfG9iamN8YXZmb3VuZGF0aW9ufGNhfGN1cmx8CiAKIGRpcmVjdG9y eSBTb3VyY2UKIGV4Y2x1ZGUgU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzCi1leGNsdWRlIFNv dXJjZS9UaGlyZFBhcnR5L2NhcHN0b25lCi1leGNsdWRlIFNvdXJjZS9UaGlyZFBhcnR5L2xpYndl YnJ0YwotZXhjbHVkZSBTb3VyY2UvVGhpcmRQYXJ0eS9xdW5pdAotZXhjbHVkZSBTb3VyY2UvVGhp cmRQYXJ0eS9vcGVudnIKIGV4Y2x1ZGUgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vcmVz b3VyY2VzCiBleGNsdWRlIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdAogZXhj bHVkZSBTb3VyY2UvV2ViQ29yZS9SZXNvdXJjZXMKQEAgLTYxLDYgKzU3LDExIEBAIGV4Y2x1ZGUg U291cmNlL2NtYWtlL09wdGlvbnNBcHBsZVdpbi5jbWFrZSQKIGV4Y2x1ZGUgU291cmNlL2NtYWtl L09wdGlvbnNXUEUuY21ha2UkCiBleGNsdWRlIFNvdXJjZS9XZWJJbnNwZWN0b3JVSS9Ub29scwog CitleGNsdWRlIFNvdXJjZS9UaGlyZFBhcnR5CitkaXJlY3RvcnkgU291cmNlL1RoaXJkUGFydHkv QU5HTEUKK2RpcmVjdG9yeSBTb3VyY2UvVGhpcmRQYXJ0eS9ndGVzdAorZGlyZWN0b3J5IFNvdXJj ZS9UaGlyZFBhcnR5L3hkZ21pbWUKKwogZXhjbHVkZSBTb3VyY2UvV2ViS2l0L1Jlc291cmNlcwog ZGlyZWN0b3J5IFNvdXJjZS9XZWJLaXQvUmVzb3VyY2VzL2d0awogCmRpZmYgLS1naXQgYS9Ub29s cy93cGUvbWFuaWZlc3QudHh0LmluIGIvVG9vbHMvd3BlL21hbmlmZXN0LnR4dC5pbgppbmRleCBh MWM4NGVmNWNjNWUuLjM5NmEyNDA3ODRkMSAxMDA2NDQKLS0tIGEvVG9vbHMvd3BlL21hbmlmZXN0 LnR4dC5pbgorKysgYi9Ub29scy93cGUvbWFuaWZlc3QudHh0LmluCkBAIC00NywxMCArNDcsNiBA QCBleGNsdWRlIC4qXC8oQ29uZmlndXJhdGlvbnN8bWFjfGlvc3xjZnxjZ3xjb2NvYXxDb2NvYXxv YmpjfGF2Zm91bmRhdGlvbnxjYXxjdXJsfAogCiBkaXJlY3RvcnkgU291cmNlCiBleGNsdWRlIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cwotZXhjbHVkZSBTb3VyY2UvVGhpcmRQYXJ0eS9jYXBz dG9uZQotZXhjbHVkZSBTb3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMKLWV4Y2x1ZGUgU291cmNl L1RoaXJkUGFydHkvcXVuaXQKLWV4Y2x1ZGUgU291cmNlL1RoaXJkUGFydHkvb3BlbnZyCiBleGNs dWRlIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL3Jlc291cmNlcwogZXhjbHVkZSBTb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QKIGV4Y2x1ZGUgU291cmNlL1dlYkNvcmUv UmVzb3VyY2VzCkBAIC02MSw2ICs1NywxMSBAQCBleGNsdWRlIFNvdXJjZS9jbWFrZS9PcHRpb25z QXBwbGVXaW4uY21ha2UkCiBleGNsdWRlIFNvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlJAog ZXhjbHVkZSBTb3VyY2UvV2ViSW5zcGVjdG9yVUkvVG9vbHMKIAorZXhjbHVkZSBTb3VyY2UvVGhp cmRQYXJ0eQorZGlyZWN0b3J5IFNvdXJjZS9UaGlyZFBhcnR5L0FOR0xFCitkaXJlY3RvcnkgU291 cmNlL1RoaXJkUGFydHkvZ3Rlc3QKK2RpcmVjdG9yeSBTb3VyY2UvVGhpcmRQYXJ0eS94ZGdtaW1l CisKIGV4Y2x1ZGUgU291cmNlL1dlYktpdC9SZXNvdXJjZXMKIAogIyBXZSBkbyB3YW50IHRvIGlu Y2x1ZGUgdGhlIE5FV1MsIGJ1dCB3ZSB3YW50IGl0IHRvIGJlIGluIHRoZSByb290IG9mIHRoZSBh cmNoaXZlLgo=