237510 2022-03-06 22:01:37 -0800 Add options to filter generate-compile-commands output 2026-02-19 06:13:23 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED WONTFIX InRadar P2 Normal --- 1 brandonstewart brandonstewart ap emw saam webkit-bug-importer oldest_to_newest 1848626 0 brandonstewart 2022-03-06 22:01:37 -0800 Add options to filter generate-compile-commands output 1848627 1 453944 brandonstewart 2022-03-06 22:08:07 -0800 Created attachment 453944 patch 1848628 2 brandonstewart 2022-03-06 22:18:12 -0800 The generate-compile-commands generates data for all sources compiled (except third party), however, users may only care about a subset of the files. This allows users to output a more focused compile_commands.json with only the directories they care about. Passing no parameters will output all sources like before. How to use: generate-compile-commands WebKitBuild/Debug/ --exclude_bmalloc --exclude_jsc This will filter out the bmalloc and JavaScriptCore directories from compile_commands.json. 1848783 3 ap 2022-03-07 09:00:21 -0800 It's not really clear to me when one would what to exclude specific directories. I believe you that there is a use case, but it's hard to me to comment without understanding it. In the department on bike shed painting, I think that the names should use dashes, not underscores. Or alternatively, --exclude wtf,jsc,tools 1848975 4 emw 2022-03-07 14:31:36 -0800 I would love to not have a hard-coded list of projects in here. Can you do this while matching path or target names in a more generic way? My understanding of the problem is that we emit so much build metadata that clangd is sluggish, and the recommended solution is to skip merging compile commands from third-party sources. This feels like a reasonable default. Could we do automatically so that engineers don't have to know about these options? Also, I'm curious if our cmake-based ports have a similar problem with clangd, and if so, whether they've done anything to address it. 1850792 5 webkit-bug-importer 2022-03-13 23:02:15 -0700 <rdar://problem/90230511> 453944 2022-03-06 22:08:07 -0800 2022-03-24 08:18:47 -0700 patch 237510.patch text/plain 6928 brandonstewart ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxMDM4 NzZiZDllOGIuLmY5MWVmODBjMmM1MyAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBi L1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIyLTAzLTA2ICBCcmFuZG9uIFN0 ZXdhcnQgIDxicmFuZG9uc3Rld2FydEBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIG9wdGlvbnMg dG8gZmlsdGVyIGdlbmVyYXRlLWNvbXBpbGUtY29tbWFuZHMgb3V0cHV0CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzc1MTAKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgb3B0aW9ucyB0byBmaWx0ZXIg dGhlIG91dHB1dCBvZiBnZW5lcmF0ZS1jb21waWxlLWNvbW1hbmRzLiBUaGUgdXNlciBjYW4gbm93 IGZpbHRlciBiYXNlZCBvbgorICAgICAgICBhbGwgbWFqb3IgZGlyZWN0b3JpZXMgaW4gU291cmNl LgorCisgICAgICAgIEV4YW1wbGU6CisgICAgICAgIGdlbmVyYXRlLWNvbXBpbGUtY29tbWFuZHMg V2ViS2l0QnVpbGQvRGVidWcvIC0tZXhjbHVkZV9ibWFsbG9jIC0tZXhjbHVkZV9qc2MKKworICAg ICAgICAqIFNjcmlwdHMvZ2VuZXJhdGUtY29tcGlsZS1jb21tYW5kczoKKwogMjAyMi0wMy0wNCAg QWRpdHlhIEtlZXJ0aGkgIDxha2VlcnRoaUBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gVW5h YmxlIHRvIHNjcm9sbCB0byBhIGZvdW5kIHRleHQgcmFuZ2Ugd2hlbiB0aGVyZSBpcyBhbiBleGlz dGluZyBzZWxlY3Rpb24KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvZ2VuZXJhdGUtY29tcGls ZS1jb21tYW5kcyBiL1Rvb2xzL1NjcmlwdHMvZ2VuZXJhdGUtY29tcGlsZS1jb21tYW5kcwppbmRl eCAxYzNmMGJmMTlkZWUuLjZmN2NlZjhhNzI5ZSAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9n ZW5lcmF0ZS1jb21waWxlLWNvbW1hbmRzCisrKyBiL1Rvb2xzL1NjcmlwdHMvZ2VuZXJhdGUtY29t cGlsZS1jb21tYW5kcwpAQCAtMzYsMTcgKzM2LDU0IEBAIGltcG9ydCBqc29uCiBpbXBvcnQgYXJn cGFyc2UKIAogIyBHZXQgY29tbWFuZCBsaW5lIGFyZ3MKLXBhcnNlciA9IGFyZ3BhcnNlLkFyZ3Vt ZW50UGFyc2VyKGRlc2NyaXB0aW9uPSdHZW5lcmF0ZSBjb21waWxlX2NvbW1hbmRzLmpzb24nLCAK LSAgICAgICAgICAgIHVzYWdlPSIiIgotICAgICAgICAgICAgICAgICAgbWFrZSByIEVYUE9SVF9D T01QSUxFX0NPTU1BTkRTPVlFUwotICAgICAgICAgICAgICAgICAgZ2VuZXJhdGUtY29tcGlsZS1j b21tYW5kcyBXZWJLaXRCdWlsZC9SZWxlYXNlCitwYXJzZXIgPSBhcmdwYXJzZS5Bcmd1bWVudFBh cnNlcihkZXNjcmlwdGlvbj0nR2VuZXJhdGUgY29tcGlsZV9jb21tYW5kcy5qc29uJywKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVzYWdlPSIiIgorbWFrZSByIEVYUE9SVF9DT01Q SUxFX0NPTU1BTkRTPVlFUworZ2VuZXJhdGUtY29tcGlsZS1jb21tYW5kcyBXZWJLaXRCdWlsZC9S ZWxlYXNlCisKK2h0dHBzOi8vdHJhYy53ZWJraXQub3JnL3dpa2kvQ2xhbmdkCisiIiIpCisKK3Bh cnNlci5hZGRfYXJndW1lbnQoJ2J1aWx0X3Byb2R1Y3RzX2RpcicsCisgICAgICAgICAgICAgICAg ICAgIGhlbHA9J3BhdGggdG8gdGhlIGJ1aWxkIGRpcmVjdG9yeSBjb250YWluaW5nIGdlbmVyYXRl ZCBjb21waWxlIGNvbW1hbmRzIChleDogV2ViS2l0QnVpbGQvUmVsZWFzZSknKQorCitwYXJzZXIu YWRkX2FyZ3VtZW50KCctLWV4Y2x1ZGVfYm1hbGxvYycsIGhlbHA9J2V4Y2x1ZGUgYm1hbGxvYyBm cm9tIGNvbXBpbGVfY29tbWFuZHMuanNvbicsIGFjdGlvbj0nc3RvcmVfdHJ1ZScpCitwYXJzZXIu YWRkX2FyZ3VtZW50KCctLWV4Y2x1ZGVfanNjJywgaGVscD0nZXhjbHVkZSBKYXZhU2NyaXB0Q29y ZSBmcm9tIGNvbXBpbGVfY29tbWFuZHMuanNvbicsIGFjdGlvbj0nc3RvcmVfdHJ1ZScpCitwYXJz ZXIuYWRkX2FyZ3VtZW50KCctLWV4Y2x1ZGVfdG9vbHMnLCBoZWxwPSdleGNsdWRlIFRvb2xzIGZy b20gY29tcGlsZV9jb21tYW5kcy5qc29uJywgYWN0aW9uPSdzdG9yZV90cnVlJykKK3BhcnNlci5h ZGRfYXJndW1lbnQoJy0tZXhjbHVkZV93ZWJjb3JlJywgaGVscD0nZXhjbHVkZSBXZWJDb3JlIGZy b20gY29tcGlsZV9jb21tYW5kcy5qc29uJywgYWN0aW9uPSdzdG9yZV90cnVlJykKK3BhcnNlci5h ZGRfYXJndW1lbnQoJy0tZXhjbHVkZV93ZWJraXQnLCBoZWxwPSdleGNsdWRlIFdlYktpdCBmcm9t IGNvbXBpbGVfY29tbWFuZHMuanNvbicsIGFjdGlvbj0nc3RvcmVfdHJ1ZScpCitwYXJzZXIuYWRk X2FyZ3VtZW50KCctLWV4Y2x1ZGVfd2Via2l0X2xlZ2FjeScsIGhlbHA9J2V4Y2x1ZGUgV2ViS2l0 TGVnYWN5IGZyb20gY29tcGlsZV9jb21tYW5kcy5qc29uJywgYWN0aW9uPSdzdG9yZV90cnVlJykK K3BhcnNlci5hZGRfYXJndW1lbnQoJy0tZXhjbHVkZV93ZWJfZ3B1JywgaGVscD0nZXhjbHVkZSBX ZWJHUFUgZnJvbSBjb21waWxlX2NvbW1hbmRzLmpzb24nLCBhY3Rpb249J3N0b3JlX3RydWUnKQor cGFyc2VyLmFkZF9hcmd1bWVudCgnLS1leGNsdWRlX3dlYl9pbnNwZWN0b3JfdWknLCBoZWxwPSdl eGNsdWRlIFdlYkluc3BlY3RvclVJIGZyb20gY29tcGlsZV9jb21tYW5kcy5qc29uJywgYWN0aW9u PSdzdG9yZV90cnVlJykKK3BhcnNlci5hZGRfYXJndW1lbnQoJy0tZXhjbHVkZV93dGYnLCBoZWxw PSdleGNsdWRlIFdURiBmcm9tIGNvbXBpbGVfY29tbWFuZHMuanNvbicsIGFjdGlvbj0nc3RvcmVf dHJ1ZScpCitwYXJzZXIuYWRkX2FyZ3VtZW50KCctLWluY2x1ZGVfdGhpcmRfcGFydHknLCBoZWxw PSdpbmNsdWRlIFRoaXJkUGFydHkgaW4gY29tcGlsZV9jb21tYW5kcy5qc29uICh0aGlzIGRpcmVj dG9yeSBpcyBleGNsdWRlZCBieSBkZWZhdWx0KScsIGFjdGlvbj0nc3RvcmVfdHJ1ZScpCiAKLSAg ICAgICAgICAgICAgICAgIGh0dHBzOi8vdHJhYy53ZWJraXQub3JnL3dpa2kvQ2xhbmdkCi0gICAg ICAgICAgICAgICAgICAiIiIpCi0KLXBhcnNlci5hZGRfYXJndW1lbnQoJ2J1aWx0X3Byb2R1Y3Rz X2RpcicsIGhlbHA9J3BhdGggdG8gdGhlIGJ1aWxkIGRpcmVjdG9yeSBjb250YWluaW5nIGdlbmVy YXRlZCBjb21waWxlIGNvbW1hbmRzIChleDogV2ViS2l0QnVpbGQvUmVsZWFzZSknKQogb3B0cyA9 IHBhcnNlci5wYXJzZV9hcmdzKCkKIAorIyBEZXRlcm1pbmUgd2hpY2ggcHJvamVjdHMgdG8gaW5j bHVkZQorZXhjbHVkZV9ibWFsbG9jID0gb3B0cy5leGNsdWRlX2JtYWxsb2MKK2V4Y2x1ZGVfanNj ID0gb3B0cy5leGNsdWRlX2pzYworZXhjbHVkZV90aGlyZF9wYXJ0eSA9IG5vdCBvcHRzLmluY2x1 ZGVfdGhpcmRfcGFydHkKK2V4Y2x1ZGVfdG9vbHMgPSBvcHRzLmV4Y2x1ZGVfdG9vbHMKK2V4Y2x1 ZGVfd2ViY29yZSA9IG9wdHMuZXhjbHVkZV93ZWJjb3JlCitleGNsdWRlX3dlYmtpdCA9IG9wdHMu ZXhjbHVkZV93ZWJraXQKK2V4Y2x1ZGVfd2Via2l0X2xlZ2FjeSA9IG9wdHMuZXhjbHVkZV93ZWJr aXRfbGVnYWN5CitleGNsdWRlX3dlYl9ncHUgPSBvcHRzLmV4Y2x1ZGVfd2ViX2dwdQorZXhjbHVk ZV93ZWJfaW5zcGVjdG9yX3VpID0gb3B0cy5leGNsdWRlX3dlYl9pbnNwZWN0b3JfdWkKK2V4Y2x1 ZGVfd3RmID0gb3B0cy5leGNsdWRlX3d0ZgorCitwcmludCgiSW5jbHVkaW5nIFByb2plY3RzOiIp CitwcmludCgiSW5jbHVkZSBibWFsbG9jICIgKyBzdHIobm90IGV4Y2x1ZGVfYm1hbGxvYykpCitw cmludCgiSW5jbHVkZSBKYXZhU2NyaXB0Q29yZSAiICsgc3RyKG5vdCBleGNsdWRlX2pzYykpCitw cmludCgiSW5jbHVkZSBUaGlyZFBhcnR5ICIgKyBzdHIobm90IGV4Y2x1ZGVfdGhpcmRfcGFydHkp KQorcHJpbnQoIkluY2x1ZGUgVG9vbHMgIiArIHN0cihub3QgZXhjbHVkZV90b29scykpCitwcmlu dCgiSW5jbHVkZSBXZWJDb3JlICIgKyBzdHIobm90IGV4Y2x1ZGVfd2ViY29yZSkpCitwcmludCgi SW5jbHVkZSBXZWJLaXQgIiArIHN0cihub3QgZXhjbHVkZV93ZWJraXQpKQorcHJpbnQoIkluY2x1 ZGUgV2ViS2l0TGVnYWN5ICIgKyBzdHIobm90IGV4Y2x1ZGVfd2Via2l0X2xlZ2FjeSkpCitwcmlu dCgiSW5jbHVkZSBXZWJHUFUgIiArIHN0cihub3QgZXhjbHVkZV93ZWJfZ3B1KSkKK3ByaW50KCJJ bmNsdWRlIFdlYkluc3BlY3RvclVJICIgKyBzdHIobm90IGV4Y2x1ZGVfd2ViX2luc3BlY3Rvcl91 aSkpCitwcmludCgiSW5jbHVkZSBXVEYgIiArIHN0cihub3QgZXhjbHVkZV93dGYpKQorCiAjIENo YW5nZSB0byB0aGUgcm9vdCBvZiBXZWJLaXQgRGlyZWN0b3J5CiBmaWxlX2RpciA9IG9zLnBhdGgu ZGlybmFtZShvcy5wYXRoLnJlYWxwYXRoKF9fZmlsZV9fKSkKIGJhc2VfZGlyID0gZmlsZV9kaXIg KyAiLy4uLy4uLyIKQEAgLTczLDIxICsxMTAsNjAgQEAgaWYgbm90IG9zLnBhdGguZXhpc3RzKGNv bXBpbGVfY29tbWFuZHNfZGlyKToKICMgVmFsdWUgLSBUaW1lc3RhbXAgY29udGVudHMKIGZpbGVz ID0gZGljdCgpCiAKLSMgRG8gbm90IGluZGV4IHRoaXJkIHBhcnR5IGNvZGUuCi0jIE1vc3QgcGVv cGxlIHByb2JhYmx5IGRvIG5vdCBuZWVkIGl0LgorYm1hbGxvY19yZWdleCA9IHJlLmNvbXBpbGUo J1NvdXJjZS9ibWFsbG9jJykKK2pzY19yZWdleCA9IHJlLmNvbXBpbGUoJ1NvdXJjZS9KYXZhU2Ny aXB0Q29yZScpCiB0aGlyZF9wYXJ0eV9yZWdleCA9IHJlLmNvbXBpbGUoJ1NvdXJjZS9UaGlyZFBh cnR5JykKK3Rvb2xzX3JlZ2V4ID0gcmUuY29tcGlsZSgnVG9vbHMnKQord2ViY29yZV9yZWdleCA9 IHJlLmNvbXBpbGUoJ1NvdXJjZS9XZWJDb3JlJykKK3dlYmtpdF9yZWdleCA9IHJlLmNvbXBpbGUo J1NvdXJjZS9XZWJLaXQnKQord2Via2l0X2xlZ2FjeV9yZWdleCA9IHJlLmNvbXBpbGUoJ1NvdXJj ZS9XZWJLaXRMZWdhY3knKQord2ViZ3B1X3JlZ2V4ID0gcmUuY29tcGlsZSgnU291cmNlL1dlYkdQ VScpCit3ZWJfaW5zcGVjdG9yX3VpX3JlZ2V4ID0gcmUuY29tcGlsZSgnU291cmNlL1dlYkluc3Bl Y3RvclVJJykKK3d0Zl9yZWdleCA9IHJlLmNvbXBpbGUoJ1NvdXJjZS9XVEYnKQogCiBmb3Igal9m aWxlX25hbWUgaW4gZ2xvYi5nbG9iKGNvbXBpbGVfY29tbWFuZHNfZGlyICsgIi8qLmpzb24iKToK LSAgICBqX2ZpbGUgPSBvcGVuKGpfZmlsZV9uYW1lLCAiciIpCi0gICAganNvbl9jb250ZW50cyA9 IGpfZmlsZS5yZWFkKCkKLQotICAgIGlmIHRoaXJkX3BhcnR5X3JlZ2V4LnNlYXJjaChqc29uX2Nv bnRlbnRzKToKLSAgICAgICAgY29udGludWUKKyAgICBqc29uX2ZpbGUgPSBvcGVuKGpfZmlsZV9u YW1lLCAiciIpCisgICAganNvbl9jb250ZW50cyA9IGpzb25fZmlsZS5yZWFkKCkKIAogICAgICMg VHJ5IHRvIGxvYWQgSlNPTiBGaWxlCi0gICAgdHJ5OiAKKyAgICB0cnk6CiAgICAgICAgICMgLTIg Z2V0cyByaWQgb2YgdGhlIGNvbW1hIGF0IHRoZSBlbmQgb2YgdGhlIGZpbGUuCi0gICAgICAgIGpz b24ubG9hZHMoanNvbl9jb250ZW50c1s6LTJdKQorICAgICAgICBqc29uX2RhdGEgPSBqc29uLmxv YWRzKGpzb25fY29udGVudHNbOi0yXSkKKyAgICAgICAgZGlyZWN0b3J5X3BhdGggPSBqc29uX2Rh dGFbImRpcmVjdG9yeSJdCisKKyAgICAgICAgIyBFeGNsdWRlIGFueSBmaWxlIGlmIGl0IGlzIG1h cmtlZCB0byBiZSBleGNsdWRlZCwgYW5kIGl0IG1hdGNoZXMgdGhlCisgICAgICAgICMgcmVnZXgg c2VhcmNoIG9uIHRoZSBkaXJlY3RvcnkuIFdlIG5lZWQgdG8gc3BlY2lmaWNhbGx5IGxvb2sgYXQg dGhlIGRpcmVjdG9yeQorICAgICAgICAjIGFzIHRoZSByZWdleCBtYXkgYXBwZWFyIGluIHRoZSBh cmd1bWVudHMgc2VjdGlvbiBvZiB0aGUganNvbiBmaWxlLCBidXQgbm90IGluIHRoZSBkaXJlY3Rv cnkgcGF0aC4KKyAgICAgICAgaWYgYm1hbGxvY19yZWdleC5zZWFyY2goZGlyZWN0b3J5X3BhdGgp IGFuZCBleGNsdWRlX2JtYWxsb2M6CisgICAgICAgICAgICBjb250aW51ZQorCisgICAgICAgIGlm IGpzY19yZWdleC5zZWFyY2goZGlyZWN0b3J5X3BhdGgpIGFuZCBleGNsdWRlX2pzYzoKKyAgICAg ICAgICAgIGNvbnRpbnVlCisKKyAgICAgICAgaWYgdGhpcmRfcGFydHlfcmVnZXguc2VhcmNoKGRp cmVjdG9yeV9wYXRoKSBhbmQgZXhjbHVkZV90aGlyZF9wYXJ0eToKKyAgICAgICAgICAgIGNvbnRp bnVlCisKKyAgICAgICAgaWYgdG9vbHNfcmVnZXguc2VhcmNoKGRpcmVjdG9yeV9wYXRoKSBhbmQg ZXhjbHVkZV90b29sczoKKyAgICAgICAgICAgIGNvbnRpbnVlCisKKyAgICAgICAgaWYgd2ViY29y ZV9yZWdleC5zZWFyY2goZGlyZWN0b3J5X3BhdGgpIGFuZCBleGNsdWRlX3dlYmNvcmU6CisgICAg ICAgICAgICBjb250aW51ZQorCisgICAgICAgIGlmIHdlYmtpdF9yZWdleC5zZWFyY2goZGlyZWN0 b3J5X3BhdGgpIGFuZCBleGNsdWRlX3dlYmtpdDoKKyAgICAgICAgICAgIGNvbnRpbnVlCisKKyAg ICAgICAgaWYgd2Via2l0X2xlZ2FjeV9yZWdleC5zZWFyY2goZGlyZWN0b3J5X3BhdGgpIGFuZCBl eGNsdWRlX3dlYmtpdF9sZWdhY3k6CisgICAgICAgICAgICBjb250aW51ZQorCisgICAgICAgIGlm IHdlYmdwdV9yZWdleC5zZWFyY2goZGlyZWN0b3J5X3BhdGgpIGFuZCBleGNsdWRlX3dlYl9ncHU6 CisgICAgICAgICAgICBjb250aW51ZQorCisgICAgICAgIGlmIHdlYl9pbnNwZWN0b3JfdWlfcmVn ZXguc2VhcmNoKGRpcmVjdG9yeV9wYXRoKSBhbmQgZXhjbHVkZV93ZWJfaW5zcGVjdG9yX3VpOgor ICAgICAgICAgICAgY29udGludWUKKworICAgICAgICBpZiB3dGZfcmVnZXguc2VhcmNoKGRpcmVj dG9yeV9wYXRoKSBhbmQgZXhjbHVkZV93dGY6CisgICAgICAgICAgICBjb250aW51ZQorCiAgICAg ZXhjZXB0IEV4Y2VwdGlvbjoKICAgICAgICAgcHJpbnQoIkludmFsaWQgSlNPTiBGaWxlOiAiICsg al9maWxlX25hbWUpCiAgICAgICAgIGNvbnRpbnVlCg==