237506 2022-03-06 06:11:29 -0800 [GTK] generate-automation-atom.py breaks reproducible builds 2022-03-07 08:38:43 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 berto aperez aperez bugs-noreply cgarcia mcatanzaro oldest_to_newest 1848589 0 berto 2022-03-06 06:11:29 -0800 Running this a few times in a row produces different output files: $ python3 Source/WebKit/Scripts/generate-automation-atom.py ./Source/WebKit/UIProcess/Automation/atoms/FindNodes.js out.js All generated files are equally valid and there are no semantic changes, it's just that the functions appear in different order. This results in different WebKitWebDriver binaries and therefore makes the builds non reproducible. 1848604 1 453933 aperez 2022-03-06 14:50:05 -0800 Created attachment 453933 Patch 1848613 2 453933 mcatanzaro 2022-03-06 16:31:29 -0800 Comment on attachment 453933 Patch Did this somehow break webkitpy tests, or is the EWS busted even without your patch? 1848693 3 453966 aperez 2022-03-07 04:49:24 -0800 Created attachment 453966 Patch v2 1848694 4 453966 berto 2022-03-07 05:17:14 -0800 Comment on attachment 453966 Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=453966&action=review > Source/WebKit/Scripts/generate-automation-atom.py:55 > def append_functions(utils_data, util_functions, util_functions_impl, functions_written): > + util_functions_list = list(util_functions) > + util_functions_list.sort() > for function in util_functions: You forgot to actually use util_functions_list in the for loop 1848742 5 aperez 2022-03-07 07:04:49 -0800 (In reply to Alberto Garcia from comment #4) > Comment on attachment 453966 [details] > Patch v2 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=453966&action=review > > > Source/WebKit/Scripts/generate-automation-atom.py:55 > > def append_functions(utils_data, util_functions, util_functions_impl, functions_written): > > + util_functions_list = list(util_functions) > > + util_functions_list.sort() > > for function in util_functions: > > You forgot to actually use util_functions_list in the for loop Of course 🤦️; I'll fix that before landing. 1848746 6 453979 aperez 2022-03-07 07:14:16 -0800 Created attachment 453979 Patch for landing 1848767 7 ews-feeder 2022-03-07 08:38:37 -0800 Committed r290890 (248121@main): <https://commits.webkit.org/248121@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453979. 453933 2022-03-06 14:50:05 -0800 2022-03-07 04:49:19 -0800 Patch bug-237506-20220307005004.patch text/plain 1375 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwODcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGY0NTgwZDZiNGVkMWExOTll ZjRiYTRjMjU5NjE0NzUyMGMzZDgwNDEuLjRiNTVjZTQ2OGFlNTk4ZWQyYzU5OTI0ZGVlOGM2MWE0 MTRlYWU3OTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjItMDMtMDYgIEFkcmlhbiBQ ZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBnZW5l cmF0ZS1hdXRvbWF0aW9uLWF0b20ucHkgYnJlYWtzIHJlcHJvZHVjaWJsZSBidWlsZHMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNzUwNgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy9nZW5l cmF0ZS1hdXRvbWF0aW9uLWF0b20ucHk6CisgICAgICAgIChhcHBlbmRfZnVuY3Rpb25zKTogU29y dCB1dGlsaXR5IGZ1bmN0aW9ucyB0byBwcm9kdWNlIHN0YWJsZSBvdXRwdXQuCisKIDIwMjItMDMt MDQgIFNpaHVpIExpdSAgPHNpaHVpX2xpdUBhcHBsZS5jb20+CiAKICAgICAgICAgU3RvcCBzZXR0 aW5nIE5TVVJMSXNFeGNsdWRlZEZyb21CYWNrdXBLZXkgYXR0cmlidXRlIGZvciBsb2NhbFNvcmFn ZURpcmVjdG9yeSBpbiBVSSBwcm9jZXNzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1Njcmlw dHMvZ2VuZXJhdGUtYXV0b21hdGlvbi1hdG9tLnB5IGIvU291cmNlL1dlYktpdC9TY3JpcHRzL2dl bmVyYXRlLWF1dG9tYXRpb24tYXRvbS5weQppbmRleCA4YjgyMmQ4YzQwMmQxOGQzZTgxNmUwMTAy YzAyNWZkNmMxMjUyMzM1Li5jOTg0YTYzMTgyZjk0YzM5MjUzNzI0OGFhYWRmNTRhZDI3NWQ3YmUz IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1NjcmlwdHMvZ2VuZXJhdGUtYXV0b21hdGlvbi1h dG9tLnB5CisrKyBiL1NvdXJjZS9XZWJLaXQvU2NyaXB0cy9nZW5lcmF0ZS1hdXRvbWF0aW9uLWF0 b20ucHkKQEAgLTUwLDcgKzUwLDcgQEAgZGVmIHBhcnNlX3V0aWxzKHV0aWxzKToKIAogCiBkZWYg YXBwZW5kX2Z1bmN0aW9ucyh1dGlsc19kYXRhLCB1dGlsX2Z1bmN0aW9ucywgdXRpbF9mdW5jdGlv bnNfaW1wbCwgZnVuY3Rpb25zX3dyaXR0ZW4pOgotICAgIGZvciBmdW5jdGlvbiBpbiB1dGlsX2Z1 bmN0aW9uczoKKyAgICBmb3IgZnVuY3Rpb24gaW4gc29ydGVkKHV0aWxfZnVuY3Rpb25zKToKICAg ICAgICAgaWYgZnVuY3Rpb24gaW4gZnVuY3Rpb25zX3dyaXR0ZW46CiAgICAgICAgICAgICBjb250 aW51ZQogCg== 453966 2022-03-07 04:49:24 -0800 2022-03-07 07:14:11 -0800 Patch v2 bug-237506-20220307144923.patch text/plain 1426 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwODc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDhlY2QxZTYyZDFiM2VkNDUw OGE1MzcwOWRjZjYwNzY4ZjlkNmU4ODguLjQ3Mzc5NmMxYzg1NjI2Zjg4ZWNlYmY2NjAzN2U3NjE2 ZTc2M2RlMGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjItMDMtMDcgIEFkcmlhbiBQ ZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBnZW5l cmF0ZS1hdXRvbWF0aW9uLWF0b20ucHkgYnJlYWtzIHJlcHJvZHVjaWJsZSBidWlsZHMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNzUwNgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy9nZW5l cmF0ZS1hdXRvbWF0aW9uLWF0b20ucHk6CisgICAgICAgIChhcHBlbmRfZnVuY3Rpb25zKTogU29y dCB1dGlsaXR5IGZ1bmN0aW9ucyB0byBwcm9kdWNlIHN0YWJsZSBvdXRwdXQuCisKIDIwMjItMDMt MDYgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgW2lP U10gTGF5ZXIgdHJlZSBjYW4gZ2V0IGluZGVmaW5pdGVseSBmcm96ZW4gaWYgV0tXZWJWaWV3IGlz IHVucGFyZW50ZWQgdW5kZXJuZWF0aCAtW1VJV2luZG93IGRlYWxsb2NdCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L1NjcmlwdHMvZ2VuZXJhdGUtYXV0b21hdGlvbi1hdG9tLnB5IGIvU291cmNl L1dlYktpdC9TY3JpcHRzL2dlbmVyYXRlLWF1dG9tYXRpb24tYXRvbS5weQppbmRleCA4YjgyMmQ4 YzQwMmQxOGQzZTgxNmUwMTAyYzAyNWZkNmMxMjUyMzM1Li4yZTA1ZGNlOWJkYjdhNjBmNTkxNzEz ZTk2NWY3YTc5MThkZjY3ZTgwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1NjcmlwdHMvZ2Vu ZXJhdGUtYXV0b21hdGlvbi1hdG9tLnB5CisrKyBiL1NvdXJjZS9XZWJLaXQvU2NyaXB0cy9nZW5l cmF0ZS1hdXRvbWF0aW9uLWF0b20ucHkKQEAgLTUwLDYgKzUwLDggQEAgZGVmIHBhcnNlX3V0aWxz KHV0aWxzKToKIAogCiBkZWYgYXBwZW5kX2Z1bmN0aW9ucyh1dGlsc19kYXRhLCB1dGlsX2Z1bmN0 aW9ucywgdXRpbF9mdW5jdGlvbnNfaW1wbCwgZnVuY3Rpb25zX3dyaXR0ZW4pOgorICAgIHV0aWxf ZnVuY3Rpb25zX2xpc3QgPSBsaXN0KHV0aWxfZnVuY3Rpb25zKQorICAgIHV0aWxfZnVuY3Rpb25z X2xpc3Quc29ydCgpCiAgICAgZm9yIGZ1bmN0aW9uIGluIHV0aWxfZnVuY3Rpb25zOgogICAgICAg ICBpZiBmdW5jdGlvbiBpbiBmdW5jdGlvbnNfd3JpdHRlbjoKICAgICAgICAgICAgIGNvbnRpbnVl Cg== 453979 2022-03-07 07:14:16 -0800 2022-03-07 08:38:40 -0800 Patch for landing bug-237506-20220307171414.patch text/plain 1476 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwODg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDhlY2QxZTYyZDFiM2VkNDUw OGE1MzcwOWRjZjYwNzY4ZjlkNmU4ODguLmJhY2ZlZDc5YjBjOWIyYmQ1MGEzN2MxNjExMmQzNWRj MWE3OTdmMzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjItMDMtMDcgIEFkcmlhbiBQ ZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBnZW5l cmF0ZS1hdXRvbWF0aW9uLWF0b20ucHkgYnJlYWtzIHJlcHJvZHVjaWJsZSBidWlsZHMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNzUwNgorCisgICAg ICAgIFJldmlld2VkIGJ5IENhcmxvcyBHYXJjaWEgQ2FtcG9zLgorCisgICAgICAgICogU2NyaXB0 cy9nZW5lcmF0ZS1hdXRvbWF0aW9uLWF0b20ucHk6CisgICAgICAgIChhcHBlbmRfZnVuY3Rpb25z KTogU29ydCB1dGlsaXR5IGZ1bmN0aW9ucyB0byBwcm9kdWNlIHN0YWJsZSBvdXRwdXQuCisKIDIw MjItMDMtMDYgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAg ICAgW2lPU10gTGF5ZXIgdHJlZSBjYW4gZ2V0IGluZGVmaW5pdGVseSBmcm96ZW4gaWYgV0tXZWJW aWV3IGlzIHVucGFyZW50ZWQgdW5kZXJuZWF0aCAtW1VJV2luZG93IGRlYWxsb2NdCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L1NjcmlwdHMvZ2VuZXJhdGUtYXV0b21hdGlvbi1hdG9tLnB5IGIv U291cmNlL1dlYktpdC9TY3JpcHRzL2dlbmVyYXRlLWF1dG9tYXRpb24tYXRvbS5weQppbmRleCA4 YjgyMmQ4YzQwMmQxOGQzZTgxNmUwMTAyYzAyNWZkNmMxMjUyMzM1Li44MGZmZjM5MWM1Zjc5ZWFm YThmOGYxM2MzOTE5YmRjM2MzMTA1NzQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1Njcmlw dHMvZ2VuZXJhdGUtYXV0b21hdGlvbi1hdG9tLnB5CisrKyBiL1NvdXJjZS9XZWJLaXQvU2NyaXB0 cy9nZW5lcmF0ZS1hdXRvbWF0aW9uLWF0b20ucHkKQEAgLTUwLDcgKzUwLDkgQEAgZGVmIHBhcnNl X3V0aWxzKHV0aWxzKToKIAogCiBkZWYgYXBwZW5kX2Z1bmN0aW9ucyh1dGlsc19kYXRhLCB1dGls X2Z1bmN0aW9ucywgdXRpbF9mdW5jdGlvbnNfaW1wbCwgZnVuY3Rpb25zX3dyaXR0ZW4pOgotICAg IGZvciBmdW5jdGlvbiBpbiB1dGlsX2Z1bmN0aW9uczoKKyAgICB1dGlsX2Z1bmN0aW9uc19saXN0 ID0gbGlzdCh1dGlsX2Z1bmN0aW9ucykKKyAgICB1dGlsX2Z1bmN0aW9uc19saXN0LnNvcnQoKQor ICAgIGZvciBmdW5jdGlvbiBpbiB1dGlsX2Z1bmN0aW9uc19saXN0OgogICAgICAgICBpZiBmdW5j dGlvbiBpbiBmdW5jdGlvbnNfd3JpdHRlbjoKICAgICAgICAgICAgIGNvbnRpbnVlCiAK