237504 2022-03-05 16:24:19 -0800 Fix JITOperationList::addPointers() to support JIT_OPERATION_VALIDATION_ASSERT_ENABLED. 2022-03-05 23:00:11 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1848567 0 mark.lam 2022-03-05 16:24:19 -0800 According to tagJSCCodePtrImpl(), we will only use an operation's validation entry if Options::useJITCage(). Make JITOperationList::addPointers() conform to this. <rdar://problem/89770507> 1848568 1 453923 mark.lam 2022-03-05 16:26:45 -0800 Created attachment 453923 [fast-cq] proposed patch. 1848580 2 453923 saam 2022-03-05 20:00:52 -0800 Comment on attachment 453923 [fast-cq] proposed patch. r=me 1848585 3 mark.lam 2022-03-05 22:56:27 -0800 The 2 failing tests on the Win EWS are: - fast/dom/connected-subframe-counter-overflow.html - fast/frames/exponential-frames.html According to: https://results.webkit.org/?suite=layout-tests&test=fast%2Fdom%2Fconnected-subframe-counter-overflow.html and https://results.webkit.org/?suite=layout-tests&test=fast%2Fframes%2Fexponential-frames.htm, the first is a flaky on Win10, and the second crashes all the time in recent builds. Also, this patch only populates a HashMap that is only used on Debug build. The Win EWS is running with a Release build. This patch only takes effect on ARM64E CPUs. The Win EWS runs on x86. Hence, these failures cannot be due to this patch. 1848586 4 453923 mark.lam 2022-03-05 22:57:23 -0800 Comment on attachment 453923 [fast-cq] proposed patch. Thanks for the review. Landing now. 1848587 5 ews-feeder 2022-03-05 23:00:09 -0800 Committed r290873 (248104@main): <https://commits.webkit.org/248104@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453923. 453923 2022-03-05 16:26:45 -0800 2022-03-05 23:00:10 -0800 [fast-cq] proposed patch. bug-237504.patch text/plain 1952 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjkwODcxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDIyLTAzLTA1ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBG aXggSklUT3BlcmF0aW9uTGlzdDo6YWRkUG9pbnRlcnMoKSB0byBzdXBwb3J0IEpJVF9PUEVSQVRJ T05fVkFMSURBVElPTl9BU1NFUlRfRU5BQkxFRC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNzUwNAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vODk3 NzA1MDc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QWNjb3JkaW5nIHRvIHRhZ0pTQ0NvZGVQdHJJbXBsKCksIHdlIHdpbGwgb25seSB1c2UgYW4gb3Bl cmF0aW9uJ3MgdmFsaWRhdGlvbiBlbnRyeQorICAgICAgICBpZiBPcHRpb25zOjp1c2VKSVRDYWdl KCkuICBNYWtlIEpJVE9wZXJhdGlvbkxpc3Q6OmFkZFBvaW50ZXJzKCkgY29uZm9ybSB0byB0aGlz LgorCisgICAgICAgICogYXNzZW1ibGVyL0pJVE9wZXJhdGlvbkxpc3QuY3BwOgorICAgICAgICAo SlNDOjpKSVRPcGVyYXRpb25MaXN0OjphZGRQb2ludGVycyk6CisKIDIwMjItMDMtMDUgIE1hcmsg TGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIE9wdGltaXplIFZNVHJhcHM6Om1h eWJlTmVlZEhhbmRsaW5nKCkuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVy L0pJVE9wZXJhdGlvbkxpc3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9hc3NlbWJsZXIvSklUT3BlcmF0aW9uTGlzdC5jcHAJKHJldmlzaW9uIDI5MDg3MSkKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvSklUT3BlcmF0aW9uTGlzdC5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTY2LDExICs2NiwxMSBAQCBTVVBQUkVTU19BU0FOIEFMV0FZU19JTkxJTkUg dm9pZCBKSVRPcGVyCiAgICAgICAgIHJldHVybjsKICAgICB9CiAjZW5kaWYKLSAgICBpZiBjb25z dGV4cHIgKEFTU0VSVF9FTkFCTEVEKSB7CisgICAgaWYgY29uc3RleHByIChKSVRfT1BFUkFUSU9O X1ZBTElEQVRJT05fQVNTRVJUX0VOQUJMRUQpIHsKICAgICAgICAgZm9yIChjb25zdCBhdXRvKiBj dXJyZW50ID0gYmVnaW47IGN1cnJlbnQgIT0gZW5kOyArK2N1cnJlbnQpIHsKICAgICAgICAgICAg IHZvaWQqIG9wZXJhdGlvbiA9IHJlbW92ZUNvZGVQdHJUYWcoY3VycmVudC0+b3BlcmF0aW9uKTsK ICAgICAgICAgICAgIGlmIChvcGVyYXRpb24pIHsKLSAgICAgICAgICAgICAgICB2b2lkKiB2YWxp ZGF0b3IgPSByZW1vdmVDb2RlUHRyVGFnKGN1cnJlbnQtPm9wZXJhdGlvbldpdGhWYWxpZGF0aW9u KTsKKyAgICAgICAgICAgICAgICB2b2lkKiB2YWxpZGF0b3IgPSByZW1vdmVDb2RlUHRyVGFnKE9w dGlvbnM6OnVzZUpJVENhZ2UoKSA/IGN1cnJlbnQtPm9wZXJhdGlvbldpdGhWYWxpZGF0aW9uIDog Y3VycmVudC0+b3BlcmF0aW9uKTsKICAgICAgICAgICAgICAgICB2YWxpZGF0b3IgPSBXVEY6OnRh Z05hdGl2ZUNvZGVQdHJJbXBsPE9wZXJhdGlvblB0clRhZz4odmFsaWRhdG9yKTsKICAgICAgICAg ICAgICAgICBtYXAuYWRkKG9wZXJhdGlvbiwgdmFsaWRhdG9yKTsKICAgICAgICAgICAgICAgICBK U0NfUkVHSVNURVJfSU5WRVJTRV9KSVRfQ0FHRURfUE9JTlRFUl9GT1JfREVCVUcodmFsaWRhdG9y LCBvcGVyYXRpb24pOwo=