237503 2022-03-05 11:22:27 -0800 Optimize VMTraps::maybeNeedHandling(). 2022-03-05 13:57:17 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1848545 0 mark.lam 2022-03-05 11:22:27 -0800 There's no need for VMTraps::maybeNeedHandling() to mask the VMTraps bits for events. Under normal circumstances, there are no traps firing and the traps bits are 0 anyway. We should optimize for this and do away with the masking. Clients who use VMTraps::maybeNeedHandling() should and current does call VMTraps::needHandling() to get the real story on whether there are actually traps to handle or not. Hence, the masking in VMTraps::maybeNeedHandling() is also not needed for correctness. 1848547 1 453916 mark.lam 2022-03-05 11:29:55 -0800 Created attachment 453916 proposed patch. 1848551 2 453916 saam 2022-03-05 12:58:01 -0800 Comment on attachment 453916 proposed patch. Going back to r?. They’re non zero when we defer, which may happen frequently? 1848552 3 saam 2022-03-05 12:58:33 -0800 (In reply to Saam Barati from comment #2) > Comment on attachment 453916 [details] > proposed patch. > > Going back to r?. They’re non zero when we defer, which may happen > frequently? Maybe not frequently enough though. Might be worth just giving a bit of thought to defer% to non-defer% 1848553 4 mark.lam 2022-03-05 13:00:38 -0800 (In reply to Saam Barati from comment #3) > (In reply to Saam Barati from comment #2) > > Comment on attachment 453916 [details] > > proposed patch. > > > > Going back to r?. They’re non zero when we defer, which may happen > > frequently? > > Maybe not frequently enough though. Might be worth just giving a bit of > thought to defer% to non-defer% I think that would be rare in a few sites only. We shouldn't be penalizing all exception check sites to favor just a few defer sites. Plus if bots show a regression, we can just roll this back. 1848556 5 453916 saam 2022-03-05 13:08:16 -0800 Comment on attachment 453916 proposed patch. r=me 1848557 6 453916 mark.lam 2022-03-05 13:11:27 -0800 Comment on attachment 453916 proposed patch. Thanks for the review. 1848561 7 ews-feeder 2022-03-05 13:56:47 -0800 Committed r290871 (248102@main): <https://commits.webkit.org/248102@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453916. 1848562 8 webkit-bug-importer 2022-03-05 13:57:17 -0800 <rdar://problem/89861322> 453916 2022-03-05 11:29:55 -0800 2022-03-05 13:56:48 -0800 proposed patch. bug-237503.patch text/plain 3404 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjkwODY5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBA CisyMDIyLTAzLTA1ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBP cHRpbWl6ZSBWTVRyYXBzOjptYXliZU5lZWRIYW5kbGluZygpLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM3NTAzCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlcmUncyBubyBuZWVkIGZvciBWTVRyYXBz OjptYXliZU5lZWRIYW5kbGluZygpIHRvIG1hc2sgdGhlIFZNVHJhcHMgYml0cyBmb3IKKyAgICAg ICAgZXZlbnRzLiAgVW5kZXIgbm9ybWFsIGNpcmN1bXN0YW5jZXMsIHRoZXJlIGFyZSBubyB0cmFw cyBmaXJpbmcgYW5kIHRoZSB0cmFwcyBiaXRzCisgICAgICAgIGFyZSAwIGFueXdheS4gIFdlIHNo b3VsZCBvcHRpbWl6ZSBmb3IgdGhpcyBhbmQgZG8gYXdheSB3aXRoIHRoZSBtYXNraW5nLiAgQ2xp ZW50cworICAgICAgICB3aG8gdXNlIFZNVHJhcHM6Om1heWJlTmVlZEhhbmRsaW5nKCkgc2hvdWxk IGFuZCBjdXJyZW50IGRvIGNhbGwgVk1UcmFwczo6bmVlZEhhbmRsaW5nKCkKKyAgICAgICAgdG8g Z2V0IHRoZSByZWFsIHN0b3J5IG9uIHdoZXRoZXIgdGhlcmUgYXJlIGFjdHVhbGx5IHRyYXBzIHRv IGhhbmRsZSBvciBub3QuICBIZW5jZSwKKyAgICAgICAgdGhlIG1hc2tpbmcgaW4gVk1UcmFwczo6 bWF5YmVOZWVkSGFuZGxpbmcoKSBpcyBhbHNvIG5vdCBuZWVkZWQgZm9yIGNvcnJlY3RuZXNzLgor CisgICAgICAgIFdlIGtub3cgZnJvbSBleHBlcmllbmNlIHRoYXQgY2hhbmdlcyBpbiBSRVRVUk5f SU5fRVhDRVBUSU9OIGNhbiBoYXZlIGFuIGltcGFjdCBvbgorICAgICAgICBwZXJmb3JtYW5jZS4g IFBlcmhhcHMgdGhpcyBjaGFuZ2UgY2FuIGFsc28gaGVscCBwZXJmb3JtYW5jZS4KKworICAgICAg ICAqIHJ1bnRpbWUvRXhjZXB0aW9uU2NvcGUuaDoKKyAgICAgICAgKiBydW50aW1lL1ZNVHJhcHMu aDoKKyAgICAgICAgKEpTQzo6Vk1UcmFwczo6bWF5YmVOZWVkSGFuZGxpbmcgY29uc3QpOgorCiAy MDIyLTAzLTA1ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXgg YnJva2VuIFN1c3BlbmRFeGNlcHRpb25TY29wZSBhbmQgcmVtb3ZlIHJlZHVuZGFudCBWTTo6RGVm ZXJFeGNlcHRpb25TY29wZS4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0V4 Y2VwdGlvblNjb3BlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvRXhjZXB0aW9uU2NvcGUuaAkocmV2aXNpb24gMjkwODY5KQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvRXhjZXB0aW9uU2NvcGUuaAkod29ya2luZyBjb3B5KQpAQCAtMSw1ICsx LDUgQEAKIC8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMTYtMjAyMSBBcHBsZSBJbmMuIEFsbCByaWdo dHMgcmVzZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKEMpIDIwMTYtMjAyMiBBcHBsZSBJbmMuIEFsbCBy aWdodHMgcmVzZXJ2ZWQuCiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2Ug YW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmljYXRpb24sIGFyZSBw ZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTExMCw3 ICsxMTAsNyBAQCBwcm90ZWN0ZWQ6CiAjZGVmaW5lIFJFVFVSTl9JRl9FWENFUFRJT04oc2NvcGVf XywgdmFsdWVfXykgZG8geyBcCiAgICAgICAgIEpTQzo6Vk0mIHZtID0gKHNjb3BlX18pLnZtKCk7 IFwKICAgICAgICAgQVNTRVJUKCEhKHNjb3BlX18pLmV4Y2VwdGlvbigpID09IHZtLnRyYXBzKCku bmVlZEhhbmRsaW5nKEpTQzo6Vk1UcmFwczo6TmVlZEV4Y2VwdGlvbkhhbmRsaW5nKSk7IFwKLSAg ICAgICAgaWYgKFVOTElLRUxZKHZtLnRyYXBzKCkubWF5YmVOZWVkSGFuZGxpbmcoSlNDOjpWTVRy YXBzOjpOb25EZWJ1Z2dlckV2ZW50cykpKSB7IFwKKyAgICAgICAgaWYgKFVOTElLRUxZKHZtLnRy YXBzKCkubWF5YmVOZWVkSGFuZGxpbmcoKSkpIHsgXAogICAgICAgICAgICAgaWYgKHZtLmhhc0V4 Y2VwdGlvbnNBZnRlckhhbmRsaW5nVHJhcHMoKSkgXAogICAgICAgICAgICAgICAgIHJldHVybiB2 YWx1ZV9fOyBcCiAgICAgICAgIH0gXApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvVk1UcmFwcy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L1ZNVHJhcHMuaAkocmV2aXNpb24gMjkwODY5KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvVk1UcmFwcy5oCSh3b3JraW5nIGNvcHkpCkBAIC0xLDUgKzEsNSBAQAogLyoKLSAqIENv cHlyaWdodCAoQykgMjAxNy0yMDIxIEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAq IENvcHlyaWdodCAoQykgMjAxNy0yMDIyIEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4K ICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1z LCB3aXRoIG9yIHdpdGhvdXQKICAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRl ZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwpAQCAtMjAzLDcgKzIwMyw3IEBAIHB1Ymxp YzoKICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0KICAgICAvLyBEZXNpZ25lZCB0byBiZSBh IGZhc3QgY2hlY2sgdG8gcnVsZSBvdXQgaWYgd2UgbWlnaHQgbmVlZCBoYW5kbGluZywgYW5kIHdl IG5lZWQgdG8gZW5zdXJlIG5lZWRIYW5kbGluZyBvbiB0aGUgc2xvdyBwYXRoLgotICAgIEFMV0FZ U19JTkxJTkUgYm9vbCBtYXliZU5lZWRIYW5kbGluZyhCaXRGaWVsZCBtYXNrKSBjb25zdCB7IHJl dHVybiBtX3RyYXBCaXRzLmxvYWRSZWxheGVkKCkgJiBtYXNrOyB9CisgICAgQUxXQVlTX0lOTElO RSBib29sIG1heWJlTmVlZEhhbmRsaW5nKCkgY29uc3QgeyByZXR1cm4gbV90cmFwQml0cy5sb2Fk UmVsYXhlZCgpOyB9CiAgICAgdm9pZCogdHJhcEJpdHNBZGRyZXNzKCkgeyByZXR1cm4gJm1fdHJh cEJpdHM7IH0KIAogICAgIGVudW0gY2xhc3MgRGVmZXJBY3Rpb24gewo=