237465 2022-03-04 02:16:23 -0800 [GTK][WPE] Documentation for webkit_web_context_set_spell_checking_languages() is incomplete 2022-03-04 03:39:15 -0800 1 1 1 Unclassified WebKit WebKit API WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aperez aperez cgarcia mcatanzaro webkit-bug-importer oldest_to_newest 1848212 0 aperez 2022-03-04 02:16:23 -0800 The API documentation for webkit_web_context_set_spell_checking_languages() only mentions that it affects the Accept-Language header in requests, but says nothing about navigator.language(s) and the Intl default locale, which are also affected by it because in the end using the function results in a call to WTF::overrideUserPreferredLanguages(). 1848214 1 aperez 2022-03-04 02:17:32 -0800 One could also argue that the function should not receive a WebKitWebContext because it operates on a global setting, but let's just document all the implications for now and leave that for another bug ;-) 1848215 2 453824 aperez 2022-03-04 02:19:28 -0800 Created attachment 453824 Patch 1848230 3 ews-feeder 2022-03-04 03:38:26 -0800 Committed r290825 (248061@main): <https://commits.webkit.org/248061@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453824. 1848231 4 webkit-bug-importer 2022-03-04 03:39:15 -0800 <rdar://problem/89806783> 453824 2022-03-04 02:19:28 -0800 2022-03-04 03:38:27 -0800 Patch bug-237465-20220304121926.patch text/plain 2051 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwODIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDc1MmIxZWZkYjMxY2M2MmUy OTFjMTliMTlhOTk4MDBhYzVhZDg5NTUuLmJiNTE4MDZkMTM0OTM2NTZlMTU0YmNkNzA2OTAwMDEy YjlhOGEyYzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMjItMDMtMDQgIEFkcmlhbiBQ ZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXVtXUEVd IERvY3VtZW50YXRpb24gZm9yIHdlYmtpdF93ZWJfY29udGV4dF9zZXRfc3BlbGxfY2hlY2tpbmdf bGFuZ3VhZ2VzKCkgaXMgaW5jb21wbGV0ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjM3NDY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0V2ViQ29udGV4dC5j cHA6IEltcHJvdmUgZG9jdW1lbnRhdGlvbi4KKwogMjAyMi0wMy0wMyAgQnJhZHkgRWlkc29uICA8 YmVpZHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIGEgbmV3ICJEYWVtb24gLT4gQ2xpZW50 IiBtZXNzYWdlIHR5cGUgdG8gd2VicHVzaGQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL0FQSS9nbGliL1dlYktpdFdlYkNvbnRleHQuY3BwIGIvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvQVBJL2dsaWIvV2ViS2l0V2ViQ29udGV4dC5jcHAKaW5kZXggMWIxMjhhNGM2ODI1ZGU5 ZjkzNTUwNzI1YzUxOTVmNGFiMDQ0MzU0OC4uYWI0MzY4YmY5NzZiZDBkZWRjMDQ1NzkwN2RlM2M4 NmJkOWRhMWFmNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIv V2ViS2l0V2ViQ29udGV4dC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2ds aWIvV2ViS2l0V2ViQ29udGV4dC5jcHAKQEAgLTE0NjksOSArMTQ2OSwxMyBAQCB2b2lkIHdlYmtp dF93ZWJfY29udGV4dF9zZXRfc3BlbGxfY2hlY2tpbmdfbGFuZ3VhZ2VzKFdlYktpdFdlYkNvbnRl eHQqIGNvbnRleHQsCiAgKiBAbGFuZ3VhZ2VzOiAoYWxsb3ctbm9uZSkgKGFycmF5IHplcm8tdGVy bWluYXRlZD0xKSAoZWxlbWVudC10eXBlIHV0ZjgpICh0cmFuc2ZlciBub25lKTogYSAlTlVMTC10 ZXJtaW5hdGVkIGxpc3Qgb2YgbGFuZ3VhZ2UgaWRlbnRpZmllcnMKICAqCiAgKiBTZXQgdGhlIGxp c3Qgb2YgcHJlZmVycmVkIGxhbmd1YWdlcywgc29ydGVkIGZyb20gbW9zdCBkZXNpcmFibGUKLSAq IHRvIGxlYXN0IGRlc2lyYWJsZS4gVGhlIGxpc3Qgd2lsbCBiZSB1c2VkIHRvIGJ1aWxkIHRoZSAi QWNjZXB0LUxhbmd1YWdlIgotICogaGVhZGVyIHRoYXQgd2lsbCBiZSBpbmNsdWRlZCBpbiB0aGUg bmV0d29yayByZXF1ZXN0cyBzdGFydGVkIGJ5Ci0gKiB0aGUgI1dlYktpdFdlYkNvbnRleHQuCisg KiB0byBsZWFzdCBkZXNpcmFibGUuIFRoZSBsaXN0IHdpbGwgYmUgdXNlZCBpbiB0aGUgZm9sbG93 aW5nIHdheXM6CisgKgorICogLSBEZXRlcm1pbmluZyBob3cgdG8gYnVpbGQgdGhlIGBBY2NlcHQt TGFuZ3VhZ2VgIEhUVFAgaGVhZGVyIHRoYXQgd2lsbCBiZQorICogICBpbmNsdWRlZCBpbiB0aGUg bmV0d29yayByZXF1ZXN0cyBzdGFydGVkIGJ5IHRoZSAjV2ViS2l0V2ViQ29udGV4dC4KKyAqIC0g U2V0dGluZyB0aGUgdmFsdWVzIG9mIGBuYXZpZ2F0b3IubGFuZ3VhZ2VgIGFuZCBgbmF2aWdhdG9y Lmxhbmd1YWdlc2AuCisgKiAtIFRoZSBmaXJzdCBpdGVtIGluIHRoZSBsaXN0IHNldHMgdGhlIGRl ZmF1bHQgbG9jYWxlIGZvciBKYXZhU2NyaXB0CisgKiAgIGBJbnRsYCBmdW5jdGlvbnMuCiAgKi8K IHZvaWQgd2Via2l0X3dlYl9jb250ZXh0X3NldF9wcmVmZXJyZWRfbGFuZ3VhZ2VzKFdlYktpdFdl YkNvbnRleHQqIGNvbnRleHQsIGNvbnN0IGdjaGFyKiBjb25zdCogbGFuZ3VhZ2VMaXN0KQogewo=