237443 2022-03-03 12:30:21 -0800 Implement remote-inbound-rtp packetsLost 2022-03-05 03:35:17 -0800 1 1 1 Unclassified WebKit WebRTC Safari 15 All All RESOLVED FIXED InRadar P2 Normal --- 1 daginge youennf eric.carlson ews-watchlist glenn hta jer.noble philipj sergio tommyw webkit-bug-importer youennf oldest_to_newest 1848035 0 daginge 2022-03-03 12:30:21 -0800 Would be great to have remote-inbound-rtp packetsLost implemented to calculate send-side packet loss calculations for media tracks. Chrome now implements this (from https://webrtc.github.io/samples/src/content/peerconnection/constraints/) Report type=remote-inbound-rtp id RTCRemoteInboundRtpAudioStream_1121966634 time 1646339188209.999 ssrc: 1121966634 kind: audio transportId: RTCTransport_0_1 codecId: RTCCodec_0_Outbound_111 jitter: 0.00014583333333333335 packetsLost: 0 <-- here localId: RTCOutboundRTPAudioStream_1121966634 roundTripTime: 0.001 fractionLost: 0 totalRoundTripTime: 0.003 roundTripTimeMeasurements: 3 Would be a great way for us to design UI/handling around packet loss depending on this heuristic, as well as for our own analytical purposes and tagging calls good/bad. Since it's currently unsupported in Safari which amounts to about 60% of our traffic, we lose one important signal of quantitative call quality. 1848207 1 453822 youennf 2022-03-04 01:33:19 -0800 Created attachment 453822 Patch 1848220 2 daginge 2022-03-04 02:47:58 -0800 Amazing turnaround time! Thank you, youenn! 1848516 3 ews-feeder 2022-03-05 03:34:30 -0800 Committed r290865 (248096@main): <https://commits.webkit.org/248096@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453822. 1848517 4 webkit-bug-importer 2022-03-05 03:35:17 -0800 <rdar://problem/89854282> 453822 2022-03-04 01:33:19 -0800 2022-03-05 03:34:32 -0800 Patch bug-237443-20220304103318.patch text/plain 6837 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwODE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmZhOTRhNmZiYjQwNTg5 ZmJjYzk2NTBlNDdiZWU3ZWU4MmFkZTU1YS4uMWU5MzJlYzljZTljYmY3MTNhMGJkYTEyYTY4NWE3 OGU3ZWEzYjIwNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIyLTAzLTA0ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBJbXBsZW1lbnQgcmVtb3Rl LWluYm91bmQtcnRwIHBhY2tldHNMb3N0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMzc0NDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUYWtlIGJlbmVmaXQgb2YgbGF0ZXN0IGJhY2tlbmQgdG8gZXhwb3Nl IFJlbW90ZUluYm91bmRSdHBTdHJlYW1TdGF0cyB2YWx1ZXMgaW5oZXJpdGVkIGZyb20gUmVjZWl2 ZWRSdHBTdHJlYW1TdGF0cy4KKyAgICAgICAgQ292ZXJlZCBieSB1cGRhdGVkIHRlc3QuCisKKyAg ICAgICAgKiBNb2R1bGVzL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENTdGF0c0NvbGxl Y3Rvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpmaWxsUmVjZWl2ZWRSdHBTdHJlYW1TdGF0cyk6 CisgICAgICAgIChXZWJDb3JlOjpmaWxsSW5ib3VuZFJ0cFN0cmVhbVN0YXRzKToKKyAgICAgICAg KFdlYkNvcmU6OmZpbGxSZW1vdGVJbmJvdW5kUnRwU3RyZWFtU3RhdHMpOgorCiAyMDIyLTAzLTA0 ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBBbGxvdyB0byBw YXNzIHdlYnJ0YyB2aWRlbyBmcmFtZSBidWZmZXJzIHRocm91Z2ggUmVhbHRpbWVNZWRpYVNvdXJj ZSBiYXNlZCBwaXBlbGluZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVk aWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ1N0YXRzQ29sbGVjdG9yLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ1N0YXRzQ29sbGVj dG9yLmNwcAppbmRleCA0ODA1MDNhMWI2OGM2ZDdmNGQxMGZhODYwM2RhMWUyZGJlZmZkOGQ1Li41 NDY2MTE1NDE3NzM5Mzc3OWMzODFiMWNjMDU4ZjhiNzM2MzdhOWU5IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENTdGF0c0Nv bGxlY3Rvci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9saWJ3 ZWJydGMvTGliV2ViUlRDU3RhdHNDb2xsZWN0b3IuY3BwCkBAIC03NiwxOCArNzYsMjYgQEAgc3Rh dGljIGlubGluZSB2b2lkIGZpbGxSdHBTdHJlYW1TdGF0cyhSVENTdGF0c1JlcG9ydDo6UnRwU3Ry ZWFtU3RhdHMmIHN0YXRzLCBjb24KICAgICB9CiB9CiAKLXN0YXRpYyBpbmxpbmUgdm9pZCBmaWxs UmVjZWl2ZWRSdHBTdHJlYW1TdGF0cyhSVENTdGF0c1JlcG9ydDo6UmVjZWl2ZWRSdHBTdHJlYW1T dGF0cyYgc3RhdHMsIGNvbnN0IHdlYnJ0Yzo6UlRDSW5ib3VuZFJUUFN0cmVhbVN0YXRzJiBydGNT dGF0cykKK3N0YXRpYyBpbmxpbmUgdm9pZCBmaWxsUmVjZWl2ZWRSdHBTdHJlYW1TdGF0cyhSVENT dGF0c1JlcG9ydDo6UmVjZWl2ZWRSdHBTdHJlYW1TdGF0cyYgc3RhdHMsIGNvbnN0IHdlYnJ0Yzo6 UlRDUmVjZWl2ZWRSdHBTdHJlYW1TdGF0cyYgcnRjU3RhdHMpCiB7CiAgICAgZmlsbFJ0cFN0cmVh bVN0YXRzKHN0YXRzLCBydGNTdGF0cyk7CiAKLSAgICBpZiAocnRjU3RhdHMucGFja2V0c19yZWNl aXZlZC5pc19kZWZpbmVkKCkpCi0gICAgICAgIHN0YXRzLnBhY2tldHNSZWNlaXZlZCA9ICpydGNT dGF0cy5wYWNrZXRzX3JlY2VpdmVkOwogICAgIGlmIChydGNTdGF0cy5wYWNrZXRzX2xvc3QuaXNf ZGVmaW5lZCgpKQogICAgICAgICBzdGF0cy5wYWNrZXRzTG9zdCA9ICpydGNTdGF0cy5wYWNrZXRz X2xvc3Q7CiAgICAgaWYgKHJ0Y1N0YXRzLmppdHRlci5pc19kZWZpbmVkKCkpCiAgICAgICAgIHN0 YXRzLmppdHRlciA9ICpydGNTdGF0cy5qaXR0ZXI7CiAgICAgaWYgKHJ0Y1N0YXRzLnBhY2tldHNf ZGlzY2FyZGVkLmlzX2RlZmluZWQoKSkKICAgICAgICAgc3RhdHMucGFja2V0c0Rpc2NhcmRlZCA9 ICpydGNTdGF0cy5wYWNrZXRzX2Rpc2NhcmRlZDsKK30KKworc3RhdGljIGlubGluZSB2b2lkIGZp bGxJbmJvdW5kUnRwU3RyZWFtU3RhdHMoUlRDU3RhdHNSZXBvcnQ6OkluYm91bmRSdHBTdHJlYW1T dGF0cyYgc3RhdHMsIGNvbnN0IHdlYnJ0Yzo6UlRDSW5ib3VuZFJUUFN0cmVhbVN0YXRzJiBydGNT dGF0cykKK3sKKyAgICBmaWxsUmVjZWl2ZWRSdHBTdHJlYW1TdGF0cyhzdGF0cywgcnRjU3RhdHMp OworCisgICAgLy8gcmVjZWl2ZXJJZAorICAgIC8vIHJlbW90ZUlkCisgICAgaWYgKHJ0Y1N0YXRz LnBhY2tldHNfcmVjZWl2ZWQuaXNfZGVmaW5lZCgpKQorICAgICAgICBzdGF0cy5wYWNrZXRzUmVj ZWl2ZWQgPSAqcnRjU3RhdHMucGFja2V0c19yZWNlaXZlZDsKICAgICBpZiAocnRjU3RhdHMucGFj a2V0c19yZXBhaXJlZC5pc19kZWZpbmVkKCkpCiAgICAgICAgIHN0YXRzLnBhY2tldHNSZXBhaXJl ZCA9ICpydGNTdGF0cy5wYWNrZXRzX3JlcGFpcmVkOwogICAgIGlmIChydGNTdGF0cy5idXJzdF9w YWNrZXRzX2xvc3QuaXNfZGVmaW5lZCgpKQpAQCAtMTA3LDE0ICsxMTUsNyBAQCBzdGF0aWMgaW5s aW5lIHZvaWQgZmlsbFJlY2VpdmVkUnRwU3RyZWFtU3RhdHMoUlRDU3RhdHNSZXBvcnQ6OlJlY2Vp dmVkUnRwU3RyZWFtUwogICAgIGlmIChydGNTdGF0cy5nYXBfZGlzY2FyZF9yYXRlLmlzX2RlZmlu ZWQoKSkKICAgICAgICAgc3RhdHMuZ2FwRGlzY2FyZFJhdGUgPSAqcnRjU3RhdHMuZ2FwX2Rpc2Nh cmRfcmF0ZTsKICAgICAvLyBBZGQgZnJhbWVzX2Ryb3BwZWQgYW5kIGZ1bGxfZnJhbWVzX2xvc3Qu Ci19Ci0KLXN0YXRpYyBpbmxpbmUgdm9pZCBmaWxsSW5ib3VuZFJ0cFN0cmVhbVN0YXRzKFJUQ1N0 YXRzUmVwb3J0OjpJbmJvdW5kUnRwU3RyZWFtU3RhdHMmIHN0YXRzLCBjb25zdCB3ZWJydGM6OlJU Q0luYm91bmRSVFBTdHJlYW1TdGF0cyYgcnRjU3RhdHMpCi17Ci0gICAgZmlsbFJlY2VpdmVkUnRw U3RyZWFtU3RhdHMoc3RhdHMsIHJ0Y1N0YXRzKTsKIAotICAgIC8vIHJlY2VpdmVySWQKLSAgICAv LyByZW1vdGVJZAogICAgIGlmIChydGNTdGF0cy5mcmFtZXNfZGVjb2RlZC5pc19kZWZpbmVkKCkp CiAgICAgICAgIHN0YXRzLmZyYW1lc0RlY29kZWQgPSAqcnRjU3RhdHMuZnJhbWVzX2RlY29kZWQ7 CiAgICAgaWYgKHJ0Y1N0YXRzLmtleV9mcmFtZXNfZGVjb2RlZC5pc19kZWZpbmVkKCkpCkBAIC0x ODgsNyArMTg5LDcgQEAgc3RhdGljIGlubGluZSB2b2lkIGZpbGxJbmJvdW5kUnRwU3RyZWFtU3Rh dHMoUlRDU3RhdHNSZXBvcnQ6OkluYm91bmRSdHBTdHJlYW1TdGEKIAogc3RhdGljIGlubGluZSB2 b2lkIGZpbGxSZW1vdGVJbmJvdW5kUnRwU3RyZWFtU3RhdHMoUlRDU3RhdHNSZXBvcnQ6OlJlbW90 ZUluYm91bmRSdHBTdHJlYW1TdGF0cyYgc3RhdHMsIGNvbnN0IHdlYnJ0Yzo6UlRDUmVtb3RlSW5i b3VuZFJ0cFN0cmVhbVN0YXRzJiBydGNTdGF0cykKIHsKLSAgICBmaWxsUlRDU3RhdHMoc3RhdHMs IHJ0Y1N0YXRzKTsKKyAgICBmaWxsUmVjZWl2ZWRSdHBTdHJlYW1TdGF0cyhzdGF0cywgcnRjU3Rh dHMpOwogCiAgICAgLy8gRklYTUU6IHRoaXMgc2hvdWxkIGJlIGZpbGxlZCBpbiBmaWxsUnRwU3Ry ZWFtU3RhdHMuCiAgICAgaWYgKHJ0Y1N0YXRzLnNzcmMuaXNfZGVmaW5lZCgpKQpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGM4 ZWVjYjU5ZGEzZGRmNjg4NjZhZDBiOTI2NjcxMThjZjdmOWY4NTMuLjFlYjIzYThmOWY0MjYzMzAw MWViNDlkMmQzZTNkNjhiNzFhOTQ0ZjggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxv ZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAyMi0wMy0w NCAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CisKKyAgICAgICAgSW1wbGVtZW50 IHJlbW90ZS1pbmJvdW5kLXJ0cCBwYWNrZXRzTG9zdAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM3NDQzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9uczoK KyAgICAgICAgKiB3ZWJydGMvdmlkZW8tc3RhdHMuaHRtbDoKKwogMjAyMi0wMy0wNCAgWW91ZW5u IEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgSW1wcm92ZSBXZWJSVEMgVlBY IG1lZGlhIGNhcGFiaWxpdGllcyBhY2N1cmFjeQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxh dGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVz dEV4cGVjdGF0aW9ucwppbmRleCA1NzczMzNkYThlMGFkOWI5ODMyNWQxNjdhMDIxNDRkNThmOTVj MWYxLi44YzYyZjlmMmFmNzZlYmI2ZTAwNjY0OWRiMTZjZjdlYjEzNGRiZGNhIDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMjA5Nyw3ICsyMDk3LDYgQEAg d2Via2l0Lm9yZy9iLzIyMjY5MiBpbnNwZWN0b3IvcGFnZS9lbXB0eS1vci1taXNzaW5nLXJlc291 cmNlcy5odG1sIFsgUGFzcyBUaW1lb3UKIFsgYXJtNjQgXSB3ZWJydGMvY2FwdHVyZUNhbnZhcy13 ZWJydGMtc29mdHdhcmUtaDI2NC1oaWdoLmh0bWwgWyBQYXNzIEZhaWx1cmUgXQogI1RoZXNlIHR3 byBhcmUgZmFpbGluZyBvbiBpbnRlbCBhcyB3ZWxsIGZvciBld3MKIHdlYnJ0Yy9oMjY0LWJhc2Vs aW5lLmh0bWwgIFsgRmFpbHVyZSBUaW1lb3V0IF0KLXdlYnJ0Yy92aWRlby1zdGF0cy5odG1sIFsg UGFzcyBGYWlsdXJlIF0KIAogd2Via2l0Lm9yZy9iLzIyMzA0MyBbIEJpZ1N1ciBdIHdlYnJ0Yy9t dWx0aS1hdWRpby5odG1sIFsgUGFzcyBGYWlsdXJlIF0KIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvd2VicnRjL3ZpZGVvLXN0YXRzLmh0bWwgYi9MYXlvdXRUZXN0cy93ZWJydGMvdmlkZW8tc3Rh dHMuaHRtbAppbmRleCAyMjAyNzM5ZWQyNzQxODg3MzBkMDFlMjc3ZjlmOWRhYjEyM2NjOTFmLi5j NzliZWM4MWM4YWU4MzVmZTBkNDFlMWY3ZmY5NGIwODNkM2RlNDA4IDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy93ZWJydGMvdmlkZW8tc3RhdHMuaHRtbAorKysgYi9MYXlvdXRUZXN0cy93ZWJydGMv dmlkZW8tc3RhdHMuaHRtbApAQCAtMTMwLDcgKzEzMCw3IEBAIGZ1bmN0aW9uIGNoZWNrSW5ib3Vu ZEZyYW1lc051bWJlckluY3JlYXNlZChzZWNvbmRDb25uZWN0aW9uLCBzdGF0c1NlY29uZENvbm5l Y3RpCiAgICAgICAgICAgICBhc3NlcnRfbm90X2VxdWFscyhPYmplY3Qua2V5cyhzdGF0cykuaW5k ZXhPZigidHJhY2tJZCIpLCAtMSwgInRyYWNrSWQiKTsKICAgICAgICAgICAgIHJldHVybjsKICAg ICAgICAgfQotICAgICAgICBpZiAoKytjb3VudCA9PT0gMjApCisgICAgICAgIGlmICgrK2NvdW50 ID09PSA1MCkKICAgICAgICAgICAgIHJldHVybiBQcm9taXNlLnJlamVjdCgiY2hlY2tpbmcgaW5i b3VuZCBzdGF0cyBmcmFtZSBudW1iZXIgaW5jcmVhc2luZyB0aW1lZCBvdXQiKTsKICAgICAgICAg cmV0dXJuIHdhaXRGb3IoNTApLnRoZW4oKCkgPT4gewogICAgICAgICAgICAgcmV0dXJuIGNoZWNr SW5ib3VuZEZyYW1lc051bWJlckluY3JlYXNlZChzZWNvbmRDb25uZWN0aW9uLCBzdGF0c1NlY29u ZENvbm5lY3Rpb24sIGNvdW50KQpAQCAtMTQ4LDcgKzE0OCw3IEBAIGZ1bmN0aW9uIGNoZWNrT3V0 Ym91bmRGcmFtZXNOdW1iZXJJbmNyZWFzZWQoZmlyc3RDb25uZWN0aW9uLCBzdGF0c0ZpcnN0Q29u bmVjdGlvCiAgICAgICAgICAgICBhc3NlcnRfbm90X2VxdWFscyhPYmplY3Qua2V5cyhzdGF0cyku aW5kZXhPZigidHJhY2tJZCIpLCAtMSwgInRyYWNrSWQiKTsKICAgICAgICAgICAgIHJldHVybjsK ICAgICAgICAgfQotICAgICAgICBpZiAoKytjb3VudCA9PT0gMjApCisgICAgICAgIGlmICgrK2Nv dW50ID09PSA1MCkKICAgICAgICAgICAgIHJldHVybiBQcm9taXNlLnJlamVjdCgiY2hlY2tpbmcg b3V0Ym91bmQgc3RhdHMgZnJhbWUgbnVtYmVyIGluY3JlYXNpbmcgdGltZWQgb3V0Iik7CiAgICAg ICAgIHJldHVybiB3YWl0Rm9yKDUwKS50aGVuKCgpID0+IHsKICAgICAgICAgICAgIHJldHVybiBj aGVja091dGJvdW5kRnJhbWVzTnVtYmVySW5jcmVhc2VkKGZpcnN0Q29ubmVjdGlvbiwgc3RhdHNG aXJzdENvbm5lY3Rpb24sIGNvdW50KQpAQCAtMjIwLDYgKzIyMCw3IEBAIHByb21pc2VfdGVzdChh c3luYyAodGVzdCkgPT4gewogCiAgICAgY29uc3QgcmVtb3RlSW5ib3VuZFN0YXRzID0gYXdhaXQg Z2V0UmVtb3RlSW5ib3VuZFJUUFN0YXRzKGZpcnN0Q29ubmVjdGlvbik7CiAgICAgYXNzZXJ0X3Ry dWUocmVtb3RlSW5ib3VuZFN0YXRzLmtpbmQgPT09ICJhdWRpbyJ8fCByZW1vdGVJbmJvdW5kU3Rh dHMua2luZCA9PT0gInZpZGVvIiwgImtpbmQgaXMgcHJlc2VudCIpOworICAgIGFzc2VydF9ub3Rf ZXF1YWxzKHJlbW90ZUluYm91bmRTdGF0cy5wYWNrZXRzTG9zdCwgdW5kZWZpbmVkKTsKIH0sICJC YXNpYyB2aWRlbyBzdGF0cyIpOwogCiBwcm9taXNlX3Rlc3QoYXN5bmMgKHRlc3QpID0+IHsK