<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>237421</bug_id>
          
          <creation_ts>2022-03-03 05:02:56 -0800</creation_ts>
          <short_desc>LibWebRTCCodecs::setEncodeRates should send LibWebRTCCodecsProxy::SetEncodeRates only when the encoder is live</short_desc>
          <delta_ts>2022-03-04 05:24:16 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebRTC</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="youenn fablet">youennf</reporter>
          <assigned_to name="youenn fablet">youennf</assigned_to>
          <cc>darin</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>youennf</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1847838</commentid>
    <comment_count>0</comment_count>
    <who name="youenn fablet">youennf</who>
    <bug_when>2022-03-03 05:02:56 -0800</bug_when>
    <thetext>LibWebRTCCodecs::setEncodeRates should send LibWebRTCCodecsProxy::SetEncodeRates only when the encoder is live</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1847839</commentid>
    <comment_count>1</comment_count>
      <attachid>453722</attachid>
    <who name="youenn fablet">youennf</who>
    <bug_when>2022-03-03 05:06:58 -0800</bug_when>
    <thetext>Created attachment 453722
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1847950</commentid>
    <comment_count>2</comment_count>
      <attachid>453722</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2022-03-03 10:09:11 -0800</bug_when>
    <thetext>Comment on attachment 453722
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453722&amp;action=review

&gt; Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp:525
&gt; +            auto* encoder = m_encoders.get(encoderIdentifier);

If this is guaranteed non-null, then I suggest putting in a reference, not a pointer. Maybe also add an assertion? Not clear to me why this is strongly guaranteed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1847992</commentid>
    <comment_count>3</comment_count>
    <who name="youenn fablet">youennf</who>
    <bug_when>2022-03-03 11:03:46 -0800</bug_when>
    <thetext>(In reply to Darin Adler from comment #2)
&gt; Comment on attachment 453722 [details]
&gt; Patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=453722&amp;action=review
&gt; 
&gt; &gt; Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp:525
&gt; &gt; +            auto* encoder = m_encoders.get(encoderIdentifier);
&gt; 
&gt; If this is guaranteed non-null, then I suggest putting in a reference, not a
&gt; pointer. Maybe also add an assertion? Not clear to me why this is strongly
&gt; guaranteed.

Will do.
It is guaranteed to be non null as creation/deletion of the pointer is doing the same journey (hop to main-thread then hop to work queue).
I&apos;ll update the code to directly use the LibWebRTCCodecs connection instead, which is more efficient anyway.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1848194</commentid>
    <comment_count>4</comment_count>
      <attachid>453818</attachid>
    <who name="youenn fablet">youennf</who>
    <bug_when>2022-03-04 00:27:01 -0800</bug_when>
    <thetext>Created attachment 453818
Patch for landing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1848265</commentid>
    <comment_count>5</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2022-03-04 05:23:19 -0800</bug_when>
    <thetext>Committed r290829 (248065@main): &lt;https://commits.webkit.org/248065@main&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453818.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1848266</commentid>
    <comment_count>6</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-03-04 05:24:16 -0800</bug_when>
    <thetext>&lt;rdar://problem/89809391&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>453722</attachid>
            <date>2022-03-03 05:06:58 -0800</date>
            <delta_ts>2022-03-04 00:26:57 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-237421-20220303140657.patch</filename>
            <type>text/plain</type>
            <size>3722</size>
            <attacher name="youenn fablet">youennf</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwNzY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGY0N2NjYTZmZDY1ODljYTJk
MjYzY2YxNjg4MWU0Y2E2MjEwZDgxY2IuLjFjMmRhYmQyNmFiYTFiN2JjMjMyYzdiNDBmY2FiYmUx
ZWQyODg2OGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMjItMDMtMDMgIFlvdWVubiBG
YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIExpYldlYlJUQ0NvZGVjczo6c2V0
RW5jb2RlUmF0ZXMgc2hvdWxkIHNlbmQgTGliV2ViUlRDQ29kZWNzUHJveHk6OlNldEVuY29kZVJh
dGVzIG9ubHkgd2hlbiB0aGUgZW5jb2RlciBpcyBsaXZlCisgICAgICAgIGh0dHBzOi8vYnVncy53
ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzc0MjEKKworICAgICAgICBSZXZpZXdlZCBieSBO
T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSB3ZXJlIHByZXZpb3VzbHkgbm90IGFzc2VydGlu
ZyBpbiBMaWJXZWJSVENDb2RlY3NQcm94eTo6c2V0RW5jb2RlUmF0ZXMgYW5kIHdlIHdlcmUgbWlz
c2luZyBzb21lIGVuY29kZSByYXRlIG9yZGVycy4KKyAgICAgICAgVGhpcyBpcyBkdWUgdG8gdGhl
IGZhY3QgdGhhdCB3aGVuIGNyZWF0aW5nIGFuIGVuY29kZXIsIHdlIGFyZSBob3BwaW5nIHRvIG1h
aW4gdGhyZWFkLCB0aGVuIHRvIHdvcmsgcXVldWUgdG8gc2VuZCB0aGUgbWVzc2FnZSB0byBjcmVh
dGUgYW4gZW5jb2Rlci4KKyAgICAgICAgSW4gTGliV2ViUlRDQ29kZWNzOjpzZXRFbmNvZGVSYXRl
cywgd2Ugd2VyZSBob3BwaW5nIHRvIG1haW4gdGhyZWFkIGlmIG5lZWRlZC4KKyAgICAgICAgSWYg
dGhlIGVuY29kZXIgY29ubmVjdGlvbiBpcyBudWxsLCB3ZSBhcmUgbm93IGhvcHBpbmcgdG8gbWFp
biB0aHJlYWQsIHRoZW4gdG8gd29yayBxdWV1ZSBhcyBkb25lIHdoZW4gY3JlYXRpbmcgYW4gZW5j
b2Rlci4KKyAgICAgICAgU2luY2UgdGhlcmUgaXMgYSB0aW1lIHdoZXJlIExpYldlYlJUQ0NvZGVj
c1Byb3h5OjpzZXRFbmNvZGVSYXRlcyBtaWdodCBoYXZlIHNlbnQgZW5jb2RlIHJhdGVzLCB3ZSBi
YWlsIG91dCBlYXJseSB0byBub3Qgc2V0IGJhc2VkIG9uIG9sZCBiaXRyYXRlcy4KKworICAgICAg
ICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzIG5vdCBjcmFzaGluZyBpbiBMaWJXZWJSVENDb2Rl
Y3NQcm94eTo6c2V0RW5jb2RlUmF0ZXMuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL0dQVS93ZWJy
dGMvTGliV2ViUlRDQ29kZWNzLmNwcDoKKyAgICAgICAgKFdlYktpdDo6TGliV2ViUlRDQ29kZWNz
OjpzZXRFbmNvZGVSYXRlcyk6CisgICAgICAgICogV2ViUHJvY2Vzcy9HUFUvd2VicnRjL0xpYldl
YlJUQ0NvZGVjcy5oOgorCiAyMDIyLTAzLTAzICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxl
LmNvbT4KIAogICAgICAgICBBbGxvdyB0byBwYXNzIHdlYnJ0YyB2aWRlbyBmcmFtZSBidWZmZXJz
IHRocm91Z2ggUmVhbHRpbWVNZWRpYVNvdXJjZSBiYXNlZCBwaXBlbGluZXMKZGlmZiAtLWdpdCBh
L1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9HUFUvd2VicnRjL0xpYldlYlJUQ0NvZGVjcy5jcHAg
Yi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvR1BVL3dlYnJ0Yy9MaWJXZWJSVENDb2RlY3MuY3Bw
CmluZGV4IGJiOTlhNGQxMzgyZGQxODBiMDE0YmQ4ZjA2MTUzZWRlMDdiNTg3ZDkuLjZiMTFkZDRl
YzZmY2UzNjE2OWJjZTgzMGU1YTVmOTE0OTcwNjhiZGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL
aXQvV2ViUHJvY2Vzcy9HUFUvd2VicnRjL0xpYldlYlJUQ0NvZGVjcy5jcHAKKysrIGIvU291cmNl
L1dlYktpdC9XZWJQcm9jZXNzL0dQVS93ZWJydGMvTGliV2ViUlRDQ29kZWNzLmNwcApAQCAtNTE5
LDExICs1MTksMTcgQEAgdm9pZCBMaWJXZWJSVENDb2RlY3M6OnNldEVuY29kZVJhdGVzKEVuY29k
ZXImIGVuY29kZXIsIHVpbnQzMl90IGJpdFJhdGUsIHVpbnQzMl8KIAogICAgIGF1dG8qIGNvbm5l
Y3Rpb24gPSBlbmNvZGVyQ29ubmVjdGlvbihlbmNvZGVyKTsKICAgICBpZiAoIWNvbm5lY3Rpb24p
IHsKLSAgICAgICAgY2FsbE9uTWFpblJ1bkxvb3AoW2VuY29kZXJJZGVudGlmaWVyID0gZW5jb2Rl
ci5pZGVudGlmaWVyLCBiaXRSYXRlLCBmcmFtZVJhdGVdIHsKLSAgICAgICAgICAgIFdlYlByb2Nl
c3M6OnNpbmdsZXRvbigpLmVuc3VyZUdQVVByb2Nlc3NDb25uZWN0aW9uKCkuY29ubmVjdGlvbigp
LnNlbmQoTWVzc2FnZXM6OkxpYldlYlJUQ0NvZGVjc1Byb3h5OjpTZXRFbmNvZGVSYXRlcyB7IGVu
Y29kZXJJZGVudGlmaWVyLCBiaXRSYXRlLCBmcmFtZVJhdGUgfSwgMCk7CisgICAgICAgIGVuc3Vy
ZUdQVVByb2Nlc3NDb25uZWN0aW9uQW5kRGlzcGF0Y2hUb1RocmVhZChbdGhpcywgZW5jb2Rlcklk
ZW50aWZpZXIgPSBlbmNvZGVyLmlkZW50aWZpZXIsIGJpdFJhdGUsIGZyYW1lUmF0ZV0geworICAg
ICAgICAgICAgYXNzZXJ0SXNDdXJyZW50KHdvcmtRdWV1ZSgpKTsKKworICAgICAgICAgICAgYXV0
byogZW5jb2RlciA9IG1fZW5jb2RlcnMuZ2V0KGVuY29kZXJJZGVudGlmaWVyKTsKKyAgICAgICAg
ICAgIExvY2tlciBsb2NrZXIgeyBtX2VuY29kZXJzQ29ubmVjdGlvbkxvY2sgfTsKKyAgICAgICAg
ICAgIGlmICghZW5jb2Rlci0+aGFzU2VudEluaXRpYWxFbmNvZGVSYXRlcykKKyAgICAgICAgICAg
ICAgICBlbmNvZGVyQ29ubmVjdGlvbigqZW5jb2RlciktPnNlbmQoTWVzc2FnZXM6OkxpYldlYlJU
Q0NvZGVjc1Byb3h5OjpTZXRFbmNvZGVSYXRlcyB7IGVuY29kZXJJZGVudGlmaWVyLCBiaXRSYXRl
LCBmcmFtZVJhdGUgfSwgMCk7CiAgICAgICAgIH0pOwogICAgICAgICByZXR1cm47CiAgICAgfQor
ICAgIGVuY29kZXIuaGFzU2VudEluaXRpYWxFbmNvZGVSYXRlcyA9IHRydWU7CiAgICAgY29ubmVj
dGlvbi0+c2VuZChNZXNzYWdlczo6TGliV2ViUlRDQ29kZWNzUHJveHk6OlNldEVuY29kZVJhdGVz
IHsgZW5jb2Rlci5pZGVudGlmaWVyLCBiaXRSYXRlLCBmcmFtZVJhdGUgfSwgMCk7CiB9CiAKZGlm
ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9HUFUvd2VicnRjL0xpYldlYlJUQ0Nv
ZGVjcy5oIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0dQVS93ZWJydGMvTGliV2ViUlRDQ29k
ZWNzLmgKaW5kZXggZjRmM2JiZWM1NzNlMDM3OWRlY2FjYTc3ZmRkNjM1MjZmOTUzMWYzNi4uZjU4
MjI2Y2RjMmZhYWE1YTQzM2ZkODk4NGJkNGE1OGJhMTAzNDA5MiAxMDA2NDQKLS0tIGEvU291cmNl
L1dlYktpdC9XZWJQcm9jZXNzL0dQVS93ZWJydGMvTGliV2ViUlRDQ29kZWNzLmgKKysrIGIvU291
cmNlL1dlYktpdC9XZWJQcm9jZXNzL0dQVS93ZWJydGMvTGliV2ViUlRDQ29kZWNzLmgKQEAgLTEw
OCw2ICsxMDgsNyBAQCBwdWJsaWM6CiAgICAgICAgIExvY2sgZW5jb2RlZEltYWdlQ2FsbGJhY2tM
b2NrOwogICAgICAgICBSZWZQdHI8SVBDOjpDb25uZWN0aW9uPiBjb25uZWN0aW9uOwogICAgICAg
ICBTaGFyZWRWaWRlb0ZyYW1lV3JpdGVyIHNoYXJlZFZpZGVvRnJhbWVXcml0ZXI7CisgICAgICAg
IGJvb2wgaGFzU2VudEluaXRpYWxFbmNvZGVSYXRlcyB7IGZhbHNlIH07CiAgICAgfTsKIAogICAg
IEVuY29kZXIqIGNyZWF0ZUVuY29kZXIoVHlwZSwgY29uc3Qgc3RkOjptYXA8c3RkOjpzdHJpbmcs
IHN0ZDo6c3RyaW5nPiYpOwo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>453818</attachid>
            <date>2022-03-04 00:27:01 -0800</date>
            <delta_ts>2022-03-04 05:23:20 -0800</delta_ts>
            <desc>Patch for landing</desc>
            <filename>bug-237421-20220304092700.patch</filename>
            <type>text/plain</type>
            <size>3874</size>
            <attacher name="youenn fablet">youennf</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwODE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDc1MmIxZWZkYjMxY2M2MmUy
OTFjMTliMTlhOTk4MDBhYzVhZDg5NTUuLmFiMWQ2Y2EzNGJiMjM0YmRkMzExMDg4N2JlNjNkYWNi
ZjNjOWM2NmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMjItMDMtMDQgIFlvdWVubiBG
YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIExpYldlYlJUQ0NvZGVjczo6c2V0
RW5jb2RlUmF0ZXMgc2hvdWxkIHNlbmQgTGliV2ViUlRDQ29kZWNzUHJveHk6OlNldEVuY29kZVJh
dGVzIG9ubHkgd2hlbiB0aGUgZW5jb2RlciBpcyBsaXZlCisgICAgICAgIGh0dHBzOi8vYnVncy53
ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzc0MjEKKworICAgICAgICBSZXZpZXdlZCBieSBE
YXJpbiBBZGxlci4KKworICAgICAgICBXZSB3ZXJlIHByZXZpb3VzbHkgbm90IGFzc2VydGluZyBp
biBMaWJXZWJSVENDb2RlY3NQcm94eTo6c2V0RW5jb2RlUmF0ZXMgYW5kIHdlIHdlcmUgbWlzc2lu
ZyBzb21lIGVuY29kZSByYXRlIG9yZGVycy4KKyAgICAgICAgVGhpcyBpcyBkdWUgdG8gdGhlIGZh
Y3QgdGhhdCB3aGVuIGNyZWF0aW5nIGFuIGVuY29kZXIsIHdlIGFyZSBob3BwaW5nIHRvIG1haW4g
dGhyZWFkLCB0aGVuIHRvIHdvcmsgcXVldWUgdG8gc2VuZCB0aGUgbWVzc2FnZSB0byBjcmVhdGUg
YW4gZW5jb2Rlci4KKyAgICAgICAgSW4gTGliV2ViUlRDQ29kZWNzOjpzZXRFbmNvZGVSYXRlcywg
d2Ugd2VyZSBob3BwaW5nIHRvIG1haW4gdGhyZWFkIGlmIG5lZWRlZC4KKyAgICAgICAgSWYgdGhl
IGVuY29kZXIgY29ubmVjdGlvbiBpcyBudWxsLCB3ZSBhcmUgbm93IGhvcHBpbmcgdG8gbWFpbiB0
aHJlYWQsIHRoZW4gdG8gd29yayBxdWV1ZSBhcyBkb25lIHdoZW4gY3JlYXRpbmcgYW4gZW5jb2Rl
ci4KKyAgICAgICAgU2luY2UgdGhlcmUgaXMgYSB0aW1lIHdoZXJlIExpYldlYlJUQ0NvZGVjc1By
b3h5OjpzZXRFbmNvZGVSYXRlcyBtaWdodCBoYXZlIHNlbnQgZW5jb2RlIHJhdGVzLCB3ZSBiYWls
IG91dCBlYXJseSB0byBub3Qgc2V0IGJhc2VkIG9uIG9sZCBiaXRyYXRlcy4KKworICAgICAgICBD
b3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzIG5vdCBjcmFzaGluZyBpbiBMaWJXZWJSVENDb2RlY3NQ
cm94eTo6c2V0RW5jb2RlUmF0ZXMuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL0dQVS93ZWJydGMv
TGliV2ViUlRDQ29kZWNzLmNwcDoKKyAgICAgICAgKFdlYktpdDo6TGliV2ViUlRDQ29kZWNzOjpz
ZXRFbmNvZGVSYXRlcyk6CisgICAgICAgICogV2ViUHJvY2Vzcy9HUFUvd2VicnRjL0xpYldlYlJU
Q0NvZGVjcy5oOgorCiAyMDIyLTAzLTAzICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNv
bT4KIAogICAgICAgICBBZGQgYSBuZXcgIkRhZW1vbiAtPiBDbGllbnQiIG1lc3NhZ2UgdHlwZSB0
byB3ZWJwdXNoZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0dQVS93ZWJy
dGMvTGliV2ViUlRDQ29kZWNzLmNwcCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9HUFUvd2Vi
cnRjL0xpYldlYlJUQ0NvZGVjcy5jcHAKaW5kZXggZDc1YjlmZjdlMDIwM2UxYWMzMTQzODU3Nzlk
MjdmYzc3MmRhNjc1Yy4uMTQxMTQzNzljNDIwNzU5YzNkNDQxNDY0ODVkZjk1MGZiNTY2YTE0NSAx
MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0dQVS93ZWJydGMvTGliV2ViUlRD
Q29kZWNzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvR1BVL3dlYnJ0Yy9MaWJX
ZWJSVENDb2RlY3MuY3BwCkBAIC01NDUsMTEgKzU0NSwyMCBAQCB2b2lkIExpYldlYlJUQ0NvZGVj
czo6c2V0RW5jb2RlUmF0ZXMoRW5jb2RlciYgZW5jb2RlciwgdWludDMyX3QgYml0UmF0ZSwgdWlu
dDMyXwogCiAgICAgYXV0byogY29ubmVjdGlvbiA9IGVuY29kZXJDb25uZWN0aW9uKGVuY29kZXIp
OwogICAgIGlmICghY29ubmVjdGlvbikgewotICAgICAgICBjYWxsT25NYWluUnVuTG9vcChbZW5j
b2RlcklkZW50aWZpZXIgPSBlbmNvZGVyLmlkZW50aWZpZXIsIGJpdFJhdGUsIGZyYW1lUmF0ZV0g
ewotICAgICAgICAgICAgV2ViUHJvY2Vzczo6c2luZ2xldG9uKCkuZW5zdXJlR1BVUHJvY2Vzc0Nv
bm5lY3Rpb24oKS5jb25uZWN0aW9uKCkuc2VuZChNZXNzYWdlczo6TGliV2ViUlRDQ29kZWNzUHJv
eHk6OlNldEVuY29kZVJhdGVzIHsgZW5jb2RlcklkZW50aWZpZXIsIGJpdFJhdGUsIGZyYW1lUmF0
ZSB9LCAwKTsKKyAgICAgICAgZW5zdXJlR1BVUHJvY2Vzc0Nvbm5lY3Rpb25BbmREaXNwYXRjaFRv
VGhyZWFkKFt0aGlzLCBoYXNTZW50SW5pdGlhbEVuY29kZVJhdGVzID0gJmVuY29kZXIuaGFzU2Vu
dEluaXRpYWxFbmNvZGVSYXRlcywgZW5jb2RlcklkZW50aWZpZXIgPSBlbmNvZGVyLmlkZW50aWZp
ZXIsIGJpdFJhdGUsIGZyYW1lUmF0ZV0geworICAgICAgICAgICAgYXNzZXJ0SXNDdXJyZW50KHdv
cmtRdWV1ZSgpKTsKKyAgICAgICAgICAgIEFTU0VSVChtX2VuY29kZXJzLmdldChlbmNvZGVySWRl
bnRpZmllcikpOworCisgICAgICAgICAgICAvLyBoYXNTZW50SW5pdGlhbEVuY29kZVJhdGVzIHJl
bWFpbnMgdmFsaWQgYXMgZW5jb2RlciBkZXN0cnVjdGlvbiBnb2VzIHRocm91Z2ggZW5zdXJlR1BV
UHJvY2Vzc0Nvbm5lY3Rpb25BbmREaXNwYXRjaFRvVGhyZWFkLgorICAgICAgICAgICAgaWYgKCpo
YXNTZW50SW5pdGlhbEVuY29kZVJhdGVzKQorICAgICAgICAgICAgICAgIHJldHVybjsKKworICAg
ICAgICAgICAgTG9ja2VyIGxvY2tlciB7IG1fY29ubmVjdGlvbkxvY2sgfTsKKyAgICAgICAgICAg
IG1fY29ubmVjdGlvbi0+c2VuZChNZXNzYWdlczo6TGliV2ViUlRDQ29kZWNzUHJveHk6OlNldEVu
Y29kZVJhdGVzIHsgZW5jb2RlcklkZW50aWZpZXIsIGJpdFJhdGUsIGZyYW1lUmF0ZSB9LCAwKTsK
ICAgICAgICAgfSk7CiAgICAgICAgIHJldHVybjsKICAgICB9CisgICAgZW5jb2Rlci5oYXNTZW50
SW5pdGlhbEVuY29kZVJhdGVzID0gdHJ1ZTsKICAgICBjb25uZWN0aW9uLT5zZW5kKE1lc3NhZ2Vz
OjpMaWJXZWJSVENDb2RlY3NQcm94eTo6U2V0RW5jb2RlUmF0ZXMgeyBlbmNvZGVyLmlkZW50aWZp
ZXIsIGJpdFJhdGUsIGZyYW1lUmF0ZSB9LCAwKTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl
YktpdC9XZWJQcm9jZXNzL0dQVS93ZWJydGMvTGliV2ViUlRDQ29kZWNzLmggYi9Tb3VyY2UvV2Vi
S2l0L1dlYlByb2Nlc3MvR1BVL3dlYnJ0Yy9MaWJXZWJSVENDb2RlY3MuaAppbmRleCBmNGYzYmJl
YzU3M2UwMzc5ZGVjYWNhNzdmZGQ2MzUyNmY5NTMxZjM2Li5mNTgyMjZjZGMyZmFhYTVhNDMzZmQ4
OTg0YmQ0YTU4YmExMDM0MDkyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3Mv
R1BVL3dlYnJ0Yy9MaWJXZWJSVENDb2RlY3MuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nl
c3MvR1BVL3dlYnJ0Yy9MaWJXZWJSVENDb2RlY3MuaApAQCAtMTA4LDYgKzEwOCw3IEBAIHB1Ymxp
YzoKICAgICAgICAgTG9jayBlbmNvZGVkSW1hZ2VDYWxsYmFja0xvY2s7CiAgICAgICAgIFJlZlB0
cjxJUEM6OkNvbm5lY3Rpb24+IGNvbm5lY3Rpb247CiAgICAgICAgIFNoYXJlZFZpZGVvRnJhbWVX
cml0ZXIgc2hhcmVkVmlkZW9GcmFtZVdyaXRlcjsKKyAgICAgICAgYm9vbCBoYXNTZW50SW5pdGlh
bEVuY29kZVJhdGVzIHsgZmFsc2UgfTsKICAgICB9OwogCiAgICAgRW5jb2RlciogY3JlYXRlRW5j
b2RlcihUeXBlLCBjb25zdCBzdGQ6Om1hcDxzdGQ6OnN0cmluZywgc3RkOjpzdHJpbmc+Jik7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>