237406 2022-03-02 20:34:19 -0800 [Style] Forbid spaces between type names and protocol names in Objective-C 2022-03-03 10:22:17 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mmaxfield mmaxfield darin ews-watchlist glenn jbedard webkit-bug-importer oldest_to_newest 1847734 0 mmaxfield 2022-03-02 20:34:19 -0800 [Style] Forbid spaces between type names and protocol names in Objective-C 1847735 1 453694 mmaxfield 2022-03-02 20:36:13 -0800 Created attachment 453694 Patch 1847901 2 453694 darin 2022-03-03 08:10:37 -0800 Comment on attachment 453694 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453694&action=review > Tools/Scripts/webkitpy/style/checkers/cpp.py:3420 > + using_space_with_protocol = search(r'\Wid <', line) Is \W better than \b for this? 1847913 3 453694 mmaxfield 2022-03-03 08:57:08 -0800 Comment on attachment 453694 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453694&action=review >> Tools/Scripts/webkitpy/style/checkers/cpp.py:3420 >> + using_space_with_protocol = search(r'\Wid <', line) > > Is \W better than \b for this? \b is probably better. I’ll update before landing. 1847954 4 mmaxfield 2022-03-03 10:21:14 -0800 Committed r290784 (248028@trunk): <https://commits.webkit.org/248028@trunk> 1847956 5 webkit-bug-importer 2022-03-03 10:22:17 -0800 <rdar://problem/89762953> 453694 2022-03-02 20:36:13 -0800 2022-03-03 08:10:37 -0800 Patch bug-237406-20220302203612.patch text/plain 4811 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwNzU0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTQ1Njg1NDZkZmZiYjQ3ODM1ZDZmNzUwM2E4ODcxZWYz Yjk5ZDg1OC4uOGU1MjYxZWU5NzUyZjExNDQxODQwNTdjMGVlOWRiOGIxMTk3ZDczYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDIyLTAzLTAyICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+ CisKKyAgICAgICAgW1N0eWxlXSBGb3JiaWQgc3BhY2VzIGJldHdlZW4gdHlwZSBuYW1lcyBhbmQg cHJvdG9jb2wgbmFtZXMgaW4gT2JqZWN0aXZlLUMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNzQwNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEFjY29yZGluZyB0byBodHRwczovL2xpc3RzLndlYmtpdC5v cmcvcGlwZXJtYWlsL3dlYmtpdC1kZXYvMjAyMi1GZWJydWFyeS8wMzIxMzAuaHRtbC4KKworICAg ICAgICBCZWNhdXNlIHRoZSBzdHlsZSBjaGVja2VyIHVzZXMgcmVnZXhlcywgd2UgZG9uJ3Qga25v dyB3aGF0J3MgYSB0eXBlIG5hbWUgYW5kIHdoYXQncworICAgICAgICBhIHByb3RvY29sIG5hbWUs IHNvIHRoZSBjaGVja2VyIHNpbXBsaWZpZXMgdGhlIHByb2JsZW0gYW5kIGp1c3QgY2hlY2tzIGZv ciAiaWQgPCIuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2Nw cC5weToKKyAgICAgICAgKGNoZWNrX29iamNfcHJvdG9jb2wpOgorICAgICAgICAoY2hlY2tfc3R5 bGUpOgorCiAyMDIyLTAzLTAyICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4K IAogICAgICAgICBbUHl0aG9uLTNdIEludm9rZSB3ZWJraXQtcGF0Y2ggd2l0aCBQeXRob24gMyBi eSBkZWZhdWx0CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNr ZXJzL2NwcC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5 CmluZGV4IDNjNWE4YjBjYjdhNGE3OTBkNjY3ZTE2M2VmNWM4MzJiYWNkY2I5N2UuLmExYWNjMjA0 MThiNTEyZTU4ODM3NGZkMjQ2Yjc3YzZkMmVmYmU2N2YgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CkBAIC0yLDcgKzIsNyBAQAogIwogIyBDb3B5cmln aHQgKEMpIDIwMDksIDIwMTAsIDIwMTIgR29vZ2xlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4K ICMgQ29weXJpZ2h0IChDKSAyMDA5IFRvcmNoIE1vYmlsZSBJbmMuCi0jIENvcHlyaWdodCAoQykg MjAwOS0yMDIxIEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyMgQ29weXJpZ2h0IChD KSAyMDA5LTIwMjIgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogIyBDb3B5cmlnaHQg KEMpIDIwMTAgQ2hyaXMgSmVyZG9uZWsgKGNqZXJkb25la0B3ZWJraXQub3JnKQogIwogIyBSZWRp c3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdp dGhvdXQKQEAgLTMzOTksNiArMzM5OSwzMSBAQCBkZWYgY2hlY2tfYXJndW1lbnRzX2Zvcl93a19h cGlfYXZhaWxhYmxlKGNsZWFuX2xpbmVzLCBsaW5lX251bWJlciwgZXJyb3IpOgogICAgICAgICBj aGVja192ZXJzaW9uX3N0cmluZyh3a19hcGlfYXZhaWxhYmxlLmdyb3VwKDEpLCAiaW9zIikKIAog CitkZWYgY2hlY2tfb2JqY19wcm90b2NvbChjbGVhbl9saW5lcywgbGluZV9udW1iZXIsIGZpbGVf ZXh0ZW5zaW9uLCBlcnJvcik6CisgICAgIiIiTG9va3MgZm9yIHNwYWNlcyBiZXR3ZWVuIHR5cGUg bmFtZXMgYW5kIHByb3RvY29sIG5hbWVzLgorCisgICAgQmVjYXVzZSB0aGUgc3R5bGUgY2hlY2tl ciB1c2VzIHJlZ2V4ZXMsIHdlIGRvbid0IGtub3cgd2hhdCdzIGEgdHlwZSBhbmQgd2hhdCdzIGEg cHJvdG9jb2wuCisgICAgU28sIHRoaXMgY2hlY2sgaXMgYSBzaW1wbGlmaWNhdGlvbiBhbmQganVz dCBjaGVja3MgZm9yICJpZCA8IgorCisgICAgQXJnczoKKyAgICAgIGNsZWFuX2xpbmVzOiBBIENs ZWFuc2VkTGluZXMgaW5zdGFuY2UgY29udGFpbmluZyB0aGUgZmlsZS4KKyAgICAgIGxpbmVfbnVt YmVyOiBUaGUgbnVtYmVyIG9mIHRoZSBsaW5lIHRvIGNoZWNrLgorICAgICAgZmlsZV9leHRlbnNp b246IFRoZSBleHRlbnNpb24gKHdpdGhvdXQgdGhlIGRvdCkgb2YgdGhlIGZpbGVuYW1lLgorICAg ICAgZXJyb3I6IFRoZSBmdW5jdGlvbiB0byBjYWxsIHdpdGggYW55IGVycm9ycyBmb3VuZC4KKyAg ICAiIiIKKworICAgIGlmIGZpbGVfZXh0ZW5zaW9uICE9ICJtIiBhbmQgZmlsZV9leHRlbnNpb24g IT0gIm1tIjoKKyAgICAgICAgcmV0dXJuCisKKyAgICBsaW5lID0gY2xlYW5fbGluZXMuZWxpZGVk W2xpbmVfbnVtYmVyXSAgIyBHZXQgcmlkIG9mIGNvbW1lbnRzIGFuZCBzdHJpbmdzLgorCisgICAg dXNpbmdfc3BhY2Vfd2l0aF9wcm90b2NvbCA9IHNlYXJjaChyJ1xXaWQgPCcsIGxpbmUpCisgICAg aWYgbm90IHVzaW5nX3NwYWNlX3dpdGhfcHJvdG9jb2w6CisgICAgICAgIHJldHVybgorCisgICAg ZXJyb3IobGluZV9udW1iZXIsICdzcGFjaW5nL29iamMtcHJvdG9jb2wnLCAyLCAiUHJvdG9jb2wg bmFtZXMgc2hvdWxkbid0IGhhdmUgYSBzcGFjZSBiZWZvcmUgdGhlbS4iKQorCisKIGRlZiBjaGVj a19zdHlsZShjbGVhbl9saW5lcywgbGluZV9udW1iZXIsIGZpbGVfZXh0ZW5zaW9uLCBjbGFzc19z dGF0ZSwgZmlsZV9zdGF0ZSwgZW51bV9zdGF0ZSwgZXJyb3IpOgogICAgICIiIkNoZWNrcyBydWxl cyBmcm9tIHRoZSAnQysrIHN0eWxlIHJ1bGVzJyBzZWN0aW9uIG9mIGNwcGd1aWRlLmh0bWwuCiAK QEAgLTM0ODAsNiArMzUwNSw3IEBAIGRlZiBjaGVja19zdHlsZShjbGVhbl9saW5lcywgbGluZV9u dW1iZXIsIGZpbGVfZXh0ZW5zaW9uLCBjbGFzc19zdGF0ZSwgZmlsZV9zdGF0CiAgICAgY2hlY2tf ZW51bV9jYXNpbmcoY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBlbnVtX3N0YXRlLCBlcnJvcikK ICAgICBjaGVja19vbmNlX2ZsYWcoY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBmaWxlX3N0YXRl LCBlcnJvcikKICAgICBjaGVja19hcmd1bWVudHNfZm9yX3drX2FwaV9hdmFpbGFibGUoY2xlYW5f bGluZXMsIGxpbmVfbnVtYmVyLCBlcnJvcikKKyAgICBjaGVja19vYmpjX3Byb3RvY29sKGNsZWFu X2xpbmVzLCBsaW5lX251bWJlciwgZmlsZV9leHRlbnNpb24sIGVycm9yKQogCiAKIF9SRV9QQVRU RVJOX0lOQ0xVREVfTkVXX1NUWUxFID0gcmUuY29tcGlsZShyJyMoPzppbmNsdWRlfGltcG9ydCkg KyJbXi9dK1wuaCInKQpkaWZmIC0tZ2l0IGEvV2Vic2l0ZXMvd2Via2l0Lm9yZy9DaGFuZ2VMb2cg Yi9XZWJzaXRlcy93ZWJraXQub3JnL0NoYW5nZUxvZwppbmRleCAyZmRkMThkZjUwODg0NzEzZjEy OWQyZTgzNTBmNzc0YjNjYWQ4MmJlLi45NzA0ZmVlNmE4MDQ0NTYyNGZmYjlmMjRmMmMwOWZiOWM4 NDIzZDM5IDEwMDY0NAotLS0gYS9XZWJzaXRlcy93ZWJraXQub3JnL0NoYW5nZUxvZworKysgYi9X ZWJzaXRlcy93ZWJraXQub3JnL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIyLTAzLTAy ICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgW1N0 eWxlXSBGb3JiaWQgc3BhY2VzIGJldHdlZW4gdHlwZSBuYW1lcyBhbmQgcHJvdG9jb2wgbmFtZXMg aW4gT2JqZWN0aXZlLUMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIzNzQwNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEFjY29yZGluZyB0byBodHRwczovL2xpc3RzLndlYmtpdC5vcmcvcGlwZXJtYWlsL3dl YmtpdC1kZXYvMjAyMi1GZWJydWFyeS8wMzIxMzAuaHRtbC4KKworICAgICAgICAqIGNvZGUtc3R5 bGUubWQ6CisKIDIwMjItMDItMTUgIEpvbiBEYXZpcyAgPGpvbmRAYXBwbGUuY29tPgogCiAgICAg ICAgIEZpeCBXb3JkUHJlc3Mgd3BhdXRvcCB0byBhY2NvdW50IGZvciB0aGUgRGlhbG9nIGVsZW1l bnQuCmRpZmYgLS1naXQgYS9XZWJzaXRlcy93ZWJraXQub3JnL2NvZGUtc3R5bGUubWQgYi9XZWJz aXRlcy93ZWJraXQub3JnL2NvZGUtc3R5bGUubWQKaW5kZXggYzI1MzUyZGVjMzRmZmZlN2NlNjI2 OTg1YWI5YjVmZmFiYzg3ZTExNi4uM2Y0N2U4MDVhMzk3YWRjNjUwMjFjYzY5N2I1NmY3YzdiYmZj YzYxMyAxMDA2NDQKLS0tIGEvV2Vic2l0ZXMvd2Via2l0Lm9yZy9jb2RlLXN0eWxlLm1kCisrKyBi L1dlYnNpdGVzL3dlYmtpdC5vcmcvY29kZS1zdHlsZS5tZApAQCAtMzIwLDYgKzMyMCwyMCBAQCBi bG9jayA9IF4gKGludCwgaW50KXsKIAogYGBgCiAKK1tdKCNzcGFjaW5nLW9iamMtcHJvdG9jb2wp IEluIE9iamVjdGl2ZS1DLCBkbyBub3QgcGxhY2UgYSBzcGFjZSBiZXR3ZWVuIHRoZSB0eXBlIG5h bWUgYW5kIHRoZSBwcm90b2NvbCBuYW1lLgorCisjIyMjIyMgUmlnaHQ6CisKK2BgYGNwcAoraWQ8 TVRMRGV2aWNlPiBkZXZpY2UgPSAuLi47CitgYGAKKworIyMjIyMjIFdyb25nOgorCitgYGBjcHAK K2lkIDxNVExEZXZpY2U+IGRldmljZSA9IC4uLjsKK2BgYAorCiAjIyMgTGluZSBicmVha2luZwog CiBbXSgjbGluZWJyZWFraW5nLW11bHRpcGxlLXN0YXRlbWVudHMpIEVhY2ggc3RhdGVtZW50IHNo b3VsZCBnZXQgaXRzIG93biBsaW5lLgo=