237404 2022-03-02 20:13:45 -0800 [Tools] Fix linux_get_crash_log.py error logging with python3 2022-03-02 22:25:17 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=226658 InRadar P2 Normal --- 1 lmoura lmoura bugs-noreply ews-watchlist fujii glenn jbedard webkit-bug-importer oldest_to_newest 1847725 0 lmoura 2022-03-02 20:13:45 -0800 [Tools] Fix linux_get_crash_log.py error logging with python3 1847726 1 453692 lmoura 2022-03-02 20:14:50 -0800 Created attachment 453692 Patch 1847727 2 453692 lmoura 2022-03-02 20:16:37 -0800 Comment on attachment 453692 Patch Sample error from https://build.webkit.org/#/builders/63/builds/4407 TypeError raised: %b requires a bytes-like object, or an object that implements __bytes__, not 'str' (from worker/5) Traceback (most recent call last): File "/app/webkit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 92, in main run_details = run(port, options, args, stderr) File "/app/webkit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 495, in run run_details = manager.run(args) File "/app/webkit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 413, in run temp_initial_results, temp_retry_results, temp_enabled_pixel_tests_in_retry = self._run_test_subset(test_inputs, device_type=device_type) File "/app/webkit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 487, in _run_test_subset initial_results = self._run_tests(test_inputs, self._options.repeat_each, self._options.iterations, int(self._options.child_processes), retrying=False, device_type=device_type) File "/app/webkit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 566, in _run_tests return self._runner.run_tests(self._expectations[device_type], new_test_inputs, num_workers, retrying, device_type) File "/app/webkit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 179, in run_tests pool.wait() File "/app/webkit/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py", line 454, in __exit__ reraise(*inflight) File "/app/webkit/Tools/Scripts/libraries/autoinstalled/python-3-x86_64/six.py", line 703, in reraise raise value File "/app/webkit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 179, in run_tests pool.wait() File "/app/webkit/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py", line 426, in wait self.queue.receive()(self) File "/app/webkit/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py", line 133, in __call__ reraise(*self.exc_info) File "/app/webkit/Tools/Scripts/libraries/autoinstalled/python-3-x86_64/six.py", line 702, in reraise raise value.with_traceback(tb) File "/app/webkit/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py", line 299, in main queue.send(_Result(value=task(None), id=task.id)) File "/app/webkit/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py", line 56, in __call__ return self.function(*self.args, **self.kwargs) File "/app/webkit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 76, in run_shard return Worker.instance.run_tests(shard) File "/app/webkit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 318, in run_tests Worker.instance.run_test(input, shard.name) File "/app/webkit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 346, in run_test result = self._run_test_with_or_without_timeout(test_input, test_timeout_sec, stop_when_done) File "/app/webkit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 403, in _run_test_with_or_without_timeout return self._run_test_in_this_thread(test_input, stop_when_done) File "/app/webkit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 489, in _run_test_in_this_thread return self._run_single_test(self._driver, test_input, stop_when_done) File "/app/webkit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 492, in _run_single_test return single_test_runner.run_single_test( File "/app/webkit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py", line 48, in run_single_test return runner.run() File "/app/webkit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py", line 126, in run return self._run_compare_test() File "/app/webkit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py", line 129, in _run_compare_test driver_output = self._driver.run_test(self._driver_input(), self._stop_when_done) File "/app/webkit/Tools/Scripts/webkitpy/port/driver.py", line 843, in run_test return self._driver.run_test(driver_input, stop_when_done) File "/app/webkit/Tools/Scripts/webkitpy/port/driver.py", line 257, in run_test self.error_from_test, crash_log = self._get_crash_log(text, self.error_from_test, newer_than=start_time) File "/app/webkit/Tools/Scripts/webkitpy/port/driver.py", line 326, in _get_crash_log return self._port._get_crash_log(self._crashed_process_name, self._crashed_pid, stdout, stderr, newer_than, target_host=self._target_host) File "/app/webkit/Tools/Scripts/webkitpy/port/gtk.py", line 247, in _get_crash_log return GDBCrashLogGenerator(self._executive, name, pid, newer_than, File "/app/webkit/Tools/Scripts/webkitpy/port/linux_get_crash_log.py", line 156, in generate_crash_log crash_log, errors = self._get_gdb_output(coredump_path) File "/app/webkit/Tools/Scripts/webkitpy/port/linux_get_crash_log.py", line 63, in _get_gdb_output stdout = (b'ERROR: The gdb process exited with non-zero return code %s\n\n' % str(proc.returncode)) + stdout TypeError: %b requires a bytes-like object, or an object that implements __bytes__, not 'str' (from worker/5) 1847747 3 ews-feeder 2022-03-02 22:24:44 -0800 Committed r290767 (248011@main): <https://commits.webkit.org/248011@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453692. 1847748 4 webkit-bug-importer 2022-03-02 22:25:17 -0800 <rdar://problem/89733848> 453692 2022-03-02 20:14:50 -0800 2022-03-02 22:24:47 -0800 Patch bug-237404-20220303011448.patch text/plain 1754 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwNzYyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzJjYzY2YzU3NTMzMGVlZWM0ZWNhYmYzNjA2ZDczODZm NGRiYjQyZi4uNDVmMTZiNWNmMzk3OGRiZDFmODE2ZWExMTRiOTBiNDdkMDQ3NjYzMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDIyLTAzLTAyICBMYXVybyBNb3VyYSAgPGxtb3VyYUBpZ2FsaWEuY29tPgorCisgICAg ICAgIFtUb29sc10gRml4IGxpbnV4X2dldF9jcmFzaF9sb2cucHkgZXJyb3IgbG9nZ2luZyB3aXRo IHB5dGhvbjMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIzNzQwNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEF2b2lkIGlzc3VlcyBnZW5lcmF0aW5nIGVycm9yIGxvZ3MgYWZ0ZXIgMjQ3NzM2QG1haW4gZGVm YXVsdGVkIHRvCisgICAgICAgIHB5dGhvbjMuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5 L3BvcnQvbGludXhfZ2V0X2NyYXNoX2xvZy5weToKKyAgICAgICAgKEdEQkNyYXNoTG9nR2VuZXJh dG9yLl9nZXRfZ2RiX291dHB1dCk6IEVuY29kZSByZXR1cm5jb2RlIGJlZm9yZQorICAgICAgICBh cHBlbmRpbmcgdG8gYnl0ZXMuCisKIDIwMjItMDMtMDIgIEpvbmF0aGFuIEJlZGFyZCAgPGpiZWRh cmRAYXBwbGUuY29tPgogCiAgICAgICAgIFt3ZWJraXRjb3JlcHldIEFkZCBUZXJtaW5hbC5vcGVu X3VybApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2xpbnV4X2dldF9j cmFzaF9sb2cucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvbGludXhfZ2V0X2NyYXNo X2xvZy5weQppbmRleCBlMzQ5YjZjMDE5MzY3M2E0Mzc5MDM0NzU4OGYwZDEyNDA3MjA4YzJhLi5m MmFkMTNkODAzMzdjZjgwY2YwYzVlMTMxYjYyZmExOWQwODExZGE1IDEwMDY0NAotLS0gYS9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvbGludXhfZ2V0X2NyYXNoX2xvZy5weQorKysgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvbGludXhfZ2V0X2NyYXNoX2xvZy5weQpAQCAtNjAsNyAr NjAsNyBAQCBjbGFzcyBHREJDcmFzaExvZ0dlbmVyYXRvcihvYmplY3QpOgogICAgICAgICBzdGRv dXQsIHN0ZGVyciA9IHByb2MuY29tbXVuaWNhdGUoKQogICAgICAgICBlcnJvcnMgPSBbc3RkZXJy X2xpbmUuc3RyaXAoKS5kZWNvZGUoJ3V0ZjgnLCAnaWdub3JlJykgZm9yIHN0ZGVycl9saW5lIGlu IHN0ZGVyci5zcGxpdGxpbmVzKCldCiAgICAgICAgIGlmIHByb2MucmV0dXJuY29kZSAhPSAwOgot ICAgICAgICAgICAgc3Rkb3V0ID0gKGInRVJST1I6IFRoZSBnZGIgcHJvY2VzcyBleGl0ZWQgd2l0 aCBub24temVybyByZXR1cm4gY29kZSAlc1xuXG4nICUgc3RyKHByb2MucmV0dXJuY29kZSkpICsg c3Rkb3V0CisgICAgICAgICAgICBzdGRvdXQgPSAoYidFUlJPUjogVGhlIGdkYiBwcm9jZXNzIGV4 aXRlZCB3aXRoIG5vbi16ZXJvIHJldHVybiBjb2RlICVzXG5cbicgJSBzdHIocHJvYy5yZXR1cm5j b2RlKS5lbmNvZGUoJ3V0ZjgnLCAnaWdub3JlJykpICsgc3Rkb3V0CiAgICAgICAgIHJldHVybiAo c3Rkb3V0LmRlY29kZSgndXRmOCcsICdpZ25vcmUnKSwgZXJyb3JzKQogCiAgICAgZGVmIF9nZXRf dG1wX2ZpbGVfbmFtZShzZWxmLCBjb3JlZHVtcGN0bCwgZmlsZW5hbWUpOgo=