237397 2022-03-02 16:18:24 -0800 Web Inspector: (Regression: r270134) [Timelines] CPU timeline details view is empty (and remains empty) if it was visible during an automatic recording on page load 2022-03-02 17:36:28 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All NEW InRadar P2 Normal --- 1 pangle pangle ews-watchlist hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1847665 0 pangle 2022-03-02 16:18:24 -0800 <rdar://89660755> 1847671 1 453675 pangle 2022-03-02 16:32:02 -0800 Created attachment 453675 Patch v1.0 1847682 2 453675 hi 2022-03-02 17:01:17 -0800 Comment on attachment 453675 Patch v1.0 View in context: https://bugs.webkit.org/attachment.cgi?id=453675&action=review > Source/WebInspectorUI/ChangeLog:19 > + This wasn't the case for the first recording's `CPUTimelineView because it is already attached when it performs If this is not a problem for `initialLayout`, then how does the `TimelineRuler` have bad values after that if the user hasn't navigated away from the `CPUTimelineView`? This makes it sound like reloading the page somehow `detach` and then re-`attach` the `CPUTimelineView`. I would hope that we're not doing that for a simple page reload. > Source/WebInspectorUI/UserInterface/Views/View.js:37 > + this._dirtyFromResize = false; Rather than adding another property, maybe we make `_layoutReason` into a `Set` (or bitmap if we're concerned about memory) so that if more `WI.View.LayoutReason` are added (or custom ones like `WI.CPUTimelineView.LayoutReason.Internal` are used more frequently) then we don't have to add even more properties. I think there's only a dozen or so uses of `this.layoutReason === ...` anyways, so changing those to `this.layoutReasons.has(...)` (or `this.layoutReasons & ...`) would probably be pretty simple. Though we'd also probably wanna allow anything that previously only accepted a `layoutReason` to now accept a `layoutReasons` (i.e. `Set`) too. 453675 2022-03-02 16:32:02 -0800 2022-03-02 17:36:28 -0800 Patch v1.0 bug-237397-20220302163201.patch text/plain 5189 pangle U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwNjY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBk NDUxMjdhNGY5ODUyZDIzY2FhZWVlZDA2YmY4NmIzNWE0MzlhNmU3Li41OTViMDY5ZjliMTE4OWI2 OWNiNjFkMzdjMDMzOTcwNWQ1ZTkxMWYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwzNiBAQAorMjAyMi0wMy0wMiAgUGF0cmljayBBbmdsZSAgPHBhbmdsZUBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogKFJlZ3Jlc3Npb246IHIyNzAxMzQpIFtUaW1lbGlu ZXNdIENQVSB0aW1lbGluZSBkZXRhaWxzIHZpZXcgaXMgZW1wdHkgKGFuZCByZW1haW5zIGVtcHR5 KSBpZiBpdCB3YXMgdmlzaWJsZSBkdXJpbmcgYW4gYXV0b21hdGljIHJlY29yZGluZyBvbiBwYWdl IGxvYWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIz NzM5NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENQ VVRpbWVsaW5lVmlldyB1c2VzIGEgYFRpbWVsaW5lUnVsZXJgIGZvciBwYXJ0IG9mIGl0cyBsYXlv dXQsIGFuZCBpZiB0aGUgcnVsZXIgaGFzIG5vdCBiZWVuIHByb3Blcmx5IGxhaWQgb3V0CisgICAg ICAgIGFmdGVyIGJlaW5nIGF0dGFjaGVkIHRvIHRoZSBET00gaXQgd2lsbCBiZWxpZXZlIGl0cyB3 aWR0aCBpcyB6ZXJvLCB3aGljaCBjYXVzZXMgbmVjZXNzYXJ5IHZhbHVlcyAoYHplcm9UaW1lYCwK KyAgICAgICAgYHN0YXJ0VGltZWAsIGBlbmRUaW1lYCwgYW5kIGBzZWNvbmRzUGVyUGl4ZWxgKSB0 byBiZSBtaXNzaW5nIHdoZW4gd2UgcmVhY2ggYENQVVRpbWVsaW5lVmlldy5wcm90b3R5cGUubGF5 b3V0YC4KKyAgICAgICAgVGhpcyBvY2N1cnMgYmVjYXVzZSBgVGltZWxpbmVSdWxlcmAgb25seSB1 cGRhdGVzIGl0cyBjYWNoZWQgc2l6ZSB3aGVuIGBzaXplRGlkQ2hhbmdlYCBpcyBjYWxsZWQuIFRo aXMgc2hvdWxkCisgICAgICAgIG9jY3VyIGFzIHRoZSByZXN1bHQgb2YgY2FsbGluZyBgbmVlZHNM YXlvdXQoV0kuVmlldy5MYXlvdXRSZWFzb24uUmVzaXplKWAgb24gdGhlIGBUaW1lbGluZVJ1bGVy YCBhcyBwYXJ0IG9mCisgICAgICAgIGBDUFVUaW1lbGluZVZpZXcucHJvdG90eXBlLmF0dGFjaGVk YCwgaG93ZXZlciB0aGlzIGxheW91dCByZWFzb24gZW5kcyB1cCBiZWluZyBpZ25vcmVkIGJlY2F1 c2Ugb24gdGhlIG5leHQKKyAgICAgICAgbGF5b3V0IHdlIGFjdHVhbGx5IGxheSBvdXQgYSBwYXJl bnQgb2YgdGhlIHJ1bGVyLiBQcmV2aW91c2x5IHdoZW4gdGhpcyB3b3VsZCBvY2N1ciB0aGUgbGF5 b3V0IHJlYXNvbiB3b3VsZCBiZQorICAgICAgICByZXBsYWNlZCB3aXRoIHRoZSByZWFzb24gZm9y IHRoZSBwYXJlbnQgdmlldywgd2hpY2ggd2FzIGp1c3QgYFdJLlZpZXcuTGF5b3V0UmVhc29uLkRp cnR5YC4gVGhpcyBtZWFucyB0aGF0CisgICAgICAgIGBzaXplRGlkQ2hhbmdlYCB3YXMgbmV2ZXIg Y2FsbGVkIGZvciB0aGUgYFRpbWVsaW5lUnVsZXJgIHNpbmNlIHRoZSBsYXRlc3QgbGF5b3V0IHJl YXNvbiB3YXMgYERpcnR5YCwgbm90CisgICAgICAgIGBSZXNpemVgLgorCisgICAgICAgIFRoaXMg d2Fzbid0IHRoZSBjYXNlIGZvciB0aGUgZmlyc3QgcmVjb3JkaW5nJ3MgYENQVVRpbWVsaW5lVmll dyAgYmVjYXVzZSBpdCBpcyBhbHJlYWR5IGF0dGFjaGVkIHdoZW4gaXQgcGVyZm9ybXMKKyAgICAg ICAgYGluaXRpYWxMYXlvdXRgLCB3aGljaCBhbGxvd3MgdGhlIGV4cGxpY2l0IGNhbGwgdG8gdGhl IGBUaW1lbGluZVJ1bGVyYCB0bworICAgICAgICBgdXBkYXRlTGF5b3V0KFdJLlZpZXcuTGF5b3V0 UmVhc29uLlJlc2l6ZSlgIHRvIGFjdHVhbGx5IG1lYXN1cmUgdGhlIHNpemUgb2YgaXRzIGVsZW1l bnQsIHNpbmNlIGl0IGlzIGFscmVhZHkKKyAgICAgICAgYXR0YWNoZWQgdG8gdGhlIERPTS4KKwor ICAgICAgICBUbyBjb3JyZWN0IHRoaXMgd2Ugbm93IHByb3BhZ2F0ZSBhIGBfZGlydHlGcm9tUmVz aXplYCB2YWx1ZSB0byBhbGwgY2hpbGRyZW4gdmlld3MgaW4KKyAgICAgICAgYFZpZXcucHJvdG90 eXBlLl9sYXlvdXRTdWJ0cmVlYCwgd2hpY2ggYWxzbyBlbnN1cmVzIHN1YnNlcXVlbnQgY2FsbHMg dG8gYG5lZWRzTGF5b3V0YCAoYWZ0ZXIgYSBjYWxsIHdpdGggYQorICAgICAgICByZWFzb24gb2Yg YFJlc2l6ZWApIHdpbGwgc3RpbGwgY2FsbCBgc2l6ZURpZENoYW5nZWAgZHVyaW5nIGxheW91dCBh cyBleHBlY3RlZC4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvVmlldy5qczoKKyAg ICAgICAgKFdJLlZpZXcpOgorICAgICAgICAoV0kuVmlldy5wcm90b3R5cGUuX2xheW91dFN1YnRy ZWUpOgorICAgICAgICAoV0kuVmlldy5wcm90b3R5cGUuX3NldExheW91dFJlYXNvbik6CisgICAg ICAgIChXSS5WaWV3Ll9jYW5jZWxTY2hlZHVsZWRMYXlvdXRGb3JWaWV3KToKKwogMjAyMi0wMi0y OCAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3Bl Y3RvcjogW0ZsZXhib3hdIEFkZCBvcHRpb25zIHRvIHNob3cgZWFjaCBhcmVhJ3MgQ1NTIGBvcmRl cmAgYW5kL29yIERPTSBpbmRleCBpbiB0aGUgcGFyZW50IGZsZXggY29udGFpbmVyCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9WaWV3LmpzIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVmlldy5qcwppbmRleCBi NmQwZGE0YmQ1ZjIwZTYwNDkxMzEzYzI4Yzc1YjEzMWZkMGU2ZGExLi5jZTZkOWYxZmUyZTAzMWUz Yzg4NDMxZWE4ZGUwMzk3Y2E1Njc1NzgzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9WaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1ZpZXcuanMKQEAgLTM0LDYgKzM0LDcgQEAgV0kuVmlldyA9 IGNsYXNzIFZpZXcgZXh0ZW5kcyBXSS5PYmplY3QKICAgICAgICAgdGhpcy5fcGFyZW50VmlldyA9 IG51bGw7CiAgICAgICAgIHRoaXMuX3N1YnZpZXdzID0gW107CiAgICAgICAgIHRoaXMuX2RpcnR5 ID0gZmFsc2U7CisgICAgICAgIHRoaXMuX2RpcnR5RnJvbVJlc2l6ZSA9IGZhbHNlOwogICAgICAg ICB0aGlzLl9kaXJ0eURlc2NlbmRhbnRzQ291bnQgPSAwOwogICAgICAgICB0aGlzLl9pc0F0dGFj aGVkVG9Sb290ID0gZmFsc2U7CiAgICAgICAgIHRoaXMuX2xheW91dFJlYXNvbiA9IG51bGw7CkBA IC0yODIsNyArMjgzLDcgQEAgV0kuVmlldyA9IGNsYXNzIFZpZXcgZXh0ZW5kcyBXSS5PYmplY3QK ICAgICAgICAgICAgIHRoaXMuX2RpZEluaXRpYWxMYXlvdXQgPSB0cnVlOwogICAgICAgICB9CiAK LSAgICAgICAgaWYgKHRoaXMuX2xheW91dFJlYXNvbiA9PT0gV0kuVmlldy5MYXlvdXRSZWFzb24u UmVzaXplIHx8IGlzSW5pdGlhbExheW91dCkgeworICAgICAgICBpZiAodGhpcy5fZGlydHlGcm9t UmVzaXplIHx8IGlzSW5pdGlhbExheW91dCkgewogICAgICAgICAgICAgY29uc29sZS5hc3NlcnQo V0kuc2V0UmVlbnRyYW50Q2hlY2sodGhpcywgInNpemVEaWRDaGFuZ2UiKSwgIkVSUk9SOiBjYWxs aW5nIGBzaXplRGlkQ2hhbmdlYCB3aGlsZSBhbHJlYWR5IGluIGl0IiwgdGhpcyk7CiAgICAgICAg ICAgICB0aGlzLnNpemVEaWRDaGFuZ2UoKTsKICAgICAgICAgICAgIGNvbnNvbGUuYXNzZXJ0KFdJ LmNsZWFyUmVlbnRyYW50Q2hlY2sodGhpcywgInNpemVEaWRDaGFuZ2UiKSwgIkVSUk9SOiBtaXNz aW5nIHJldHVybiBmcm9tIGBzaXplRGlkQ2hhbmdlYCIsIHRoaXMpOwpAQCAtMzA2LDEwICszMDcs MTIgQEAgV0kuVmlldyA9IGNsYXNzIFZpZXcgZXh0ZW5kcyBXSS5PYmplY3QKIAogICAgICAgICBm b3IgKGxldCB2aWV3IG9mIHRoaXMuX3N1YnZpZXdzKSB7CiAgICAgICAgICAgICB2aWV3Ll9zZXRM YXlvdXRSZWFzb24odGhpcy5fbGF5b3V0UmVhc29uKTsKKyAgICAgICAgICAgIHZpZXcuX2RpcnR5 RnJvbVJlc2l6ZSB8fD0gdGhpcy5fZGlydHlGcm9tUmVzaXplOwogICAgICAgICAgICAgdmlldy5f bGF5b3V0U3VidHJlZSgpOwogICAgICAgICB9CiAKICAgICAgICAgdGhpcy5fbGF5b3V0UmVhc29u ID0gbnVsbDsKKyAgICAgICAgdGhpcy5fZGlydHlGcm9tUmVzaXplID0gZmFsc2U7CiAKICAgICAg ICAgY29uc29sZS5hc3NlcnQoV0kuc2V0UmVlbnRyYW50Q2hlY2sodGhpcywgImRpZExheW91dFN1 YnRyZWUiKSwgIkVSUk9SOiBjYWxsaW5nIGBkaWRMYXlvdXRTdWJ0cmVlYCB3aGlsZSBhbHJlYWR5 IGluIGl0IiwgdGhpcyk7CiAgICAgICAgIHRoaXMuZGlkTGF5b3V0U3VidHJlZSgpOwpAQCAtMzE5 LDYgKzMyMiwxMCBAQCBXSS5WaWV3ID0gY2xhc3MgVmlldyBleHRlbmRzIFdJLk9iamVjdAogICAg IF9zZXRMYXlvdXRSZWFzb24obGF5b3V0UmVhc29uKQogICAgIHsKICAgICAgICAgdGhpcy5fbGF5 b3V0UmVhc29uID0gbGF5b3V0UmVhc29uIHx8IFdJLlZpZXcuTGF5b3V0UmVhc29uLkRpcnR5Owor CisgICAgICAgIC8vIE11bHRpcGxlIHJlcXVlc3RzIGZvciBsYXlvdXQgdG8gYSBzaW5nbGUgdmll dyBtYXkgcHJvZHVjZSBtdWx0aXBsZSBkaWZmZXJlbnQgYGxheW91dFJlYXNvbmBzLCBidXQgaWYg YW55IG9mCisgICAgICAgIC8vIHRoZSByZWFzb25zIHdlcmUgYFJlc2l6ZWAgd2UgbmVlZCB0byBj YWxsIGBzaXplRGlkQ2hhbmdlYCBpbiBgX2xheW91dFN1YnRyZWVgLgorICAgICAgICB0aGlzLl9k aXJ0eUZyb21SZXNpemUgfHw9IGxheW91dFJlYXNvbiA9PT0gV0kuVmlldy5MYXlvdXRSZWFzb24u UmVzaXplOwogICAgIH0KIAogICAgIF9kcmF3TGF5b3V0Rmxhc2hpbmdPdXRsaW5lKGlzSW5pdGlh bExheW91dCkKQEAgLTM3NCw2ICszODEsNyBAQCBXSS5WaWV3ID0gY2xhc3MgVmlldyBleHRlbmRz IFdJLk9iamVjdAogICAgICAgICB9CiAKICAgICAgICAgdmlldy5fZGlydHkgPSBmYWxzZTsKKyAg ICAgICAgdmlldy5fZGlydHlGcm9tUmVzaXplID0gZmFsc2U7CiAKICAgICAgICAgaWYgKCFXSS5W aWV3Ll9zY2hlZHVsZWRMYXlvdXRVcGRhdGVJZGVudGlmaWVyKQogICAgICAgICAgICAgcmV0dXJu Owo=