237390 2022-03-02 13:50:17 -0800 [AppSSO] Correct logging messages to avoid confusing screeners that an error has occurred 2024-07-13 12:35:06 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham pascoe sacolo9459 simon.fraser webkit-bug-importer yivarak978 oldest_to_newest 1847604 0 bfulgham 2022-03-02 13:50:17 -0800 The phrasing of the message in 'SOAuthorizationCoordinator::tryAuthorize' when a URL is not relevant for AppSSO flows is: AUTHORIZATIONCOORDINATOR_RELEASE_LOG("tryAuthorize: Cannot authorize the requested URL."); This leads people spelunking logs to believe that the URL can't be authorized (perhaps due to an error). Instead, we should more accurately report that the URL is not one that is mediated through an AppSSO flow, and so no AppSSO processing is needed. 1847605 1 webkit-bug-importer 2022-03-02 13:51:49 -0800 <rdar://problem/89710486> 1847608 2 453657 bfulgham 2022-03-02 14:02:08 -0800 Created attachment 453657 Patch 1847640 3 ews-feeder 2022-03-02 15:26:26 -0800 Committed r290758 (248002@main): <https://commits.webkit.org/248002@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453657. 453657 2022-03-02 14:02:08 -0800 2022-03-02 15:26:29 -0800 Patch bug-237390-20220302140207.patch text/plain 4934 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwNzM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDJhZDkwNmJjYjQ1NjQ4ZTgw ODgyNzkzN2E3NDFmZTYzNDlmZDI5ZWMuLjMwZGM0MmExNGNiYTM3ZDQ1YzYxYzExZjRkMDFjNGMz NGJhYjJkODMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMjItMDMtMDIgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgW0FwcFNTT10gQ29ycmVjdCBs b2dnaW5nIG1lc3NhZ2VzIHRvIGF2b2lkIGNvbmZ1c2luZyBzY3JlZW5lcnMgdGhhdCBhbiBlcnJv ciBoYXMgb2NjdXJyZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIzNzM5MAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vODk3MTA0ODY+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHBocmFzaW5nIG9m IHRoZSBtZXNzYWdlIGluICdTT0F1dGhvcml6YXRpb25Db29yZGluYXRvcjo6dHJ5QXV0aG9yaXpl JyB3aGVuIGEgVVJMIGlzIG5vdCByZWxldmFudCBmb3IKKyAgICAgICAgQXBwU1NPIGZsb3dzIGlz OgorCisgICAgICAgICAgICAgICAgQVVUSE9SSVpBVElPTkNPT1JESU5BVE9SX1JFTEVBU0VfTE9H KCJ0cnlBdXRob3JpemU6IENhbm5vdCBhdXRob3JpemUgdGhlIHJlcXVlc3RlZCBVUkwuIik7CisK KyAgICAgICAgVGhpcyBsZWFkcyBwZW9wbGUgc3BlbHVua2luZyBsb2dzIHRvIGJlbGlldmUgdGhh dCB0aGUgVVJMIGNhbid0IGJlIGF1dGhvcml6ZWQgKHBlcmhhcHMgZHVlIHRvIGFuIGVycm9yKS4K KworICAgICAgICBJbnN0ZWFkLCB3ZSBzaG91bGQgbW9yZSBhY2N1cmF0ZWx5IHJlcG9ydCB0aGF0 IHRoZSBVUkwgaXMgbm90IG9uZSB0aGF0IGlzIG1lZGlhdGVkIHRocm91Z2ggYW4gQXBwU1NPIGZs b3csCisgICAgICAgIGFuZCBzbyBubyBBcHBTU08gcHJvY2Vzc2luZyBpcyBuZWVkZWQuCisKKyAg ICAgICAgKiBVSVByb2Nlc3MvQ29jb2EvU09BdXRob3JpemF0aW9uL1NPQXV0aG9yaXphdGlvbkNv b3JkaW5hdG9yLm1tOgorICAgICAgICAoV2ViS2l0OjpTT0F1dGhvcml6YXRpb25Db29yZGluYXRv cjo6dHJ5QXV0aG9yaXplKToKKwogMjAyMi0wMy0wMiAgU2lodWkgTGl1ICA8c2lodWlfbGl1QGFw cGxlLmNvbT4KIAogICAgICAgICBBZGQgYXNzZXJ0aW9uIHRoYXQgbm8gdHdvIHNlc3Npb25zIHNo YXJlIHRoZSBzYW1lIGdlbmVyYWwgc3RvcmFnZSBkaXJlY3RvcnkKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1NPQXV0aG9yaXphdGlvbi9TT0F1dGhvcml6YXRpb25D b29yZGluYXRvci5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1NPQXV0aG9yaXph dGlvbi9TT0F1dGhvcml6YXRpb25Db29yZGluYXRvci5tbQppbmRleCA1Zjk1MTNmNTQ3NzBiN2Q0 YzQxZWEzZDkyYmY0YmE1ZjVlMjA4MDE1Li5jMmFmMWY0ODMyZDc4ZDJkZGQ0MGEwMzUzMGM5NmEy NzkxZTNmN2IwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9TT0F1 dGhvcml6YXRpb24vU09BdXRob3JpemF0aW9uQ29vcmRpbmF0b3IubW0KKysrIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvQ29jb2EvU09BdXRob3JpemF0aW9uL1NPQXV0aG9yaXphdGlvbkNvb3Jk aW5hdG9yLm1tCkBAIC00Miw2ICs0Miw3IEBACiAjaW1wb3J0IDx3dGYvRnVuY3Rpb24uaD4KIAog I2RlZmluZSBBVVRIT1JJWkFUSU9OQ09PUkRJTkFUT1JfUkVMRUFTRV9MT0coZm10LCAuLi4pIFJF TEVBU0VfTE9HKEFwcFNTTywgIiVwIC0gU09BdXRob3JpemF0aW9uQ29vcmRpbmF0b3I6OiIgZm10 LCB0aGlzLCAjI19fVkFfQVJHU19fKQorI2RlZmluZSBBVVRIT1JJWkFUSU9OQ09PUkRJTkFUT1Jf UkVMRUFTRV9MT0dfRVJST1IoZm10LCAuLi4pIFJFTEVBU0VfTE9HX0VSUk9SKEFwcFNTTywgIiVw IC0gU09BdXRob3JpemF0aW9uQ29vcmRpbmF0b3I6OiIgZm10LCB0aGlzLCAjI19fVkFfQVJHU19f KQogCiBuYW1lc3BhY2UgV2ViS2l0IHsKIApAQCAtNjcsNyArNjgsNyBAQCB2b2lkIFNPQXV0aG9y aXphdGlvbkNvb3JkaW5hdG9yOjp0cnlBdXRob3JpemUoUmVmPEFQSTo6TmF2aWdhdGlvbkFjdGlv bj4mJiBuYXZpZwogewogICAgIEFVVEhPUklaQVRJT05DT09SRElOQVRPUl9SRUxFQVNFX0xPRygi dHJ5QXV0aG9yaXplIik7CiAgICAgaWYgKCFjYW5BdXRob3JpemUobmF2aWdhdGlvbkFjdGlvbi0+ cmVxdWVzdCgpLnVybCgpKSkgewotICAgICAgICBBVVRIT1JJWkFUSU9OQ09PUkRJTkFUT1JfUkVM RUFTRV9MT0coInRyeUF1dGhvcml6ZTogQ2Fubm90IGF1dGhvcml6ZSB0aGUgcmVxdWVzdGVkIFVS TC4iKTsKKyAgICAgICAgQVVUSE9SSVpBVElPTkNPT1JESU5BVE9SX1JFTEVBU0VfTE9HKCJ0cnlB dXRob3JpemU6IFRoZSByZXF1ZXN0ZWQgVVJMIGlzIG5vdCByZWdpc3RlcmVkIGZvciBBcHBTU08g aGFuZGxpbmcuIE5vIGZ1cnRoZXIgYWN0aW9uIG5lZWRlZC4iKTsKICAgICAgICAgY29tcGxldGlv bkhhbmRsZXIoZmFsc2UpOwogICAgICAgICByZXR1cm47CiAgICAgfQpAQCAtNzYsNyArNzcsNyBA QCB2b2lkIFNPQXV0aG9yaXphdGlvbkNvb3JkaW5hdG9yOjp0cnlBdXRob3JpemUoUmVmPEFQSTo6 TmF2aWdhdGlvbkFjdGlvbj4mJiBuYXZpZwogICAgIGF1dG8qIHRhcmdldEZyYW1lID0gbmF2aWdh dGlvbkFjdGlvbi0+dGFyZ2V0RnJhbWUoKTsKICAgICBib29sIHN1YmZyYW1lTmF2aWdhdGlvbiA9 IHRhcmdldEZyYW1lICYmICF0YXJnZXRGcmFtZS0+aXNNYWluRnJhbWUoKTsKICAgICBpZiAoc3Vi ZnJhbWVOYXZpZ2F0aW9uICYmICghcGFnZS5tYWluRnJhbWUoKSB8fCAhW0FLQXV0aG9yaXphdGlv bkNvbnRyb2xsZXIgaXNVUkxGcm9tQXBwbGVPd25lZERvbWFpbjpwYWdlLm1haW5GcmFtZSgpLT51 cmwoKV0pKSB7Ci0gICAgICAgIEFVVEhPUklaQVRJT05DT09SRElOQVRPUl9SRUxFQVNFX0xPRygi dHJ5QXV0aG9yaXplOiBBdHRlbXB0aW5nIHRvIHBlcmZvcm0gc3ViZnJhbWUgbmF2aWdhdGlvbiBm b3Igbm9uLUFwcGxlIGF1dGhvcml6YXRpb24gVVJMLiIpOworICAgICAgICBBVVRIT1JJWkFUSU9O Q09PUkRJTkFUT1JfUkVMRUFTRV9MT0dfRVJST1IoInRyeUF1dGhvcml6ZTogQXR0ZW1wdGluZyB0 byBwZXJmb3JtIHN1YmZyYW1lIG5hdmlnYXRpb24gZm9yIG5vbi1BcHBsZSBhdXRob3JpemF0aW9u IFVSTC4iKTsKICAgICAgICAgY29tcGxldGlvbkhhbmRsZXIoZmFsc2UpOwogICAgICAgICByZXR1 cm47CiAgICAgfQpAQCAtODgsOSArODksMjEgQEAgdm9pZCBTT0F1dGhvcml6YXRpb25Db29yZGlu YXRvcjo6dHJ5QXV0aG9yaXplKFJlZjxBUEk6Ok5hdmlnYXRpb25BY3Rpb24+JiYgbmF2aWcKIHZv aWQgU09BdXRob3JpemF0aW9uQ29vcmRpbmF0b3I6OnRyeUF1dGhvcml6ZShSZWY8QVBJOjpOYXZp Z2F0aW9uQWN0aW9uPiYmIG5hdmlnYXRpb25BY3Rpb24sIFdlYlBhZ2VQcm94eSYgcGFnZSwgTmV3 UGFnZUNhbGxiYWNrJiYgbmV3UGFnZUNhbGxiYWNrLCBVSUNsaWVudENhbGxiYWNrJiYgdWlDbGll bnRDYWxsYmFjaykKIHsKICAgICBBVVRIT1JJWkFUSU9OQ09PUkRJTkFUT1JfUkVMRUFTRV9MT0co InRyeUF1dGhvcml6ZSAoMikiKTsKKyAgICBpZiAoIWNhbkF1dGhvcml6ZShuYXZpZ2F0aW9uQWN0 aW9uLT5yZXF1ZXN0KCkudXJsKCkpKSB7CisgICAgICAgIEFVVEhPUklaQVRJT05DT09SRElOQVRP Ul9SRUxFQVNFX0xPRygidHJ5QXV0aG9yaXplICgyKTogVGhlIHJlcXVlc3RlZCBVUkwgaXMgbm90 IHJlZ2lzdGVyZWQgZm9yIEFwcFNTTyBoYW5kbGluZy4gTm8gZnVydGhlciBhY3Rpb24gbmVlZGVk LiIpOworICAgICAgICB1aUNsaWVudENhbGxiYWNrKFdURk1vdmUobmF2aWdhdGlvbkFjdGlvbiks IFdURk1vdmUobmV3UGFnZUNhbGxiYWNrKSk7CisgICAgICAgIHJldHVybjsKKyAgICB9CisKICAg ICBib29sIHN1YmZyYW1lTmF2aWdhdGlvbiA9IG5hdmlnYXRpb25BY3Rpb24tPnNvdXJjZUZyYW1l KCkgJiYgIW5hdmlnYXRpb25BY3Rpb24tPnNvdXJjZUZyYW1lKCktPmlzTWFpbkZyYW1lKCk7Ci0g ICAgaWYgKHN1YmZyYW1lTmF2aWdhdGlvbiB8fCAhbmF2aWdhdGlvbkFjdGlvbi0+aXNQcm9jZXNz aW5nVXNlckdlc3R1cmUoKSB8fCAhY2FuQXV0aG9yaXplKG5hdmlnYXRpb25BY3Rpb24tPnJlcXVl c3QoKS51cmwoKSkpIHsKLSAgICAgICAgQVVUSE9SSVpBVElPTkNPT1JESU5BVE9SX1JFTEVBU0Vf TE9HKCJ0cnlBdXRob3JpemUgKDIpOiBBdHRlbXB0aW5nIHRvIHBlcmZvcm0gaW52YWxpZCBhdXRo LiIpOworICAgIGlmIChzdWJmcmFtZU5hdmlnYXRpb24pIHsKKyAgICAgICAgQVVUSE9SSVpBVElP TkNPT1JESU5BVE9SX1JFTEVBU0VfTE9HX0VSUk9SKCJ0cnlBdXRob3JpemUgKDIpOiBBdHRlbXB0 aW5nIHRvIHBlcmZvcm0gc3ViZnJhbWUgbmF2aWdhdGlvbi4iKTsKKyAgICAgICAgdWlDbGllbnRD YWxsYmFjayhXVEZNb3ZlKG5hdmlnYXRpb25BY3Rpb24pLCBXVEZNb3ZlKG5ld1BhZ2VDYWxsYmFj aykpOworICAgICAgICByZXR1cm47CisgICAgfQorCisgICAgaWYgKCFuYXZpZ2F0aW9uQWN0aW9u LT5pc1Byb2Nlc3NpbmdVc2VyR2VzdHVyZSgpKSB7CisgICAgICAgIEFVVEhPUklaQVRJT05DT09S RElOQVRPUl9SRUxFQVNFX0xPR19FUlJPUigidHJ5QXV0aG9yaXplICgyKTogQXR0ZW1wdGluZyB0 byBwZXJmb3JtIGF1dGggd2l0aG91dCBhIHVzZXIgZ2VzdHVyZS4iKTsKICAgICAgICAgdWlDbGll bnRDYWxsYmFjayhXVEZNb3ZlKG5hdmlnYXRpb25BY3Rpb24pLCBXVEZNb3ZlKG5ld1BhZ2VDYWxs YmFjaykpOwogICAgICAgICByZXR1cm47CiAgICAgfQo=