23738 2009-02-04 12:58:45 -0800 Add the ability to determine what the target string is in a hit test. 2009-02-13 06:46:43 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Major --- 0 ben webkit-unassigned manyoso zimmermann oldest_to_newest 108320 0 ben 2009-02-04 12:58:45 -0800 Currently in the QWebHitTest you can get a pointer to the QWebFrame that the target link points to. This is nice that the string is automatically converted to the frame, but when the frame is 0 because the target string is not necessarily _blank, but could be a bad frame name such as foobar. This patch adds a function to QWebHitTest to return the string name. Included is a test for it. http://code.staikos.net/cgi-bin/gitweb.cgi?p=webkit;a=commit;h=05088d2fb9c454ff9e5029985eb35e1707d0a2d0 108321 1 zimmermann 2009-02-04 13:10:24 -0800 Looks just fine to me. You need to upload a patch though, best is to apply your patch to a WebKit trunk checkout. Run prepare-ChangeLog, edit ChangeLog, use svn-create-patch and then upload the resulting patch here, I'll r+ it then. 109543 2 27622 ben 2009-02-12 12:55:42 -0800 Created attachment 27622 webkit patch 109559 3 27622 zimmermann 2009-02-12 14:31:23 -0800 Comment on attachment 27622 webkit patch r=me. 109666 4 manyoso 2009-02-13 06:46:43 -0800 Committed with r40973 with slight change for the qdocs saying this is introduced in 4.6+. 27622 2009-02-12 12:55:42 -0800 2009-02-12 14:31:23 -0800 webkit patch target.patch text/plain 4574 ben RnJvbSBlYjY0Y2IzYWVhODQ0MjkyZGE0ZWM5OTk0NTczODc2ODZkYzhkYWJkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCZW5qYW1pbiBDIE1leWVyIDxiZW5qYW1pbi5tZXllckB0b3Jj aG1vYmlsZS5jb20+CkRhdGU6IFR1ZSwgMyBGZWIgMjAwOSAxMjoxNjoyMiAtMDUwMApTdWJqZWN0 OiAyMDA5LTAyLTAzICBCZW5qYW1pbiBDIE1leWVyIDxiZW5qYW1pbi5tZXllckB0b3JjaG1vYmls ZS5jb20+CgogICAgICAgICAgICBFeHBvc2UgdGhlIHVybCBlbGVtZW50cyB0YXJnZXQgZnJhbWUg c3RyaW5nLiAgVGhpcyBpcyB0aGUgc2lzdGVyIGZ1bmN0aW9uIHRvIHRoZSBleGlzdGluZyBsaW5r VGFyZ2V0RnJhbWUgd2hpY2ggcmV0dXJucyB0aGUgUVdlYkZyYW1lKi4gIFdoZW4gdGhlIGxpbmtU YXJnZXRGcmFtZSBpcyAwIGl0IGlzIHVzZWZ1bCB0byBrbm93IHdoYXQgdGhlIHRhcmdldCB3YXMg dG8gYmUuCgogICAgICAgICAgICAqIEFwaS9xd2ViZnJhbWUuW2gsY3BwLF9wLGhdCi0tLQogV2Vi S2l0L3F0L0FwaS9xd2ViZnJhbWUuY3BwICAgICAgICAgICAgICAgICB8ICAgMTcgKysrKysrKysr KysrKysrKysKIFdlYktpdC9xdC9BcGkvcXdlYmZyYW1lLmggICAgICAgICAgICAgICAgICAgfCAg ICAxICsKIFdlYktpdC9xdC9BcGkvcXdlYmZyYW1lX3AuaCAgICAgICAgICAgICAgICAgfCAgICAx ICsKIFdlYktpdC9xdC9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDEzICsr KysrKysrKysrKysKIFdlYktpdC9xdC90ZXN0cy9xd2ViZnJhbWUvdHN0X3F3ZWJmcmFtZS5jcHAg fCAgICAzICsrLQogNSBmaWxlcyBjaGFuZ2VkLCAzNCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9u cygtKQoKZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYmZyYW1lLmNwcCBiL1dlYktpdC9x dC9BcGkvcXdlYmZyYW1lLmNwcAppbmRleCBhNjU5NDMxLi5jZGNiOTM0IDEwMDY0NAotLS0gYS9X ZWJLaXQvcXQvQXBpL3F3ZWJmcmFtZS5jcHAKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2ViZnJhbWUu Y3BwCkBAIC0xMTYzLDYgKzExNjMsOSBAQCBRV2ViSGl0VGVzdFJlc3VsdFByaXZhdGU6OlFXZWJI aXRUZXN0UmVzdWx0UHJpdmF0ZShjb25zdCBXZWJDb3JlOjpIaXRUZXN0UmVzdWx0CiAgICAgV2Vi Q29yZTo6RnJhbWUgKndmcmFtZSA9IGhpdFRlc3QudGFyZ2V0RnJhbWUoKTsKICAgICBpZiAod2Zy YW1lKQogICAgICAgICBsaW5rVGFyZ2V0RnJhbWUgPSBRV2ViRnJhbWVQcml2YXRlOjpraXQod2Zy YW1lKTsKKyAgICBFbGVtZW50KiB1cmxFbGVtZW50ID0gaGl0VGVzdC5VUkxFbGVtZW50KCk7Cisg ICAgaWYgKHVybEVsZW1lbnQpCisgICAgICAgIGxpbmtUYXJnZXQgPSB1cmxFbGVtZW50LT50YXJn ZXQoKTsKIAogICAgIGlzQ29udGVudEVkaXRhYmxlID0gaGl0VGVzdC5pc0NvbnRlbnRFZGl0YWJs ZSgpOwogICAgIGlzQ29udGVudFNlbGVjdGVkID0gaGl0VGVzdC5pc1NlbGVjdGVkKCk7CkBAIC0x MzA3LDcgKzEzMTAsMjEgQEAgUVVybCBRV2ViSGl0VGVzdFJlc3VsdDo6bGlua1RpdGxlKCkgY29u c3QKIH0KIAogLyohCisgICAgUmV0dXJucyB0aGUgbmFtZSBvZiB0aGUgdGFyZ2V0IGZyYW1lIHRo YXQgd2lsbCBsb2FkIHRoZSBsaW5rIGlmIGl0IGlzIGFjdGl2YXRlZC4KKworICAgIFxzYSBsaW5r VGFyZ2V0RnJhbWUKKyovCitRU3RyaW5nIFFXZWJIaXRUZXN0UmVzdWx0OjpsaW5rVGFyZ2V0KCkg Y29uc3QKK3sKKyAgICBpZiAoIWQpCisgICAgICAgIHJldHVybiAwOworICAgIHJldHVybiBkLT5s aW5rVGFyZ2V0OworfQorCisvKiEKICAgICBSZXR1cm5zIHRoZSBmcmFtZSB0aGF0IHdpbGwgbG9h ZCB0aGUgbGluayBpZiBpdCBpcyBhY3RpdmF0ZWQuCisKKyAgICBcc2EgbGlua1RhcmdldAogKi8K IFFXZWJGcmFtZSAqUVdlYkhpdFRlc3RSZXN1bHQ6OmxpbmtUYXJnZXRGcmFtZSgpIGNvbnN0CiB7 CmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvQXBpL3F3ZWJmcmFtZS5oIGIvV2ViS2l0L3F0L0FwaS9x d2ViZnJhbWUuaAppbmRleCBkYjE4MGQwLi5kMGZhMTkzIDEwMDY0NAotLS0gYS9XZWJLaXQvcXQv QXBpL3F3ZWJmcmFtZS5oCisrKyBiL1dlYktpdC9xdC9BcGkvcXdlYmZyYW1lLmgKQEAgLTc4LDYg Kzc4LDcgQEAgcHVibGljOgogICAgIFFVcmwgbGlua1VybCgpIGNvbnN0OwogICAgIFFVcmwgbGlu a1RpdGxlKCkgY29uc3Q7CiAgICAgUVdlYkZyYW1lICpsaW5rVGFyZ2V0RnJhbWUoKSBjb25zdDsK KyAgICBRU3RyaW5nIGxpbmtUYXJnZXQoKSBjb25zdDsKIAogICAgIFFTdHJpbmcgYWx0ZXJuYXRl VGV4dCgpIGNvbnN0OyAvLyBmb3IgaW1nLCBhcmVhLCBpbnB1dCBhbmQgYXBwbGV0CiAKZGlmZiAt LWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYmZyYW1lX3AuaCBiL1dlYktpdC9xdC9BcGkvcXdlYmZy YW1lX3AuaAppbmRleCAzMGY5NGNmLi5jNTQxY2QzIDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvQXBp L3F3ZWJmcmFtZV9wLmgKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2ViZnJhbWVfcC5oCkBAIC0xMDcs NiArMTA3LDcgQEAgcHVibGljOgogICAgIFFVcmwgbGlua1VybDsKICAgICBRU3RyaW5nIGxpbmtU aXRsZTsKICAgICBRUG9pbnRlcjxRV2ViRnJhbWU+IGxpbmtUYXJnZXRGcmFtZTsKKyAgICBRU3Ry aW5nIGxpbmtUYXJnZXQ7CiAgICAgUVN0cmluZyBhbHRlcm5hdGVUZXh0OwogICAgIFFVcmwgaW1h Z2VVcmw7CiAgICAgUVBpeG1hcCBwaXhtYXA7CmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvQ2hhbmdl TG9nIGIvV2ViS2l0L3F0L0NoYW5nZUxvZwppbmRleCBhMTYzYTQyLi4xNjA0MWM5IDEwMDY0NAot LS0gYS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisrKyBiL1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAwOS0wMi0wNCAgQmVuamFtaW4gQyBNZXllciAgPGJlbmphbWluLm1leWVy QHRvcmNobW9iaWxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBFeHBvc2UgdGhlIHVybCBlbGVtZW50cyB0YXJnZXQgZnJhbWUgc3RyaW5nLiAg VGhpcyBpcyB0aGUgc2lzdGVyIGZ1bmN0aW9uIHRvIHRoZSBleGlzdGluZyBsaW5rVGFyZ2V0RnJh bWUgd2hpY2ggcmV0dXJucyB0aGUgUVdlYkZyYW1lKi4gIFdoZW4gdGhlIGxpbmtUYXJnZXRGcmFt ZSBpcyAwIGl0IGlzIHVzZWZ1bCB0byBrbm93IHdoYXQgdGhlIHRhcmdldCB3YXMgdG8gYmUuCisg ICAgICAgIAorICAgICAgICAqIEFwaS9xd2ViZnJhbWUuY3BwOgorICAgICAgICAoUVdlYkhpdFRl c3RSZXN1bHRQcml2YXRlOjpRV2ViSGl0VGVzdFJlc3VsdFByaXZhdGUpOgorICAgICAgICAoUVdl YkhpdFRlc3RSZXN1bHQ6OmxpbmtUYXJnZXQpOgorICAgICAgICAqIEFwaS9xd2ViZnJhbWUuaDoK KyAgICAgICAgKiBBcGkvcXdlYmZyYW1lX3AuaDoKKyAgICAgICAgKiB0ZXN0cy9xd2ViZnJhbWUv dHN0X3F3ZWJmcmFtZS5jcHA6CisKIDIwMDktMDItMTEgIERpbWl0cmkgRHVwdWlzLWxhdG91ciAg PGR1cHVpc2xhdG91ckBhcHBsZS5jb20+CiAKICAgICAgICAgU3R1YiBvdXQgSW5zcGVjdG9yQ2xp ZW50UXQ6OmhpZGRlblBhbmVscy4KZGlmZiAtLWdpdCBhL1dlYktpdC9xdC90ZXN0cy9xd2ViZnJh bWUvdHN0X3F3ZWJmcmFtZS5jcHAgYi9XZWJLaXQvcXQvdGVzdHMvcXdlYmZyYW1lL3RzdF9xd2Vi ZnJhbWUuY3BwCmluZGV4IDdhNmU5MzguLmQ5Yzk3YzggMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC90 ZXN0cy9xd2ViZnJhbWUvdHN0X3F3ZWJmcmFtZS5jcHAKKysrIGIvV2ViS2l0L3F0L3Rlc3RzL3F3 ZWJmcmFtZS90c3RfcXdlYmZyYW1lLmNwcApAQCAtMjI3Nyw3ICsyMjc3LDcgQEAgdm9pZCB0c3Rf UVdlYkZyYW1lOjpwb3B1cEZvY3VzKCkKIAogdm9pZCB0c3RfUVdlYkZyYW1lOjpoaXRUZXN0Q29u dGVudCgpCiB7Ci0gICAgUVN0cmluZyBodG1sKCI8aHRtbD48Ym9keT48cD5BIHBhcmFncmFwaDwv cD48YnIvPjxici8+PGJyLz48YSBocmVmPVwiYWJvdXQ6YmxhbmtcIj5saW5rIHRleHQ8L2E+PC9i b2R5PjwvaHRtbD4iKTsKKyAgICBRU3RyaW5nIGh0bWwoIjxodG1sPjxib2R5PjxwPkEgcGFyYWdy YXBoPC9wPjxici8+PGJyLz48YnIvPjxhIGhyZWY9XCJhYm91dDpibGFua1wiIHRhcmdldD1cIl9m b29cIj5saW5rIHRleHQ8L2E+PC9ib2R5PjwvaHRtbD4iKTsKIAogICAgIFFXZWJQYWdlIHBhZ2U7 CiAgICAgUVdlYkZyYW1lKiBmcmFtZSA9IHBhZ2UubWFpbkZyYW1lKCk7CkBAIC0yMjg1LDYgKzIy ODUsNyBAQCB2b2lkIHRzdF9RV2ViRnJhbWU6OmhpdFRlc3RDb250ZW50KCkKICAgICBwYWdlLnNl dFZpZXdwb3J0U2l6ZShRU2l6ZSgyMDAsIDApKTsgLy9ubyBoZWlnaHQgc28gbGluayBpcyBub3Qg dmlzaWJsZQogICAgIFFXZWJIaXRUZXN0UmVzdWx0IHJlc3VsdCA9IGZyYW1lLT5oaXRUZXN0Q29u dGVudChRUG9pbnQoMTAsIDEwMCkpOwogICAgIFFDT01QQVJFKHJlc3VsdC5saW5rVGV4dCgpLCBR U3RyaW5nKCJsaW5rIHRleHQiKSk7CisgICAgUUNPTVBBUkUocmVzdWx0LmxpbmtUYXJnZXQoKSwg UVN0cmluZygiX2ZvbyIpKTsKIH0KIAogdm9pZCB0c3RfUVdlYkZyYW1lOjpqc0J5dGVBcnJheSgp Ci0tIAoxLjUuNi4zCgo=