237376 2022-03-02 09:51:18 -0800 Verify DOM and Render text lengths are in sync in RenderTextLineBoxes::dirtyRange() 2022-07-22 11:53:40 -0700 1 1 1 Unclassified WebKit Layout and Rendering Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 brandonstewart brandonstewart bfulgham changseok esprehn+autocc ews-watchlist glenn kondapallykalyan mmaxfield pdr simon.fraser webkit-bug-importer zalan oldest_to_newest 1847472 0 brandonstewart 2022-03-02 09:51:18 -0800 <rdar://88813941> 1847478 1 453630 brandonstewart 2022-03-02 09:58:05 -0800 Created attachment 453630 Patch 1847511 2 453630 simon.fraser 2022-03-02 11:03:19 -0800 Comment on attachment 453630 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453630&action=review > Source/WebCore/rendering/RenderText.cpp:1297 > - int delta = newText.length() - text().length(); > + unsigned delta = std::abs(static_cast<int>(newText.length() - text().length())); This doesn't seem right. dirtyRange() is written to accept negative delta values; see the assertion in offsetRun(). This clamping needs to be more nuanced somehow. 1882126 3 460797 brandonstewart 2022-07-11 13:51:10 -0700 Created attachment 460797 patch 1886031 4 brandonstewart 2022-07-22 11:17:26 -0700 Pull request: https://github.com/WebKit/WebKit/pull/2660 1886054 5 ews-feeder 2022-07-22 11:53:36 -0700 Committed 252736@main (22aafa30b9a2): <https://commits.webkit.org/252736@main> Reviewed commits have been landed. Closing PR #2660 and removing active labels. 453630 2022-03-02 09:58:05 -0800 2022-07-11 13:51:10 -0700 Patch bug-237376-20220302095804.patch text/plain 3283 brandonstewart U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwNzE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTUyMmJjM2YzZTBjNTYx MjFjNTcwYTljNWU4YjNiOTk1MTU2ZGZjMy4uMzA3YzJhYjRhNDZjZjIzZjBlMTY2OWU0OTYzMTQ4 NjkwYzY0YjRlZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIyLTAzLTAyICBCcmFu ZG9uIFN0ZXdhcnQgIDxicmFuZG9uc3Rld2FydEBhcHBsZS5jb20+CisKKyAgICAgICAgRW5zdXJl IGRlbHRhIGxlbmd0aHMgYXJlIHBvc2l0aXZlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMzczNzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaGUgZGVsdGEgbGVuZ3RoIGNhbGN1bGF0aW9ucyBjYW4gc29t ZXRpbWVzIHJldHVybiBuZWdhdGl2ZSB2YWx1ZXMsIHdoaWNoCisgICAgICAgIGNhbiBjYXVzZSBp c3N1ZXMgd2hlbiBjYWxsaW5nIG9mZnNldFJ1bi4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5k ZXJUZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRleHQ6OnNldFRleHRXaXRoT2Zm c2V0KToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGV4dExpbmVCb3hlcy5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpSZW5kZXJUZXh0TGluZUJveGVzOjpkaXJ0eVJhbmdlKToKKyAgICAgICAg KiByZW5kZXJpbmcvUmVuZGVyVGV4dExpbmVCb3hlcy5oOgorCiAyMDIyLTAzLTAxICBBbGFuIEJ1 anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OKHIyODUyMzIpIGh0 dHBzOi8vYWx2YXJvbW9udG9yby5naXRodWIuaW8vYWxtb25kLmNzcy9kZW1vLyBsb29rcyB3cm9u ZyBpbiBTYWZhcmksIG9rIGluIENocm9tZSBhbmQgRmlyZWZveApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlclRleHQuY3BwCmluZGV4IDM2NWQyZjlhMjljMGZhYTdhOWYwYWMwMzg4MjFlMGY4 MTA1MzQ1ZTkuLmMxOGIyNzRkNWQ0ZDRhMzRkNDNkOTBiMDQ5ZTBkZDNkMzhhNzk0ODkgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0LmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4dC5jcHAKQEAgLTI4LDYgKzI4LDcgQEAKICNp bmNsdWRlICJBWE9iamVjdENhY2hlLmgiCiAjaW5jbHVkZSAiQnJlYWtMaW5lcy5oIgogI2luY2x1 ZGUgIkJyZWFraW5nQ29udGV4dC5oIgorI2luY2x1ZGUgPGNzdGRsaWI+CiAjaW5jbHVkZSAiQ2hh cmFjdGVyUHJvcGVydGllcy5oIgogI2luY2x1ZGUgIkRvY3VtZW50SW5saW5lcy5oIgogI2luY2x1 ZGUgIkRvY3VtZW50TWFya2VyQ29udHJvbGxlci5oIgpAQCAtMTI5Myw3ICsxMjk0LDcgQEAgdm9p ZCBSZW5kZXJUZXh0OjpzZXRUZXh0V2l0aE9mZnNldChjb25zdCBTdHJpbmcmIG5ld1RleHQsIHVu c2lnbmVkIG9mZnNldCwgdW5zaWcKICAgICBpZiAoIWZvcmNlICYmIHRleHQoKSA9PSBuZXdUZXh0 KQogICAgICAgICByZXR1cm47CiAKLSAgICBpbnQgZGVsdGEgPSBuZXdUZXh0Lmxlbmd0aCgpIC0g dGV4dCgpLmxlbmd0aCgpOworICAgIHVuc2lnbmVkIGRlbHRhID0gc3RkOjphYnMoc3RhdGljX2Nh c3Q8aW50PihuZXdUZXh0Lmxlbmd0aCgpIC0gdGV4dCgpLmxlbmd0aCgpKSk7CiAgICAgdW5zaWdu ZWQgZW5kID0gb2Zmc2V0ICsgbGVuZ3RoOwogCiAgICAgbV9saW5lc0RpcnR5ID0gbV9saW5lQm94 ZXMuZGlydHlSYW5nZSgqdGhpcywgb2Zmc2V0LCBlbmQsIGRlbHRhKTsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0TGluZUJveGVzLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0TGluZUJveGVzLmNwcAppbmRleCBhOTRkYTk3MGJm ODIyNTk4Njk4NTJiNjFiZGIxN2JjOTUyZDRkZWZjLi5lMjViNjM1ZDI0ZTJiM2Y1YmJlNTViN2E3 Njc0OGU5NDdiNmU2Njk3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyVGV4dExpbmVCb3hlcy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl clRleHRMaW5lQm94ZXMuY3BwCkBAIC0xNTMsNyArMTUzLDcgQEAgdm9pZCBSZW5kZXJUZXh0TGlu ZUJveGVzOjpkaXJ0eUFsbCgpCiAgICAgICAgIGJveC0+ZGlydHlMaW5lQm94ZXMoKTsKIH0KIAot Ym9vbCBSZW5kZXJUZXh0TGluZUJveGVzOjpkaXJ0eVJhbmdlKFJlbmRlclRleHQmIHJlbmRlcmVy LCB1bnNpZ25lZCBzdGFydCwgdW5zaWduZWQgZW5kLCBpbnQgbGVuZ3RoRGVsdGEpCitib29sIFJl bmRlclRleHRMaW5lQm94ZXM6OmRpcnR5UmFuZ2UoUmVuZGVyVGV4dCYgcmVuZGVyZXIsIHVuc2ln bmVkIHN0YXJ0LCB1bnNpZ25lZCBlbmQsIHVuc2lnbmVkIGxlbmd0aERlbHRhKQogewogICAgIExl Z2FjeVJvb3RJbmxpbmVCb3gqIGZpcnN0Um9vdEJveCA9IG51bGxwdHI7CiAgICAgTGVnYWN5Um9v dElubGluZUJveCogbGFzdFJvb3RCb3ggPSBudWxscHRyOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlclRleHRMaW5lQm94ZXMuaCBiL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJUZXh0TGluZUJveGVzLmgKaW5kZXggNzhhZmFmN2UwM2I4MmNiMmZhYTU0 YzRjMDIwNDA4OGRmOTgyOWZhZS4uZTc0MjE1MWViNzhiMDBiOGQxMWYyNGU4YTYxMGE1NDU4MTZm YzIxNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRleHRMaW5l Qm94ZXMuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4dExpbmVCb3hl cy5oCkBAIC01Miw3ICs1Miw3IEBAIHB1YmxpYzoKICAgICB2b2lkIGRlbGV0ZUFsbCgpOwogCiAg ICAgdm9pZCBkaXJ0eUFsbCgpOwotICAgIGJvb2wgZGlydHlSYW5nZShSZW5kZXJUZXh0JiwgdW5z aWduZWQgc3RhcnQsIHVuc2lnbmVkIGVuZCwgaW50IGxlbmd0aERlbHRhKTsKKyAgICBib29sIGRp cnR5UmFuZ2UoUmVuZGVyVGV4dCYsIHVuc2lnbmVkIHN0YXJ0LCB1bnNpZ25lZCBlbmQsIHVuc2ln bmVkIGxlbmd0aERlbHRhKTsKIAogICAgIExlZ2FjeUlubGluZVRleHRCb3gqIGZpbmROZXh0KGlu dCBvZmZzZXQsIGludCYgcG9zaXRpb24pIGNvbnN0OwogCg== 460797 2022-07-11 13:51:10 -0700 2022-07-22 11:04:59 -0700 patch patch.patch text/plain 941 brandonstewart ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy91cGRhdGluZy9SZW5kZXJUcmVl VXBkYXRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvdXBkYXRpbmcvUmVuZGVyVHJl ZVVwZGF0ZXIuY3BwCmluZGV4IDRjYmU0NTdhY2IxZS4uZDk2M2U2Mzg0NTk2IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvdXBkYXRpbmcvUmVuZGVyVHJlZVVwZGF0ZXIuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy91cGRhdGluZy9SZW5kZXJUcmVlVXBkYXRl ci5jcHAKQEAgLTUwNiwxNCArNTA2LDE5IEBAIHZvaWQgUmVuZGVyVHJlZVVwZGF0ZXI6OnVwZGF0 ZVRleHRSZW5kZXJlcihUZXh0JiB0ZXh0LCBjb25zdCBTdHlsZTo6VGV4dFVwZGF0ZSoKICAgICAg ICAgaWYgKG5lZWRzUmVuZGVyZXIpIHsKICAgICAgICAgICAgIGlmICh0ZXh0VXBkYXRlKQogICAg ICAgICAgICAgICAgIGV4aXN0aW5nUmVuZGVyZXItPnNldFRleHRXaXRoT2Zmc2V0KHRleHQuZGF0 YSgpLCB0ZXh0VXBkYXRlLT5vZmZzZXQsIHRleHRVcGRhdGUtPmxlbmd0aCk7CisKKyAgICAgICAg ICAgIHRlYXJEb3duVGV4dFJlbmRlcmVyKHRleHQsIG1fYnVpbGRlcik7CiAgICAgICAgICAgICBy ZXR1cm47CiAgICAgICAgIH0KKwogICAgICAgICB0ZWFyRG93blRleHRSZW5kZXJlcih0ZXh0LCBt X2J1aWxkZXIpOwogICAgICAgICByZW5kZXJpbmdQYXJlbnQoKS5kaWRDcmVhdGVPckRlc3Ryb3lD aGlsZFJlbmRlcmVyID0gdHJ1ZTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KKwogICAgIGlmICgh bmVlZHNSZW5kZXJlcikKICAgICAgICAgcmV0dXJuOworCiAgICAgY3JlYXRlVGV4dFJlbmRlcmVy KHRleHQsIHRleHRVcGRhdGUpOwogICAgIHJlbmRlcmluZ1BhcmVudCgpLmRpZENyZWF0ZU9yRGVz dHJveUNoaWxkUmVuZGVyZXIgPSB0cnVlOwogfQo=