237349 2022-03-01 17:13:00 -0800 AX: Handle null FileList in RenderFileUploadControl::fileTextValue() 2022-03-02 10:55:19 -0800 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tyler_w tyler_w andresg_22 cdumez cfleizach changseok esprehn+autocc ews-watchlist glenn kondapallykalyan mifenton pdr webkit-bug-importer oldest_to_newest 1847262 0 tyler_w 2022-03-01 17:13:00 -0800 In rare circumstances, it's possible for the FileList associated with RenderFileUploadControl::inputElement (HTMLInputElement::files()) to be null. We should avoid crashing in these scenarios. 1847263 1 webkit-bug-importer 2022-03-01 17:13:12 -0800 <rdar://problem/89651456> 1847268 2 453555 tyler_w 2022-03-01 17:47:57 -0800 Created attachment 453555 Patch 1847272 3 453555 cfleizach 2022-03-01 17:56:56 -0800 Comment on attachment 453555 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453555&action=review > Source/WebCore/rendering/RenderFileUploadControl.cpp:261 > + return String(); return { }; 1847278 4 453559 tyler_w 2022-03-01 18:18:19 -0800 Created attachment 453559 Patch 1847280 5 tyler_w 2022-03-01 18:19:20 -0800 > > Source/WebCore/rendering/RenderFileUploadControl.cpp:261 > > + return String(); > > return { }; Fixed. 1847505 6 ews-feeder 2022-03-02 10:55:13 -0800 Committed r290738 (247984@main): <https://commits.webkit.org/247984@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453559. 453555 2022-03-01 17:47:57 -0800 2022-03-01 18:18:14 -0800 Patch bug-237349-20220301194756.patch text/plain 2091 tyler_w U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwNjIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGVmMTA3YTYwMzBjNjkz ODQzN2RhNTUyY2ViMmMzNTA5NmY4MTdlZC4uOTJmM2MwYmFlOTA3Y2NlNjA4YWQ0ZDdlMmZkOGE0 NTk2OWVjNDE4MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIyLTAzLTAxICBUeWxl ciBXaWxjb2NrICA8dHlsZXJfd0BhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IEhhbmRsZSBudWxs IEZpbGVMaXN0IGluIFJlbmRlckZpbGVVcGxvYWRDb250cm9sOjpmaWxlVGV4dFZhbHVlKCkKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNzM0OQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIHJhcmUgY2ly Y3Vtc3RhbmNlcywgaXQncyBwb3NzaWJsZSBmb3IgdGhlIEZpbGVMaXN0IGFzc29jaWF0ZWQKKyAg ICAgICAgd2l0aCBSZW5kZXJGaWxlVXBsb2FkQ29udHJvbDo6aW5wdXRFbGVtZW50IChIVE1MSW5w dXRFbGVtZW50OjpmaWxlcygpKQorICAgICAgICB0byBiZSBudWxsLiBUaGlzIGNhdXNlcyBhIGNy YXNoIGluIFJlbmRlckZpbGVVcGxvYWRDb250cm9sOjpmaWxlVGV4dFZhbHVlKCkuCisKKyAgICAg ICAgSW4gdGhpcyBwYXRjaCwgd2UgYXZvaWQgdGhpcyBjcmFzaCBieSBoYW5kbGluZyBhIG51bGwg YEZpbGVMaXN0YAorICAgICAgICBhbmQgcmV0dXJuaW5nIGEgbnVsbCBgU3RyaW5nYC4KKworICAg ICAgICAqIHJlbmRlcmluZy9SZW5kZXJGaWxlVXBsb2FkQ29udHJvbC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpSZW5kZXJGaWxlVXBsb2FkQ29udHJvbDo6ZmlsZVRleHRWYWx1ZSBjb25zdCk6Cisg ICAgICAgIEhhbmRsZSBudWxsIGBpbnB1dC5maWxlcygpYCBhbmQgcmV0dXJuIGEgbnVsbCBgU3Ry aW5nYCByYXRoZXIgdGhhbiBgQVNTRVJUYGluZy4KKwogMjAyMi0wMi0yOCAgSmVyIE5vYmxlICA8 amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBbQ29jb2FdIEFkb3B0IC1zdHJlYW1EYXRh UGFyc2VyOmRpZFByb3ZpZGVDb250ZW50S2V5U3BlY2lmaWVyOmZvclRyYWNrSUQ6IGRlbGVnYXRl IGNhbGxiYWNrCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmls ZVVwbG9hZENvbnRyb2wuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZpbGVV cGxvYWRDb250cm9sLmNwcAppbmRleCA4NzUwNjkzYmQyYTY4OGJlOTRlOGE3MDlkN2JkNDZjYjYz NDNkMjI3Li5jOTkxMGRhZTRkOWZlZTNkZjdjZjVlZjUwZTRhMjZjNzNlZTgzOWE3IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmlsZVVwbG9hZENvbnRyb2wuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGaWxlVXBsb2FkQ29udHJvbC5j cHAKQEAgLTI1Nyw3ICsyNTcsOCBAQCBTdHJpbmcgUmVuZGVyRmlsZVVwbG9hZENvbnRyb2w6OmJ1 dHRvblZhbHVlKCkKIFN0cmluZyBSZW5kZXJGaWxlVXBsb2FkQ29udHJvbDo6ZmlsZVRleHRWYWx1 ZSgpIGNvbnN0CiB7CiAgICAgYXV0byYgaW5wdXQgPSBpbnB1dEVsZW1lbnQoKTsKLSAgICBBU1NF UlQoaW5wdXRFbGVtZW50KCkuZmlsZXMoKSk7CisgICAgaWYgKCFpbnB1dC5maWxlcygpKQorICAg ICAgICByZXR1cm4gU3RyaW5nKCk7CiAgICAgaWYgKGlucHV0LmZpbGVzKCktPmxlbmd0aCgpICYm ICFpbnB1dC5kaXNwbGF5U3RyaW5nKCkuaXNFbXB0eSgpKQogICAgICAgICByZXR1cm4gU3RyaW5n VHJ1bmNhdG9yOjpyaWdodFRydW5jYXRlKGlucHV0LmRpc3BsYXlTdHJpbmcoKSwgbWF4RmlsZW5h bWVXaWR0aCgpLCBzdHlsZSgpLmZvbnRDYXNjYWRlKCkpOwogICAgIHJldHVybiB0aGVtZSgpLmZp bGVMaXN0TmFtZUZvcldpZHRoKGlucHV0LmZpbGVzKCksIHN0eWxlKCkuZm9udENhc2NhZGUoKSwg bWF4RmlsZW5hbWVXaWR0aCgpLCBpbnB1dC5tdWx0aXBsZSgpKTsK 453559 2022-03-01 18:18:19 -0800 2022-03-02 10:55:17 -0800 Patch bug-237349-20220301201818.patch text/plain 2086 tyler_w U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwNjIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGVmMTA3YTYwMzBjNjkz ODQzN2RhNTUyY2ViMmMzNTA5NmY4MTdlZC4uOTJmM2MwYmFlOTA3Y2NlNjA4YWQ0ZDdlMmZkOGE0 NTk2OWVjNDE4MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIyLTAzLTAxICBUeWxl ciBXaWxjb2NrICA8dHlsZXJfd0BhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IEhhbmRsZSBudWxs IEZpbGVMaXN0IGluIFJlbmRlckZpbGVVcGxvYWRDb250cm9sOjpmaWxlVGV4dFZhbHVlKCkKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNzM0OQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIHJhcmUgY2ly Y3Vtc3RhbmNlcywgaXQncyBwb3NzaWJsZSBmb3IgdGhlIEZpbGVMaXN0IGFzc29jaWF0ZWQKKyAg ICAgICAgd2l0aCBSZW5kZXJGaWxlVXBsb2FkQ29udHJvbDo6aW5wdXRFbGVtZW50IChIVE1MSW5w dXRFbGVtZW50OjpmaWxlcygpKQorICAgICAgICB0byBiZSBudWxsLiBUaGlzIGNhdXNlcyBhIGNy YXNoIGluIFJlbmRlckZpbGVVcGxvYWRDb250cm9sOjpmaWxlVGV4dFZhbHVlKCkuCisKKyAgICAg ICAgSW4gdGhpcyBwYXRjaCwgd2UgYXZvaWQgdGhpcyBjcmFzaCBieSBoYW5kbGluZyBhIG51bGwg YEZpbGVMaXN0YAorICAgICAgICBhbmQgcmV0dXJuaW5nIGEgbnVsbCBgU3RyaW5nYC4KKworICAg ICAgICAqIHJlbmRlcmluZy9SZW5kZXJGaWxlVXBsb2FkQ29udHJvbC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpSZW5kZXJGaWxlVXBsb2FkQ29udHJvbDo6ZmlsZVRleHRWYWx1ZSBjb25zdCk6Cisg ICAgICAgIEhhbmRsZSBudWxsIGBpbnB1dC5maWxlcygpYCBhbmQgcmV0dXJuIGEgbnVsbCBgU3Ry aW5nYCByYXRoZXIgdGhhbiBgQVNTRVJUYGluZy4KKwogMjAyMi0wMi0yOCAgSmVyIE5vYmxlICA8 amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBbQ29jb2FdIEFkb3B0IC1zdHJlYW1EYXRh UGFyc2VyOmRpZFByb3ZpZGVDb250ZW50S2V5U3BlY2lmaWVyOmZvclRyYWNrSUQ6IGRlbGVnYXRl IGNhbGxiYWNrCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmls ZVVwbG9hZENvbnRyb2wuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZpbGVV cGxvYWRDb250cm9sLmNwcAppbmRleCA4NzUwNjkzYmQyYTY4OGJlOTRlOGE3MDlkN2JkNDZjYjYz NDNkMjI3Li5lZTNiOGJkY2MxOTEzNTVhNTJlMjlhOTI4MzY1YTY0ODE0YTA2Njc2IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmlsZVVwbG9hZENvbnRyb2wuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGaWxlVXBsb2FkQ29udHJvbC5j cHAKQEAgLTI1Nyw3ICsyNTcsOCBAQCBTdHJpbmcgUmVuZGVyRmlsZVVwbG9hZENvbnRyb2w6OmJ1 dHRvblZhbHVlKCkKIFN0cmluZyBSZW5kZXJGaWxlVXBsb2FkQ29udHJvbDo6ZmlsZVRleHRWYWx1 ZSgpIGNvbnN0CiB7CiAgICAgYXV0byYgaW5wdXQgPSBpbnB1dEVsZW1lbnQoKTsKLSAgICBBU1NF UlQoaW5wdXRFbGVtZW50KCkuZmlsZXMoKSk7CisgICAgaWYgKCFpbnB1dC5maWxlcygpKQorICAg ICAgICByZXR1cm4geyB9OwogICAgIGlmIChpbnB1dC5maWxlcygpLT5sZW5ndGgoKSAmJiAhaW5w dXQuZGlzcGxheVN0cmluZygpLmlzRW1wdHkoKSkKICAgICAgICAgcmV0dXJuIFN0cmluZ1RydW5j YXRvcjo6cmlnaHRUcnVuY2F0ZShpbnB1dC5kaXNwbGF5U3RyaW5nKCksIG1heEZpbGVuYW1lV2lk dGgoKSwgc3R5bGUoKS5mb250Q2FzY2FkZSgpKTsKICAgICByZXR1cm4gdGhlbWUoKS5maWxlTGlz dE5hbWVGb3JXaWR0aChpbnB1dC5maWxlcygpLCBzdHlsZSgpLmZvbnRDYXNjYWRlKCksIG1heEZp bGVuYW1lV2lkdGgoKSwgaW5wdXQubXVsdGlwbGUoKSk7Cg==