237341 2022-03-01 13:24:07 -0800 [libpas] Add missing PlayStation implementation. 2022-03-02 08:12:05 -0800 1 1 1 Unclassified WebKit bmalloc WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 basuke basuke basuke darin don.olmstead fpizlo ggaren ross.kirsling webkit-bug-importer ysuzuki oldest_to_newest 1847160 0 basuke 2022-03-01 13:24:07 -0800 Add pas_get_current_monotonic_time_nanoseconds 1847163 1 453535 basuke 2022-03-01 13:28:42 -0800 Created attachment 453535 PATCH 1847166 2 453535 ysuzuki 2022-03-01 13:34:00 -0800 Comment on attachment 453535 PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=453535&action=review > Source/bmalloc/libpas/src/libpas/pas_monotonic_time.c:88 > + clock_gettime_np(CLOCK_MONOTONIC, &ts); Is it possible to use CLOCK_MONOTONIC_FAST in this playstation platform? (FreeBSD has this one). This function needs to be super fast, so full CLOCK_MONOTONIC is not ideal if the platform has an alternative. 1847183 3 basuke 2022-03-01 13:53:10 -0800 (In reply to Yusuke Suzuki from comment #2) > Comment on attachment 453535 [details] > PATCH > > View in context: > https://bugs.webkit.org/attachment.cgi?id=453535&action=review > > > Source/bmalloc/libpas/src/libpas/pas_monotonic_time.c:88 > > + clock_gettime_np(CLOCK_MONOTONIC, &ts); > > Is it possible to use CLOCK_MONOTONIC_FAST in this playstation platform? > (FreeBSD has this one). > This function needs to be super fast, so full CLOCK_MONOTONIC is not ideal > if the platform has an alternative. Sure. Sorry, I've forgotten your advice. 1847184 4 453539 basuke 2022-03-01 13:57:14 -0800 Created attachment 453539 PATCH 1847186 5 453539 darin 2022-03-01 14:01:32 -0800 Comment on attachment 453539 PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=453539&action=review > Source/bmalloc/libpas/src/libpas/pas_monotonic_time.c:89 > + return ts.tv_sec * 1.0e9 + ts.tv_nsec; Do you really want to do floating point double precision multiplication here, and then convert back to integer? Maybe uint64_t multiplication would be better? 1847189 6 basuke 2022-03-01 14:08:10 -0800 (In reply to Darin Adler from comment #5) > Comment on attachment 453539 [details] > PATCH > > View in context: > https://bugs.webkit.org/attachment.cgi?id=453539&action=review > > > Source/bmalloc/libpas/src/libpas/pas_monotonic_time.c:89 > > + return ts.tv_sec * 1.0e9 + ts.tv_nsec; > > Do you really want to do floating point double precision multiplication > here, and then convert back to integer? Maybe uint64_t multiplication would > be better? Yusuke, what do you think? I think Darin's point is reasonable, but any reason to use float? I've followed Linux implementation. 1847190 7 basuke 2022-03-01 14:09:06 -0800 We need to add special rule to check-webkit-style for libpas C files... https://ews-build.webkit.org/#/builders/6/builds/70223 1847191 8 453539 ysuzuki 2022-03-01 14:11:49 -0800 Comment on attachment 453539 PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=453539&action=review >>> Source/bmalloc/libpas/src/libpas/pas_monotonic_time.c:89 >>> + return ts.tv_sec * 1.0e9 + ts.tv_nsec; >> >> Do you really want to do floating point double precision multiplication here, and then convert back to integer? Maybe uint64_t multiplication would be better? > > Yusuke, what do you think? I think Darin's point is reasonable, but any reason to use float? I've followed Linux implementation. I think either is fine. 1847193 9 basuke 2022-03-01 14:23:12 -0800 https://godbolt.org/z/dq34fn6xz Quick code comparison seems compact and looks faster. I'm building this and comparing with JetStream2 result. 1847281 10 basuke 2022-03-01 19:06:00 -0800 original: Total Score: 28.991 integer version: Total Score: 29.347 So the later is a bit faster. I'll go with this for PlayStation port. Thanks! 1847294 11 453568 basuke 2022-03-01 21:04:11 -0800 Created attachment 453568 PATCH Thanks, Yusuke and Darin. 1847299 12 ews-feeder 2022-03-01 22:06:48 -0800 Committed r290719 (247966@main): <https://commits.webkit.org/247966@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453568. 1847300 13 webkit-bug-importer 2022-03-01 22:07:17 -0800 <rdar://problem/89665276> 1847400 14 453568 darin 2022-03-02 08:12:05 -0800 Comment on attachment 453568 PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=453568&action=review > Source/bmalloc/libpas/src/libpas/pas_monotonic_time.c:89 > + return ts.tv_sec * 1000u * 1000u * 1000u + ts.tv_nsec; This looks wrong given C type promotion rules. The multiplication will not be done as uint64_t, since the things we are multiplying are unsigned (32 bit). So it may be truncated at 32 bits unless tv_sec already a has 64-bit type, then addition also done as 32-bit and only then put into 64-bit. Need to convert one of the integers being multiplied to uint64_t before multiplying. I suggest putting tv_sec into a uint64_t local. 453535 2022-03-01 13:28:42 -0800 2022-03-01 13:57:14 -0800 PATCH patch.diff text/plain 1269 basuke ZGlmZiAtLWdpdCBhL1NvdXJjZS9ibWFsbG9jL0NoYW5nZUxvZyBiL1NvdXJjZS9ibWFsbG9jL0No YW5nZUxvZwppbmRleCAyZTNhN2Q0NTExYjkuLmY2MTljZGUyMGRlZCAxMDA2NDQKLS0tIGEvU291 cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9ibWFsbG9jL0NoYW5nZUxvZwpAQCAt MSwzICsxLDEzIEBACisyMDIyLTAzLTAxICBCYXN1a2UgU3V6dWtpICA8YmFzdWtlLnN1enVraUBz b255LmNvbT4KKworICAgICAgICBbbGlicGFzXSBBZGQgbWlzc2luZyBQbGF5U3RhdGlvbiBpbXBs ZW1lbnRhdGlvbi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIzNzM0MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogbGlicGFzL3NyYy9saWJwYXMvcGFzX21vbm90b25pY190aW1lLmM6CisgICAgICAgIChw YXNfZ2V0X2N1cnJlbnRfbW9ub3RvbmljX3RpbWVfbmFub3NlY29uZHMpOgorCiAyMDIyLTAyLTI1 ICBCYXN1a2UgU3V6dWtpICA8YmFzdWtlLnN1enVraUBzb255LmNvbT4KIAogICAgICAgICBbbGli cGFzXSBTdXBwcmVzcyBjYXN0LWFsaWduIHdhcm5pbmdzCmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1h bGxvYy9saWJwYXMvc3JjL2xpYnBhcy9wYXNfbW9ub3RvbmljX3RpbWUuYyBiL1NvdXJjZS9ibWFs bG9jL2xpYnBhcy9zcmMvbGlicGFzL3Bhc19tb25vdG9uaWNfdGltZS5jCmluZGV4IDYzOTZjMGI1 NmJlYi4uYTViNTI5MzIxMzAyIDEwMDY0NAotLS0gYS9Tb3VyY2UvYm1hbGxvYy9saWJwYXMvc3Jj L2xpYnBhcy9wYXNfbW9ub3RvbmljX3RpbWUuYworKysgYi9Tb3VyY2UvYm1hbGxvYy9saWJwYXMv c3JjL2xpYnBhcy9wYXNfbW9ub3RvbmljX3RpbWUuYwpAQCAtODAsNiArODAsMTUgQEAgdWludDY0 X3QgcGFzX2dldF9jdXJyZW50X21vbm90b25pY190aW1lX25hbm9zZWNvbmRzKHZvaWQpCiAgICAg cmV0dXJuIHRzLnR2X3NlYyAqIDEuMGU5ICsgdHMudHZfbnNlYzsKIH0KIAorI2VsaWYgUEFTX1BM QVRGT1JNKFBMQVlTVEFUSU9OKQorCit1aW50NjRfdCBwYXNfZ2V0X2N1cnJlbnRfbW9ub3Rvbmlj X3RpbWVfbmFub3NlY29uZHModm9pZCkKK3sKKyAgICBzdHJ1Y3QgdGltZXNwZWMgdHM7CisgICAg Y2xvY2tfZ2V0dGltZV9ucChDTE9DS19NT05PVE9OSUMsICZ0cyk7CisgICAgcmV0dXJuIHRzLnR2 X3NlYyAqIDEuMGU5ICsgdHMudHZfbnNlYzsKK30KKwogI2VuZGlmCiAKICNlbmRpZiAvKiBMSUJQ QVNfRU5BQkxFRCAqLw0K 453539 2022-03-01 13:57:14 -0800 2022-03-01 21:04:11 -0800 PATCH patch.diff text/plain 1274 basuke ZGlmZiAtLWdpdCBhL1NvdXJjZS9ibWFsbG9jL0NoYW5nZUxvZyBiL1NvdXJjZS9ibWFsbG9jL0No YW5nZUxvZwppbmRleCAyZTNhN2Q0NTExYjkuLmY2MTljZGUyMGRlZCAxMDA2NDQKLS0tIGEvU291 cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9ibWFsbG9jL0NoYW5nZUxvZwpAQCAt MSwzICsxLDEzIEBACisyMDIyLTAzLTAxICBCYXN1a2UgU3V6dWtpICA8YmFzdWtlLnN1enVraUBz b255LmNvbT4KKworICAgICAgICBbbGlicGFzXSBBZGQgbWlzc2luZyBQbGF5U3RhdGlvbiBpbXBs ZW1lbnRhdGlvbi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIzNzM0MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogbGlicGFzL3NyYy9saWJwYXMvcGFzX21vbm90b25pY190aW1lLmM6CisgICAgICAgIChw YXNfZ2V0X2N1cnJlbnRfbW9ub3RvbmljX3RpbWVfbmFub3NlY29uZHMpOgorCiAyMDIyLTAyLTI1 ICBCYXN1a2UgU3V6dWtpICA8YmFzdWtlLnN1enVraUBzb255LmNvbT4KIAogICAgICAgICBbbGli cGFzXSBTdXBwcmVzcyBjYXN0LWFsaWduIHdhcm5pbmdzCmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1h bGxvYy9saWJwYXMvc3JjL2xpYnBhcy9wYXNfbW9ub3RvbmljX3RpbWUuYyBiL1NvdXJjZS9ibWFs bG9jL2xpYnBhcy9zcmMvbGlicGFzL3Bhc19tb25vdG9uaWNfdGltZS5jCmluZGV4IDYzOTZjMGI1 NmJlYi4uYzFiZWU3MWEyNDk0IDEwMDY0NAotLS0gYS9Tb3VyY2UvYm1hbGxvYy9saWJwYXMvc3Jj L2xpYnBhcy9wYXNfbW9ub3RvbmljX3RpbWUuYworKysgYi9Tb3VyY2UvYm1hbGxvYy9saWJwYXMv c3JjL2xpYnBhcy9wYXNfbW9ub3RvbmljX3RpbWUuYwpAQCAtODAsNiArODAsMTUgQEAgdWludDY0 X3QgcGFzX2dldF9jdXJyZW50X21vbm90b25pY190aW1lX25hbm9zZWNvbmRzKHZvaWQpCiAgICAg cmV0dXJuIHRzLnR2X3NlYyAqIDEuMGU5ICsgdHMudHZfbnNlYzsKIH0KIAorI2VsaWYgUEFTX1BM QVRGT1JNKFBMQVlTVEFUSU9OKQorCit1aW50NjRfdCBwYXNfZ2V0X2N1cnJlbnRfbW9ub3Rvbmlj X3RpbWVfbmFub3NlY29uZHModm9pZCkKK3sKKyAgICBzdHJ1Y3QgdGltZXNwZWMgdHM7CisgICAg Y2xvY2tfZ2V0dGltZV9ucChDTE9DS19NT05PVE9OSUNfRkFTVCwgJnRzKTsKKyAgICByZXR1cm4g dHMudHZfc2VjICogMS4wZTkgKyB0cy50dl9uc2VjOworfQorCiAjZW5kaWYKIAogI2VuZGlmIC8q IExJQlBBU19FTkFCTEVEICovDQo= 453568 2022-03-01 21:04:11 -0800 2022-03-01 22:06:50 -0800 PATCH patch.diff text/plain 1289 basuke ZGlmZiAtLWdpdCBhL1NvdXJjZS9ibWFsbG9jL0NoYW5nZUxvZyBiL1NvdXJjZS9ibWFsbG9jL0No YW5nZUxvZwppbmRleCAyZTNhN2Q0NTExYjkuLmMzOTMyZmU3MmIzYyAxMDA2NDQKLS0tIGEvU291 cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9ibWFsbG9jL0NoYW5nZUxvZwpAQCAt MSwzICsxLDEzIEBACisyMDIyLTAzLTAxICBCYXN1a2UgU3V6dWtpICA8YmFzdWtlLnN1enVraUBz b255LmNvbT4KKworICAgICAgICBbbGlicGFzXSBBZGQgbWlzc2luZyBQbGF5U3RhdGlvbiBpbXBs ZW1lbnRhdGlvbi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIzNzM0MQorCisgICAgICAgIFJldmlld2VkIGJ5IFl1c3VrZSBTdXp1a2kuCisKKyAgICAg ICAgKiBsaWJwYXMvc3JjL2xpYnBhcy9wYXNfbW9ub3RvbmljX3RpbWUuYzoKKyAgICAgICAgKHBh c19nZXRfY3VycmVudF9tb25vdG9uaWNfdGltZV9uYW5vc2Vjb25kcyk6CisKIDIwMjItMDItMjUg IEJhc3VrZSBTdXp1a2kgIDxiYXN1a2Uuc3V6dWtpQHNvbnkuY29tPgogCiAgICAgICAgIFtsaWJw YXNdIFN1cHByZXNzIGNhc3QtYWxpZ24gd2FybmluZ3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9ibWFs bG9jL2xpYnBhcy9zcmMvbGlicGFzL3Bhc19tb25vdG9uaWNfdGltZS5jIGIvU291cmNlL2JtYWxs b2MvbGlicGFzL3NyYy9saWJwYXMvcGFzX21vbm90b25pY190aW1lLmMKaW5kZXggNjM5NmMwYjU2 YmViLi4yYWRjMDA2NzZkMWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9ibWFsbG9jL2xpYnBhcy9zcmMv bGlicGFzL3Bhc19tb25vdG9uaWNfdGltZS5jCisrKyBiL1NvdXJjZS9ibWFsbG9jL2xpYnBhcy9z cmMvbGlicGFzL3Bhc19tb25vdG9uaWNfdGltZS5jCkBAIC04MCw2ICs4MCwxNSBAQCB1aW50NjRf dCBwYXNfZ2V0X2N1cnJlbnRfbW9ub3RvbmljX3RpbWVfbmFub3NlY29uZHModm9pZCkKICAgICBy ZXR1cm4gdHMudHZfc2VjICogMS4wZTkgKyB0cy50dl9uc2VjOwogfQogCisjZWxpZiBQQVNfUExB VEZPUk0oUExBWVNUQVRJT04pCisKK3VpbnQ2NF90IHBhc19nZXRfY3VycmVudF9tb25vdG9uaWNf dGltZV9uYW5vc2Vjb25kcyh2b2lkKQoreworICAgIHN0cnVjdCB0aW1lc3BlYyB0czsKKyAgICBj bG9ja19nZXR0aW1lX25wKENMT0NLX01PTk9UT05JQ19GQVNULCAmdHMpOworICAgIHJldHVybiB0 cy50dl9zZWMgKiAxMDAwdSAqIDEwMDB1ICogMTAwMHUgKyB0cy50dl9uc2VjOworfQorCiAjZW5k aWYKIAogI2VuZGlmIC8qIExJQlBBU19FTkFCTEVEICovDQo=