23733 2009-02-04 09:52:58 -0800 Assertion fails in SecurityOrigin.cpp 2009-02-05 06:34:40 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED P2 Normal --- 1 yael webkit-unassigned oldest_to_newest 108284 0 yael 2009-02-04 09:52:58 -0800 Assertion fails when creating a SecurityOrigin from DatabaseIdentifier. That is because a DatabaseIdentifier includes an origin without a path. The fix is to use a different constructor to KRUL, one that does not asert. 108285 1 27317 yael 2009-02-04 09:54:32 -0800 Created attachment 27317 Use the KURL constructor that takes 2 parameters instead of one. 108294 2 27317 ap 2009-02-04 10:14:15 -0800 Comment on attachment 27317 Use the KURL constructor that takes 2 parameters instead of one. r=me It's always better to have a bug URL in ChangeLog. 108295 3 yael 2009-02-04 10:27:38 -0800 Thank you for quick review. I will make sure to add the bug URL in the future. Now I need help in committing this :-) 108430 4 hausmann 2009-02-05 06:34:40 -0800 Landed in r40669 27317 2009-02-04 09:54:32 -0800 2009-02-04 10:14:15 -0800 Use the KURL constructor that takes 2 parameters instead of one. securityorigin.patch text/plain 1207 yael SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MDYxMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMDktMDItMDQgIFlhZWwgQWhhcm9uICA8eWFlbC5haGFyb25Abm9r aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFVzZSBhIDIgYXJndW1lbnRzIGNvbnN0cnVjdG9yIGZvciBLVVJMIHRvIGF2b2lkIEFTU0VSVCBm YWlsdXJlLgorCisgICAgICAgICogcGFnZS9TZWN1cml0eU9yaWdpbi5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpTZWN1cml0eU9yaWdpbjo6Y3JlYXRlRnJvbURhdGFiYXNlSWRlbnRpZmllcik6CisK IDIwMDktMDItMDQgIFNpbW9uIEhhdXNtYW5uICA8c2ltb24uaGF1c21hbm5Abm9raWEuY29tPgog CiAgICAgICAgIFVucmV2aWV3ZWQgUXQgYnVpbGQgZml4LgpJbmRleDogV2ViQ29yZS9wYWdlL1Nl Y3VyaXR5T3JpZ2luLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvU2VjdXJpdHlPcmln aW4uY3BwCShyZXZpc2lvbiA0MDU2MykKKysrIFdlYkNvcmUvcGFnZS9TZWN1cml0eU9yaWdpbi5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTI2OSw3ICsyNjksNyBAQAogICAgIC8vIFNwbGl0IG91dCB0 aGUgMyBzZWN0aW9ucyBvZiBkYXRhCiAgICAgU3RyaW5nIHByb3RvY29sID0gZGF0YWJhc2VJZGVu dGlmaWVyLnN1YnN0cmluZygwLCBzZXBhcmF0b3IxKTsKICAgICBTdHJpbmcgaG9zdCA9IGRhdGFi YXNlSWRlbnRpZmllci5zdWJzdHJpbmcoc2VwYXJhdG9yMSArIDEsIHNlcGFyYXRvcjIgLSBzZXBh cmF0b3IxIC0gMSk7Ci0gICAgcmV0dXJuIGNyZWF0ZShLVVJMKHByb3RvY29sICsgIjovLyIgKyBo b3N0ICsgIjoiICsgU3RyaW5nOjpudW1iZXIocG9ydCkpKTsKKyAgICByZXR1cm4gY3JlYXRlKEtV UkwoS1VSTCgpLCBwcm90b2NvbCArICI6Ly8iICsgaG9zdCArICI6IiArIFN0cmluZzo6bnVtYmVy KHBvcnQpKSk7CiB9CiAKIFN0cmluZyBTZWN1cml0eU9yaWdpbjo6ZGF0YWJhc2VJZGVudGlmaWVy KCkgY29uc3QgCg==