23728 2009-02-04 04:38:19 -0800 [QT] clearRect fill's a given rect with white 2009-02-06 09:39:06 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 krit webkit-unassigned hausmann oldest_to_newest 108258 0 krit 2009-02-04 04:38:19 -0800 clearRect doesn't erase a given rect, it just fills it with white. clearRect uses p->eraseRect to clear a given rect. eraseRect is the same as p->fillRect(rect, p->background()). We never set the background, because we're using transparent background mode, the default. And the documentation saith that setBackground() has no effect in transparent background mode. But adding: m_context.get()->platformContext()->setBackground(QColor(Qt::transparent)); to ImageBuffer::ImageBuffer(const IntSize& size, bool grayScale, bool& success) solves the problem. (I would add set the background somewhere in the ImageBuffer. We may need to erase the context somewehere else than in context->clearRect().) 108259 1 27312 krit 2009-02-04 05:16:42 -0800 Created attachment 27312 transparent background for context see above 108263 2 hausmann 2009-02-04 07:42:04 -0800 Dirk, thanks for tracking this down! I think an alternate and perhaps cleaner solution would be to set the composition mode to QPainter::CompositionMode_Clear. What do you think? 108302 3 krit 2009-02-04 11:13:47 -0800 I tried QPainter::CompositionMode_Clear first, but it doesn't fix the problem. I'm not sure why setBackground() works. It shouldn't http://doc.trolltech.com/4.4/qpainter.html#setBackground . And setting background mode manually to Qt::TransparentMode doens't work either. 108436 4 hausmann 2009-02-05 07:21:56 -0800 (In reply to comment #3) > I tried QPainter::CompositionMode_Clear first, but it doesn't fix the problem. > I'm not sure why setBackground() works. It shouldn't > http://doc.trolltech.com/4.4/qpainter.html#setBackground . And setting > background mode manually to Qt::TransparentMode doens't work either. > That's odd. What's the easiest way to test/verify this? I can try to take a look at this with our QPainter guys. 108445 5 27350 krit 2009-02-05 08:50:22 -0800 Created attachment 27350 clearRect test This shows the problem in Canvas. Hope that's what you wanted. 108636 6 hausmann 2009-02-06 08:17:48 -0800 I had a chat with our QPainter guys and discussed your testcase. We can use CompositionMode_Clear, but then we have to call drawRect(rect); instead of eraseRect(). The fastest way however is to simply call fillRect(Qt::transparent). Both worked for me (_Clear with drawRect() and fillRect(Qt::transparent). Can you make a patch with fillRect(Qt::transparent)? I'll review it then :) Thanks again, Dirk! 108641 7 27400 krit 2009-02-06 09:20:38 -0800 Created attachment 27400 Fix for clearRect Fix for clearRect with another composite operator. 108642 8 krit 2009-02-06 09:39:06 -0800 landed in r40721 27312 2009-02-04 05:16:42 -0800 2009-02-06 09:20:38 -0800 transparent background for context qt-imageBuffer-fix.patch text/plain 1284 krit SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MDYwOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMDItMDQgIERpcmsgU2NodWx6ZSAgPGtyaXRAd2Via2l0Lm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBRdCdz IGNsZWFyUmVjdCBmaWxscyB0aGUgZ2l2ZW4gcmVjdCB3aXRoIHdoaXRlLiBUaGlzIGlzIGEgcHJv YmxlbSBmb3IgaGFsZiB0cmFuc3BhcmVudCBpbWFnZXMKKyAgICAgICAgYW5kIGNhbnZhcy4gVGhl IGJhY2tncm91bmQgY29sb3Igb2YgdGhlIGNvbnRleHQgaGFzIHRvIGJlIHNldCB0byB0cmFuc3Bh cmVudCBzZXBhcmF0ZWx5IGhlcmUuCisKKyAgICAgICAgW1FUXSBjbGVhclJlY3QgZmlsbCdzIGEg Z2l2ZW4gcmVjdCB3aXRoIHdoaXRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMzcyOAorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvcXQvSW1h Z2VCdWZmZXJRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbWFnZUJ1ZmZlcjo6SW1hZ2VCdWZm ZXIpOgorCiAyMDA5LTAyLTAzICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgSm9obiBTdWxsaXZhbi4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvcXQvSW1hZ2VCdWZmZXJRdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9xdC9JbWFnZUJ1ZmZlclF0LmNwcAkocmV2aXNpb24gNDA1NTkpCisrKyBX ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0ltYWdlQnVmZmVyUXQuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC01NSw2ICs1NSw3IEBAIEltYWdlQnVmZmVyOjpJbWFnZUJ1ZmZlcihjb25zdCBJbnRT aXplJiAKICAgICAsIG1fc2l6ZShzaXplKQogewogICAgIG1fY29udGV4dC5zZXQobmV3IEdyYXBo aWNzQ29udGV4dChtX2RhdGEubV9wYWludGVyLmdldCgpKSk7CisgICAgbV9jb250ZXh0LmdldCgp LT5wbGF0Zm9ybUNvbnRleHQoKS0+c2V0QmFja2dyb3VuZChRQ29sb3IoUXQ6OnRyYW5zcGFyZW50 KSk7CiAgICAgc3VjY2VzcyA9IHRydWU7CiB9CiAK 27350 2009-02-05 08:50:22 -0800 2009-02-05 08:50:22 -0800 clearRect test clearRect-test.html text/html 436 krit PGh0bWw+DQogIDxoZWFkPg0KICAgIDxzY3JpcHQgdHlwZT0iYXBwbGljYXRpb24veC1qYXZhc2Ny aXB0Ij4NCmZ1bmN0aW9uIGRyYXcoKSB7CiAgICB2YXIgY3R4ID0gZG9jdW1lbnQuZ2V0RWxlbWVu dEJ5SWQoJ2NhbnZhcycpLmdldENvbnRleHQoJzJkJyk7CiAgICBjdHgubW92ZVRvKDAsMCk7CiAg ICBjdHgubGluZVRvKDEwMCwxMDApOwogICAgY3R4LnN0cm9rZSgpOwogICAgY3R4LmNsZWFyUmVj dCgyMCwyMCw2MCw2MCk7Cn0NCiAgICA8L3NjcmlwdD4NCiAgPC9oZWFkPg0KICA8Ym9keSBvbmxv YWQ9ImRyYXcoKTsiIHN0eWxlPSJiYWNrZ3JvdW5kLWNvbG9yOiByZWQ7Ij4NCiAgICA8ZGl2Pg0K ICAgICAgPGNhbnZhcyBpZD0iY2FudmFzIiB3aWR0aD0iMTAwIiBoZWlnaHQ9IjEwMCI+PC9jYW52 YXM+DQogICAgPC9kaXY+DQogIDwvYm9keT4NCjwvaHRtbD4NCg== 27400 2009-02-06 09:20:38 -0800 2009-02-06 09:27:17 -0800 Fix for clearRect qt-clearRect-fix.patch text/plain 1498 krit SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MDcxOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMDItMDYgIERpcmsgU2NodWx6ZSAgPGtyaXRAd2Via2l0Lm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2Ug Y29tcG9zaXRlIG9wZXJhdG9yIENvbXBvc2l0ZUNsZWFyIHRvIGNsZWFyIHRoZSByZWN0IGFuZCBn ZXQgYSB0cmFuc3BhcmVudCBDb250ZXh0LgorCisgICAgICAgIFtRVF0gY2xlYXJSZWN0IGZpbGwn cyBhIGdpdmVuIHJlY3Qgd2l0aCB3aGl0ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjM3MjgKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3F0 L0dyYXBoaWNzQ29udGV4dFF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4 dDo6Y2xlYXJSZWN0KToKKwogMjAwOS0wMi0wNiAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2Vy QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXZlIEh5YXR0CkluZGV4OiBXZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4dFF0LmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4dFF0LmNwcAko cmV2aXNpb24gNDA1NTgpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNz Q29udGV4dFF0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzk2LDggKzc5Niw4IEBAIHZvaWQgR3Jh cGhpY3NDb250ZXh0OjpjbGVhclJlY3QoY29uc3QgRmwKICAgICBRUGFpbnRlciAqcCA9IG1fZGF0 YS0+cCgpOwogICAgIFFQYWludGVyOjpDb21wb3NpdGlvbk1vZGUgY3VycmVudENvbXBvc2l0aW9u TW9kZSA9IHAtPmNvbXBvc2l0aW9uTW9kZSgpOwogICAgIGlmIChwLT5wYWludEVuZ2luZSgpLT5o YXNGZWF0dXJlKFFQYWludEVuZ2luZTo6UG9ydGVyRHVmZikpCi0gICAgICAgIHAtPnNldENvbXBv c2l0aW9uTW9kZShRUGFpbnRlcjo6Q29tcG9zaXRpb25Nb2RlX1NvdXJjZSk7Ci0gICAgcC0+ZXJh c2VSZWN0KHJlY3QpOworICAgICAgICBwLT5zZXRDb21wb3NpdGlvbk1vZGUoUVBhaW50ZXI6OkNv bXBvc2l0aW9uTW9kZV9DbGVhcik7CisgICAgcC0+ZmlsbFJlY3QocmVjdCwgUXQ6OnRyYW5zcGFy ZW50KTsKICAgICBpZiAocC0+cGFpbnRFbmdpbmUoKS0+aGFzRmVhdHVyZShRUGFpbnRFbmdpbmU6 OlBvcnRlckR1ZmYpKQogICAgICAgICBwLT5zZXRDb21wb3NpdGlvbk1vZGUoY3VycmVudENvbXBv c2l0aW9uTW9kZSk7CiB9Cg==