237278 2022-02-28 10:16:54 -0800 Remove release assert when UI process is blocking IOSurface IOKit access 2022-03-01 14:07:56 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham darin ggaren simon.fraser slewis webkit-bug-importer oldest_to_newest 1846682 0 pvollan 2022-02-28 10:16:54 -0800 Remove release assert in IOSurface::bytesPerRowAlignment() when UI process is blocking IOSurface IOKit access. 1846686 1 453405 pvollan 2022-02-28 10:19:18 -0800 Created attachment 453405 Patch 1846714 2 453405 simon.fraser 2022-02-28 11:21:28 -0800 Comment on attachment 453405 Patch I'm not sure why we'd special-case this one, and not the other places where we make IOKit calls which need to be removed before we can enable blocking? 1846730 3 pvollan 2022-02-28 12:53:18 -0800 (In reply to Simon Fraser (smfr) from comment #2) > Comment on attachment 453405 [details] > Patch > > I'm not sure why we'd special-case this one, and not the other places where > we make IOKit calls which need to be removed before we can enable blocking? This IOKit call only takes place in the UI process. We're brokering the value to the WebContent process. Thanks for reviewing! 1846778 4 453405 darin 2022-02-28 14:33:10 -0800 Comment on attachment 453405 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453405&action=review > Source/WebCore/platform/graphics/cocoa/IOSurface.mm:299 > + // 64 bytes is currently the alignment on all platforms. > + alignment = 64; Why not just return a constant? We don’t need to call IOSurface just to feel good. 1846783 5 pvollan 2022-02-28 14:41:34 -0800 (In reply to Darin Adler from comment #4) > Comment on attachment 453405 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=453405&action=review > > > Source/WebCore/platform/graphics/cocoa/IOSurface.mm:299 > > + // 64 bytes is currently the alignment on all platforms. > > + alignment = 64; > > Why not just return a constant? We don’t need to call IOSurface just to feel > good. That is a good point. I kept the IOSurface call in case the constant should change at some point. Thanks for reviewing! 1846812 6 ews-feeder 2022-02-28 15:27:59 -0800 Committed r290618 (247891@main): <https://commits.webkit.org/247891@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453405. 1846813 7 webkit-bug-importer 2022-02-28 15:29:15 -0800 <rdar://problem/89585043> 1846814 8 453405 ggaren 2022-02-28 15:31:27 -0800 Comment on attachment 453405 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453405&action=review > Source/WebCore/platform/graphics/cocoa/IOSurface.mm:297 > + RELEASE_LOG_FAULT(Layers, "Sandbox does not allow IOSurface IOKit access."); RELEASE_LOG_FAULT produces a CrashTracer report. Does this code path execute frequently? If so, it will become our top CrashTracer report (even if the user does not experience a process termination). Do we have other options for gathering whatever information we're trying to gather here? 1847021 9 pvollan 2022-03-01 07:41:26 -0800 (In reply to Geoffrey Garen from comment #8) > Comment on attachment 453405 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=453405&action=review > > > Source/WebCore/platform/graphics/cocoa/IOSurface.mm:297 > > + RELEASE_LOG_FAULT(Layers, "Sandbox does not allow IOSurface IOKit access."); > > RELEASE_LOG_FAULT produces a CrashTracer report. Does this code path execute > frequently? If so, it will become our top CrashTracer report (even if the > user does not experience a process termination). Do we have other options > for gathering whatever information we're trying to gather here? That is a very good point. The code path is expected to execute very infrequently, although I still think it makes sense to avoid possible crash reports. I will change this to log an error instead. Thanks for reviewing! 1847053 10 pvollan 2022-03-01 09:23:27 -0800 Reopening to attach new patch. 1847054 11 453503 pvollan 2022-03-01 09:23:28 -0800 Created attachment 453503 Patch 1847188 12 ews-feeder 2022-03-01 14:07:51 -0800 Committed r290675 (247946@main): <https://commits.webkit.org/247946@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453503. 453405 2022-02-28 10:19:18 -0800 2022-02-28 18:00:30 -0800 Patch bug-237278-20220228101918.patch text/plain 1778 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI5MDYwNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDIyLTAyLTI4ICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgcmVsZWFzZSBh c3NlcnQgd2hlbiBVSSBwcm9jZXNzIGlzIGJsb2NraW5nIElPU3VyZmFjZSBJT0tpdCBhY2Nlc3MK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNzI3OAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBy ZWxlYXNlIGFzc2VydCBpbiBJT1N1cmZhY2U6OmJ5dGVzUGVyUm93QWxpZ25tZW50KCkgd2hlbiBV SSBwcm9jZXNzIGlzIGJsb2NraW5nIElPU3VyZmFjZSBJT0tpdCBhY2Nlc3MuCisgICAgICAgIElu c3RlYWQsIGxvZyB0aGlzIGV2ZW50LCBhbmQgcmV0dXJuIGFuIGFwcHJvcHJpYXRlIHZhbHVlLgor CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvSU9TdXJmYWNlLm1tOgorICAgICAg ICAoV2ViQ29yZTo6SU9TdXJmYWNlOjpieXRlc1BlclJvd0FsaWdubWVudCk6CisKIDIwMjItMDIt MjggIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2 ZXJ0IHIyOTA1NDgKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvY29h L0lPU3VyZmFjZS5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9jb2NvYS9JT1N1cmZhY2UubW0JKHJldmlzaW9uIDI5MDU5OCkKKysrIFNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL0lPU3VyZmFjZS5tbQkod29ya2luZyBjb3B5KQpA QCAtMjkzLDcgKzI5MywxMSBAQCBzaXplX3QgSU9TdXJmYWNlOjpieXRlc1BlclJvd0FsaWdubWVu dCgpCiAgICAgICAgIC8vIFNlZSBodHRwczovL2RldmVsb3Blci5hcHBsZS5jb20vZG9jdW1lbnRh dGlvbi9pb3N1cmZhY2UvMTQxOTQ1My1pb3N1cmZhY2VnZXRwcm9wZXJ0eWFsaWdubWVudD9sYW5n dWFnZT1vYmpjCiAgICAgICAgIC8vIFRoaXMgbGlrZWx5IG1lYW5zIHRoYXQgdGhlIHNhbmRib3gg aXMgYmxvY2tpbmcgYWNjZXNzIHRvIHRoZSBJT1N1cmZhY2UgSU9LaXQgY2xhc3MsCiAgICAgICAg IC8vIGFuZCB0aGF0IElPU3VyZmFjZTo6Ynl0ZXNQZXJSb3dBbGlnbm1lbnQoKSBoYXMgYmVlbiBj YWxsZWQgYmVmb3JlIElPU3VyZmFjZTo6c2V0Qnl0ZXNQZXJSb3dBbGlnbm1lbnQuCi0gICAgICAg IFJFTEVBU0VfQVNTRVJUKGFsaWdubWVudCA+IDEpOworICAgICAgICBpZiAoYWxpZ25tZW50IDw9 IDEpIHsKKyAgICAgICAgICAgIFJFTEVBU0VfTE9HX0ZBVUxUKExheWVycywgIlNhbmRib3ggZG9l cyBub3QgYWxsb3cgSU9TdXJmYWNlIElPS2l0IGFjY2Vzcy4iKTsKKyAgICAgICAgICAgIC8vIDY0 IGJ5dGVzIGlzIGN1cnJlbnRseSB0aGUgYWxpZ25tZW50IG9uIGFsbCBwbGF0Zm9ybXMuCisgICAg ICAgICAgICBhbGlnbm1lbnQgPSA2NDsKKyAgICAgICAgfQogICAgIH0KICAgICByZXR1cm4gYWxp Z25tZW50OwogfQo= 453503 2022-03-01 09:23:28 -0800 2022-03-01 14:07:54 -0800 Patch bug-237278-20220301092328.patch text/plain 1608 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI5MDY1MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDIyLTAzLTAxICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgcmVsZWFzZSBh c3NlcnQgd2hlbiBVSSBwcm9jZXNzIGlzIGJsb2NraW5nIElPU3VyZmFjZSBJT0tpdCBhY2Nlc3MK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNzI3OAor ICAgICAgICA8cmRhcjovL3Byb2JsZW0vODk1ODUwNDM+CisKKyAgICAgICAgVW5yZXZpZXdlZCwg YWRkcmVzcyByZXZpZXcgY29tbWVudHMuCisKKyAgICAgICAgTG9nIGVycm9yIGluc3RlYWQgb2Yg Y3JlYXRpbmcgQ3Jhc2hUcmFjZXIgcmVwb3J0cy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL2NvY29hL0lPU3VyZmFjZS5tbToKKyAgICAgICAgKFdlYkNvcmU6OklPU3VyZmFjZTo6Ynl0 ZXNQZXJSb3dBbGlnbm1lbnQpOgorCiAyMDIyLTAzLTAxICBDb21taXQgUXVldWUgIDxjb21taXQt cXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByZXZlcnRpbmcgcjI5MDMy NS4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL0lPU3VyZmFj ZS5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2Nv YS9JT1N1cmZhY2UubW0JKHJldmlzaW9uIDI5MDY0OSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2NvY29hL0lPU3VyZmFjZS5tbQkod29ya2luZyBjb3B5KQpAQCAtMjkzLDcg KzI5Myw3IEBAIHNpemVfdCBJT1N1cmZhY2U6OmJ5dGVzUGVyUm93QWxpZ25tZW50KCkKICAgICAg ICAgLy8gVGhpcyBsaWtlbHkgbWVhbnMgdGhhdCB0aGUgc2FuZGJveCBpcyBibG9ja2luZyBhY2Nl c3MgdG8gdGhlIElPU3VyZmFjZSBJT0tpdCBjbGFzcywKICAgICAgICAgLy8gYW5kIHRoYXQgSU9T dXJmYWNlOjpieXRlc1BlclJvd0FsaWdubWVudCgpIGhhcyBiZWVuIGNhbGxlZCBiZWZvcmUgSU9T dXJmYWNlOjpzZXRCeXRlc1BlclJvd0FsaWdubWVudC4KICAgICAgICAgaWYgKGFsaWdubWVudCA8 PSAxKSB7Ci0gICAgICAgICAgICBSRUxFQVNFX0xPR19GQVVMVChMYXllcnMsICJTYW5kYm94IGRv ZXMgbm90IGFsbG93IElPU3VyZmFjZSBJT0tpdCBhY2Nlc3MuIik7CisgICAgICAgICAgICBSRUxF QVNFX0xPR19FUlJPUihMYXllcnMsICJTYW5kYm94IGRvZXMgbm90IGFsbG93IElPU3VyZmFjZSBJ T0tpdCBhY2Nlc3MuIik7CiAgICAgICAgICAgICAvLyA2NCBieXRlcyBpcyBjdXJyZW50bHkgdGhl IGFsaWdubWVudCBvbiBhbGwgcGxhdGZvcm1zLgogICAgICAgICAgICAgYWxpZ25tZW50ID0gNjQ7 CiAgICAgICAgIH0K