237273 2022-02-28 06:20:53 -0800 Implement focus fixup rule 2023-02-09 09:46:54 -0800 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ntim rniwa ahmad.saleem792 emilio rniwa webkit-bug-importer oldest_to_newest 1846620 0 ntim 2022-02-28 06:20:53 -0800 https://html.spec.whatwg.org/multipage/interaction.html#focus-fixup-rule Focus fixup rule: When the designated focused area of the document is removed from that Document in some way (e.g. it stops being a focusable area, it is removed from the DOM, it becomes inert, etc.), designate the Document's viewport to be the new focused area of the document. 1846623 1 ntim 2022-02-28 06:38:28 -0800 Adding this seems to work: ``` if (auto* activeElement = document.activeElement()) { if (!activeElement->isFocusable()) document.setFocusedElement(nullptr); } ``` I put it in the RenderingUpdateStep::FlushAutofocusCandidates block, but that's probably not the right place (not sure which one is?). One thing that's broken is interaction with shadow DOM: shadow-dom/focus/focus-pseudo-on-shadow-host-1.html fails. This is precisely because activeElement->isFocusable() doesn't take in account contents of the shadow DOM, and wrongly clears focus in this case. Though I expect that's not too hard to fix. 1846624 2 ntim 2022-02-28 06:40:04 -0800 imported/w3c/web-platform-tests/inert/dynamic-inert-on-focused-element.tentative.html tests this functionality. I'm actually a bit surprised there aren't more tests (e.g. moving out of a focusable area, disabled attribute, etc.) 1848718 3 webkit-bug-importer 2022-03-07 06:21:13 -0800 <rdar://problem/89902824> 1890952 4 ahmad.saleem792 2022-08-12 11:28:55 -0700 Safari TP 151 is still failing these tests: https://wpt.fyi/results/inert/dynamic-inert-on-focused-element.html?label=master&label=experimental&aligned&view=subtest&q=dynamic-inert-on-focused-element 1909964 5 ntim 2022-11-02 18:51:55 -0700 Pull request: https://github.com/WebKit/WebKit/pull/6069 1932125 6 rniwa 2023-02-08 13:35:55 -0800 Pull request: https://github.com/WebKit/WebKit/pull/9835 1932369 7 ews-feeder 2023-02-09 09:46:51 -0800 Committed 260067@main (71bc5343fd7b): <https://commits.webkit.org/260067@main> Reviewed commits have been landed. Closing PR #9835 and removing active labels.