237252 2022-02-27 08:59:46 -0800 [svg] fill-opacity should be clamped to the [0,1] range 2022-02-27 13:04:16 -0800 1 1 1 Unclassified WebKit SVG WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar, WebExposed, WPTImpact P2 Normal --- 1 graouts graouts changseok darin dino esprehn+autocc ews-watchlist glenn kondapallykalyan pdr sabouhallawa webkit-bug-importer zimmermann oldest_to_newest 1846443 0 graouts 2022-02-27 08:59:46 -0800 [svg] fill-opacity should be clamped to the [0,1] range 1846444 1 453342 graouts 2022-02-27 09:00:17 -0800 Created attachment 453342 Patch 1846477 2 ews-feeder 2022-02-27 12:33:20 -0800 Committed r290568 (247846@main): <https://commits.webkit.org/247846@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453342. 1846478 3 webkit-bug-importer 2022-02-27 12:34:20 -0800 <rdar://problem/89531516> 1846479 4 453342 darin 2022-02-27 12:35:49 -0800 Comment on attachment 453342 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453342&action=review > Source/WebCore/rendering/style/SVGRenderStyle.h:285 > + auto clampedOpacity = clampTo<float>(opacity, 0.f, 1.f); Should have been able to use std::clamp instead of clampTo<float> here. But I suppose either is OK. 453342 2022-02-27 09:00:17 -0800 2022-02-27 13:04:16 -0800 Patch bug-237252-20220227180016.patch text/plain 5033 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwNTU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmU5OWIwMzI3Njk4ZWEz ZjliZTBkZTkxYTk1ZmY2ODIxNmY4YTk3NC4uNDIzMjExMDY1ZTRjZThlMWUxYTg1OWQ1NjkyZjBm YTY2ZDA1ZDM1ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIyLTAyLTI3ICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0B3ZWJraXQub3JnPgorCisgICAgICAgIFtzdmddIGZpbGwtb3Bh Y2l0eSBzaG91bGQgYmUgY2xhbXBlZCB0byB0aGUgWzAsMV0gcmFuZ2UKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNzI1MgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcmVuZGVyaW5nL3N0eWxlL1NWR1Jl bmRlclN0eWxlLmg6CisgICAgICAgIChXZWJDb3JlOjpTVkdSZW5kZXJTdHlsZTo6c2V0RmlsbE9w YWNpdHkpOgorCiAyMDIyLTAyLTI2ICBUaW0gTmd1eWVuICA8bnRpbUBhcHBsZS5jb20+CiAKICAg ICAgICAgUmVtb3ZlIE5vZGU6OmRlcHJlY2F0ZWRJc0luZXJ0CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvU1ZHUmVuZGVyU3R5bGUuaCBiL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9zdHlsZS9TVkdSZW5kZXJTdHlsZS5oCmluZGV4IDdmMTliMGY5ZjI5ZTE1Yzg2 N2Q1NjM4MDg4YTRhMGQyZjJlOGRmMjEuLjE2NDIzMGIyMjgzMTZhNWM3MmU3NWJmM2NmZTAwZDI1 NDAzMTAwMjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9TVkdS ZW5kZXJTdHlsZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9TVkdSZW5k ZXJTdHlsZS5oCkBAIC0yODIsOCArMjgyLDkgQEAgaW5saW5lIHZvaWQgU1ZHUmVuZGVyU3R5bGU6 OnNldFkoY29uc3QgTGVuZ3RoJiBsZW5ndGgpCiAKIGlubGluZSB2b2lkIFNWR1JlbmRlclN0eWxl OjpzZXRGaWxsT3BhY2l0eShmbG9hdCBvcGFjaXR5KQogewotICAgIGlmICghKG1fZmlsbERhdGEt Pm9wYWNpdHkgPT0gb3BhY2l0eSkpCi0gICAgICAgIG1fZmlsbERhdGEuYWNjZXNzKCkub3BhY2l0 eSA9IG9wYWNpdHk7CisgICAgYXV0byBjbGFtcGVkT3BhY2l0eSA9IGNsYW1wVG88ZmxvYXQ+KG9w YWNpdHksIDAuZiwgMS5mKTsKKyAgICBpZiAoIShtX2ZpbGxEYXRhLT5vcGFjaXR5ID09IGNsYW1w ZWRPcGFjaXR5KSkKKyAgICAgICAgbV9maWxsRGF0YS5hY2Nlc3MoKS5vcGFjaXR5ID0gY2xhbXBl ZE9wYWNpdHk7CiB9CiAKIGlubGluZSB2b2lkIFNWR1JlbmRlclN0eWxlOjpzZXRGaWxsUGFpbnQo U1ZHUGFpbnRUeXBlIHR5cGUsIGNvbnN0IENvbG9yJiBjb2xvciwgY29uc3QgU3RyaW5nJiB1cmks IGJvb2wgYXBwbHlUb1JlZ3VsYXJTdHlsZSwgYm9vbCBhcHBseVRvVmlzaXRlZExpbmtTdHlsZSkK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cgYi9MYXlvdXRU ZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCmluZGV4IDE2MjU4MGNlZDJhYjFkYzM4ZWFmYWY3 YWE3OTY1ZGVkZjk5YmU4NWMuLjI0YzYxNDRlNGM5MDdjY2JmMjE2ZWZmNGE1Y2UxYzdkNmRlMGE1 YzggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKKysrIGIv TGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIy LTAyLTI3ICBBbnRvaW5lIFF1aW50ICA8Z3Jhb3V0c0B3ZWJraXQub3JnPgorCisgICAgICAgIFtz dmddIGZpbGwtb3BhY2l0eSBzaG91bGQgYmUgY2xhbXBlZCB0byB0aGUgWzAsMV0gcmFuZ2UKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNzI1MgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd2ViLXBsYXRm b3JtLXRlc3RzL3dlYi1hbmltYXRpb25zL2FuaW1hdGlvbi1tb2RlbC9hbmltYXRpb24tdHlwZXMv YWNjdW11bGF0aW9uLXBlci1wcm9wZXJ0eS0wMDEtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIHdl Yi1wbGF0Zm9ybS10ZXN0cy93ZWItYW5pbWF0aW9ucy9hbmltYXRpb24tbW9kZWwvYW5pbWF0aW9u LXR5cGVzL2FkZGl0aW9uLXBlci1wcm9wZXJ0eS0wMDEtZXhwZWN0ZWQudHh0OgorCiAyMDIyLTAy LTI2ICBUaW0gTmd1eWVuICA8bnRpbUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIE5vZGU6 OmRlcHJlY2F0ZWRJc0luZXJ0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mv d2ViLXBsYXRmb3JtLXRlc3RzL3dlYi1hbmltYXRpb25zL2FuaW1hdGlvbi1tb2RlbC9hbmltYXRp b24tdHlwZXMvYWNjdW11bGF0aW9uLXBlci1wcm9wZXJ0eS0wMDEtZXhwZWN0ZWQudHh0IGIvTGF5 b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy93ZWItYW5pbWF0aW9ucy9h bmltYXRpb24tbW9kZWwvYW5pbWF0aW9uLXR5cGVzL2FjY3VtdWxhdGlvbi1wZXItcHJvcGVydHkt MDAxLWV4cGVjdGVkLnR4dAppbmRleCAxNjM5ZmEzODMxODlkODAwZmVhNGY2OTRiNTFlNWQ1N2Vl OTYyZGQ4Li4xZjA4NDc2ZWJjNGY3N2M2MTk1NTY4Y2VjYTMwZDExNTJkODYwZTFlIDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3dlYi1hbmlt YXRpb25zL2FuaW1hdGlvbi1tb2RlbC9hbmltYXRpb24tdHlwZXMvYWNjdW11bGF0aW9uLXBlci1w cm9wZXJ0eS0wMDEtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93 ZWItcGxhdGZvcm0tdGVzdHMvd2ViLWFuaW1hdGlvbnMvYW5pbWF0aW9uLW1vZGVsL2FuaW1hdGlv bi10eXBlcy9hY2N1bXVsYXRpb24tcGVyLXByb3BlcnR5LTAwMS1leHBlY3RlZC50eHQKQEAgLTE3 MSw3ICsxNzEsNyBAQCBQQVNTIGVtcHR5LWNlbGxzOiAiaGlkZSIgb250byAic2hvdyIKIFBBU1Mg ZW1wdHktY2VsbHM6ICJzaG93IiBvbnRvICJoaWRlIgogUEFTUyBmaWxsLW9wYWNpdHkgKHR5cGU6 IG9wYWNpdHkpIGhhcyB0ZXN0QWNjdW11bGF0aW9uIGZ1bmN0aW9uCiBQQVNTIGZpbGwtb3BhY2l0 eTogWzAsIDFdIG51bWJlcgotRkFJTCBmaWxsLW9wYWNpdHk6IFswLCAxXSBudW1iZXIgKGNsYW1w ZWQpIGFzc2VydF9lcXVhbHM6IFRoZSB2YWx1ZSBzaG91bGQgYmUgMSBhdCAwbXMgZXhwZWN0ZWQg IjEiIGJ1dCBnb3QgIjEuMSIKK1BBU1MgZmlsbC1vcGFjaXR5OiBbMCwgMV0gbnVtYmVyIChjbGFt cGVkKQogUEFTUyBmaWx0ZXIgKHR5cGU6IGZpbHRlckxpc3QpIGhhcyB0ZXN0QWNjdW11bGF0aW9u IGZ1bmN0aW9uCiBGQUlMIGZpbHRlcjogc2FtZSBvcmRlcmVkIGZpbHRlciBmdW5jdGlvbnMgYXNz ZXJ0X2VxdWFsczogVGhlIHZhbHVlIHNob3VsZCBiZSBibHVyKDMwcHgpIGJyaWdodG5lc3MoMCkg YXQgMG1zIGV4cGVjdGVkICJibHVyKDMwcHgpIGJyaWdodG5lc3MoMCkiIGJ1dCBnb3QgImJsdXIo MzBweCkgYnJpZ2h0bmVzcygwLjQpIgogUEFTUyBmaWx0ZXI6IG1pc21hdGNoZWQgb3JkZXJlZCBm aWx0ZXIgZnVuY3Rpb25zCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2Vi LXBsYXRmb3JtLXRlc3RzL3dlYi1hbmltYXRpb25zL2FuaW1hdGlvbi1tb2RlbC9hbmltYXRpb24t dHlwZXMvYWRkaXRpb24tcGVyLXByb3BlcnR5LTAwMS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0 cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3dlYi1hbmltYXRpb25zL2FuaW1hdGlv bi1tb2RlbC9hbmltYXRpb24tdHlwZXMvYWRkaXRpb24tcGVyLXByb3BlcnR5LTAwMS1leHBlY3Rl ZC50eHQKaW5kZXggYzU4ZDg1ZDdiNDI0M2ZiMjAxZjAwNjFmMmNlZTA2OTA0MDc2NzFjOS4uMGM2 NTQxYTkzNTkyMDM0NDFhOTM2YTk2YjA4MDFjNjA1YzZkNTEwZiAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy93ZWItYW5pbWF0aW9ucy9hbmlt YXRpb24tbW9kZWwvYW5pbWF0aW9uLXR5cGVzL2FkZGl0aW9uLXBlci1wcm9wZXJ0eS0wMDEtZXhw ZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVz dHMvd2ViLWFuaW1hdGlvbnMvYW5pbWF0aW9uLW1vZGVsL2FuaW1hdGlvbi10eXBlcy9hZGRpdGlv bi1wZXItcHJvcGVydHktMDAxLWV4cGVjdGVkLnR4dApAQCAtMTcxLDcgKzE3MSw3IEBAIFBBU1Mg ZW1wdHktY2VsbHM6ICJoaWRlIiBvbnRvICJzaG93IgogUEFTUyBlbXB0eS1jZWxsczogInNob3ci IG9udG8gImhpZGUiCiBQQVNTIGZpbGwtb3BhY2l0eSAodHlwZTogb3BhY2l0eSkgaGFzIHRlc3RB ZGRpdGlvbiBmdW5jdGlvbgogUEFTUyBmaWxsLW9wYWNpdHk6IFswLCAxXSBudW1iZXIKLUZBSUwg ZmlsbC1vcGFjaXR5OiBbMCwgMV0gbnVtYmVyIChjbGFtcGVkKSBhc3NlcnRfZXF1YWxzOiBUaGUg dmFsdWUgc2hvdWxkIGJlIDEgYXQgMG1zIGV4cGVjdGVkICIxIiBidXQgZ290ICIxLjEiCitQQVNT IGZpbGwtb3BhY2l0eTogWzAsIDFdIG51bWJlciAoY2xhbXBlZCkKIFBBU1MgZmlsdGVyICh0eXBl OiBmaWx0ZXJMaXN0KSBoYXMgdGVzdEFkZGl0aW9uIGZ1bmN0aW9uCiBGQUlMIGZpbHRlcjogYmx1 ciBvbiBibHVyIGFzc2VydF9lcXVhbHM6IFRoZSB2YWx1ZSBzaG91bGQgYmUgYmx1cigxMHB4KSBi bHVyKDIwcHgpIGF0IDBtcyBleHBlY3RlZCAiYmx1cigxMHB4KSBibHVyKDIwcHgpIiBidXQgZ290 ICJibHVyKDMwcHgpIgogRkFJTCBmaWx0ZXI6IGRpZmZlcmVudCBmaWx0ZXIgZnVuY3Rpb25zIGFz c2VydF9lcXVhbHM6IFRoZSB2YWx1ZSBzaG91bGQgYmUgYmx1cigxMHB4KSBicmlnaHRuZXNzKDAu OCkgYXQgMG1zIGV4cGVjdGVkICJibHVyKDEwcHgpIGJyaWdodG5lc3MoMC44KSIgYnV0IGdvdCAi YnJpZ2h0bmVzcygwLjgpIgo=