237239 2022-02-26 09:48:41 -0800 AX: Remove unnecessary AccessibilityRenderObject::init() override 2022-02-26 16:47:50 -0800 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tyler_w tyler_w aboxhall andresg_22 apinheiro cfleizach dmazzoni ews-watchlist jcraig jdiggs samuel_white webkit-bug-importer oldest_to_newest 1846309 0 tyler_w 2022-02-26 09:48:41 -0800 It just calls AccessibilityNodeObject::init(), so we don't need it as an override. 1846310 1 webkit-bug-importer 2022-02-26 09:48:54 -0800 <rdar://problem/89514519> 1846311 2 453299 tyler_w 2022-02-26 09:50:42 -0800 Created attachment 453299 Patch 1846315 3 453299 cfleizach 2022-02-26 10:02:36 -0800 Comment on attachment 453299 Patch Style error 1846316 4 453300 tyler_w 2022-02-26 10:02:57 -0800 Created attachment 453300 Patch 1846319 5 453302 tyler_w 2022-02-26 10:25:26 -0800 Created attachment 453302 Patch 1846360 6 ews-feeder 2022-02-26 16:47:47 -0800 Committed r290553 (247831@main): <https://commits.webkit.org/247831@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453302. 453299 2022-02-26 09:50:42 -0800 2022-02-26 10:02:54 -0800 Patch bug-237239-20220226115041.patch text/plain 2313 tyler_w U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwMzE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWI1NWJlYTg5MWI5ZGU2 OGZlMjA4MmQ4YTZjNDE4OTIwMDQ1MjU5Yi4uNmUyMDE3NWFiNzY0MDdjNDg0ODBhYjViZmNmY2Jl NDgwNjlhNzM2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIyLTAyLTI2ICBUeWxl ciBXaWxjb2NrICA8dHlsZXJfd0BhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IFJlbW92ZSB1bm5l Y2Vzc2FyeSBBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0Ojppbml0KCkgb3ZlcnJpZGUKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNzIzOQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCQkKKyAgICAgICAgVGhlIGltcGxlbWVu dGF0aW9uIG9mIEFjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3Q6OmluaXQoKSBqdXN0IGNhbGxzCisg ICAgICAgIEFjY2Vzc2liaWxpdHlOb2RlT2JqZWN0Ojppbml0KCksIHNvIHdlIGRvbid0IG5lZWQg aXQgYXMgYW4gb3ZlcnJpZGUuCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxp dHlSZW5kZXJPYmplY3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eVJlbmRl ck9iamVjdDo6aW5pdCk6IERlbGV0ZWQuCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9BY2Nlc3Np YmlsaXR5UmVuZGVyT2JqZWN0Lmg6CisKIDIwMjItMDItMjIgIFRpbSBOZ3V5ZW4gIDxudGltQGFw cGxlLmNvbT4KIAogICAgICAgICBSZS1zdHlsZSBQREYuanMgZm9ybSBmaWVsZHMgdG8gbWF0Y2gg UERGS2l0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2li aWxpdHlSZW5kZXJPYmplY3QuY3BwIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nl c3NpYmlsaXR5UmVuZGVyT2JqZWN0LmNwcAppbmRleCAyN2UzNzhhYjA0OWNjMDQ4NzRhNWE5NzJl MDZlZDlkNWU0ZjVlZDk3Li5lM2MxYzFlNmQ0NTU5NzhmOGZiNDMxZjZhNWJiYmQyYzA5YjdkNDNi IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlS ZW5kZXJPYmplY3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNz aWJpbGl0eVJlbmRlck9iamVjdC5jcHAKQEAgLTEzNCwxMSArMTM0LDYgQEAgQWNjZXNzaWJpbGl0 eVJlbmRlck9iamVjdDo6fkFjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QoKQogICAgIEFTU0VSVChp c0RldGFjaGVkKCkpOwogfQogCi12b2lkIEFjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3Q6OmluaXQo KQotewotICAgIEFjY2Vzc2liaWxpdHlOb2RlT2JqZWN0Ojppbml0KCk7Ci19Ci0KIFJlZjxBY2Nl c3NpYmlsaXR5UmVuZGVyT2JqZWN0PiBBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0OjpjcmVhdGUo UmVuZGVyT2JqZWN0KiByZW5kZXJlcikKIHsKICAgICByZXR1cm4gYWRvcHRSZWYoKm5ldyBBY2Nl c3NpYmlsaXR5UmVuZGVyT2JqZWN0KHJlbmRlcmVyKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuaCBiL1NvdXJjZS9X ZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5oCmluZGV4IGQ4 ZjhhODRmMGM3ZTE3Mzc0MjRjM2U3ODNiZTBiZTIxMjNjMmRlNjYuLmFhZjU3OWQzZmY5ZGQ2ZjU5 NGVjNTEwOThmOWY4ZjA2YjVlYTIwZDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vz c2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5oCkBAIC01NSw4ICs1NSw2 IEBAIGNsYXNzIEFjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QgOiBwdWJsaWMgQWNjZXNzaWJpbGl0 eU5vZGVPYmplY3QsIHB1YmxpYyBDYW5NYWtlCiBwdWJsaWM6CiAgICAgc3RhdGljIFJlZjxBY2Nl c3NpYmlsaXR5UmVuZGVyT2JqZWN0PiBjcmVhdGUoUmVuZGVyT2JqZWN0Kik7CiAgICAgdmlydHVh bCB+QWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdCgpOwotCi0gICAgdm9pZCBpbml0KCkgb3ZlcnJp ZGU7CiAgICAgCiAgICAgYm9vbCBpc0F0dGFjaG1lbnQoKSBjb25zdCBvdmVycmlkZTsKICAgICBi b29sIGlzU2VsZWN0ZWQoKSBjb25zdCBvdmVycmlkZTsK 453300 2022-02-26 10:02:57 -0800 2022-02-26 10:25:23 -0800 Patch bug-237239-20220226120256.patch text/plain 2311 tyler_w U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwMzE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWI1NWJlYTg5MWI5ZGU2 OGZlMjA4MmQ4YTZjNDE4OTIwMDQ1MjU5Yi4uZjgyYzlkMzEyNmI3NDRiYjJhNzNkMjMyMDIyODY2 ZTk3MDMyY2E4MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIyLTAyLTI2ICBUeWxl ciBXaWxjb2NrICA8dHlsZXJfd0BhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IFJlbW92ZSB1bm5l Y2Vzc2FyeSBBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0Ojppbml0KCkgb3ZlcnJpZGUKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNzIzOQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBpbXBsZW1lbnRh dGlvbiBvZiBBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0Ojppbml0KCkganVzdCBjYWxscworICAg ICAgICBBY2Nlc3NpYmlsaXR5Tm9kZU9iamVjdDo6aW5pdCgpLCBzbyB3ZSBkb24ndCBuZWVkIGl0 IGFzIGFuIG92ZXJyaWRlLgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5 UmVuZGVyT2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFjY2Vzc2liaWxpdHlSZW5kZXJP YmplY3Q6OmluaXQpOiBEZWxldGVkLgorICAgICAgICAqIGFjY2Vzc2liaWxpdHkvQWNjZXNzaWJp bGl0eVJlbmRlck9iamVjdC5oOgorCiAyMDIyLTAyLTIyICBUaW0gTmd1eWVuICA8bnRpbUBhcHBs ZS5jb20+CiAKICAgICAgICAgUmUtc3R5bGUgUERGLmpzIGZvcm0gZmllbGRzIHRvIG1hdGNoIFBE RktpdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmls aXR5UmVuZGVyT2JqZWN0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNz aWJpbGl0eVJlbmRlck9iamVjdC5jcHAKaW5kZXggMjdlMzc4YWIwNDljYzA0ODc0YTVhOTcyZTA2 ZWQ5ZDVlNGY1ZWQ5Ny4uZTNjMWMxZTZkNDU1OTc4ZjhmYjQzMWY2YTViYmJkMmMwOWI3ZDQzYiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVu ZGVyT2JqZWN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2li aWxpdHlSZW5kZXJPYmplY3QuY3BwCkBAIC0xMzQsMTEgKzEzNCw2IEBAIEFjY2Vzc2liaWxpdHlS ZW5kZXJPYmplY3Q6On5BY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0KCkKICAgICBBU1NFUlQoaXNE ZXRhY2hlZCgpKTsKIH0KIAotdm9pZCBBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0Ojppbml0KCkK LXsKLSAgICBBY2Nlc3NpYmlsaXR5Tm9kZU9iamVjdDo6aW5pdCgpOwotfQotCiBSZWY8QWNjZXNz aWJpbGl0eVJlbmRlck9iamVjdD4gQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6Y3JlYXRlKFJl bmRlck9iamVjdCogcmVuZGVyZXIpCiB7CiAgICAgcmV0dXJuIGFkb3B0UmVmKCpuZXcgQWNjZXNz aWJpbGl0eVJlbmRlck9iamVjdChyZW5kZXJlcikpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0LmggYi9Tb3VyY2UvV2Vi Q29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuaAppbmRleCBkOGY4 YTg0ZjBjN2UxNzM3NDI0YzNlNzgzYmUwYmUyMTIzYzJkZTY2Li5hYWY1NzlkM2ZmOWRkNmY1OTRl YzUxMDk4ZjlmOGYwNmI1ZWEyMGQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3Np YmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9h Y2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuaApAQCAtNTUsOCArNTUsNiBA QCBjbGFzcyBBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0IDogcHVibGljIEFjY2Vzc2liaWxpdHlO b2RlT2JqZWN0LCBwdWJsaWMgQ2FuTWFrZQogcHVibGljOgogICAgIHN0YXRpYyBSZWY8QWNjZXNz aWJpbGl0eVJlbmRlck9iamVjdD4gY3JlYXRlKFJlbmRlck9iamVjdCopOwogICAgIHZpcnR1YWwg fkFjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QoKTsKLQotICAgIHZvaWQgaW5pdCgpIG92ZXJyaWRl OwogICAgIAogICAgIGJvb2wgaXNBdHRhY2htZW50KCkgY29uc3Qgb3ZlcnJpZGU7CiAgICAgYm9v bCBpc1NlbGVjdGVkKCkgY29uc3Qgb3ZlcnJpZGU7Cg== 453302 2022-02-26 10:25:26 -0800 2022-02-26 16:47:49 -0800 Patch bug-237239-20220226122524.patch text/plain 2311 tyler_w U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwMzE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWI1NWJlYTg5MWI5ZGU2 OGZlMjA4MmQ4YTZjNDE4OTIwMDQ1MjU5Yi4uYTNmNDE3MWM0N2U5ZTRjMzA2NGE3YmMwNTU4NmJk N2RmMzliMTk5NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIyLTAyLTI2ICBUeWxl ciBXaWxjb2NrICA8dHlsZXJfd0BhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IFJlbW92ZSB1bm5l Y2Vzc2FyeSBBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0Ojppbml0KCkgb3ZlcnJpZGUKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNzIzOQorCisgICAg ICAgIFJldmlld2VkIGJ5IENocmlzIEZsZWl6YWNoLgorCisgICAgICAgIFRoZSBpbXBsZW1lbnRh dGlvbiBvZiBBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0Ojppbml0KCkganVzdCBjYWxscworICAg ICAgICBBY2Nlc3NpYmlsaXR5Tm9kZU9iamVjdDo6aW5pdCgpLCBzbyB3ZSBkb24ndCBuZWVkIGl0 IGFzIGFuIG92ZXJyaWRlLgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5 UmVuZGVyT2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFjY2Vzc2liaWxpdHlSZW5kZXJP YmplY3Q6OmluaXQpOiBEZWxldGVkLgorICAgICAgICAqIGFjY2Vzc2liaWxpdHkvQWNjZXNzaWJp bGl0eVJlbmRlck9iamVjdC5oOgorCiAyMDIyLTAyLTIyICBUaW0gTmd1eWVuICA8bnRpbUBhcHBs ZS5jb20+CiAKICAgICAgICAgUmUtc3R5bGUgUERGLmpzIGZvcm0gZmllbGRzIHRvIG1hdGNoIFBE RktpdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmls aXR5UmVuZGVyT2JqZWN0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNz aWJpbGl0eVJlbmRlck9iamVjdC5jcHAKaW5kZXggMjdlMzc4YWIwNDljYzA0ODc0YTVhOTcyZTA2 ZWQ5ZDVlNGY1ZWQ5Ny4uZTNjMWMxZTZkNDU1OTc4ZjhmYjQzMWY2YTViYmJkMmMwOWI3ZDQzYiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVu ZGVyT2JqZWN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2li aWxpdHlSZW5kZXJPYmplY3QuY3BwCkBAIC0xMzQsMTEgKzEzNCw2IEBAIEFjY2Vzc2liaWxpdHlS ZW5kZXJPYmplY3Q6On5BY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0KCkKICAgICBBU1NFUlQoaXNE ZXRhY2hlZCgpKTsKIH0KIAotdm9pZCBBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0Ojppbml0KCkK LXsKLSAgICBBY2Nlc3NpYmlsaXR5Tm9kZU9iamVjdDo6aW5pdCgpOwotfQotCiBSZWY8QWNjZXNz aWJpbGl0eVJlbmRlck9iamVjdD4gQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6Y3JlYXRlKFJl bmRlck9iamVjdCogcmVuZGVyZXIpCiB7CiAgICAgcmV0dXJuIGFkb3B0UmVmKCpuZXcgQWNjZXNz aWJpbGl0eVJlbmRlck9iamVjdChyZW5kZXJlcikpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0LmggYi9Tb3VyY2UvV2Vi Q29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuaAppbmRleCBkOGY4 YTg0ZjBjN2UxNzM3NDI0YzNlNzgzYmUwYmUyMTIzYzJkZTY2Li5hYWY1NzlkM2ZmOWRkNmY1OTRl YzUxMDk4ZjlmOGYwNmI1ZWEyMGQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3Np YmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9h Y2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuaApAQCAtNTUsOCArNTUsNiBA QCBjbGFzcyBBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0IDogcHVibGljIEFjY2Vzc2liaWxpdHlO b2RlT2JqZWN0LCBwdWJsaWMgQ2FuTWFrZQogcHVibGljOgogICAgIHN0YXRpYyBSZWY8QWNjZXNz aWJpbGl0eVJlbmRlck9iamVjdD4gY3JlYXRlKFJlbmRlck9iamVjdCopOwogICAgIHZpcnR1YWwg fkFjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QoKTsKLQotICAgIHZvaWQgaW5pdCgpIG92ZXJyaWRl OwogICAgIAogICAgIGJvb2wgaXNBdHRhY2htZW50KCkgY29uc3Qgb3ZlcnJpZGU7CiAgICAgYm9v bCBpc1NlbGVjdGVkKCkgY29uc3Qgb3ZlcnJpZGU7Cg==