237237 2022-02-26 08:11:12 -0800 Fix deprecations for ERB.new in GenerateSettings.rb 2022-03-01 22:05:19 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=237035 https://bugs.webkit.org/show_bug.cgi?id=236684 InRadar P2 Normal --- 1 don.olmstead fujii fujii webkit-bug-importer oldest_to_newest 1846302 0 don.olmstead 2022-02-26 08:11:12 -0800 C:/webkit/Source/WebCore/Scripts/GenerateSettings.rb:283: warning: Passing safe_level with the 2nd argument of ERB.new is deprecated. Do not use it, and specify other arguments as keyword arguments. C:/webkit/Source/WebCore/Scripts/GenerateSettings.rb:283: warning: Passing trim_mode with the 3rd argument of ERB.new is deprecated. Use keyword argument like ERB.new(str, trim_mode: ...) instead. C:/webkit/Source/WebCore/Scripts/GenerateSettings.rb:283: warning: Passing safe_level with the 2nd argument of ERB.new is deprecated. Do not use it, and specify other arguments as keyword arguments. C:/webkit/Source/WebCore/Scripts/GenerateSettings.rb:283: warning: Passing trim_mode with the 3rd argument of ERB.new is deprecated. Use keyword argument like ERB.new(str, trim_mode: ...) instead. C:/webkit/Source/WebCore/Scripts/GenerateSettings.rb:283: warning: Passing safe_level with the 2nd argument of ERB.new is deprecated. Do not use it, and specify other arguments as keyword arguments. C:/webkit/Source/WebCore/Scripts/GenerateSettings.rb:283: warning: Passing trim_mode with the 3rd argument of ERB.new is deprecated. Use keyword argument like ERB.new(str, trim_mode: ...) instead. C:/webkit/Source/WebCore/Scripts/GenerateSettings.rb:283: warning: Passing safe_level with the 2nd argument of ERB.new is deprecated. Do not use it, and specify other arguments as keyword arguments. C:/webkit/Source/WebCore/Scripts/GenerateSettings.rb:283: warning: Passing trim_mode with the 3rd argument of ERB.new is deprecated. Use keyword argument like ERB.new(str, trim_mode: ...) instead. C:/webkit/Source/WebCore/Scripts/GenerateSettings.rb:283: warning: Passing safe_level with the 2nd argument of ERB.new is deprecated. Do not use it, and specify other arguments as keyword arguments. C:/webkit/Source/WebCore/Scripts/GenerateSettings.rb:283: warning: Passing trim_mode with the 3rd argument of ERB.new is deprecated. Use keyword argument like ERB.new(str, trim_mode: ...) instead. 1846469 1 fujii 2022-02-27 12:00:21 -0800 Thank you for bug reporting. This issue was fixded by r290104. Please try the latest. *** This bug has been marked as a duplicate of bug 236684 *** 1846545 2 don.olmstead 2022-02-27 22:52:04 -0800 This is for GenerateSettings.rb while the bug you marked is for GeneratePreferences.rb 1847227 3 fujii 2022-03-01 15:56:34 -0800 Oops. It's my mistake. Will fix. 1847249 4 453548 fujii 2022-03-01 16:36:49 -0800 Created attachment 453548 Patch 1847250 5 453548 don.olmstead 2022-03-01 16:38:55 -0800 Comment on attachment 453548 Patch r=me assuming bots are happy 1847297 6 ews-feeder 2022-03-01 22:04:27 -0800 Committed r290718 (247965@main): <https://commits.webkit.org/247965@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453548. 1847298 7 webkit-bug-importer 2022-03-01 22:05:19 -0800 <rdar://problem/89665192> 453548 2022-03-01 16:36:49 -0800 2022-03-01 22:04:28 -0800 Patch bug-237237-20220302093647.patch text/plain 2049 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwNzA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTBmZWY0NzQ5OWM1NDg1 MGNiZmU1ZjVkYmI2NmFiNjRhNzBjMGMzZC4uZTgxOTk3YjY4NmM3YzNkZmI5M2ZkNDE5YzE0ZTI4 NmUzZGRhZTNlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIyLTAzLTAxICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIEZpeCBkZXBy ZWNhdGlvbnMgZm9yIEVSQi5uZXcgaW4gR2VuZXJhdGVTZXR0aW5ncy5yYgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM3MjM3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUnVieSAzLjEuMCByZXBvcnRlZCB0 aGUgZm9sbG93aW5nIHdhcm5pbmc6CisgICAgICAgID4gR2VuZXJhdGVTZXR0aW5ncy5yYjoyODM6 IHdhcm5pbmc6IFBhc3Npbmcgc2FmZV9sZXZlbCB3aXRoIHRoZSAybmQgYXJndW1lbnQgb2YgRVJC Lm5ldyBpcyBkZXByZWNhdGVkLiBEbyBub3QgdXNlIGl0LCBhbmQgc3BlY2lmeSBvdGhlciBhcmd1 bWVudHMgYXMga2V5d29yZCBhcmd1bWVudHMuCisgICAgICAgID4gR2VuZXJhdGVTZXR0aW5ncy5y YjoyODM6IHdhcm5pbmc6IFBhc3NpbmcgdHJpbV9tb2RlIHdpdGggdGhlIDNyZCBhcmd1bWVudCBv ZiBFUkIubmV3IGlzIGRlcHJlY2F0ZWQuIFVzZSBrZXl3b3JkIGFyZ3VtZW50IGxpa2UgRVJCLm5l dyhzdHIsIHRyaW1fbW9kZTogLi4uKSBpbnN0ZWFkLgorCisgICAgICAgIHIyOTAxMDQgYW5kIHIy OTAzMzEgZml4ZWQgdGhlIHNhbWUgcHJvYmxlbSBmb3IKKyAgICAgICAgR2VuZXJhdGVQcmVmZXJl bmNlcy5yYiwgYnV0IGZvcmdvdCBHZW5lcmF0ZVNldHRpbmdzLnJiLgorCisgICAgICAgICogU2Ny aXB0cy9HZW5lcmF0ZVNldHRpbmdzLnJiOiBVc2UgdGhlIGtleXdvcmQgYXJndW1lbnQgZm9yIEVS Qi5uZXcgZm9yIFJ1YnkgMi42Ky4KKwogMjAyMi0wMy0wMSAgTWljaGFlbCBDYXRhbnphcm8gIDxt Y2F0YW56YXJvQGdub21lLm9yZz4KIAogICAgICAgICBNaXNjIGNvbXBpbGVyIHdhcm5pbmdzLCBs YXRlIEZlYiAyMDIyIGVkaXRpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1NjcmlwdHMv R2VuZXJhdGVTZXR0aW5ncy5yYiBiL1NvdXJjZS9XZWJDb3JlL1NjcmlwdHMvR2VuZXJhdGVTZXR0 aW5ncy5yYgppbmRleCAyN2U2MzEwMGYxMzhmZjJmMTg5MWM5ZDc1ODhhOTdiZWFhNzY5NDA1Li4y YTU1YmQ0Njg5NzZlNDU0MTU4OWNiMzZhOGFlN2FlM2Y0ODNiZWI0IDEwMDc1NQotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9TY3JpcHRzL0dlbmVyYXRlU2V0dGluZ3MucmIKKysrIGIvU291cmNlL1dlYkNv cmUvU2NyaXB0cy9HZW5lcmF0ZVNldHRpbmdzLnJiCkBAIC0yODAsNyArMjgwLDExIEBAIGNsYXNz IFNldHRpbmdzCiAgIGRlZiByZW5kZXJUZW1wbGF0ZSh0ZW1wbGF0ZSwgb3V0cHV0RGlyZWN0b3J5 KQogICAgIGZpbGUgPSBGaWxlLmpvaW4ob3V0cHV0RGlyZWN0b3J5LCBGaWxlLmJhc2VuYW1lKHRl bXBsYXRlLCAiLmVyYiIpKQogCi0gICAgb3V0cHV0ID0gRVJCLm5ldyhGaWxlLnJlYWQodGVtcGxh dGUpLCAwLCAiLSIpLnJlc3VsdChiaW5kaW5nKQorICAgIGlmIEVSQi5pbnN0YW5jZV9tZXRob2Qo OmluaXRpYWxpemUpLnBhcmFtZXRlcnMuYXNzb2MoOmtleSkgIyBSdWJ5IDIuNisKKyAgICAgICAg b3V0cHV0ID0gRVJCLm5ldyhGaWxlLnJlYWQodGVtcGxhdGUpLCB0cmltX21vZGU6Ii0iKS5yZXN1 bHQoYmluZGluZykKKyAgICBlbHNlCisgICAgICAgIG91dHB1dCA9IEVSQi5uZXcoRmlsZS5yZWFk KHRlbXBsYXRlKSwgMCwgIi0iKS5yZXN1bHQoYmluZGluZykKKyAgICBlbmQKICAgICBGaWxlLm9w ZW4oZmlsZSwgIncrIikgZG8gfGZ8CiAgICAgICBmLndyaXRlKG91dHB1dCkKICAgICBlbmQK