<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>237229</bug_id>
          
          <creation_ts>2022-02-25 15:11:40 -0800</creation_ts>
          <short_desc>[Win] vswhere should search for Visual Studio Build tools</short_desc>
          <delta_ts>2022-02-28 13:51:34 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Platform</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Christopher Reid">chris.reid</reporter>
          <assigned_to name="Christopher Reid">chris.reid</assigned_to>
          <cc>don.olmstead</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>fujii</cc>
    
    <cc>jbedard</cc>
    
    <cc>ross.kirsling</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1846203</commentid>
    <comment_count>0</comment_count>
    <who name="Christopher Reid">chris.reid</who>
    <bug_when>2022-02-25 15:11:40 -0800</bug_when>
    <thetext>vswhere needs the -products switch when building with Visual Studio Build tools.
See https://developercommunity.visualstudio.com/t/vswhere-does-not-find-build-tools-for-visual-studi/703424.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1846210</commentid>
    <comment_count>1</comment_count>
      <attachid>453272</attachid>
    <who name="Christopher Reid">chris.reid</who>
    <bug_when>2022-02-25 15:22:35 -0800</bug_when>
    <thetext>Created attachment 453272
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1846751</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2022-02-28 13:50:09 -0800</bug_when>
    <thetext>Committed r290614 (247887@main): &lt;https://commits.webkit.org/247887@main&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453272.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1846755</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-02-28 13:51:34 -0800</bug_when>
    <thetext>&lt;rdar://problem/89579480&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>453272</attachid>
            <date>2022-02-25 15:22:35 -0800</date>
            <delta_ts>2022-02-28 13:50:11 -0800</delta_ts>
            <desc>patch</desc>
            <filename>237229.diff</filename>
            <type>text/plain</type>
            <size>1279</size>
            <attacher name="Christopher Reid">chris.reid</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA0MjQ2
MDA1Yzc4MmQuLjQwNWVlZDljMjhhMCAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBi
L1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDIyLTAyLTI1ICBDaHJpc3RvcGhl
ciBSZWlkICA8Y2hyaXMucmVpZEBzb255LmNvbT4KKworICAgICAgICBbV2luXSB2c3doZXJlIHNo
b3VsZCBzZWFyY2ggZm9yIFZpc3VhbCBTdHVkaW8gQnVpbGQgdG9vbHMKKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNzIyOQorCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBt
OgorCiAyMDIyLTAyLTI1ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5v
cmc+CiAKICAgICAgICAgUmUtYWRkIFlvdVR1YmVQbHVnaW5SZXBsYWNlbWVudCwgcmVtb3ZlZCBp
biByMjg1MjUyCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0gYi9Ub29s
cy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KaW5kZXggYzQzMTdlMjllOGI4Li41OTkyNTFlNGZjZTAg
MTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQorKysgYi9Ub29scy9TY3Jp
cHRzL3dlYmtpdGRpcnMucG0KQEAgLTc3NCw3ICs3NzQsNyBAQCBzdWIgdmlzdWFsU3R1ZGlvSW5z
dGFsbERpclZTV2hlcmUKIHsKICAgICBteSAkdnN3aGVyZSA9IEZpbGU6OlNwZWMtPmNhdGRpcihw
cm9ncmFtRmlsZXNQYXRoWDg2KCksICJNaWNyb3NvZnQgVmlzdWFsIFN0dWRpbyIsICJJbnN0YWxs
ZXIiLCAidnN3aGVyZS5leGUiKTsKICAgICByZXR1cm4gdW5sZXNzIC1lICR2c3doZXJlOwotICAg
IG9wZW4obXkgJGhhbmRsZSwgIi18IiwgJHZzd2hlcmUsIHF3KC1ub2xvZ28gLWxhdGVzdCAtcmVx
dWlyZXMgTWljcm9zb2Z0LkNvbXBvbmVudC5NU0J1aWxkIC1wcm9wZXJ0eSBpbnN0YWxsYXRpb25Q
YXRoKSkgfHwgcmV0dXJuOworICAgIG9wZW4obXkgJGhhbmRsZSwgIi18IiwgJHZzd2hlcmUsIHF3
KC1ub2xvZ28gLWxhdGVzdCAtcmVxdWlyZXMgTWljcm9zb2Z0LkNvbXBvbmVudC5NU0J1aWxkIC1w
cm9wZXJ0eSBpbnN0YWxsYXRpb25QYXRoIC1wcm9kdWN0cyAqKSkgfHwgcmV0dXJuOwogICAgIG15
ICR2c1doZXJlT3V0ID0gPCRoYW5kbGU+OwogICAgICR2c1doZXJlT3V0ID1+IHMvXHI/XG4vLzsK
ICAgICByZXR1cm4gJHZzV2hlcmVPdXQ7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>