237226 2022-02-25 13:50:45 -0800 Adjust -[WKContentView _requiresKeyboardWhenFirstResponder] to account for editable web views 2022-02-25 21:40:10 -0800 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh akeerthi hi katherine_cheney megan_gardner thorton webkit-bug-importer oldest_to_newest 1846171 0 wenson_hsieh 2022-02-25 13:50:45 -0800 rdar://89447095 1846185 1 453261 wenson_hsieh 2022-02-25 14:21:01 -0800 Created attachment 453261 Patch 1846273 2 453261 wenson_hsieh 2022-02-25 20:54:14 -0800 Comment on attachment 453261 Patch Thanks for the review! 1846280 3 ews-feeder 2022-02-25 21:40:08 -0800 Committed r290543 (247821@main): <https://commits.webkit.org/247821@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453261. 453261 2022-02-25 14:21:01 -0800 2022-02-25 21:40:09 -0800 Patch bug-237226-20220225142101.patch text/plain 5824 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwNDUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDE2NzcyODk4ZmMwOGNlNzE5 M2MyOTUyZjgzYTYzMWM3ODc5MTE1ZGYuLjVjNWE5YzM1Mzk3NDM4MjQyYmY4MGIzZmY1MzExZTc4 YTkyMmJmNTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMjItMDItMjUgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgQWRqdXN0IC1bV0tDb250 ZW50VmlldyBfcmVxdWlyZXNLZXlib2FyZFdoZW5GaXJzdFJlc3BvbmRlcl0gdG8gYWNjb3VudCBm b3IgZWRpdGFibGUgd2ViIHZpZXdzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMzcyMjYKKyAgICAgICAgcmRhcjovLzg5NDQ3MDk1CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRqdXN0IHRoZSBpbXBsZW1l bnRhdGlvbiBvZiBgLVtXS0NvbnRlbnRWaWV3IF9yZXF1aXJlc0tleWJvYXJkV2hlbkZpcnN0UmVz cG9uZGVyXWAsIHN1Y2ggdGhhdCBpdCByZXR1cm5zIFlFUworICAgICAgICBmb3IgZWRpdGFibGUg d2ViIHZpZXdzLCBleGNlcHQgZm9yIHRoZSBzY2VuYXJpbyB3aGVyZSBhbiBpbnB1dCBmaWVsZCB0 aGF0IGRvZXMgKm5vdCogcmVxdWlyZSB0aGUgYXV0b21hdGljCisgICAgICAgIGtleWJvYXJkIGlz IGN1cnJlbnRseSBmb2N1c2VkIGluIHRoZSBwYWdlIGluc2lkZSB0aGUgZWRpdGFibGUgd2ViIHZp ZXcgKGUuZy4gYSBgcmVhZG9ubHlgIHRleHQgZmllbGQpLgorCisgICAgICAgIFVJS2l0IGNvbnN1 bHRzIHRoaXMgbWV0aG9kIHRvIGtub3cgd2hldGhlciBvciBub3QgYSBnaXZlbiByZXNwb25kZXIg d291bGQgcmVxdWlyZSB0aGUga2V5Ym9hcmQgKGVpdGhlciBzb2Z0d2FyZQorICAgICAgICBrZXli b2FyZCBvciB0aGUgbWluaW1pemVkIFVDQiBmb3IgaGFyZHdhcmUga2V5Ym9hcmQpIGlmIGl0IHdl cmUgdG8gYmVjb21lIHRoZSBmaXJzdCByZXNwb25kZXIuIEZvciB3ZWIgdmlld3MKKyAgICAgICAg dGhhdCBhcmUgbWFkZSBlZGl0YWJsZSBpbiB0aGUgU1BJIHNlbnNlLCB3ZSBrbm93IGEtcHJpb3Jp IHRoYXQgdGhpcyBzaG91bGQgcmV0dXJuIFlFUywgdW5sZXNzIGEgcmVhZG9ubHkgZWxlbWVudAor ICAgICAgICB1bmRlcm5lYXRoIHRoZSB3ZWIgdmlldyBoYXMgZm9jdXMgKGluIHdoaWNoIGNhc2Us IGBfZGlzYWJsZUF1dG9tYXRpY0tleWJvYXJkVUlgIHdvdWxkIGJlIHRydWUpLgorCisgICAgICAg IFRlc3Q6IEtleWJvYXJkSW5wdXRUZXN0cy5FZGl0YWJsZVdlYlZpZXdSZXF1aXJlc0tleWJvYXJk V2hlbkZpcnN0UmVzcG9uZGVyCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dLQ29udGVudFZp ZXdJbnRlcmFjdGlvbi5tbToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBfcmVxdWlyZXNLZXli b2FyZFdoZW5GaXJzdFJlc3BvbmRlcl0pOgorCiAyMDIyLTAyLTI0ICBXZW5zb24gSHNpZWggIDx3 ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAgICAgIFJlZmFjdG9yIGxvZ2ljIGZvciBzaG93 aW5nICJNYXJrdXAgSW1hZ2UiIGFuZCBRdWljayBOb3RlIGl0ZW1zIGluIHRoZSBjYWxsb3V0IGJh cgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJ bnRlcmFjdGlvbi5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3 SW50ZXJhY3Rpb24ubW0KaW5kZXggNjk3OTVkNmJjZmE5NWJiZTc0NTFlNGJjYjlkOGZhYmZjNDU0 MTA5NS4uMGIzMzkxN2RhOGU2MTA4N2M1ZDY3OThjMDE0NTViZWRhMWJiYTg5MyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5t bQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0 aW9uLm1tCkBAIC0yMzQzLDYgKzIzNDMsOCBAQCBzdGF0aWMgTlNWYWx1ZSAqbnNTaXplRm9yVGFw SGlnaGxpZ2h0Qm9yZGVyUmFkaXVzKFdlYkNvcmU6OkludFNpemUgYm9yZGVyUmFkaXVzLAogCiAt IChCT09MKV9yZXF1aXJlc0tleWJvYXJkV2hlbkZpcnN0UmVzcG9uZGVyCiB7CisgICAgaWYgKFtf d2ViVmlldyBfaXNFZGl0YWJsZV0gJiYgIXNlbGYuX2Rpc2FibGVBdXRvbWF0aWNLZXlib2FyZFVJ KQorICAgICAgICByZXR1cm4gWUVTOwogICAgIC8vIEZJWE1FOiBXZSBzaG91bGQgYWRkIHRoZSBs b2dpYyB0byBoYW5kbGUga2V5Ym9hcmQgdmlzaWJpbGl0eSBkdXJpbmcgZm9jdXMgcmVkaXJlY3Rz LgogICAgIHJldHVybiBbc2VsZiBfc2hvdWxkU2hvd0F1dG9tYXRpY0tleWJvYXJkVUlJZ25vcmlu Z0lucHV0TW9kZV0gfHwgX3NlZW5IYXJkd2FyZUtleURvd25Jbk5vbkVkaXRhYmxlRWxlbWVudDsK IH0KZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA3 MDAzMDc0YjBmMjM0N2RmZTdiZGZlYTVlNzdiMGVhNGEzNDc0MjY5Li4yZTk4ZTY1ZjA0YjBkMjIy ZThmYzBkOTExODE4NTYwNWQyYmM0NzNhIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysr IGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMjItMDItMjUgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgQWRqdXN0IC1bV0tDb250 ZW50VmlldyBfcmVxdWlyZXNLZXlib2FyZFdoZW5GaXJzdFJlc3BvbmRlcl0gdG8gYWNjb3VudCBm b3IgZWRpdGFibGUgd2ViIHZpZXdzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMzcyMjYKKyAgICAgICAgcmRhcjovLzg5NDQ3MDk1CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGFuIEFQSSB0ZXN0IHRv IGV4ZXJjaXNlIHRoZSBjaGFuZ2UuIFRoaXMgbmV3IEFQSSB0ZXN0IGlzIGNvbXByaXNlZCBvZiAz IHBhcnRzOgorICAgICAgICAtIFZlcmlmeSB0aGF0IGAtX3JlcXVpcmVzS2V5Ym9hcmRXaGVuRmly c3RSZXNwb25kZXJgIGlzIE5PIGFmdGVyIGxvYWRpbmcgdGhlIHBhZ2UuCisgICAgICAgIC0gVmVy aWZ5IHRoYXQgYC1fcmVxdWlyZXNLZXlib2FyZFdoZW5GaXJzdFJlc3BvbmRlcmAgYmVjb21lcyBZ RVMgYWZ0ZXIgbWFraW5nIHRoZSB3ZWIgdmlldyBlZGl0YWJsZS4KKyAgICAgICAgLSBWZXJpZnkg dGhhdCBgLV9yZXF1aXJlc0tleWJvYXJkV2hlbkZpcnN0UmVzcG9uZGVyYCBpcyBOTyBhZ2FpbiBh ZnRlciBmb2N1c2luZyBhIHJlYWRvbmx5IGlucHV0IGluc2lkZSB0aGUKKyAgICAgICAgICBub3ct ZWRpdGFibGUgd2ViIHZpZXcuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL2lvcy9L ZXlib2FyZElucHV0VGVzdHNJT1MubW06CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpURVNUKToK KyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL2lvcy9VSUtpdFNQSS5oOgorCiAyMDIyLTAyLTI0ICBX ZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAgICAgIFJlZmFjdG9y IGxvZ2ljIGZvciBzaG93aW5nICJNYXJrdXAgSW1hZ2UiIGFuZCBRdWljayBOb3RlIGl0ZW1zIGlu IHRoZSBjYWxsb3V0IGJhcgpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9p b3MvS2V5Ym9hcmRJbnB1dFRlc3RzSU9TLm1tIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9p b3MvS2V5Ym9hcmRJbnB1dFRlc3RzSU9TLm1tCmluZGV4IGUxNzQ0ZWRhMGY3NzJiNGM2Yjg1ZDhh M2IxNjllN2VkMDc4Y2QxODAuLmNjOWM0M2VlNjEzMDAzZDM2ZGZkNDcwNTU4YzY2NTE2NDVkMzAx ZGUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvaW9zL0tleWJvYXJkSW5w dXRUZXN0c0lPUy5tbQorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL2lvcy9LZXlib2Fy ZElucHV0VGVzdHNJT1MubW0KQEAgLTg3MSw2ICs4NzEsMjggQEAgVEVTVChLZXlib2FyZElucHV0 VGVzdHMsIERvTm90Q3Jhc2hXaGVuRm9jdXNpbmdTZWxlY3RXaXRob3V0Vmlld1NuYXBzaG90KQog ICAgIFt3ZWJWaWV3IHdhaXRGb3JOZXh0UHJlc2VudGF0aW9uVXBkYXRlXTsKIH0KIAorVEVTVChL ZXlib2FyZElucHV0VGVzdHMsIEVkaXRhYmxlV2ViVmlld1JlcXVpcmVzS2V5Ym9hcmRXaGVuRmly c3RSZXNwb25kZXIpCit7CisgICAgYXV0byB3ZWJWaWV3ID0gYWRvcHROUyhbW1Rlc3RXS1dlYlZp ZXcgYWxsb2NdIGluaXRXaXRoRnJhbWU6Q0dSZWN0TWFrZSgwLCAwLCAzMjAsIDUwMCldKTsKKyAg ICBhdXRvIGRlbGVnYXRlID0gYWRvcHROUyhbVGVzdElucHV0RGVsZWdhdGUgbmV3XSk7CisgICAg W3dlYlZpZXcgX3NldElucHV0RGVsZWdhdGU6ZGVsZWdhdGUuZ2V0KCldOworICAgIFtkZWxlZ2F0 ZSBzZXRGb2N1c1N0YXJ0c0lucHV0U2Vzc2lvblBvbGljeUhhbmRsZXI6W10oV0tXZWJWaWV3ICos IGlkIDxfV0tGb2N1c2VkRWxlbWVudEluZm8+KSB7CisgICAgICAgIHJldHVybiBfV0tGb2N1c1N0 YXJ0c0lucHV0U2Vzc2lvblBvbGljeUFsbG93OworICAgIH1dOworCisgICAgYXV0byBjb250ZW50 VmlldyA9IFt3ZWJWaWV3IHRleHRJbnB1dENvbnRlbnRWaWV3XTsKKyAgICBbd2ViVmlldyBzeW5j aHJvbm91c2x5TG9hZEhUTUxTdHJpbmc6QCI8aW5wdXQgdmFsdWU9J2ZvbycgcmVhZG9ubHk+Il07 CisgICAgRVhQRUNUX0ZBTFNFKFtjb250ZW50VmlldyBfcmVxdWlyZXNLZXlib2FyZFdoZW5GaXJz dFJlc3BvbmRlcl0pOworCisgICAgW3dlYlZpZXcgX3NldEVkaXRhYmxlOllFU107CisgICAgW3dl YlZpZXcgd2FpdEZvck5leHRQcmVzZW50YXRpb25VcGRhdGVdOworICAgIEVYUEVDVF9UUlVFKFtj b250ZW50VmlldyBfcmVxdWlyZXNLZXlib2FyZFdoZW5GaXJzdFJlc3BvbmRlcl0pOworCisgICAg W3dlYlZpZXcgc3RyaW5nQnlFdmFsdWF0aW5nSmF2YVNjcmlwdDpAImRvY3VtZW50LnF1ZXJ5U2Vs ZWN0b3IoJ2lucHV0JykuZm9jdXMoKSJdOworICAgIFt3ZWJWaWV3IHdhaXRGb3JOZXh0UHJlc2Vu dGF0aW9uVXBkYXRlXTsKKyAgICBFWFBFQ1RfRkFMU0UoW2NvbnRlbnRWaWV3IF9yZXF1aXJlc0tl eWJvYXJkV2hlbkZpcnN0UmVzcG9uZGVyXSk7Cit9CisKIH0gLy8gbmFtZXNwYWNlIFRlc3RXZWJL aXRBUEkKIAogI2VuZGlmIC8vIFBMQVRGT1JNKElPU19GQU1JTFkpCmRpZmYgLS1naXQgYS9Ub29s cy9UZXN0V2ViS2l0QVBJL2lvcy9VSUtpdFNQSS5oIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9pb3Mv VUlLaXRTUEkuaAppbmRleCAxMmZiNWZjZGM3MWEzNjQ1OTc2YmE3ODc0NmY4ZmU4ZmQ2NTU5ZTU2 Li5hNTUyZGJjNTM0MjMyNmMxMmExOTIxZDY3MmU4NGY3Y2QwMTAyNjIxIDEwMDY0NAotLS0gYS9U b29scy9UZXN0V2ViS2l0QVBJL2lvcy9VSUtpdFNQSS5oCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRB UEkvaW9zL1VJS2l0U1BJLmgKQEAgLTMxOCw2ICszMTgsNyBAQCB0eXBlZGVmIE5TX0VOVU0oTlNV SW50ZWdlciwgX1VJQ2xpY2tJbnRlcmFjdGlvbkV2ZW50KSB7CiAKIEBpbnRlcmZhY2UgVUlSZXNw b25kZXIgKEludGVybmFsKQogLSAodm9pZClfc2hhcmU6KGlkKXNlbmRlcjsKK0Bwcm9wZXJ0eSAo bm9uYXRvbWljLCByZWFkb25seSkgQk9PTCBfcmVxdWlyZXNLZXlib2FyZFdoZW5GaXJzdFJlc3Bv bmRlcjsKIEBlbmQKIAogQGludGVyZmFjZSBVSVdlYkdlb2xvY2F0aW9uUG9saWN5RGVjaWRlciA6 IE5TT2JqZWN0Cg==