237223 2022-02-25 13:32:59 -0800 [WebAuthn] Fallback to attestation=none whenever attestation fails 2023-09-08 13:48:14 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 261349 1 pascoe pascoe bfulgham webkit-bug-importer zooms_vote_0t oldest_to_newest 1846161 0 pascoe 2022-02-25 13:32:59 -0800 As noted by a recent WebAuthn issue: https://github.com/w3c/webauthn/issues/1697, we are the only platform that errors out whenever a requested attestation fails. This leads to a bad user experience when attestation is requested, but not strictly required. Attestation is not possible for example, when using platform synced keys. 1846162 1 pascoe 2022-02-25 13:33:27 -0800 rdar://88767812 1846179 2 453259 pascoe 2022-02-25 13:58:32 -0800 Created attachment 453259 Patch 1846234 3 453259 bfulgham 2022-02-25 16:32:17 -0800 Comment on attachment 453259 Patch r=me 1846254 4 ews-feeder 2022-02-25 17:48:23 -0800 Committed r290539 (247817@main): <https://commits.webkit.org/247817@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453259. 1853895 5 bfulgham 2022-03-22 14:12:31 -0700 *** Bug 236698 has been marked as a duplicate of this bug. *** 453259 2022-02-25 13:58:32 -0800 2022-02-25 17:48:25 -0800 Patch bug-237223-20220225135831.patch text/plain 5940 pascoe U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwNTE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGYxMWZiOGFmNDViZDFkNDJj ODA5Y2FmNWMzZDkxOTc0M2UwNGM0MTkuLmNhOGQ5YWYyMjJhNDkxNThjOWRhOWU0ZTEwZWQzYTZi ZDg2NjU2NTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjItMDItMjUgIEogUGFzY29l ICA8al9wYXNjb2VAYXBwbGUuY29tPgorCisgICAgICAgIFtXZWJBdXRobl0gRmFsbGJhY2sgdG8g YXR0ZXN0YXRpb249bm9uZSB3aGVuZXZlciBhdHRlc3RhdGlvbiBmYWlscworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM3MjIzCisgICAgICAgIHJkYXI6 Ly84ODc2NzgxMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFdoZW5ldmVyIGF0dGVzdGF0aW9uIGlzIHJlcXVlc3RlZCBieSBhIFJQIGFuZCBpdCBmYWls cyB0byBjb21wbGV0ZSwKKyAgICAgICAgd2UgcHJldmlvdXNseSBlcnJvcmVkIG91dCBvZiB0aGUg cmVnaXN0cmF0aW9uLiBUaGUgbW9yZSBjb3JyZWN0IHBsYXRmb3JtCisgICAgICAgIGJlaGF2aW9y IGluIHRoaXMgY2FzZSBpcyB0byBwcm92aWRlIGF0dGVzdGF0aW9uPW5vbmUuCisKKyAgICAgICAg Q3JlYXRlZCBBUEkgdGVzdCBmb3IgdGhpcyBiZWhhdmlvci4KKworICAgICAgICAqIFVJUHJvY2Vz cy9XZWJBdXRoZW50aWNhdGlvbi9Db2NvYS9Mb2NhbEF1dGhlbnRpY2F0b3IubW06CisgICAgICAg IChXZWJLaXQ6OkxvY2FsQXV0aGVudGljYXRvcjo6Y29udGludWVNYWtlQ3JlZGVudGlhbEFmdGVy QXR0ZXN0ZWQpOgorCiAyMDIyLTAyLTI1ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNv bT4KIAogICAgICAgICBCZXR0ZXIgaXNvbGF0ZSBSZW1vdGVWaWRlb0ZyYW1lT2JqZWN0SGVhcCBj bGllbnRzIGZyb20gVGhyZWFkU2FmZU9iamVjdEhlYXAgaW1wbGVtZW50YXRpb24gZGV0YWlscwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViQXV0aGVudGljYXRpb24vQ29j b2EvTG9jYWxBdXRoZW50aWNhdG9yLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViQXV0 aGVudGljYXRpb24vQ29jb2EvTG9jYWxBdXRoZW50aWNhdG9yLm1tCmluZGV4IGZlYzM3OTQ5MTky ODc5YzAxMDMxZmQ1Y2NiMGFmNDc5OWJhZjI4NGIuLjcwOGY1ODY3N2JjY2MwNWFiZjBmM2NiOWZl NzkzNTc2OGQ5OTA0NmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYkF1 dGhlbnRpY2F0aW9uL0NvY29hL0xvY2FsQXV0aGVudGljYXRvci5tbQorKysgYi9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9XZWJBdXRoZW50aWNhdGlvbi9Db2NvYS9Mb2NhbEF1dGhlbnRpY2F0b3Iu bW0KQEAgLTQ2NSw3ICs0NjUsOSBAQCB2b2lkIExvY2FsQXV0aGVudGljYXRvcjo6Y29udGludWVN YWtlQ3JlZGVudGlhbEFmdGVyQXR0ZXN0ZWQoVmVjdG9yPHVpbnQ4X3Q+JiYgYwogICAgIGF1dG8m IGNyZWF0aW9uT3B0aW9ucyA9IHN0ZDo6Z2V0PFB1YmxpY0tleUNyZWRlbnRpYWxDcmVhdGlvbk9w dGlvbnM+KHJlcXVlc3REYXRhKCkub3B0aW9ucyk7CiAKICAgICBpZiAoZXJyb3IpIHsKLSAgICAg ICAgcmVjZWl2ZUV4Y2VwdGlvbih7IFVua25vd25FcnJvciwgbWFrZVN0cmluZygiQ291bGRuJ3Qg YXR0ZXN0OiAiLCBTdHJpbmcoZXJyb3IubG9jYWxpemVkRGVzY3JpcHRpb24pKSB9KTsKKyAgICAg ICAgTE9HX0VSUk9SKCJDb3VsZG4ndCBhdHRlc3Q6ICVzIiwgU3RyaW5nKGVycm9yLmxvY2FsaXpl ZERlc2NyaXB0aW9uKS51dGY4KCkuZGF0YSgpKTsKKyAgICAgICAgYXV0byBhdHRlc3RhdGlvbk9i amVjdCA9IGJ1aWxkQXR0ZXN0YXRpb25PYmplY3QoV1RGTW92ZShhdXRoRGF0YSksICIiLCB7IH0s IEF0dGVzdGF0aW9uQ29udmV5YW5jZVByZWZlcmVuY2U6Ok5vbmUpOworICAgICAgICByZWNlaXZl UmVzcG9uZChBdXRoZW50aWNhdG9yQXR0ZXN0YXRpb25SZXNwb25zZTo6Y3JlYXRlKGNyZWRlbnRp YWxJZCwgYXR0ZXN0YXRpb25PYmplY3QsIEF1dGhlbnRpY2F0b3JBdHRhY2htZW50OjpQbGF0Zm9y bSkpOwogICAgICAgICByZXR1cm47CiAgICAgfQogICAgIC8vIEF0dGVzdGF0aW9uIENlcnRpZmlj YXRlIGFuZCBBdHRlc3RhdGlvbiBJc3N1aW5nIENBCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VM b2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTAxNGQ4NzIyYjU0ODdhMDYwY2YzZTRkMjJlN2Rm OTVhYzg1NDc3Zi4uYjYyNTFjNjJmNTNkYjExNzY4MjU2MmUxZjJkNDEzZjI1YTk0MzBhYSAxMDA2 NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE2IEBACisyMDIyLTAyLTI1ICBKIFBhc2NvZSAgPGpfcGFzY29lQGFwcGxlLmNvbT4KKworICAg ICAgICBbV2ViQXV0aG5dIEZhbGxiYWNrIHRvIGF0dGVzdGF0aW9uPW5vbmUgd2hlbmV2ZXIgYXR0 ZXN0YXRpb24gZmFpbHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIzNzIyMworICAgICAgICByZGFyOi8vODg3Njc4MTIKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgdGVzdCBmb3IgbG9jYWwgYXV0aGVu dGljYXRvciBhdHRlc3RhdGlvbiBmYWxsYmFjayBiZWhhdmlvci4KKworICAgICAgICAqIFRlc3RX ZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvX1dLV2ViQXV0aGVudGljYXRpb25QYW5lbC5tbToK KyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OlRFU1QpOgorCiAyMDIyLTAyLTI0ICBKb25hdGhhbiBC ZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KIAogICAgICAgICBbUHl0aG9uIDNdIEludm9rZSB2 YWxpZGF0ZS1jb21taXR0ZXItbGlzdHMgd2l0aCBQeXRob24gMwpkaWZmIC0tZ2l0IGEvVG9vbHMv VGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9fV0tXZWJBdXRoZW50aWNhdGlvblBhbmVs Lm1tIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9fV0tXZWJBdXRoZW50 aWNhdGlvblBhbmVsLm1tCmluZGV4IDMwZGQwOWYwZGJiMDFkNDcxNzFiOWM0YzFiYzczYTdjOTVh MTU2YTIuLjM0YjllOTI4NzEyZGRiNWNjOWRjYWU3YTdlYjA3MjE4N2M3N2E3NjEgMTAwNjQ0Ci0t LSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvX1dLV2ViQXV0aGVudGlj YXRpb25QYW5lbC5tbQorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29h L19XS1dlYkF1dGhlbnRpY2F0aW9uUGFuZWwubW0KQEAgLTE5MjgsNiArMTkyOCwzOSBAQCBURVNU KFdlYkF1dGhlbnRpY2F0aW9uUGFuZWwsIE1ha2VDcmVkZW50aWFsTEFDbGllbnREYXRhSGFzaCkK ICAgICB9XTsKICAgICBVdGlsOjpydW4oJndlYkF1dGhlbnRpY2F0aW9uUGFuZWxSYW4pOwogfQor CitURVNUKFdlYkF1dGhlbnRpY2F0aW9uUGFuZWwsIE1ha2VDcmVkZW50aWFsTEFBdHRlc3RhdGlv bkZhbGJhY2spCit7CisgICAgcmVzZXQoKTsKKworICAgIHVpbnQ4X3QgaWRlbnRpZmllcltdID0g eyAweDAxLCAweDAyLCAweDAzLCAweDA0IH07CisgICAgdWludDhfdCBoYXNoW10gPSB7IDB4MDEs IDB4MDIsIDB4MDMsIDB4MDQsIDB4MDEsIDB4MDIsIDB4MDMsIDB4MDQsIDB4MDEsIDB4MDIsIDB4 MDMsIDB4MDQsIDB4MDEsIDB4MDIsIDB4MDMsIDB4MDQsIDB4MDEsIDB4MDIsIDB4MDMsIDB4MDQs IDB4MDEsIDB4MDIsIDB4MDMsIDB4MDQsIDB4MDEsIDB4MDIsIDB4MDMsIDB4MDQsIDB4MDEsIDB4 MDIsIDB4MDMsIDB4MDQgfTsKKyAgICBOU0RhdGEgKm5zSWRlbnRpZmllciA9IFtOU0RhdGEgZGF0 YVdpdGhCeXRlczppZGVudGlmaWVyIGxlbmd0aDpzaXplb2YoaWRlbnRpZmllcildOworICAgIGF1 dG8gbnNIYXNoID0gYWRvcHROUyhbW05TRGF0YSBhbGxvY10gaW5pdFdpdGhCeXRlczpoYXNoIGxl bmd0aDpzaXplb2YoaGFzaCldKTsKKyAgICBhdXRvIHBhcmFtZXRlcnMgPSBhZG9wdE5TKFtbX1dL UHVibGljS2V5Q3JlZGVudGlhbFBhcmFtZXRlcnMgYWxsb2NdIGluaXRXaXRoQWxnb3JpdGhtOkAt N10pOworCisgICAgYXV0byBycCA9IGFkb3B0TlMoW1tfV0tQdWJsaWNLZXlDcmVkZW50aWFsUmVs eWluZ1BhcnR5RW50aXR5IGFsbG9jXSBpbml0V2l0aE5hbWU6QCJleGFtcGxlLmNvbSJdKTsKKyAg ICBbcnAgc2V0SWRlbnRpZmllcjpAImV4YW1wbGUuY29tIl07CisgICAgYXV0byB1c2VyID0gYWRv cHROUyhbW19XS1B1YmxpY0tleUNyZWRlbnRpYWxVc2VyRW50aXR5IGFsbG9jXSBpbml0V2l0aE5h bWU6QCJqYXBwbGVzZWVkQGV4YW1wbGUuY29tIiBpZGVudGlmaWVyOm5zSWRlbnRpZmllciBkaXNw bGF5TmFtZTpAIkogQXBwbGVzZWVkIl0pOworICAgIE5TQXJyYXk8X1dLUHVibGljS2V5Q3JlZGVu dGlhbFBhcmFtZXRlcnMgKj4gKnB1YmxpY0tleUNyZWRlbnRpYWxQYXJhbWF0ZXJzID0gQFsgcGFy YW1ldGVycy5nZXQoKSBdOworICAgIGF1dG8gb3B0aW9ucyA9IGFkb3B0TlMoW1tfV0tQdWJsaWNL ZXlDcmVkZW50aWFsQ3JlYXRpb25PcHRpb25zIGFsbG9jXSBpbml0V2l0aFJlbHlpbmdQYXJ0eTpy cC5nZXQoKSB1c2VyOnVzZXIuZ2V0KCkgcHVibGljS2V5Q3JlZGVudGlhbFBhcmFtYXRlcnM6cHVi bGljS2V5Q3JlZGVudGlhbFBhcmFtYXRlcnNdKTsKKyAgICBvcHRpb25zLmdldCgpLmF0dGVzdGF0 aW9uID0gX1dLQXR0ZXN0YXRpb25Db252ZXlhbmNlUHJlZmVyZW5jZURpcmVjdDsKKworICAgIGF1 dG8gcGFuZWwgPSBhZG9wdE5TKFtbX1dLV2ViQXV0aGVudGljYXRpb25QYW5lbCBhbGxvY10gaW5p dF0pOworICAgIFtwYW5lbCBzZXRNb2NrQ29uZmlndXJhdGlvbjpAeyBAInByaXZhdGVLZXlCYXNl NjQiOiB0ZXN0RVMyNTZQcml2YXRlS2V5QmFzZTY0IH1dOworICAgIGF1dG8gZGVsZWdhdGUgPSBh ZG9wdE5TKFtbVGVzdFdlYkF1dGhlbnRpY2F0aW9uUGFuZWxEZWxlZ2F0ZSBhbGxvY10gaW5pdF0p OworICAgIFtwYW5lbCBzZXREZWxlZ2F0ZTpkZWxlZ2F0ZS5nZXQoKV07CisKKyAgICBbcGFuZWwg bWFrZUNyZWRlbnRpYWxXaXRoQ2xpZW50RGF0YUhhc2g6bnNIYXNoLmdldCgpIG9wdGlvbnM6b3B0 aW9ucy5nZXQoKSBjb21wbGV0aW9uSGFuZGxlcjpeKF9XS0F1dGhlbnRpY2F0b3JBdHRlc3RhdGlv blJlc3BvbnNlICpyZXNwb25zZSwgTlNFcnJvciAqZXJyb3IpIHsKKyAgICAgICAgd2ViQXV0aGVu dGljYXRpb25QYW5lbFJhbiA9IHRydWU7CisgICAgICAgIGNsZWFuVXBLZXljaGFpbigiZXhhbXBs ZS5jb20iKTsKKworICAgICAgICBFWFBFQ1RfTk9UX05VTEwocmVzcG9uc2UpOworICAgICAgICAv LyB7ImZtdCI6ICJub25lIiwgImF0dFN0bXQiOiB7fSwgImF1dGhEYXRhIjogLi4ufQorICAgICAg ICBFWFBFQ1RfV0tfU1RSRVEoW3Jlc3BvbnNlLmF0dGVzdGF0aW9uT2JqZWN0IGJhc2U2NEVuY29k ZWRTdHJpbmdXaXRoT3B0aW9uczowXSwgIm8yTm1iWFJrYm05dVpXZGhkSFJUZEcxMG9HaGhkWFJv UkdGMFlWaVlvM21tOXU2dnVhVmVONHdSZ0RUaWRSNW9MNnVmTFRDckU5SVNWWWJPR1VkRkFBQUFB QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFGRWpFbHg1NEJlNFJEckJKUU85d3QwV1B2RzBlcFFFQ0F5 WWdBU0ZZSURqL3p4U2t6S2dhQnVTM2NkV0RGNTU4b2Y4QWFJcGdGcHNqRi9RbTE3NDlJbGdnVkJK UGdxVUl3ZmhXSEo5MW5iN1VQSDc2YzArV0ZPelpLc2xQeXlGc2U0Zz0iKTsKKyAgICB9XTsKKyAg ICBVdGlsOjpydW4oJndlYkF1dGhlbnRpY2F0aW9uUGFuZWxSYW4pOworfQogI2VuZGlmCiAKIFRF U1QoV2ViQXV0aGVudGljYXRpb25QYW5lbCwgUHVibGljS2V5Q3JlZGVudGlhbFJlcXVlc3RPcHRp b25zTWluaW11bikK