<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>237213</bug_id>
          
          <creation_ts>2022-02-25 09:23:44 -0800</creation_ts>
          <short_desc>CSSStyleDeclaration+PropertyNames.idl: 1 input keys have identical hash values, examine output carefully...</short_desc>
          <delta_ts>2025-09-02 12:24:39 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>CSS</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=298246</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Michael Catanzaro">mcatanzaro</reporter>
          <assigned_to name="David Kilzer (:ddkilzer)">ddkilzer</assigned_to>
          <cc>ap</cc>
    
    <cc>berto</cc>
    
    <cc>cdumez</cc>
    
    <cc>cgarcia</cc>
    
    <cc>darin</cc>
    
    <cc>gsnedders</cc>
    
    <cc>koivisto</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>sam</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1846047</commentid>
    <comment_count>0</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2022-02-25 09:23:44 -0800</bug_when>
    <thetext>We should figure out what is going wrong with CSSStyleDeclaration+PropertyNames.idl:

[327/2481] Generating ../../WebCore/DerivedSources/CSSProp...bCore/DerivedSources/CSSStyleDeclaration+PropertyNames.idl
1 input keys have identical hash values, examine output carefully...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1846051</commentid>
    <comment_count>1</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2022-02-25 09:28:29 -0800</bug_when>
    <thetext>The generated file says:

// This file is automatically generated from CSSProperties.json by the makeprop.pl script. Do not edit it.

However, we have no clear way to know what &quot;input keys&quot; are problematic here. I&apos;ve failed to even find the source of this warning. We don&apos;t appear to have the strings &quot;identical hash values&quot; or &quot;examine output carefully&quot; anywhere in WebKit, nor even anywhere in Debian (I tried codesearch.debian.net), so it is unclear where this warning is coming from.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1846058</commentid>
    <comment_count>2</comment_count>
    <who name="Sam Sneddon [:gsnedders]">gsnedders</who>
    <bug_when>2022-02-25 09:52:31 -0800</bug_when>
    <thetext>My guess would be that it&apos;s from gperf, but I haven&apos;t looked into this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1846059</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-02-25 09:53:14 -0800</bug_when>
    <thetext>&lt;rdar://problem/89479324&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1904112</commentid>
    <comment_count>4</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2022-10-07 11:58:29 -0700</bug_when>
    <thetext>Somewhat long shot, but any chance for bug 245803 to be caused by this? If so, this seems seriously bad, as it changes observable behavior.

I have no idea about how to &quot;examine output carefully&quot; here.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1904148</commentid>
    <comment_count>5</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2022-10-07 14:02:32 -0700</bug_when>
    <thetext>The output files are:

${WebCore_DERIVED_SOURCES_DIR}/CSSProperties.json
${WebCore_DERIVED_SOURCES_DIR}/CSSPropertyNames.h
${WebCore_DERIVED_SOURCES_DIR}/CSSPropertyNames.cpp
${WebCore_DERIVED_SOURCES_DIR}/CSSPropertyNames.gperf
${WebCore_DERIVED_SOURCES_DIR}/StyleBuilderGenerated.cpp
${WebCore_DERIVED_SOURCES_DIR}/StylePropertyShorthandFunctions.h
${WebCore_DERIVED_SOURCES_DIR}/StylePropertyShorthandFunctions.cpp
${WebCore_DERIVED_SOURCES_DIR}/CSSStyleDeclaration+PropertyNames.idl

Of which CSSStyleDeclaration+PropertyNames.idl might possibly be related to bug #245803.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1904213</commentid>
    <comment_count>6</comment_count>
    <who name="Sam Sneddon [:gsnedders]">gsnedders</who>
    <bug_when>2022-10-07 21:07:01 -0700</bug_when>
    <thetext>(In reply to Michael Catanzaro from comment #1)
&gt; The generated file says:
&gt; 
&gt; // This file is automatically generated from CSSProperties.json by the
&gt; makeprop.pl script. Do not edit it.
&gt; 
&gt; However, we have no clear way to know what &quot;input keys&quot; are problematic
&gt; here. I&apos;ve failed to even find the source of this warning. We don&apos;t appear
&gt; to have the strings &quot;identical hash values&quot; or &quot;examine output carefully&quot;
&gt; anywhere in WebKit, nor even anywhere in Debian (I tried
&gt; codesearch.debian.net), so it is unclear where this warning is coming from.

https://git.savannah.gnu.org/gitweb/?p=gperf.git;a=blob;f=src/search.cc;h=c2459701036d3f7e2dbd35f78fc8d6168c2bd7e6;hb=refs/tags/v3.0.3#l796</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1905845</commentid>
    <comment_count>7</comment_count>
    <who name="Dan Glastonbury">djg</who>
    <bug_when>2022-10-15 01:57:55 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/5415</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1905853</commentid>
    <comment_count>8</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2022-10-15 07:31:48 -0700</bug_when>
    <thetext>Committed 255578@main (bd3be165cd17): &lt;https://commits.webkit.org/255578@main&gt;

Reviewed commits have been landed. Closing PR #5415 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2140334</commentid>
    <comment_count>9</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2025-09-02 12:17:43 -0700</bug_when>
    <thetext>&lt;rdar://problem/159680551&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2140336</commentid>
    <comment_count>10</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2025-09-02 12:18:15 -0700</bug_when>
    <thetext>Re-opening for pull request https://github.com/WebKit/WebKit/pull/50194</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2140337</commentid>
    <comment_count>11</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2025-09-02 12:24:39 -0700</bug_when>
    <thetext>Sorry, answered the question from `git-webkit` incorrectly.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>