237181 2022-02-24 20:28:58 -0800 [GTK] The setting WebKitMinimumFontSize is not reset by the testing framework, leading to flaky tests 2022-04-27 12:05:13 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 crzwdjk crzwdjk cgarcia changseok lmoura webkit-bug-importer oldest_to_newest 1845896 0 crzwdjk 2022-02-24 20:28:58 -0800 The test fast/forms/validation-message-minimum-font-size.html uses the setting WebKitMinimumFontSize, which on GTK does not appear to be getting reset between tests, leading to failures in tests that run in the same test runner process, which results in test flakiness. The code to set this setting on GTK was introduced by r288666. 1846836 1 changseok 2022-02-28 16:29:08 -0800 (In reply to Arcady Goldmints-Orlov from comment #0) > The test fast/forms/validation-message-minimum-font-size.html uses the > setting WebKitMinimumFontSize, which on GTK does not appear to be getting > reset between tests, leading to failures in tests that run in the same test > runner process, which results in test flakiness. The code to set this > setting on GTK was introduced by r288666. May I ask what tests are flaky in particular? 1846838 2 crzwdjk 2022-02-28 16:43:10 -0800 If you are looking to reproduce it, the command I have been using is: Tools/Scripts/run-webkit-tests --no-new --child-processes=1 --no-show fast/forms/validation-message-minimum-font-size.html fast/text/international 1857706 3 changseok 2022-04-03 15:20:50 -0700 (In reply to Arcady Goldmints-Orlov from comment #2) > If you are looking to reproduce it, the command I have been using is: > > Tools/Scripts/run-webkit-tests --no-new --child-processes=1 --no-show > fast/forms/validation-message-minimum-font-size.html fast/text/international Unfortunately, I could not reproduce the issue in two different Linux distributions: Ubuntu 21.10 and Fedora 35. In my investigation, a WebPreferences instance is ephemeral so each test creates its own WebPreferences rather than sharing one among tests. Would you test if the attached hotfix resolves your issue? 1857707 4 456521 changseok 2022-04-03 15:21:42 -0700 Created attachment 456521 A hotfix 1864853 5 crzwdjk 2022-04-27 11:14:04 -0700 This was fixed by r292681, I will remove the line from the TestExpectation. 1864859 6 458455 crzwdjk 2022-04-27 11:37:10 -0700 Created attachment 458455 [fast-cq] Patch 1864873 7 ews-feeder 2022-04-27 12:04:23 -0700 Committed r293523 (250054@main): <https://commits.webkit.org/250054@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458455. 1864874 8 webkit-bug-importer 2022-04-27 12:05:13 -0700 <rdar://problem/92412612> 456521 2022-04-03 15:21:42 -0700 2022-04-27 11:37:06 -0700 A hotfix hotfix.patch text/plain 1052 changseok ZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwIGIv VG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHAKaW5kZXggYTAxY2VhNDI3 NzFhLi4yZTRkMjQyZjc4NTEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVz dENvbnRyb2xsZXIuY3BwCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xs ZXIuY3BwCkBAIC05Niw2ICs5Niw4IEBACiAjaW5jbHVkZSA8d3RmL3RleHQvQ1N0cmluZy5oPgog I2luY2x1ZGUgPHd0Zi90ZXh0L1N0cmluZ0NvbmNhdGVuYXRlTnVtYmVycy5oPgogCisjaW5jbHVk ZSAiV2ViUHJlZmVyZW5jZXNEZWZpbml0aW9ucy5oIgorCiAjaWYgUExBVEZPUk0oQ09DT0EpCiAj aW5jbHVkZSA8V2ViS2l0L1dLQ29udGV4dFByaXZhdGVNYWMuaD4KICNpbmNsdWRlIDxXZWJLaXQv V0tQYWdlUHJpdmF0ZU1hYy5oPgpAQCAtOTU1LDYgKzk1Nyw5IEBAIHRlbXBsYXRlPHR5cGVuYW1l IEY+IHN0YXRpYyB2b2lkIGJhdGNoVXBkYXRlUHJlZmVyZW5jZXMoV0tQcmVmZXJlbmNlc1JlZiBw cmVmZXJlCiAKIHZvaWQgVGVzdENvbnRyb2xsZXI6OnJlc2V0UHJlZmVyZW5jZXNUb0NvbnNpc3Rl bnRWYWx1ZXMoY29uc3QgVGVzdE9wdGlvbnMmIG9wdGlvbnMpCiB7CisgICAgaWYgKFdLUHJlZmVy ZW5jZXNHZXRNaW5pbXVtRm9udFNpemUocGxhdGZvcm1QcmVmZXJlbmNlcygpKSkKKyAgICAgICAg V0tQcmVmZXJlbmNlc1NldE1pbmltdW1Gb250U2l6ZShwbGF0Zm9ybVByZWZlcmVuY2VzKCksIGRv dWJsZShERUZBVUxUX1ZBTFVFX0ZPUl9NaW5pbXVtRm9udFNpemUpKTsKKwogICAgIGJhdGNoVXBk YXRlUHJlZmVyZW5jZXMocGxhdGZvcm1QcmVmZXJlbmNlcygpLCBbb3B0aW9ucywgZW5hYmxlQWxs RXhwZXJpbWVudGFsRmVhdHVyZXMgPSBtX2VuYWJsZUFsbEV4cGVyaW1lbnRhbEZlYXR1cmVzXSAo YXV0byBwcmVmZXJlbmNlcykgewogICAgICAgICBXS1ByZWZlcmVuY2VzUmVzZXRUZXN0UnVubmVy T3ZlcnJpZGVzKHByZWZlcmVuY2VzKTsKIAo= 458455 2022-04-27 11:37:10 -0700 2022-04-27 12:04:24 -0700 [fast-cq] Patch bug-237181-20220427143709.patch text/plain 1534 crzwdjk U3VidmVyc2lvbiBSZXZpc2lvbjogMjkzNDk1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggY2MzZjhhNDYwNmY1YmVlODYxNmE5 ODY4MDIzNTU1NDk4NjQxOTUxYS4uNWEwNmQyMDJkYzJiMTIxYzU4OTk5OThiNjdhZjVhN2M2MmRi ZDE5YSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDIyLTA0LTI3ICBBcmNhZHkgR29sZG1pbnRz LU9ybG92ICA8YWdvbGRtaW50c0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIFRoZSBzZXR0 aW5nIFdlYktpdE1pbmltdW1Gb250U2l6ZSBpcyBub3QgcmVzZXQgYnkgdGhlIHRlc3RpbmcgZnJh bWV3b3JrLCBsZWFkaW5nIHRvIGZsYWt5IHRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzcxODEKKworICAgICAgICBVbnJldmlld2VkIHRlc3Qg Z2FyZGVuaW5nLgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnM6IFJl bW92ZSBza2lwIG5vdyB0aGF0IHRoZSB0ZXN0IGRvZXNuJ3QgY2F1c2UgcHJvYmxlbXMuCisKIDIw MjItMDQtMjYgIFRydWl0dCBTYXZlbGwgIDx0c2F2ZWxsQGFwcGxlLmNvbT4KIAogICAgICAgICBD bGVhbnVwIGV4cGVjdGF0aW9ucyBmb3IgNyBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3Rz L2h0bWwvc2VtYW50aWNzL2ludGVyYWN0aXZlLWVsZW1lbnRzLyB0ZXN0cwpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwppbmRleCAwMzI5ZjcyY2NhMGUxYjAwOGZhNjE0 YTI2NGU5NzAwNjYwZDg3ZjNkLi44NzFkZWJjNTkwMThkMTI5YTgwOTI4YzM3NTQ1ZmIzZmY5MWU3 ZTRmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9u cworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMTk5 LDkgKzE5OSw2IEBAIHdlYmtpdC5vcmcvYi8yMDg5ODggd2VieHIgWyBTa2lwIF0KICMgQ3Jhc2gg b24gRVdTIGJvdC4KIHdlYnJ0Yy92cDgtdGhlbi1oMjY0LWdwdS1wcm9jZXNzLWNyYXNoLmh0bWwg WyBTa2lwIF0KIAotIyBUaGlzIHRlc3QgaW50cm9kdWNlcyBmbGFraW5lc3MgZHVlIHRvIGlzc3Vl cyB3aXRoIHJlc2V0dGluZyBXZWJQcmVmZXJlbmNlcy4KLXdlYmtpdC5vcmcvYi8yMzcxODEgZmFz dC9mb3Jtcy92YWxpZGF0aW9uLW1lc3NhZ2UtbWluaW11bS1mb250LXNpemUuaHRtbCBbIFNraXAg XQotCiAjLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vCiAjIEVuZCBvZiBUcmlhZ2Vk IEV4cGVjdGF0aW9ucwogIyBMZWdhY3kgRXhwZWN0YXRpb25zIHNlY3Rpb25zIGJlbG93Cg==