<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>237146</bug_id>
          
          <creation_ts>2022-02-24 10:51:18 -0800</creation_ts>
          <short_desc>Fix bad logging in SharedWorkerObjectConnection::notifyWorkerObjectOfLoadCompletion()</short_desc>
          <delta_ts>2022-02-24 11:42:22 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit2</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Chris Dumez">cdumez</reporter>
          <assigned_to name="Chris Dumez">cdumez</assigned_to>
          <cc>achristensen</cc>
    
    <cc>ggaren</cc>
    
    <cc>kkinnunen</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>youennf</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1845668</commentid>
    <comment_count>0</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2022-02-24 10:51:18 -0800</bug_when>
    <thetext>Fix bad logging in SharedWorkerObjectConnection::notifyWorkerObjectOfLoadCompletion(). It was logging an error even when the load succeeded.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1845669</commentid>
    <comment_count>1</comment_count>
      <attachid>453118</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2022-02-24 10:52:29 -0800</bug_when>
    <thetext>Created attachment 453118
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1845676</commentid>
    <comment_count>2</comment_count>
      <attachid>453118</attachid>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2022-02-24 11:16:39 -0800</bug_when>
    <thetext>Comment on attachment 453118
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1845689</commentid>
    <comment_count>3</comment_count>
      <attachid>453118</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2022-02-24 11:41:44 -0800</bug_when>
    <thetext>Comment on attachment 453118
Patch

Clearing flags on attachment: 453118

Committed r290445 (247748@trunk): &lt;https://commits.webkit.org/247748@trunk&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1845690</commentid>
    <comment_count>4</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2022-02-24 11:41:47 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1845691</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-02-24 11:42:22 -0800</bug_when>
    <thetext>&lt;rdar://problem/89430596&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>453118</attachid>
            <date>2022-02-24 10:52:29 -0800</date>
            <delta_ts>2022-02-24 11:41:44 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-237146-20220224105229.patch</filename>
            <type>text/plain</type>
            <size>2300</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwNDM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTI5N2RjNWVhY2U5Zjg3
ZDQ5N2Q1ZDQ2Mzg1M2RmYWUxZTZkNjA0Ni4uMjJmNTQ2ZWJjZmFjNTU4OWYwY2JlNmFhMGExNTZm
MDM0NjEyYjE3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIyLTAyLTI0ICBDaHJp
cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IGJhZCBsb2dnaW5nIGlu
IFNoYXJlZFdvcmtlck9iamVjdENvbm5lY3Rpb246Om5vdGlmeVdvcmtlck9iamVjdE9mTG9hZENv
bXBsZXRpb24oKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/
aWQ9MjM3MTQ2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg
ICAgRml4IGJhZCBsb2dnaW5nIGluIFNoYXJlZFdvcmtlck9iamVjdENvbm5lY3Rpb246Om5vdGlm
eVdvcmtlck9iamVjdE9mTG9hZENvbXBsZXRpb24oKS4KKyAgICAgICAgSXQgd2FzIGxvZ2dpbmcg
YW4gZXJyb3IgZXZlbiB3aGVuIHRoZSBsb2FkIHN1Y2NlZWRlZC4KKworICAgICAgICAqIHdvcmtl
cnMvc2hhcmVkL1NoYXJlZFdvcmtlck9iamVjdENvbm5lY3Rpb24uY3BwOgorICAgICAgICAoV2Vi
Q29yZTo6U2hhcmVkV29ya2VyT2JqZWN0Q29ubmVjdGlvbjo6bm90aWZ5V29ya2VyT2JqZWN0T2ZM
b2FkQ29tcGxldGlvbik6CisKIDIwMjItMDItMjQgIEFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUu
Y29tPgogCiAgICAgICAgIFtMRkNdW0lGQ10gTm9uLW9ydGhvZ29uYWwgaW5saW5lIGJsb2NrIGJv
eGVzIGtlZXAgdGhlaXIgYmFzZWxpbmUgb24gaWRlb2dyYXBoaWMgbGluZXMKZGlmZiAtLWdpdCBh
L1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvc2hhcmVkL1NoYXJlZFdvcmtlck9iamVjdENvbm5lY3Rp
b24uY3BwIGIvU291cmNlL1dlYkNvcmUvd29ya2Vycy9zaGFyZWQvU2hhcmVkV29ya2VyT2JqZWN0
Q29ubmVjdGlvbi5jcHAKaW5kZXggMGU2NzY3OThjNTQwZjg5Y2M5NDRiNjMzNTI1MzI0ZTNkMjhi
OTQwNS4uMzA4YmJmYTZhZjkwMzAwOTU2YTJhMzk2ODdlNTVjNWQ3MzQ5ZWRiNSAxMDA2NDQKLS0t
IGEvU291cmNlL1dlYkNvcmUvd29ya2Vycy9zaGFyZWQvU2hhcmVkV29ya2VyT2JqZWN0Q29ubmVj
dGlvbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvd29ya2Vycy9zaGFyZWQvU2hhcmVkV29ya2Vy
T2JqZWN0Q29ubmVjdGlvbi5jcHAKQEAgLTcyLDcgKzcyLDEwIEBAIHZvaWQgU2hhcmVkV29ya2Vy
T2JqZWN0Q29ubmVjdGlvbjo6bm90aWZ5V29ya2VyT2JqZWN0T2ZMb2FkQ29tcGxldGlvbihXZWJD
b3JlOjpTCiB7CiAgICAgQVNTRVJUKGlzTWFpblRocmVhZCgpKTsKICAgICBhdXRvKiB3b3JrZXJP
YmplY3QgPSBTaGFyZWRXb3JrZXI6OmZyb21JZGVudGlmaWVyKHNoYXJlZFdvcmtlck9iamVjdElk
ZW50aWZpZXIpOwotICAgIENPTk5FQ1RJT05fUkVMRUFTRV9MT0dfRVJST1IoIm5vdGlmeVdvcmtl
ck9iamVjdE9mTG9hZENvbXBsZXRpb246IHNoYXJlZFdvcmtlck9iamVjdElkZW50aWZpZXI9JXtw
dWJsaWN9cywgd29ya2VyPSVwLCBzdWNjZXNzPSVkIiwgc2hhcmVkV29ya2VyT2JqZWN0SWRlbnRp
Zmllci50b1N0cmluZygpLnV0ZjgoKS5kYXRhKCksIHdvcmtlck9iamVjdCwgZXJyb3IuaXNOdWxs
KCkpOworICAgIGlmIChlcnJvci5pc051bGwoKSkKKyAgICAgICAgQ09OTkVDVElPTl9SRUxFQVNF
X0xPRygibm90aWZ5V29ya2VyT2JqZWN0T2ZMb2FkQ29tcGxldGlvbjogc2hhcmVkV29ya2VyT2Jq
ZWN0SWRlbnRpZmllcj0le3B1YmxpY31zLCB3b3JrZXI9JXAsIGxvYWQgc3VjY2VlZGVkIiwgc2hh
cmVkV29ya2VyT2JqZWN0SWRlbnRpZmllci50b1N0cmluZygpLnV0ZjgoKS5kYXRhKCksIHdvcmtl
ck9iamVjdCk7CisgICAgZWxzZQorICAgICAgICBDT05ORUNUSU9OX1JFTEVBU0VfTE9HX0VSUk9S
KCJub3RpZnlXb3JrZXJPYmplY3RPZkxvYWRDb21wbGV0aW9uOiBzaGFyZWRXb3JrZXJPYmplY3RJ
ZGVudGlmaWVyPSV7cHVibGljfXMsIHdvcmtlcj0lcCwgbG9hZCBmYWlsZWQiLCBzaGFyZWRXb3Jr
ZXJPYmplY3RJZGVudGlmaWVyLnRvU3RyaW5nKCkudXRmOCgpLmRhdGEoKSwgd29ya2VyT2JqZWN0
KTsKICAgICBpZiAod29ya2VyT2JqZWN0KQogICAgICAgICB3b3JrZXJPYmplY3QtPmRpZEZpbmlz
aExvYWRpbmcoZXJyb3IpOwogfQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>