237142 2022-02-24 09:11:46 -0800 Regression(r273929) FrameState no longer gets a move constructor 2022-02-24 11:49:45 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=222587 InRadar P2 Normal --- 1 cdumez cdumez achristensen darin ggaren kkinnunen sihui_liu webkit-bug-importer oldest_to_newest 1845630 0 cdumez 2022-02-24 09:11:46 -0800 FrameState no longer gets an implicit move constructor since r273929 because a custom destructor was added. 1845632 1 453106 cdumez 2022-02-24 09:12:44 -0800 Created attachment 453106 Patch 1845633 2 453106 darin 2022-02-24 09:16:03 -0800 Comment on attachment 453106 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453106&action=review > Source/WebKit/Shared/SessionState.h:93 > + FrameState(const FrameState&) = default; > + FrameState(FrameState&&) = default; > + FrameState& operator=(const FrameState&) = default; > + FrameState& operator=(FrameState&&) = default; I’d think we’d want the "main run loop" assertion on these other constructors too, maybe even the assignment operators, but sadly could not take advantage of the defaults then. Valuable to group these with the constructor/destructor pair, since we should delete them all at the same time. 1845638 3 453108 cdumez 2022-02-24 09:23:32 -0800 Created attachment 453108 Patch 1845640 4 cdumez 2022-02-24 09:30:16 -0800 (In reply to Darin Adler from comment #2) > Comment on attachment 453106 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=453106&action=review > > > Source/WebKit/Shared/SessionState.h:93 > > + FrameState(const FrameState&) = default; > > + FrameState(FrameState&&) = default; > > + FrameState& operator=(const FrameState&) = default; > > + FrameState& operator=(FrameState&&) = default; > > I’d think we’d want the "main run loop" assertion on these other > constructors too, maybe even the assignment operators, but sadly could not > take advantage of the defaults then. Valuable to group these with the > constructor/destructor pair, since we should delete them all at the same > time. I did the grouping as suggested. I am not convinced it is worth writing these by hand just to be able to add the threading assertion though. 1845646 5 darin 2022-02-24 09:41:00 -0800 I have no idea how important it is to get the threading assertion right so I don’t have much of an opinion; not sure what made us add that. But I do note that adding it to the default constructor and the destructor is an inconsistent choice since it affects *some* construction and *all* destruction. Oversights like that have been a problem for me before when hunting bugs. 1845693 6 ews-feeder 2022-02-24 11:48:53 -0800 Committed r290446 (247749@main): <https://commits.webkit.org/247749@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453108. 1845694 7 webkit-bug-importer 2022-02-24 11:49:45 -0800 <rdar://problem/89431031> 453106 2022-02-24 09:12:44 -0800 2022-02-24 09:23:30 -0800 Patch bug-237142-20220224091243.patch text/plain 1682 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwNDI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDM5NzY1ZTgzZThiZjYwMjdh MzUwMDQ4ODNiOWM1M2E5NzA5N2U1ZWUuLjgzYTY2YWFmMTYwNzRhYjY3NjBlODA2ODExYjUyMTBi ZGYyNWRiZGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjItMDItMjQgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBSZWdyZXNzaW9uKHIyNzM5MjkpIEZy YW1lU3RhdGUgbm8gbG9uZ2VyIGdldHMgYSBtb3ZlIGNvbnN0cnVjdG9yCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzcxNDIKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGcmFtZVN0YXRlIG5vIGxvbmdlciBn ZXRzIGFuIGltcGxpY2l0IG1vdmUgY29uc3RydWN0b3Igc2luY2UgcjI3MzkyOSBiZWNhdXNlIGEg Y3VzdG9tCisgICAgICAgIGRlc3RydWN0b3Igd2FzIGFkZGVkLgorCisgICAgICAgICogU2hhcmVk L1Nlc3Npb25TdGF0ZS5oOgorCiAyMDIyLTAyLTI0ICBLaW1tbyBLaW5udW5lbiAgPGtraW5udW5l bkBhcHBsZS5jb20+CiAKICAgICAgICAgTGliV2ViUlRDQ29kZWNzLCAtUHJveHkgY3JlYXRlIGFu ZCBjb21tdW5pY2F0ZSB0aGUgUmVtb3RlVmlkZW9GcmFtZVByb3h5IGluY29ycmVjdGx5CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9TZXNzaW9uU3RhdGUuaCBiL1NvdXJjZS9XZWJL aXQvU2hhcmVkL1Nlc3Npb25TdGF0ZS5oCmluZGV4IGEzMmIyZDU1MWFhMzZkZjk0OGVkOWI3MDQx MGY4YzAzZmQ4YWNmZWYuLmE3N2UzZmM3NDNhMTIyMWFiNGM1NjhlYmE4ZjM4ZDE3ZWJiOTQ3YzMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1Nlc3Npb25TdGF0ZS5oCisrKyBiL1Nv dXJjZS9XZWJLaXQvU2hhcmVkL1Nlc3Npb25TdGF0ZS5oCkBAIC04Niw2ICs4NiwxMiBAQCBwdWJs aWM6CiAgICAgLy8gVGhlc2UgYXJlIHVzZWQgdG8gaGVscCBkZWJ1ZyA8cmRhcjovL3Byb2JsZW0v NDg2MzQ1NTM+LgogICAgIEZyYW1lU3RhdGUoKSB7IFJFTEVBU0VfQVNTRVJUKFJ1bkxvb3A6Omlz TWFpbigpKTsgfQogICAgIH5GcmFtZVN0YXRlKCkgeyBSRUxFQVNFX0FTU0VSVChSdW5Mb29wOjpp c01haW4oKSk7IH0KKworICAgIEZyYW1lU3RhdGUoY29uc3QgRnJhbWVTdGF0ZSYpID0gZGVmYXVs dDsKKyAgICBGcmFtZVN0YXRlKEZyYW1lU3RhdGUmJikgPSBkZWZhdWx0OworICAgIEZyYW1lU3Rh dGUmIG9wZXJhdG9yPShjb25zdCBGcmFtZVN0YXRlJikgPSBkZWZhdWx0OworICAgIEZyYW1lU3Rh dGUmIG9wZXJhdG9yPShGcmFtZVN0YXRlJiYpID0gZGVmYXVsdDsKKwogICAgIGNvbnN0IFZlY3Rv cjxTdHJpbmc+JiBkb2N1bWVudFN0YXRlKCkgY29uc3QgeyByZXR1cm4gbV9kb2N1bWVudFN0YXRl OyB9CiAgICAgZW51bSBjbGFzcyBTaG91bGRWYWxpZGF0ZSA6IGJvb2wgeyBObywgWWVzIH07CiAg ICAgdm9pZCBzZXREb2N1bWVudFN0YXRlKGNvbnN0IFZlY3RvcjxTdHJpbmc+JiwgU2hvdWxkVmFs aWRhdGUgPSBTaG91bGRWYWxpZGF0ZTo6Tm8pOwo= 453108 2022-02-24 09:23:32 -0800 2022-02-24 11:48:57 -0800 Patch bug-237142-20220224092331.patch text/plain 1648 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwNDM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDM4ZTQzZTcwMmZjMGRiMGFk NzVmY2ZmNmI1YjczNzZmM2ZiZmM4MTIuLjM2YTM2MDg5MDQ2MTA3ZDQ3MzY5NWZmM2ExMmRmMGU0 YzcxODY3ODcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjItMDItMjQgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBSZWdyZXNzaW9uKHIyNzM5MjkpIEZy YW1lU3RhdGUgbm8gbG9uZ2VyIGdldHMgYSBtb3ZlIGNvbnN0cnVjdG9yCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzcxNDIKKworICAgICAgICBSZXZp ZXdlZCBieSBEYXJpbiBBZGxlci4KKworICAgICAgICBGcmFtZVN0YXRlIG5vIGxvbmdlciBnZXRz IGFuIGltcGxpY2l0IG1vdmUgY29uc3RydWN0b3Igc2luY2UgcjI3MzkyOSBiZWNhdXNlIGEgY3Vz dG9tCisgICAgICAgIGRlc3RydWN0b3Igd2FzIGFkZGVkLgorCisgICAgICAgICogU2hhcmVkL1Nl c3Npb25TdGF0ZS5oOgorCiAyMDIyLTAyLTI0ICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxl LmNvbT4KIAogICAgICAgICBbQXBwbGUgUGF5XSBzd2l0Y2ggZnJvbSBgUGFzc0tpdC8qYCB0byBg UGFzc0tpdFtDb3JlLFVJXS8qYApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9TaGFyZWQvU2Vz c2lvblN0YXRlLmggYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9TZXNzaW9uU3RhdGUuaAppbmRleCBh MzJiMmQ1NTFhYTM2ZGY5NDhlZDliNzA0MTBmOGMwM2ZkOGFjZmVmLi5kNzUwNzMwNjg3MDczMmEz MDEwYzJjMTBhYjU5NGNhNzQyMDNhMTg2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1NoYXJl ZC9TZXNzaW9uU3RhdGUuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9TZXNzaW9uU3RhdGUu aApAQCAtODYsNiArODYsMTEgQEAgcHVibGljOgogICAgIC8vIFRoZXNlIGFyZSB1c2VkIHRvIGhl bHAgZGVidWcgPHJkYXI6Ly9wcm9ibGVtLzQ4NjM0NTUzPi4KICAgICBGcmFtZVN0YXRlKCkgeyBS RUxFQVNFX0FTU0VSVChSdW5Mb29wOjppc01haW4oKSk7IH0KICAgICB+RnJhbWVTdGF0ZSgpIHsg UkVMRUFTRV9BU1NFUlQoUnVuTG9vcDo6aXNNYWluKCkpOyB9CisgICAgRnJhbWVTdGF0ZShjb25z dCBGcmFtZVN0YXRlJikgPSBkZWZhdWx0OworICAgIEZyYW1lU3RhdGUoRnJhbWVTdGF0ZSYmKSA9 IGRlZmF1bHQ7CisgICAgRnJhbWVTdGF0ZSYgb3BlcmF0b3I9KGNvbnN0IEZyYW1lU3RhdGUmKSA9 IGRlZmF1bHQ7CisgICAgRnJhbWVTdGF0ZSYgb3BlcmF0b3I9KEZyYW1lU3RhdGUmJikgPSBkZWZh dWx0OworCiAgICAgY29uc3QgVmVjdG9yPFN0cmluZz4mIGRvY3VtZW50U3RhdGUoKSBjb25zdCB7 IHJldHVybiBtX2RvY3VtZW50U3RhdGU7IH0KICAgICBlbnVtIGNsYXNzIFNob3VsZFZhbGlkYXRl IDogYm9vbCB7IE5vLCBZZXMgfTsKICAgICB2b2lkIHNldERvY3VtZW50U3RhdGUoY29uc3QgVmVj dG9yPFN0cmluZz4mLCBTaG91bGRWYWxpZGF0ZSA9IFNob3VsZFZhbGlkYXRlOjpObyk7Cg==