237138 2022-02-24 08:32:59 -0800 [IFC][Integration] verticalLogicalMargin returns incorrect values for vertical-rl 2022-02-25 14:01:38 -0800 1 1 1 Unclassified WebKit Layout and Rendering Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham jonlee koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1845615 0 zalan 2022-02-24 08:32:59 -0800 ssia 1845616 1 453101 zalan 2022-02-24 08:35:39 -0800 Created attachment 453101 Patch 1845634 2 ews-feeder 2022-02-24 09:20:40 -0800 Committed r290437 (247740@main): <https://commits.webkit.org/247740@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453101. 1845636 3 webkit-bug-importer 2022-02-24 09:21:38 -0800 <rdar://problem/89422067> 1846173 4 jonlee 2022-02-25 13:52:32 -0800 Seems like this progressed fast/writing-mode/vertical-align-flexbox-baseline.html on iOS. 1846180 5 zalan 2022-02-25 14:01:38 -0800 (In reply to Jon Lee from comment #4) > Seems like this progressed > fast/writing-mode/vertical-align-flexbox-baseline.html on iOS. That's surprising since this only changed vertical-rl behavior (and the test is about writing-mode: vertical-lr;) 453101 2022-02-24 08:35:39 -0800 2022-02-24 09:20:43 -0800 Patch bug-237138-20220224083539.patch text/plain 2328 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwNDI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWVmNjcyYTJlNTBjYmUx YzYxZGFlNTMyMTllN2MwOGZjZjNjNjJjMi4uOGMyZTU5NmJiNjVjNjVjNjU5ZmE5ZDQ2NTkxMGQ4 ODQ4MDdhZWYyYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIyLTAyLTI0ICBBbGFu IEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbSUZDXVtJbnRlZ3JhdGlvbl0g dmVydGljYWxMb2dpY2FsTWFyZ2luIHJldHVybnMgaW5jb3JyZWN0IHZhbHVlcyBmb3IgdmVydGlj YWwtcmwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIz NzEzOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo aXMgd2FzIGNhdXNlZCBieSBhbiBhY2NpZGVudGFsIGNvcHkvcGFzdGUuCisKKyAgICAgICAgKiBs YXlvdXQvaW50ZWdyYXRpb24vTGF5b3V0SW50ZWdyYXRpb25MaW5lTGF5b3V0LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkxheW91dEludGVncmF0aW9uOjp2ZXJ0aWNhbExvZ2ljYWxNYXJnaW4pOiBh bHNvIHN3aXRjaCBvdmVyIHRvICJzd2l0Y2giLgorCiAyMDIyLTAyLTI0ICBBbGFuIEJ1anRhcyAg PHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbSUZDXVtJbnRlZ3JhdGlvbl0gQWRqdXN0IGhp dHRlc3QgY29vcmRzIHdoZW4gaW4gZmxpcHBlZCB3cml0aW5nIG1vZGUKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2xheW91dC9pbnRlZ3JhdGlvbi9MYXlvdXRJbnRlZ3JhdGlvbkxpbmVMYXlv dXQuY3BwIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2ludGVncmF0aW9uL0xheW91dEludGVncmF0 aW9uTGluZUxheW91dC5jcHAKaW5kZXggNmY4Mjg1NmU4ZGFjZDQ4Y2U4NmUwNmI3MTFiMDRmOWI5 NDRlZGZhMC4uMmYwNmVjOWQxZGU1ZGUwZWEzNjA1OThhY2U3YzFmYjZjYWU0ZTk3MSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2ludGVncmF0aW9uL0xheW91dEludGVncmF0aW9u TGluZUxheW91dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2ludGVncmF0aW9uL0xh eW91dEludGVncmF0aW9uTGluZUxheW91dC5jcHAKQEAgLTE3NywxNCArMTc3LDE2IEBAIHN0YXRp YyBpbmxpbmUgTGF5b3V0OjpCb3hHZW9tZXRyeTo6SG9yaXpvbnRhbE1hcmdpbiBob3Jpem9udGFs TG9naWNhbE1hcmdpbihjb25zCiAKIHN0YXRpYyBpbmxpbmUgTGF5b3V0OjpCb3hHZW9tZXRyeTo6 VmVydGljYWxNYXJnaW4gdmVydGljYWxMb2dpY2FsTWFyZ2luKGNvbnN0IFJlbmRlckJveE1vZGVs T2JqZWN0JiByZW5kZXJlciwgV3JpdGluZ01vZGUgd3JpdGluZ01vZGUpCiB7Ci0gICAgaWYgKHdy aXRpbmdNb2RlID09IFdyaXRpbmdNb2RlOjpUb3BUb0JvdHRvbSkKKyAgICBzd2l0Y2ggKHdyaXRp bmdNb2RlKSB7CisgICAgY2FzZSBXcml0aW5nTW9kZTo6VG9wVG9Cb3R0b206CiAgICAgICAgIHJl dHVybiB7IHJlbmRlcmVyLm1hcmdpblRvcCgpLCByZW5kZXJlci5tYXJnaW5Cb3R0b20oKSB9Owot ICAgIGlmICh3cml0aW5nTW9kZSA9PSBXcml0aW5nTW9kZTo6TGVmdFRvUmlnaHQpCisgICAgY2Fz ZSBXcml0aW5nTW9kZTo6TGVmdFRvUmlnaHQ6CisgICAgY2FzZSBXcml0aW5nTW9kZTo6UmlnaHRU b0xlZnQ6CiAgICAgICAgIHJldHVybiB7IHJlbmRlcmVyLm1hcmdpblJpZ2h0KCksIHJlbmRlcmVy Lm1hcmdpbkxlZnQoKSB9OwotICAgIGlmICh3cml0aW5nTW9kZSA9PSBXcml0aW5nTW9kZTo6Umln aHRUb0xlZnQpCi0gICAgICAgIHJldHVybiB7IHJlbmRlcmVyLm1hcmdpbkxlZnQoKSwgcmVuZGVy ZXIubWFyZ2luUmlnaHQoKSB9OwotICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwotICAgIHJldHVy biAgeyB9OworICAgIGRlZmF1bHQ6CisgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAg ICAgICByZXR1cm4geyByZW5kZXJlci5tYXJnaW5Ub3AoKSwgcmVuZGVyZXIubWFyZ2luQm90dG9t KCkgfTsKKyAgICB9CiB9CiAKIHN0YXRpYyBpbmxpbmUgTGF5b3V0OjpFZGdlcyBsb2dpY2FsQm9y ZGVyKGNvbnN0IFJlbmRlckJveE1vZGVsT2JqZWN0JiByZW5kZXJlciwgYm9vbCBpc0xlZnRUb1Jp Z2h0SW5saW5lRGlyZWN0aW9uLCBXcml0aW5nTW9kZSB3cml0aW5nTW9kZSwgYm9vbCByZXRhaW5C b3JkZXJTdGFydCA9IHRydWUsIGJvb2wgcmV0YWluQm9yZGVyRW5kID0gdHJ1ZSkK