237124 2022-02-23 17:29:40 -0800 [GTK] Unreviewed, fix build after r290399 2022-02-23 17:35:43 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 dpino dpino oldest_to_newest 1845449 0 dpino 2022-02-23 17:29:40 -0800 [GTK] Unreviewed, fix build after r290399 1845451 1 453057 dpino 2022-02-23 17:31:40 -0800 Created attachment 453057 [fast-cq] Patch 1845456 2 dpino 2022-02-23 17:35:12 -0800 STDIO: https://build.webkit.org/#/builders/41/builds/9656/steps/9/logs/stdio /app/webkit/Source/WebCore/page/DOMWindow.cpp: In member function ‘void WebCore::DOMWindow::showModalDialog(const WTF::String&, const WTF::String&, WebCore::DOMWindow&, WebCore::DOMWindow&, const WTF::Function<void(WebCore::DOMWindow&)>&)’: /app/webkit/Source/WebCore/page/DOMWindow.cpp:2672:5: error: ‘printWarningMessage’ was not declared in this scope; did you mean ‘printErrorMessage’? 2672 | printWarningMessage("showModalDialog() is deprecated and will be removed. Please use the <dialog> element instead."_s); | ^~~~~~~~~~~~~~~~~~~ | printErrorMessage 1845457 3 dpino 2022-02-23 17:35:43 -0800 Fixed by https://trac.webkit.org/changeset/290406/webkit 453057 2022-02-23 17:31:40 -0800 2022-02-23 17:31:40 -0800 [fast-cq] Patch bug-237124-20220224093137.patch text/plain 1660 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwNDA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGQxNGE4ZGEzZjc2NGFh N2M4Y2Q0MTUzNDU3Zjc4M2UwZWYyOWY0MS4uMDZhMjBhZDM3MzIwYzQxOTVhZDA5MjQ5ZjFjMmQ0 NDc4MDg0ZTc5NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIyLTAyLTIzICBEaWVn byBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gVW5yZXZp ZXdlZCwgZml4IGJ1aWxkIGFmdGVyIHIyOTAzOTkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNzEyNAorCisgICAgICAgIFJlbW92ZSBsZWZ0b3ZlciBj YWxsIHRvIG1pc3NpbmcgZnVuY3Rpb24gcHJpbnRXYXJuaW5nTWVzc2FnZQorCisgICAgICAgICog cGFnZS9ET01XaW5kb3cuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RE9NV2luZG93OjpzaG93TW9k YWxEaWFsb2cpOgorCiAyMDIyLTAyLTIzICBSb2JlcnQgSmVubmVyICA8SmVubmVyQGFwcGxlLmNv bT4KIAogICAgICAgICBVbnJldmlld2VkLCByZXZlcnRpbmcgcjI5MDM0OC4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv RE9NV2luZG93LmNwcAppbmRleCAzYWZmMmE1NTRlZDE5ZjU1ZjkwMmNkZWU3MjY1MzZiYzg2ZDE4 NDNkLi5mNzk1Y2E0OWIyNmIzNDY3NTMyYmUwM2ZlMDg5ZjYzMTc1MDRiYjg5IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cGFnZS9ET01XaW5kb3cuY3BwCkBAIC0yNjY5LDcgKzI2NjksOCBAQCBFeGNlcHRpb25PcjxSZWZQ dHI8V2luZG93UHJveHk+PiBET01XaW5kb3c6Om9wZW4oRE9NV2luZG93JiBhY3RpdmVXaW5kb3cs IERPTVdpbgogCiB2b2lkIERPTVdpbmRvdzo6c2hvd01vZGFsRGlhbG9nKGNvbnN0IFN0cmluZyYg dXJsU3RyaW5nLCBjb25zdCBTdHJpbmcmIGRpYWxvZ0ZlYXR1cmVzU3RyaW5nLCBET01XaW5kb3cm IGFjdGl2ZVdpbmRvdywgRE9NV2luZG93JiBmaXJzdFdpbmRvdywgY29uc3QgRnVuY3Rpb248dm9p ZChET01XaW5kb3cmKT4mIHByZXBhcmVEaWFsb2dGdW5jdGlvbikKIHsKLSAgICBwcmludFdhcm5p bmdNZXNzYWdlKCJzaG93TW9kYWxEaWFsb2coKSBpcyBkZXByZWNhdGVkIGFuZCB3aWxsIGJlIHJl bW92ZWQuIFBsZWFzZSB1c2UgdGhlIDxkaWFsb2c+IGVsZW1lbnQgaW5zdGVhZC4iX3MpOworICAg IGlmIChSZWZQdHIgZG9jdW1lbnQgPSB0aGlzLT5kb2N1bWVudCgpKQorICAgICAgICBkb2N1bWVu dC0+YWRkQ29uc29sZU1lc3NhZ2UoTWVzc2FnZVNvdXJjZTo6SlMsIE1lc3NhZ2VMZXZlbDo6V2Fy bmluZywgbWFrZVN0cmluZygic2hvd01vZGFsRGlhbG9nKCkgaXMgZGVwcmVjYXRlZCBhbmQgd2ls bCBiZSByZW1vdmVkLiBQbGVhc2UgdXNlIHRoZSA8ZGlhbG9nPiBlbGVtZW50IGluc3RlYWQuIl9z KSk7CiAKICAgICBpZiAoIWlzQ3VycmVudGx5RGlzcGxheWVkSW5GcmFtZSgpKQogICAgICAgICBy ZXR1cm47Cg==