237115 2022-02-23 14:45:32 -0800 [XCBuild] Don't automatically use the ../Internal/WebKit workspace 2022-02-23 16:48:24 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 emw emw ap webkit-bug-importer oldest_to_newest 1845331 0 emw 2022-02-23 14:45:32 -0800 When the USE_WORKSPACE=YES Make flag was added in https://commits.webkit.org/246232@main, we configured Make to automatically use the workspace at ../Internal/WebKit/WebKit.xcworkspace, if it was available. The idea was to make it easier for workspace builds to automatically detect dependencies needed by folks at Apple, like WebKitAdditions. In practice, this has made workspace builds silently rely on code from outside of the WebKit repo, and it's unintuitive since non-workspace Make builds do not do this. Perhaps we can revisit this in the future when we're fully migrated to workspace builds, but for now I propose we reverse this. 1845343 1 453034 emw 2022-02-23 15:19:53 -0800 Created attachment 453034 Patch 1845345 2 webkit-bug-importer 2022-02-23 15:20:46 -0800 <rdar://problem/89381493> 1845377 3 453034 ap 2022-02-23 15:43:23 -0800 Comment on attachment 453034 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453034&action=review High level question tangentially related to this patch: will workspace builds allow for changing a file in WebCore, and rebuilding just WebCore `make -C Source/WebCore` without linking all dependent projects? Often, engineers know that there is no API change, and relinking everything would waste time. > Makefile.shared:-9 > - $(dir $(lastword $(MAKEFILE_LIST)))../Internal/WebKit/WebKit.xcworkspace \ I'm curious why this patch touches so many files, as opposed to just removing this line. 1845384 4 emw 2022-02-23 15:52:20 -0800 (In reply to Alexey Proskuryakov from comment #3) > High level question tangentially related to this patch: will workspace > builds allow for changing a file in WebCore, and rebuilding just WebCore > `make -C Source/WebCore` without linking all dependent projects? Often, > engineers know that there is no API change, and relinking everything would > waste time. `make -C Source/WebCore` will build everything up to WebCore, so in your scenario the only thing that would be re-linked is WebCore itself. If I'm understanding correctly, that's the behavior engineers would expect. > > Makefile.shared:-9 > > - $(dir $(lastword $(MAKEFILE_LIST)))../Internal/WebKit/WebKit.xcworkspace \ > > I'm curious why this patch touches so many files, as opposed to just > removing this line. I did this so that any Makefile could set the workspace path before including `Makefile.shared`. But on second thought, I don't think that's actually necessary. Internal projects won't call into this `Makefile.shared` at all, so they are free to point to their own workspace as part of <rdar://88844770>. I'll make this change and merge w/o more review. 1845392 5 453041 emw 2022-02-23 16:00:56 -0800 Created attachment 453041 Patch 1845424 6 ews-feeder 2022-02-23 16:48:20 -0800 Committed r290400 (247712@main): <https://commits.webkit.org/247712@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453041. 453034 2022-02-23 15:19:53 -0800 2022-02-23 16:00:55 -0800 Patch bug-237115-20220223151952.patch text/plain 8481 emw U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwMzQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9DaGFuZ2VMb2cKaW5kZXggNWQxM2I5ZjQy NzI4MTE2YWExY2IxODczMzNlOTlmMWZhYWNiZDg0Zi4uNjhiZTE2ZWVjMjExYjFlN2QzNDZjZjAx YTllMGZlMGU2NjkyNTJhZSAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDIy LTAyLTIzICBFbGxpb3R0IFdpbGxpYW1zICA8ZW13QGFwcGxlLmNvbT4KKworICAgICAgICBbWENC dWlsZF0gRG9uJ3QgYXV0b21hdGljYWxseSB1c2UgdGhlIC4uL0ludGVybmFsL1dlYktpdCB3b3Jr c3BhY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIz NzExNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog TWFrZWZpbGUuc2hhcmVkOgorCiAyMDIyLTAyLTEwICBUaW0gTmd1eWVuICA8bnRpbUBhcHBsZS5j b20+CiAKICAgICAgICAgSW1wb3J0IFBERi5qcyB2Mi4xMi4zMTMgdG8gdGhlIFdlYktpdCByZXBv CmRpZmYgLS1naXQgYS9Tb3VyY2UvTWFrZWZpbGUgYi9Tb3VyY2UvTWFrZWZpbGUKaW5kZXggMDc0 ZDdlMThmNzBlNGE4NjNkMzNiMDY2ZmZkMjQ1MTIyYjkyZGRkNS4uMGY3MTU5MjM4MDljNGE2MjMy ODc4NjcwMjczNzNjZWFiMGIzZTQ5MCAxMDA2NDQKLS0tIGEvU291cmNlL01ha2VmaWxlCisrKyBi L1NvdXJjZS9NYWtlZmlsZQpAQCAtMSw1ICsxLDYgQEAKIGlmZXEgKCQoVVNFX1dPUktTUEFDRSks WUVTKQogCitXT1JLU1BBQ0VfUEFUSCA9IC4uL1dlYktpdC54Y3dvcmtzcGFjZQogaW5jbHVkZSAu Li9NYWtlZmlsZS5zaGFyZWQKIFNDSEVNRSA9IEFsbCBTb3VyY2UKIApkaWZmIC0tZ2l0IGEvU291 cmNlL01ha2VmaWxlLnNoYXJlZCBiL1NvdXJjZS9NYWtlZmlsZS5zaGFyZWQKaW5kZXggOTVlNDhk NjBhMDgyYzljM2Y5ZjZhM2NiOTBhYWYzMDczODJlMGVhYy4uOGM3MWEyNzMxY2Q1ZmY1MGU0ZTEw NmZlOGU3ZmNkNmZmNWY0NjgyNCAxMDA2NDQKLS0tIGEvU291cmNlL01ha2VmaWxlLnNoYXJlZAor KysgYi9Tb3VyY2UvTWFrZWZpbGUuc2hhcmVkCkBAIC0xLDIgKzEsMyBAQAogU0NSSVBUU19QQVRI ID89IC4uLy4uL1Rvb2xzL1NjcmlwdHMKK1dPUktTUEFDRV9QQVRIID89IC4uLy4uL1dlYktpdC54 Y3dvcmtzcGFjZQogaW5jbHVkZSAuLi8uLi9NYWtlZmlsZS5zaGFyZWQKZGlmZiAtLWdpdCBhL1Nv dXJjZS9UaGlyZFBhcnR5L01ha2VmaWxlLnNoYXJlZCBiL1NvdXJjZS9UaGlyZFBhcnR5L01ha2Vm aWxlLnNoYXJlZAppbmRleCAxYzc4NjEzZjRiMmIxM2U3YmVlOTUyZGE4Mjk3MmEzZWFmMzM5ZmI3 Li4xMzA3OWY0OWM3OWIzMjhiY2U0N2NkODE0NzgyZjYyOTVlYjc1YjI4IDEwMDY0NAotLS0gYS9T b3VyY2UvVGhpcmRQYXJ0eS9NYWtlZmlsZS5zaGFyZWQKKysrIGIvU291cmNlL1RoaXJkUGFydHkv TWFrZWZpbGUuc2hhcmVkCkBAIC0xLDIgKzEsMyBAQAogU0NSSVBUU19QQVRIID89IC4uLy4uLy4u L1Rvb2xzL1NjcmlwdHMKK1dPUktTUEFDRV9QQVRIID89IC4uLy4uLy4uL1dlYktpdC54Y3dvcmtz cGFjZQogaW5jbHVkZSAuLi8uLi8uLi9NYWtlZmlsZS5zaGFyZWQKZGlmZiAtLWdpdCBhL1Rvb2xz L0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAwMTllMWMzYzI5NmY2NzMxNWFiY2E0 ZjhmN2M5NDg3MzU0NzE2NDE2Li5lZjhjYzFlZjNlMTFlOWYxZmY0OTUyN2NhNzU5ZjM0YmVlZDAy MTIxIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTkgQEAKKzIwMjItMDItMjMgIEVsbGlvdHQgV2lsbGlhbXMgIDxlbXdAYXBwbGUu Y29tPgorCisgICAgICAgIFtYQ0J1aWxkXSBEb24ndCBhdXRvbWF0aWNhbGx5IHVzZSB0aGUgLi4v SW50ZXJuYWwvV2ViS2l0IHdvcmtzcGFjZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjM3MTE1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBDb250ZW50RXh0ZW5zaW9uVGVzdGVyL01ha2VmaWxlOgorICAg ICAgICAqIER1bXBSZW5kZXJUcmVlL01ha2VmaWxlOgorICAgICAgICAqIEltYWdlRGlmZi9NYWtl ZmlsZToKKyAgICAgICAgKiBNYWtlZmlsZToKKyAgICAgICAgKiBNaW5pQnJvd3Nlci9NYWtlZmls ZToKKyAgICAgICAgKiBNb2JpbGVNaW5pQnJvd3Nlci9NYWtlZmlsZToKKyAgICAgICAgKiBUZXN0 V2ViS2l0QVBJL01ha2VmaWxlOgorICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvTWFrZWZpbGU6 CisKIDIwMjItMDItMjIgIFJ5YW4gSGFkZGFkICA8cnlhbmhhZGRhZEBhcHBsZS5jb20+CiAKICAg ICAgICAgUkVHUkVTU0lPTihyMjg5NTgwKTogWyBpT1MgbWFjT1MgXSBUZXN0V2ViS2l0QVBJLklQ Q1Rlc3RpbmdBUEkuQ2FuUmVjZWl2ZVNoYXJlZE1lbW9yeSBpcyBhIGNvbnN0YW50IHRpbWVvdXQK ZGlmZiAtLWdpdCBhL1Rvb2xzL0NvbnRlbnRFeHRlbnNpb25UZXN0ZXIvTWFrZWZpbGUgYi9Ub29s cy9Db250ZW50RXh0ZW5zaW9uVGVzdGVyL01ha2VmaWxlCmluZGV4IDFmMWRiYmNiMzBmZDQ3NzQ4 ZGMxODcyMzYwODMzMDFmNmRkN2I2YjUuLmI1ODQzMzRkY2MyMTY5MTlhYTg0ZTc0YjEyZTA4MGEx NTkxMjVkZTQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NvbnRlbnRFeHRlbnNpb25UZXN0ZXIvTWFrZWZp bGUKKysrIGIvVG9vbHMvQ29udGVudEV4dGVuc2lvblRlc3Rlci9NYWtlZmlsZQpAQCAtMSwyICsx LDMgQEAKIFNDUklQVFNfUEFUSCA9IC4uL1NjcmlwdHMKK1dPUktTUEFDRV9QQVRIID0gLi4vLi4v V2ViS2l0Lnhjd29ya3NwYWNlCiBpbmNsdWRlIC4uLy4uL01ha2VmaWxlLnNoYXJlZApkaWZmIC0t Z2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvTWFrZWZpbGUgYi9Ub29scy9EdW1wUmVuZGVyVHJl ZS9NYWtlZmlsZQppbmRleCBlNDg5ZmM0YmY4OTEwYzBiY2FjOWEwNTJhMDI1ODUwMzUwMzg2ZTFi Li5iNTg0MzM0ZGNjMjE2OTE5YWE4NGU3NGIxMmUwODBhMTU5MTI1ZGU0IDEwMDY0NAotLS0gYS9U b29scy9EdW1wUmVuZGVyVHJlZS9NYWtlZmlsZQorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9N YWtlZmlsZQpAQCAtMSwzICsxLDMgQEAKIFNDUklQVFNfUEFUSCA9IC4uL1NjcmlwdHMKLQorV09S S1NQQUNFX1BBVEggPSAuLi8uLi9XZWJLaXQueGN3b3Jrc3BhY2UKIGluY2x1ZGUgLi4vLi4vTWFr ZWZpbGUuc2hhcmVkCmRpZmYgLS1naXQgYS9Ub29scy9JbWFnZURpZmYvTWFrZWZpbGUgYi9Ub29s cy9JbWFnZURpZmYvTWFrZWZpbGUKaW5kZXggNjA4MjI1Mzg5ODY4YjYzNmQ3Y2ZkYjdhZTIyY2Y3 NGMzNTE1YWM3ZS4uMjM3YmU5MjAyZTZjZTcwNWI1MGE4M2MwYTY4YTM5MDYwZjdhNTE1MiAxMDA2 NDQKLS0tIGEvVG9vbHMvSW1hZ2VEaWZmL01ha2VmaWxlCisrKyBiL1Rvb2xzL0ltYWdlRGlmZi9N YWtlZmlsZQpAQCAtMSw0ICsxLDUgQEAKIFNDUklQVFNfUEFUSCA9IC4uL1NjcmlwdHMKK1dPUktT UEFDRV9QQVRIID0gLi4vLi4vV2ViS2l0Lnhjd29ya3NwYWNlCiAKIFRPX0xPV0VSID0gJChzaGVs bCBlY2hvICQoMSkgfCB0ciBbOnVwcGVyOl0gWzpsb3dlcjpdKQogCmRpZmYgLS1naXQgYS9Ub29s cy9NYWtlZmlsZSBiL1Rvb2xzL01ha2VmaWxlCmluZGV4IDRjOTQxYTc5ZDgxM2M0YzM3YTdlNDZk YjUwMTgzMzIzOGE5MzQyNjQuLjFmMDY3Nzk4MzI2MmZmNjljZDcyMTE1ZGVjNTk2MjUyMGU3YmZm OTUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL01ha2VmaWxlCisrKyBiL1Rvb2xzL01ha2VmaWxlCkBAIC0x LDUgKzEsNiBAQAogaWZlcSAoJChVU0VfV09SS1NQQUNFKSxZRVMpCiAKK1dPUktTUEFDRV9QQVRI ID0gLi4vV2ViS2l0Lnhjd29ya3NwYWNlCiBpbmNsdWRlIC4uL01ha2VmaWxlLnNoYXJlZAogU0NI RU1FID0gQWxsIFRvb2xzCiAKZGlmZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93c2VyL01ha2VmaWxl IGIvVG9vbHMvTWluaUJyb3dzZXIvTWFrZWZpbGUKaW5kZXggMWYxZGJiY2IzMGZkNDc3NDhkYzE4 NzIzNjA4MzMwMWY2ZGQ3YjZiNS4uYjU4NDMzNGRjYzIxNjkxOWFhODRlNzRiMTJlMDgwYTE1OTEy NWRlNCAxMDA2NDQKLS0tIGEvVG9vbHMvTWluaUJyb3dzZXIvTWFrZWZpbGUKKysrIGIvVG9vbHMv TWluaUJyb3dzZXIvTWFrZWZpbGUKQEAgLTEsMiArMSwzIEBACiBTQ1JJUFRTX1BBVEggPSAuLi9T Y3JpcHRzCitXT1JLU1BBQ0VfUEFUSCA9IC4uLy4uL1dlYktpdC54Y3dvcmtzcGFjZQogaW5jbHVk ZSAuLi8uLi9NYWtlZmlsZS5zaGFyZWQKZGlmZiAtLWdpdCBhL1Rvb2xzL01vYmlsZU1pbmlCcm93 c2VyL01ha2VmaWxlIGIvVG9vbHMvTW9iaWxlTWluaUJyb3dzZXIvTWFrZWZpbGUKaW5kZXggN2Ew MmY1MjNiN2MzZTBjMWQyYTdkZDIzZTBkMTIyYTNhMzQ1NGYyZC4uYzExMDQ4YjU0ODEwYjI3NWU3 Y2RiYzhmMDBjMzNmYzQzZjQ0ZWFkYSAxMDA2NDQKLS0tIGEvVG9vbHMvTW9iaWxlTWluaUJyb3dz ZXIvTWFrZWZpbGUKKysrIGIvVG9vbHMvTW9iaWxlTWluaUJyb3dzZXIvTWFrZWZpbGUKQEAgLTEs NSArMSw2IEBACiAKIFNDUklQVFNfUEFUSCA9IC4uL1NjcmlwdHMKK1dPUktTUEFDRV9QQVRIID0g Li4vLi4vV2ViS2l0Lnhjd29ya3NwYWNlCiBpbmNsdWRlIC4uLy4uL01ha2VmaWxlLnNoYXJlZAog CiB0ZXN0LWlwaG9uZTogYWxsCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL01ha2Vm aWxlIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9NYWtlZmlsZQppbmRleCAxZjFkYmJjYjMwZmQ0Nzc0 OGRjMTg3MjM2MDgzMzAxZjZkZDdiNmI1Li5iNTg0MzM0ZGNjMjE2OTE5YWE4NGU3NGIxMmUwODBh MTU5MTI1ZGU0IDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL01ha2VmaWxlCisrKyBi L1Rvb2xzL1Rlc3RXZWJLaXRBUEkvTWFrZWZpbGUKQEAgLTEsMiArMSwzIEBACiBTQ1JJUFRTX1BB VEggPSAuLi9TY3JpcHRzCitXT1JLU1BBQ0VfUEFUSCA9IC4uLy4uL1dlYktpdC54Y3dvcmtzcGFj ZQogaW5jbHVkZSAuLi8uLi9NYWtlZmlsZS5zaGFyZWQKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktp dFRlc3RSdW5uZXIvTWFrZWZpbGUgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL01ha2VmaWxlCmlu ZGV4IDFmMWRiYmNiMzBmZDQ3NzQ4ZGMxODcyMzYwODMzMDFmNmRkN2I2YjUuLmI1ODQzMzRkY2My MTY5MTlhYTg0ZTc0YjEyZTA4MGExNTkxMjVkZTQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRl c3RSdW5uZXIvTWFrZWZpbGUKKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9NYWtlZmlsZQpA QCAtMSwyICsxLDMgQEAKIFNDUklQVFNfUEFUSCA9IC4uL1NjcmlwdHMKK1dPUktTUEFDRV9QQVRI ID0gLi4vLi4vV2ViS2l0Lnhjd29ya3NwYWNlCiBpbmNsdWRlIC4uLy4uL01ha2VmaWxlLnNoYXJl ZApkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IGZhZTUwN2UzZWZiYWY5 ZDI0MjhkZmU1OWVjYjgxOTFkNWFhZWZmODIuLjI4MjNjOGFhZjE4MTk2ODIzNzAzZmI4YzFjNzgx OWY3Zjg3OTMyYjQgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNCBAQAorMjAyMi0wMi0yMyAgRWxsaW90dCBXaWxsaWFtcyAgPGVtd0BhcHBsZS5jb20+ CisKKyAgICAgICAgW1hDQnVpbGRdIERvbid0IGF1dG9tYXRpY2FsbHkgdXNlIHRoZSAuLi9JbnRl cm5hbC9XZWJLaXQgd29ya3NwYWNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMzcxMTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBXaGVuIHRoZSBVU0VfV09SS1NQQUNFPVlFUyBNYWtlIGZsYWcgd2FzIGFk ZGVkIGluIGh0dHBzOi8vY29tbWl0cy53ZWJraXQub3JnLzI0NjIzMkBtYWluLCB3ZQorICAgICAg ICBjb25maWd1cmVkIE1ha2UgdG8gYXV0b21hdGljYWxseSB1c2UgdGhlIHdvcmtzcGFjZSBhdCAu Li9JbnRlcm5hbC9XZWJLaXQvV2ViS2l0Lnhjd29ya3NwYWNlLAorICAgICAgICBpZiBpdCB3YXMg YXZhaWxhYmxlLiBUaGUgaWRlYSB3YXMgdG8gbWFrZSBpdCBlYXNpZXIgZm9yIHdvcmtzcGFjZSBi dWlsZHMgdG8gYXV0b21hdGljYWxseQorICAgICAgICBkZXRlY3QgZGVwZW5kZW5jaWVzIG5lZWRl ZCBieSBmb2xrcyBhdCBBcHBsZSwgbGlrZSBXZWJLaXRBZGRpdGlvbnMuCisKKyAgICAgICAgSW4g cHJhY3RpY2UsIHRoaXMgaGFzIG1hZGUgd29ya3NwYWNlIGJ1aWxkcyBzaWxlbnRseSByZWx5IG9u IGNvZGUgZnJvbSBvdXRzaWRlIG9mIHRoZSBXZWJLaXQKKyAgICAgICAgcmVwbywgYW5kIGl0J3Mg dW5pbnR1aXRpdmUgc2luY2Ugbm9uLXdvcmtzcGFjZSBNYWtlIGJ1aWxkcyBkbyBub3QgZG8gdGhp cy4gUmVwbGFjZSB0aGlzCisgICAgICAgIGxvZ2ljIHdpdGggV09SS1NQQUNFX1BBVEggdmFyaWFi bGVzIHRoYXQgY2FuIGJlIHNldCBmcm9tIGFueSBNYWtlZmlsZSB0byBwb2ludCB0byB0aGUKKyAg ICAgICAgYXBwcm9wcmlhdGUgd29ya3NwYWNlIHRvIGJ1aWxkIHdpdGguCisKKyAgICAgICAgKiBN YWtlZmlsZS5zaGFyZWQ6CisgICAgICAgICogU291cmNlL01ha2VmaWxlOgorICAgICAgICAqIFNv dXJjZS9NYWtlZmlsZS5zaGFyZWQ6CisKIDIwMjItMDItMjIgIFBoaWxpcHBlIE5vcm1hbmQgIDxw bm9ybWFuZEBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHU3RyZWFtZXJdIEluaXRpYWwgTWVkaWFS ZWNvcmRlciBpbXBsZW1lbnRhdGlvbgpkaWZmIC0tZ2l0IGEvTWFrZWZpbGUgYi9NYWtlZmlsZQpp bmRleCA0ZjRhM2I2NThlYWM1ZTJjNGM5Mjc2MDQyNGJkY2QwMGNhYmFhYjZjLi5kNDMwMjZlYmE2 ZmYzYTE4MWVmYmUzZmNhMzUwYzdmMDIzMzZjM2E0IDEwMDY0NAotLS0gYS9NYWtlZmlsZQorKysg Yi9NYWtlZmlsZQpAQCAtMiw2ICsyLDcgQEAgaWZlcSAoJChVU0VfV09SS1NQQUNFKSxZRVMpCiAK IFNDSEVNRSA9IEFsbCBNb2R1bGVzCiBTQ1JJUFRTX1BBVEggPSBUb29scy9TY3JpcHRzCitXT1JL U1BBQ0VfUEFUSCA9IFdlYktpdC54Y3dvcmtzcGFjZQogaW5jbHVkZSBNYWtlZmlsZS5zaGFyZWQK IAogZWxzZQpkaWZmIC0tZ2l0IGEvTWFrZWZpbGUuc2hhcmVkIGIvTWFrZWZpbGUuc2hhcmVkCmlu ZGV4IDUwYzExZDMwM2QyMmRiZjg1YjIzYWYxMGFiZjhmY2M2NzBjMWQ0MDguLjdiNmMzMzQzNGE2 Y2JlMjI1NzMyMGQ4MDI1OTMxNTU5MDRiMDZjMDYgMTAwNjQ0Ci0tLSBhL01ha2VmaWxlLnNoYXJl ZAorKysgYi9NYWtlZmlsZS5zaGFyZWQKQEAgLTEsMTQgKzEsMTEgQEAKIFNDUklQVFNfUEFUSCA/ PSAuLi9Ub29scy9TY3JpcHRzCitXT1JLU1BBQ0VfUEFUSCA/PSAuLi9XZWJLaXQueGN3b3Jrc3Bh Y2UKIAogWENPREVfT1BUSU9OUyA9IGBwZXJsIC1JJChTQ1JJUFRTX1BBVEgpIC1Nd2Via2l0ZGly cyAtZSAncHJpbnQgWGNvZGVPcHRpb25TdHJpbmcoKScgLS0gJChCVUlMRF9XRUJLSVRfT1BUSU9O UylgICQke0NPTE9SX0RJQUdOT1NUSUNTX0FSR30gJChBUkdTKQogCiBpZmVxICgkKFVTRV9XT1JL U1BBQ0UpLFlFUykKIFNDSEVNRSA/PSAkKG5vdGRpciAkKENVUkRJUikpCiBYQ09ERV9UQVJHRVQg PSAtc2NoZW1lICIkKFNDSEVNRSkiCi1XT1JLU1BBQ0UgOj0gJChmaXJzdHdvcmQgJCh3aWxkY2Fy ZCBcCi0JJChkaXIgJChsYXN0d29yZCAkKE1BS0VGSUxFX0xJU1QpKSkuLi9JbnRlcm5hbC9XZWJL aXQvV2ViS2l0Lnhjd29ya3NwYWNlIFwKLQkkKGRpciAkKGxhc3R3b3JkICQoTUFLRUZJTEVfTElT VCkpKVdlYktpdC54Y3dvcmtzcGFjZSBcCi0JKSkKIGVsc2UKIFNDSEVNRSA9CiBlbmRpZgpAQCAt MTE1LDkgKzExMiw5IEBAIGRlZmluZSBpbnZva2VfeGNvZGUKIAkoIFwKIAkJW1sgLXQgMSBdXSAm JiBDT0xPUl9ESUFHTk9TVElDU19BUkc9IkNPTE9SX0RJQUdOT1NUSUNTPVlFUyI7IFwKIAkJZWNo bzsgXAotCQllY2hvICI9PT09PSBCVUlMRElORyAkKGlmICQoV09SS1NQQUNFKSwkKFNDSEVNRSks JChub3RkaXIgJChDVVJESVIpKSkgPT09PT0iOyBcCisJCWVjaG8gIj09PT09IEJVSUxESU5HICQo aWYgJChXT1JLU1BBQ0VfUEFUSCksJChTQ0hFTUUpLCQobm90ZGlyICQoQ1VSRElSKSkpID09PT09 IjsgXAogCQllY2hvOyBcCi0JCSQxIHhjb2RlYnVpbGQgJDIgJChXT1JLU1BBQ0U6JT0td29ya3Nw YWNlICUpICQoT1RIRVJfT1BUSU9OUykgJChYQ09ERV9UQVJHRVQpICQoWENPREVfT1BUSU9OUykg JDMgfCAkKE9VVFBVVF9GSUxURVIpICYmIGV4aXQgJCR7UElQRVNUQVRVU1swXX0gXAorCQkkMSB4 Y29kZWJ1aWxkICQyICQoV09SS1NQQUNFX1BBVEg6JT0td29ya3NwYWNlICUpICQoT1RIRVJfT1BU SU9OUykgJChYQ09ERV9UQVJHRVQpICQoWENPREVfT1BUSU9OUykgJDMgfCAkKE9VVFBVVF9GSUxU RVIpICYmIGV4aXQgJCR7UElQRVNUQVRVU1swXX0gXAogCSkKIGVuZGVmCiAK 453041 2022-02-23 16:00:56 -0800 2022-02-23 16:48:22 -0800 Patch bug-237115-20220223160056.patch text/plain 1799 emw U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwMzQ2CmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFu Z2VMb2cKaW5kZXggZmFlNTA3ZTNlZmJhZjlkMjQyOGRmZTU5ZWNiODE5MWQ1YWFlZmY4Mi4uYWQz Y2I2NzE2ZjFlMzRiZGViNzcxNzg0NDExMDQ5M2I4ZDlkMTI0ZiAxMDA2NDQKLS0tIGEvQ2hhbmdl TG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIyLTAyLTIzICBFbGxpb3R0 IFdpbGxpYW1zICA8ZW13QGFwcGxlLmNvbT4KKworICAgICAgICBbWENCdWlsZF0gRG9uJ3QgYXV0 b21hdGljYWxseSB1c2UgdGhlIC4uL0ludGVybmFsL1dlYktpdCB3b3Jrc3BhY2UKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNzExNQorCisgICAgICAg IFJldmlld2VkIGJ5IEFsZXhleSBQcm9za3VyeWFrb3YuCisKKyAgICAgICAgV2hlbiB0aGUgVVNF X1dPUktTUEFDRT1ZRVMgTWFrZSBmbGFnIHdhcyBhZGRlZCBpbiBodHRwczovL2NvbW1pdHMud2Vi a2l0Lm9yZy8yNDYyMzJAbWFpbiwgd2UKKyAgICAgICAgY29uZmlndXJlZCBNYWtlIHRvIGF1dG9t YXRpY2FsbHkgdXNlIHRoZSB3b3Jrc3BhY2UgYXQgLi4vSW50ZXJuYWwvV2ViS2l0L1dlYktpdC54 Y3dvcmtzcGFjZSwKKyAgICAgICAgaWYgaXQgd2FzIGF2YWlsYWJsZS4gVGhlIGlkZWEgd2FzIHRv IG1ha2UgaXQgZWFzaWVyIGZvciB3b3Jrc3BhY2UgYnVpbGRzIHRvIGF1dG9tYXRpY2FsbHkKKyAg ICAgICAgZGV0ZWN0IGRlcGVuZGVuY2llcyBuZWVkZWQgYnkgZm9sa3MgYXQgQXBwbGUsIGxpa2Ug V2ViS2l0QWRkaXRpb25zLgorCisgICAgICAgIEluIHByYWN0aWNlLCB0aGlzIGhhcyBtYWRlIHdv cmtzcGFjZSBidWlsZHMgc2lsZW50bHkgcmVseSBvbiBjb2RlIGZyb20gb3V0c2lkZSBvZiB0aGUg V2ViS2l0CisgICAgICAgIHJlcG8sIGFuZCBpdCdzIHVuaW50dWl0aXZlIHNpbmNlIG5vbi13b3Jr c3BhY2UgTWFrZSBidWlsZHMgZG8gbm90IGRvIHRoaXMuCisKKyAgICAgICAgKiBNYWtlZmlsZS5z aGFyZWQ6CisKIDIwMjItMDItMjIgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEu Y29tPgogCiAgICAgICAgIFtHU3RyZWFtZXJdIEluaXRpYWwgTWVkaWFSZWNvcmRlciBpbXBsZW1l bnRhdGlvbgpkaWZmIC0tZ2l0IGEvTWFrZWZpbGUuc2hhcmVkIGIvTWFrZWZpbGUuc2hhcmVkCmlu ZGV4IDUwYzExZDMwM2QyMmRiZjg1YjIzYWYxMGFiZjhmY2M2NzBjMWQ0MDguLjdkZjVkYmMwY2U2 NjFhYWRkZGNmYjU1NGNkNzYxOTE4OWY4OGYzZTAgMTAwNjQ0Ci0tLSBhL01ha2VmaWxlLnNoYXJl ZAorKysgYi9NYWtlZmlsZS5zaGFyZWQKQEAgLTUsMTAgKzUsNyBAQCBYQ09ERV9PUFRJT05TID0g YHBlcmwgLUkkKFNDUklQVFNfUEFUSCkgLU13ZWJraXRkaXJzIC1lICdwcmludCBYY29kZU9wdGlv blN0cmluZwogaWZlcSAoJChVU0VfV09SS1NQQUNFKSxZRVMpCiBTQ0hFTUUgPz0gJChub3RkaXIg JChDVVJESVIpKQogWENPREVfVEFSR0VUID0gLXNjaGVtZSAiJChTQ0hFTUUpIgotV09SS1NQQUNF IDo9ICQoZmlyc3R3b3JkICQod2lsZGNhcmQgXAotCSQoZGlyICQobGFzdHdvcmQgJChNQUtFRklM RV9MSVNUKSkpLi4vSW50ZXJuYWwvV2ViS2l0L1dlYktpdC54Y3dvcmtzcGFjZSBcCi0JJChkaXIg JChsYXN0d29yZCAkKE1BS0VGSUxFX0xJU1QpKSlXZWJLaXQueGN3b3Jrc3BhY2UgXAotCSkpCitX T1JLU1BBQ0UgOj0gJChkaXIgJChsYXN0d29yZCAkKE1BS0VGSUxFX0xJU1QpKSlXZWJLaXQueGN3 b3Jrc3BhY2UKIGVsc2UKIFNDSEVNRSA9CiBlbmRpZgo=