237090 2022-02-23 09:38:18 -0800 [IFC][Integration] LineLayout::firstLinePhysicalBaseline/lastLineLogicalBaseline should flip box baseline value for vertical-lr 2022-02-23 12:54:44 -0800 1 1 1 Unclassified WebKit Layout and Rendering Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1845175 0 zalan 2022-02-23 09:38:18 -0800 ssia 1845177 1 452992 zalan 2022-02-23 09:39:29 -0800 Created attachment 452992 Patch 1845182 2 452992 koivisto 2022-02-23 09:46:14 -0800 Comment on attachment 452992 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452992&action=review > Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp:466 > + switch (rootLayoutBox().style().writingMode()) { > + case WritingMode::TopToBottom: wonder if the switch could be usefully shared between first/last cases? 1845186 3 zalan 2022-02-23 09:53:26 -0800 (In reply to Antti Koivisto from comment #2) > Comment on attachment 452992 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=452992&action=review > > > Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp:466 > > + switch (rootLayoutBox().style().writingMode()) { > > + case WritingMode::TopToBottom: > > wonder if the switch could be usefully shared between first/last cases? I'd rather not mix logical and physical translates (the first baseline API returns physical while the last baseline API returns logical baseline value) 1845267 4 ews-feeder 2022-02-23 12:35:21 -0800 Committed r290388 (247703@main): <https://commits.webkit.org/247703@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452992. 1845268 5 webkit-bug-importer 2022-02-23 12:36:16 -0800 <rdar://problem/89372080> 452992 2022-02-23 09:39:29 -0800 2022-02-23 12:54:44 -0800 Patch bug-237090-20220223093928.patch text/plain 4354 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwMzc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWU4MmE5YTU3YmY5OGMy ZmY1ZWFmNjZhZTk0OWI3M2FmMzU4NTU2MS4uM2U5NjIxZDJkYzljNTMwMDJhMjk4YjRiM2JlYjc3 MjRmYTMzMjQxMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIyLTAyLTIzICBBbGFu IEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbSUZDXVtJbnRlZ3JhdGlvbl0g TGluZUxheW91dDo6Zmlyc3RMaW5lUGh5c2ljYWxCYXNlbGluZS9sYXN0TGluZUxvZ2ljYWxCYXNl bGluZSBzaG91bGQgZmxpcCBib3ggYmFzZWxpbmUgdmFsdWUgZm9yIHZlcnRpY2FsLWxyCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzcwOTAKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGxheW91dC9pbnRl Z3JhdGlvbi9MYXlvdXRJbnRlZ3JhdGlvbkxpbmVMYXlvdXQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6TGF5b3V0SW50ZWdyYXRpb246OkxpbmVMYXlvdXQ6OmZpcnN0TGluZVBoeXNpY2FsQmFzZWxp bmUgY29uc3QpOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0SW50ZWdyYXRpb246OkxpbmVMYXlv dXQ6Omxhc3RMaW5lTG9naWNhbEJhc2VsaW5lIGNvbnN0KToKKyAgICAgICAgKFdlYkNvcmU6Okxh eW91dEludGVncmF0aW9uOjpMaW5lTGF5b3V0OjpmaXJzdElubGluZUJveFJlY3QgY29uc3QpOgor CiAyMDIyLTAyLTIzICBBbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBb SUZDXVtJbnRlZ3JhdGlvbl0gTGluZUxheW91dDo6Zmlyc3RJbmxpbmVCb3hSZWN0IHNob3VsZCBm bGlwIHRoZSByZWN0IGNvb3JkaW5hdGVzIGZvciB2ZXJ0aWNhbC1ybApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvbGF5b3V0L2ludGVncmF0aW9uL0xheW91dEludGVncmF0aW9uTGluZUxheW91 dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW50ZWdyYXRpb24vTGF5b3V0SW50ZWdyYXRp b25MaW5lTGF5b3V0LmNwcAppbmRleCAwNjgwYWQ2ZTk1YjNmZjViMTBiNTYwMzQwN2YyNjIxMGIy MjkzZGY1Li43NGMyOTc5ZDZmMTEzZWYzNGI0Y2UxMGI3ZjhlZDk1ZGVhMjY4YTU5IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW50ZWdyYXRpb24vTGF5b3V0SW50ZWdyYXRpb25M aW5lTGF5b3V0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW50ZWdyYXRpb24vTGF5 b3V0SW50ZWdyYXRpb25MaW5lTGF5b3V0LmNwcApAQCAtNDQxLDEwICs0NDEsMTcgQEAgTGF5b3V0 VW5pdCBMaW5lTGF5b3V0OjpmaXJzdExpbmVQaHlzaWNhbEJhc2VsaW5lKCkgY29uc3QKICAgICB9 CiAKICAgICBhdXRvJiBmaXJzdExpbmUgPSBtX2lubGluZUNvbnRlbnQtPmxpbmVzLmZpcnN0KCk7 Ci0gICAgaWYgKHJvb3RMYXlvdXRCb3goKS5zdHlsZSgpLmlzSG9yaXpvbnRhbFdyaXRpbmdNb2Rl KCkpCisgICAgc3dpdGNoIChyb290TGF5b3V0Qm94KCkuc3R5bGUoKS53cml0aW5nTW9kZSgpKSB7 CisgICAgY2FzZSBXcml0aW5nTW9kZTo6VG9wVG9Cb3R0b206CiAgICAgICAgIHJldHVybiBMYXlv dXRVbml0IHsgZmlyc3RMaW5lLmxpbmVCb3hUb3AoKSArIGZpcnN0TGluZS5iYXNlbGluZSgpIH07 Ci0KLSAgICByZXR1cm4gTGF5b3V0VW5pdCB7IGZpcnN0TGluZS5saW5lQm94TGVmdCgpICsgKGZp cnN0TGluZS5saW5lQm94V2lkdGgoKSAtIGZpcnN0TGluZS5iYXNlbGluZSgpKSB9OworICAgIGNh c2UgV3JpdGluZ01vZGU6OkxlZnRUb1JpZ2h0OgorICAgICAgICByZXR1cm4gTGF5b3V0VW5pdCB7 IGZpcnN0TGluZS5saW5lQm94TGVmdCgpICsgKGZpcnN0TGluZS5saW5lQm94V2lkdGgoKSAtIGZp cnN0TGluZS5iYXNlbGluZSgpKSB9OworICAgIGNhc2UgV3JpdGluZ01vZGU6OlJpZ2h0VG9MZWZ0 OgorICAgICAgICByZXR1cm4gTGF5b3V0VW5pdCB7IGZpcnN0TGluZS5saW5lQm94TGVmdCgpICsg Zmlyc3RMaW5lLmJhc2VsaW5lKCkgfTsKKyAgICBkZWZhdWx0OgorICAgICAgICBBU1NFUlRfTk9U X1JFQUNIRUQoKTsKKyAgICAgICAgcmV0dXJuIHsgfTsKKyAgICB9CiB9CiAKIExheW91dFVuaXQg TGluZUxheW91dDo6bGFzdExpbmVMb2dpY2FsQmFzZWxpbmUoKSBjb25zdApAQCAtNDU1LDE1ICs0 NjIsMjMgQEAgTGF5b3V0VW5pdCBMaW5lTGF5b3V0OjpsYXN0TGluZUxvZ2ljYWxCYXNlbGluZSgp IGNvbnN0CiAgICAgfQogCiAgICAgYXV0byYgbGFzdExpbmUgPSBtX2lubGluZUNvbnRlbnQtPmxp bmVzLmxhc3QoKTsKLSAgICBpZiAocm9vdExheW91dEJveCgpLnN0eWxlKCkuaXNIb3Jpem9udGFs V3JpdGluZ01vZGUoKSkKKyAgICBzd2l0Y2ggKHJvb3RMYXlvdXRCb3goKS5zdHlsZSgpLndyaXRp bmdNb2RlKCkpIHsKKyAgICBjYXNlIFdyaXRpbmdNb2RlOjpUb3BUb0JvdHRvbToKICAgICAgICAg cmV0dXJuIExheW91dFVuaXQgeyBsYXN0TGluZS5saW5lQm94VG9wKCkgKyBsYXN0TGluZS5iYXNl bGluZSgpIH07CisgICAgY2FzZSBXcml0aW5nTW9kZTo6TGVmdFRvUmlnaHQ6IHsKKyAgICAgICAg Ly8gRklYTUU6IFdlIHNob3VsZCBzZXQgdGhlIGNvbXB1dGVkIGhlaWdodCBvbiB0aGUgcm9vdCdz IGJveCBnZW9tZXRyeSAoaW4gUmVuZGVyQmxvY2tGbG93KSBzbyB0aGF0CisgICAgICAgIC8vIHdl IGNvdWxkIGNhbGwgbV9sYXlvdXRTdGF0ZS5nZW9tZXRyeUZvclJvb3RCb3goKS5ib3JkZXJCb3hI ZWlnaHQoKSBpbnN0ZWFkLgogCi0gICAgLy8gRklYTUU6IFdlIHNob3VsZCBzZXQgdGhlIGNvbXB1 dGVkIGhlaWdodCBvbiB0aGUgcm9vdCdzIGJveCBnZW9tZXRyeSAoaW4gUmVuZGVyQmxvY2tGbG93 KSBzbyB0aGF0Ci0gICAgLy8gd2UgY291bGQgY2FsbCBtX2xheW91dFN0YXRlLmdlb21ldHJ5Rm9y Um9vdEJveCgpLmJvcmRlckJveEhlaWdodCgpIGluc3RlYWQuCi0KLSAgICAvLyBMaW5lIGlzIGFs d2F5cyB2aXN1YWwgY29vcmRpbmF0ZXMgd2hpbGUgbG9naWNhbEhlaWdodCBpcyBub3QgKGkuZS4g dGhpcyB0cmFuc2xhdGUgdG8gImJveCB2aXN1YWwgd2lkdGgiIC0gImxpbmUgdmlzdWFsIHJpZ2h0 IikKLSAgICBhdXRvIGxpbmVMb2dpY2FsVG9wID0gZmxvdygpLmxvZ2ljYWxIZWlnaHQoKSAtIGxh c3RMaW5lLmxpbmVCb3hSaWdodCgpOwotICAgIHJldHVybiBMYXlvdXRVbml0IHsgbGluZUxvZ2lj YWxUb3AgKyBsYXN0TGluZS5iYXNlbGluZSgpIH07CisgICAgICAgIC8vIExpbmUgaXMgYWx3YXlz IHZpc3VhbCBjb29yZGluYXRlcyB3aGlsZSBsb2dpY2FsSGVpZ2h0IGlzIG5vdCAoaS5lLiB0aGlz IHRyYW5zbGF0ZSB0byAiYm94IHZpc3VhbCB3aWR0aCIgLSAibGluZSB2aXN1YWwgcmlnaHQiKQor ICAgICAgICBhdXRvIGxpbmVMb2dpY2FsVG9wID0gZmxvdygpLmxvZ2ljYWxIZWlnaHQoKSAtIGxh c3RMaW5lLmxpbmVCb3hSaWdodCgpOworICAgICAgICByZXR1cm4gTGF5b3V0VW5pdCB7IGxpbmVM b2dpY2FsVG9wICsgbGFzdExpbmUuYmFzZWxpbmUoKSB9OworICAgIH0KKyAgICBjYXNlIFdyaXRp bmdNb2RlOjpSaWdodFRvTGVmdDoKKyAgICAgICAgcmV0dXJuIExheW91dFVuaXQgeyBsYXN0TGlu ZS5saW5lQm94TGVmdCgpICsgbGFzdExpbmUuYmFzZWxpbmUoKSB9OworICAgIGRlZmF1bHQ6Cisg ICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgICAgICByZXR1cm4geyB9OworICAgIH0K IH0KIAogdm9pZCBMaW5lTGF5b3V0OjphZGp1c3RGb3JQYWdpbmF0aW9uKCkKQEAgLTU3Miw3ICs1 ODcsNyBAQCBMYXlvdXRSZWN0IExpbmVMYXlvdXQ6OmZpcnN0SW5saW5lQm94UmVjdChjb25zdCBS ZW5kZXJJbmxpbmUmIHJlbmRlcklubGluZSkgY29ucwogICAgIC8vIEZJWE1FOiBXZSBzaG91bGQg YmUgYWJsZSB0byBmbGlwIHRoZSBkaXNwbGF5IGJveGVzIHNvb24gYWZ0ZXIgdGhlIHJvb3QgYmxv Y2sKICAgICAvLyBpcyBmaW5pc2hlZCBzaXppbmcgaW4gb25lIGdvLgogICAgIGF1dG8gZmlyc3RC b3hSZWN0ID0gTGF5b3V0Ojp0b0xheW91dFJlY3QoZmlyc3RCb3gtPnJlY3QoKSk7Ci0gICAgc3dp dGNoIChmbG93KCkuc3R5bGUoKS53cml0aW5nTW9kZSgpKSB7CisgICAgc3dpdGNoIChyb290TGF5 b3V0Qm94KCkuc3R5bGUoKS53cml0aW5nTW9kZSgpKSB7CiAgICAgY2FzZSBXcml0aW5nTW9kZTo6 VG9wVG9Cb3R0b206CiAgICAgY2FzZSBXcml0aW5nTW9kZTo6TGVmdFRvUmlnaHQ6CiAgICAgICAg IHJldHVybiBmaXJzdEJveFJlY3Q7Cg==