237086 2022-02-23 07:47:52 -0800 webrtc/video-replace-muted-track.html is unnecessary long to run 2022-02-24 04:31:23 -0800 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf darin eric.carlson ews-watchlist glenn jer.noble peng.liu6 philipj sergio webkit-bug-importer youennf oldest_to_newest 1845136 0 youennf 2022-02-23 07:47:52 -0800 webrtc/video-replace-muted-track.html is unnecessary long to run 1845137 1 452980 youennf 2022-02-23 07:51:17 -0800 Created attachment 452980 Patch 1845212 2 452980 peng.liu6 2022-02-23 10:28:58 -0800 Comment on attachment 452980 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452980&action=review > LayoutTests/webrtc/video-replace-muted-track.html:47 > + return checkVideoBlack(true, canvas, video, "Check we do not receive any black frame", 360).then(assert_unreached, () => { }); To be honest, I was confused by the change at the beginning. Because you change 40 -> 360 here, which is not consistent with the change log. But I got your point after reading the source code. :-) 1845218 3 youennf 2022-02-23 10:37:09 -0800 I should probably use a decrementing counter to make it easier to understand. I'll update the patch tomorrow if it is not changing a lot of tests. 1845285 4 452980 darin 2022-02-23 13:03:33 -0800 Comment on attachment 452980 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452980&action=review > LayoutTests/ChangeLog:11 > + We were waiting for 360 iterations to validate no black frame is found. > + This makes it last around 20 seconds. > + Decrease the number of iterations to 40, around 2 seconds. I see Peng’s comment but I do not understand: Why does this change log comment say the opposite of what the change is? 1845315 5 452980 peng.liu6 2022-02-23 14:22:21 -0800 Comment on attachment 452980 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452980&action=review >> LayoutTests/ChangeLog:11 >> + Decrease the number of iterations to 40, around 2 seconds. > > I see Peng’s comment but I do not understand: Why does this change log comment say the opposite of what the change is? The checkVideoBlack() function is below: ``` async function checkVideoBlack(expected, canvas, video, errorMessage, counter) { if (isVideoBlack(canvas, video) === expected) return Promise.resolve(); if (counter === undefined) counter = 0; if (counter > 400) { if (!errorMessage) errorMessage = "checkVideoBlack timed out expecting " + expected; return Promise.reject(errorMessage); } await waitFor(50); return checkVideoBlack(expected, canvas, video, errorMessage, ++counter); } ``` So the iteration number is changed from (400-40) -> (400 - 360). 1845552 6 453084 youennf 2022-02-24 01:28:40 -0800 Created attachment 453084 Patch for landing 1845578 7 ews-feeder 2022-02-24 04:30:41 -0800 Committed r290425 (247733@main): <https://commits.webkit.org/247733@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453084. 1845579 8 webkit-bug-importer 2022-02-24 04:31:23 -0800 <rdar://problem/89411461> 452980 2022-02-23 07:51:17 -0800 2022-02-24 01:28:34 -0800 Patch bug-237086-20220223165115.patch text/plain 1667 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwMzY2CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNWZjOGYzMmE4OGM4NWI3MDZmYmNh ZGE5YWNjNmQ1ZjZlODMxYjM4MC4uZjE5M2I5MmE4NGRhMGQ5MTEyY2FlOTAwN2IyZWJjZGIxMjI3 Yzk4NiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIyLTAyLTIzICBZb3Vlbm4gRmFibGV0ICA8 eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICB3ZWJydGMvdmlkZW8tcmVwbGFjZS1tdXRlZC10 cmFjay5odG1sIGlzIHVubmVjZXNzYXJ5IGxvbmcgdG8gcnVuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzcwODYKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHdlYnJ0Yy92aWRlby1yZXBsYWNlLW11dGVk LXRyYWNrLmh0bWw6CisgICAgICAgIFdlIHdlcmUgd2FpdGluZyBmb3IgMzYwIGl0ZXJhdGlvbnMg dG8gdmFsaWRhdGUgbm8gYmxhY2sgZnJhbWUgaXMgZm91bmQuCisgICAgICAgIFRoaXMgbWFrZXMg aXQgbGFzdCBhcm91bmQgMjAgc2Vjb25kcy4KKyAgICAgICAgRGVjcmVhc2UgdGhlIG51bWJlciBv ZiBpdGVyYXRpb25zIHRvIDQwLCBhcm91bmQgMiBzZWNvbmRzLgorCiAyMDIyLTAyLTIzICBBbGVq YW5kcm8gRy4gQ2FzdHJvICA8YWxleEBpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQg dGVzdCBnYXJkZW5pbmcuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy93ZWJydGMvdmlkZW8tcmVw bGFjZS1tdXRlZC10cmFjay5odG1sIGIvTGF5b3V0VGVzdHMvd2VicnRjL3ZpZGVvLXJlcGxhY2Ut bXV0ZWQtdHJhY2suaHRtbAppbmRleCBlMzU3YmZlY2E3MGU0YWEzYTA3MGJhN2Y4MGIyZjdiODQz MjFjOTZjLi5hN2U0OGIzYWZhMDgyZDBlYjNjMzFlZjE4NTkyOGVmZjkyMGM2ZjUwIDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy93ZWJydGMvdmlkZW8tcmVwbGFjZS1tdXRlZC10cmFjay5odG1sCisr KyBiL0xheW91dFRlc3RzL3dlYnJ0Yy92aWRlby1yZXBsYWNlLW11dGVkLXRyYWNrLmh0bWwKQEAg LTQ0LDcgKzQ0LDcgQEAgcHJvbWlzZV90ZXN0KCh0ZXN0KSA9PiB7CiAgICAgfSkudGhlbigoKSA9 PiB7CiAgICAgICAgIHJldHVybiBjaGVja1ZpZGVvQmxhY2soZmFsc2UsIGNhbnZhcywgdmlkZW8s ICJDaGVjayB3ZSByZWNlaXZlIHNvbWUgbm9uIGJsYWNrIGZyYW1lcyIpOwogICAgIH0pLnRoZW4o KCkgPT4gewotICAgICAgICByZXR1cm4gY2hlY2tWaWRlb0JsYWNrKHRydWUsIGNhbnZhcywgdmlk ZW8sICJDaGVjayB3ZSBkbyBub3QgcmVjZWl2ZSBhbnkgYmxhY2sgZnJhbWUiLCA0MCkudGhlbihh c3NlcnRfdW5yZWFjaGVkLCAoKSA9PiB7IH0pOworICAgICAgICByZXR1cm4gY2hlY2tWaWRlb0Js YWNrKHRydWUsIGNhbnZhcywgdmlkZW8sICJDaGVjayB3ZSBkbyBub3QgcmVjZWl2ZSBhbnkgYmxh Y2sgZnJhbWUiLCAzNjApLnRoZW4oYXNzZXJ0X3VucmVhY2hlZCwgKCkgPT4geyB9KTsKICAgICB9 KTsKIH0sICJTd2l0Y2hpbmcgZnJvbSBkaXNhYmxlZCB0byBlbmFibGVkIHRyYWNrIik7CiAgICAg ICAgIDwvc2NyaXB0Pgo= 453084 2022-02-24 01:28:40 -0800 2022-02-24 04:30:43 -0800 Patch for landing bug-237086-20220224102838.patch text/plain 2921 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwMzY2CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggODI3NzYxYmExNjMzNGIzYTZmOGYx MGY1ZjIxODVkZDM2NThmYzljNS4uOTVjNDk4Y2ZjOTVhNzE0OTM4MmIwZGM1YTEzMzg1ZTJjNDhj ZWY4MSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIyLTAyLTI0ICBZb3Vlbm4gRmFibGV0ICA8 eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICB3ZWJydGMvdmlkZW8tcmVwbGFjZS1tdXRlZC10 cmFjay5odG1sIGlzIHVubmVjZXNzYXJ5IGxvbmcgdG8gcnVuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzcwODYKKworICAgICAgICBSZXZpZXdlZCBi eSBQZW5nIExpdS4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zOiBV bmZsYWtlIHRlc3Qgc2luY2UgaXQgaXMgbm8gbG9uZ2VyIGZsYWt5IGluIGJvdHMuCisgICAgICAg ICogd2VicnRjL3JvdXRpbmVzLmpzOgorICAgICAgICBXZSB3ZXJlIHdhaXRpbmcgZm9yIDM2MCBp dGVyYXRpb25zIHRvIHZhbGlkYXRlIG5vIGJsYWNrIGZyYW1lIGlzIGZvdW5kIGluIHdlYnJ0Yy9y b3V0aW5lcy5qcy4KKyAgICAgICAgVGhpcyBtYWtlcyBpdCBsYXN0IGFyb3VuZCAyMCBzZWNvbmRz LgorICAgICAgICBEZWNyZWFzZSB0aGUgbnVtYmVyIG9mIGl0ZXJhdGlvbnMgdG8gNDAsIGFyb3Vu ZCAyIHNlY29uZHMgYnkgZGVjcmVtZW50aW5nIGNvdW50ZXIgZnJvbSBwcm92aWRlZCB2YWx1ZQor ICAgICAgICBpbnN0ZWFkIG9mIGluY3JlbWVudGluZyB2YWx1ZSB1cCB0byA0MDAuCisKIDIwMjIt MDItMjQgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIE5vbi1z aW1wbGUgQ09SUyBwcmVmbGlnaHQgZmFpbHMgZHVlIHRvIGNhY2hlLWNvbnRyb2wgaGVhZGVyCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucyBiL0xh eW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCmluZGV4IGQ1NDgxZDQwOTA0 YTgxN2IzMThmYzExMGM1NTk2NTAzNGYwMDIwMTAuLmZjNzJhMWYwMGVhZWJmODY3ODA1MzNjMmRk YTBmNmU3ZmI2ZTIyZjYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0 RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRp b25zCkBAIC0yMTkzLDggKzIxOTMsNiBAQCB3ZWJraXQub3JnL2IvMjI1NDI1IFsgRGVidWcgXSB3 ZWJnbC8xLjAuMy9jb25mb3JtYW5jZS9nbHNsL21pc2MvZXhwcmVzc2lvbi1saXN0LQogIyBTZWUg aHR0cHM6Ly93ZWJraXQub3JnL2IvMTIwMDgxIGZvciB3aHkgdGhpcyBpcyBvbmUgZXhwZWN0YXRp b24uCiB3ZWJraXQub3JnL2IvMjI1NTIzIHdlYnJ0Yy9kaXJlY3Rpb24tY2hhbmdlLmh0bWwgWyBQ YXNzIFRpbWVvdXQgRmFpbHVyZSBdCiAKLXdlYmtpdC5vcmcvYi8yMjUyNSB3ZWJydGMvdmlkZW8t cmVwbGFjZS1tdXRlZC10cmFjay5odG1sIFsgUGFzcyBGYWlsdXJlIF0KLQogd2Via2l0Lm9yZy9i LzIyNTUyOCBbIGFybTY0IF0gaHR0cC93cHQvZmV0Y2gvZmV0Y2gtcmVzcG9uc2UtYm9keS1zdG9w LWluLXdvcmtlci5odG1sIFsgUGFzcyBDcmFzaCBdCiAKIHdlYmtpdC5vcmcvYi8yMjUyNTggWyBh cm02NCBdIGpzL2RvbS9Qcm9taXNlLXJlamVjdC1sYXJnZS1zdHJpbmcuaHRtbCBbIFBhc3MgRmFp bHVyZSBdCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy93ZWJydGMvcm91dGluZXMuanMgYi9MYXlv dXRUZXN0cy93ZWJydGMvcm91dGluZXMuanMKaW5kZXggM2M1ZmMzY2E0MjM5MzY5N2MxYzYxZWIz NTc1YzE2OTBlMDhjZTAwNS4uZjBiNGNhMGM0YWI5YjI1NTkzOTgzMTc1OTQ5M2M0YmJmMTBlNGEw YSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvd2VicnRjL3JvdXRpbmVzLmpzCisrKyBiL0xheW91 dFRlc3RzL3dlYnJ0Yy9yb3V0aW5lcy5qcwpAQCAtMjA3LDE1ICsyMDcsMTUgQEAgYXN5bmMgZnVu Y3Rpb24gY2hlY2tWaWRlb0JsYWNrKGV4cGVjdGVkLCBjYW52YXMsIHZpZGVvLCBlcnJvck1lc3Nh Z2UsIGNvdW50ZXIpCiAgICAgICAgIHJldHVybiBQcm9taXNlLnJlc29sdmUoKTsKIAogICAgIGlm IChjb3VudGVyID09PSB1bmRlZmluZWQpCi0gICAgICAgIGNvdW50ZXIgPSAwOwotICAgIGlmIChj b3VudGVyID4gNDAwKSB7CisgICAgICAgIGNvdW50ZXIgPSA0MDA7CisgICAgaWYgKGNvdW50ZXIg PT09IDApIHsKICAgICAgICAgaWYgKCFlcnJvck1lc3NhZ2UpCiAgICAgICAgICAgICBlcnJvck1l c3NhZ2UgPSAiY2hlY2tWaWRlb0JsYWNrIHRpbWVkIG91dCBleHBlY3RpbmcgIiArIGV4cGVjdGVk OwogICAgICAgICByZXR1cm4gUHJvbWlzZS5yZWplY3QoZXJyb3JNZXNzYWdlKTsKICAgICB9CiAK ICAgICBhd2FpdCB3YWl0Rm9yKDUwKTsKLSAgICByZXR1cm4gY2hlY2tWaWRlb0JsYWNrKGV4cGVj dGVkLCBjYW52YXMsIHZpZGVvLCBlcnJvck1lc3NhZ2UsICsrY291bnRlcik7CisgICAgcmV0dXJu IGNoZWNrVmlkZW9CbGFjayhleHBlY3RlZCwgY2FudmFzLCB2aWRlbywgZXJyb3JNZXNzYWdlLCAt LWNvdW50ZXIpOwogfQogCiBmdW5jdGlvbiBzZXRDb2RlYyhzZHAsIGNvZGVjKQpAQCAtNDI3LDQg KzQyNyw0IEBAIGZ1bmN0aW9uIGFzc2VydEltYWdlU291cmNlQ29udGFpbnNDYW52YXNUZXN0UGF0 dGVybihpbWFnZVNvdXJjZSwgcGF0dGVybk51bWJlciwKICAgICB9CiAgICAgaWYgKGRlYnVnZSkK ICAgICAgICAgZGVidWdlLnJlbW92ZUNoaWxkKGNhbnZhcyk7Ci19ClwgTm8gbmV3bGluZSBhdCBl bmQgb2YgZmlsZQorfQo=