237062 2022-02-22 15:18:29 -0800 PingLoader is failing to call completion handler in error case 2022-02-22 17:11:58 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham achristensen beidson bfulgham cdumez darin youennf oldest_to_newest 1844900 0 bfulgham 2022-02-22 15:18:29 -0800 WebKit is failing to trigger the completion handler when PingLoad handles a redirect that results in an error. <rdar://50157253> 1844902 1 452907 bfulgham 2022-02-22 15:26:24 -0800 Created attachment 452907 Patch 1844905 2 452907 cdumez 2022-02-22 15:31:26 -0800 Comment on attachment 452907 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452907&action=review > Source/WebKit/NetworkProcess/PingLoad.cpp:143 > + completionHandler({ }); Is there a reason we need to call this before the didFinish() call? Would seem more logical the other way around for me. 1844906 3 452907 bfulgham 2022-02-22 15:32:18 -0800 Comment on attachment 452907 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452907&action=review >> Source/WebKit/NetworkProcess/PingLoad.cpp:143 >> + completionHandler({ }); > > Is there a reason we need to call this before the didFinish() call? > Would seem more logical the other way around for me. I just made this call int he same place as the previous error section (immediately above). I'll change it before landing. 1844907 4 452908 bfulgham 2022-02-22 15:32:51 -0800 Created attachment 452908 Patch for landing 1844921 5 ews-feeder 2022-02-22 16:28:13 -0800 Committed r290338 (247659@main): <https://commits.webkit.org/247659@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452908. 1844951 6 darin 2022-02-22 17:11:58 -0800 Can we add some tests? 452907 2022-02-22 15:26:24 -0800 2022-02-22 15:32:49 -0800 Patch bug-237062-20220222152623.patch text/plain 1625 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwMjUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGJiY2IzNjE0ZWI5YTVlN2Fl Mzg1MGFhYWY0NDg0NmQwZjNlMWE0ZDcuLjNjOTQ5ZjVhODNjNzAzZjY5MWZkYjAyYzdlNjk3MGYz MjVkZmY4ZDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjItMDItMjIgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgUGluZ0xvYWRlciBpcyBmYWls aW5nIHRvIGNhbGwgY29tcGxldGlvbiBoYW5kbGVyIGluIGVycm9yIGNhc2UKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNzA2MgorICAgICAgICA8cmRh cjovLzUwMTU3MjUzPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFRoZSBjb21wbGV0aW9uIGhhbmRsZXIgd2FzIG5vdCBiZWluZyBjYWxsZWQgaW4gdGhl IGNhc2Ugb2YgYSBQaW5nTG9hZCBiZWluZyByZWRpcmVjdGVkIHRvCisgICAgICAgIGEgbm9uLUhU VFAoUykgc2NoZW1lLgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvUGluZ0xvYWQuY3BwOgor ICAgICAgICAoV2ViS2l0OjpQaW5nTG9hZDo6d2lsbFBlcmZvcm1IVFRQUmVkaXJlY3Rpb24pOgor CiAyMDIyLTAyLTIxICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KIAogICAg ICAgICBbbWFjT1NdIFJlbW92ZSByZXNvdXJjZSBhY2Nlc3MgaW4gc2FuZGJveCBmb3Igb2xkZXIg T1MgdmVyc2lvbnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvUGlu Z0xvYWQuY3BwIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9QaW5nTG9hZC5jcHAKaW5k ZXggZGI5MTQwZjFiNTBmNGQ0NDQ1NjRlNzhhZThlNjA5Mjg1ZTVkZmQ1OS4uYzI1ZmYwMWVhYTc4 MWQ4MmQ0YmVkYWYxOTBkMDA0YzcwMzg0ZTNjNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9O ZXR3b3JrUHJvY2Vzcy9QaW5nTG9hZC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJv Y2Vzcy9QaW5nTG9hZC5jcHAKQEAgLTE0MCw2ICsxNDAsNyBAQCB2b2lkIFBpbmdMb2FkOjp3aWxs UGVyZm9ybUhUVFBSZWRpcmVjdGlvbihSZXNvdXJjZVJlc3BvbnNlJiYgcmVkaXJlY3RSZXNwb25z ZSwgUgogICAgICAgICB9CiAgICAgICAgIGF1dG8gcmVxdWVzdCA9IFdURk1vdmUocmVzdWx0LT5y ZWRpcmVjdFJlcXVlc3QpOwogICAgICAgICBpZiAoIXJlcXVlc3QudXJsKCkucHJvdG9jb2xJc0lu SFRUUEZhbWlseSgpKSB7CisgICAgICAgICAgICBjb21wbGV0aW9uSGFuZGxlcih7IH0pOwogICAg ICAgICAgICAgdGhpcy0+ZGlkRmluaXNoKFJlc291cmNlRXJyb3IgeyBTdHJpbmcgeyB9LCAwLCBy ZXF1ZXN0LnVybCgpLCAiUmVkaXJlY3Rpb24gdG8gVVJMIHdpdGggYSBzY2hlbWUgdGhhdCBpcyBu b3QgSFRUUChTKSJfcywgUmVzb3VyY2VFcnJvcjo6VHlwZTo6QWNjZXNzQ29udHJvbCB9KTsKICAg ICAgICAgICAgIHJldHVybjsKICAgICAgICAgfQo= 452908 2022-02-22 15:32:51 -0800 2022-02-22 16:28:15 -0800 Patch for landing bug-237062-20220222153250.patch text/plain 2006 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwMjUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGJiY2IzNjE0ZWI5YTVlN2Fl Mzg1MGFhYWY0NDg0NmQwZjNlMWE0ZDcuLmQ1YWE5MGFhMTU5YThhYTNjZGY1NDY3OTY3OWU1MWU0 ZDdlYjk4NjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjItMDItMjIgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgUGluZ0xvYWRlciBpcyBmYWls aW5nIHRvIGNhbGwgY29tcGxldGlvbiBoYW5kbGVyIGluIGVycm9yIGNhc2UKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNzA2MgorICAgICAgICA8cmRh cjovLzUwMTU3MjUzPgorCisgICAgICAgIFJldmlld2VkIGJ5IENocmlzIER1bWV6LgorCisgICAg ICAgIFRoZSBjb21wbGV0aW9uIGhhbmRsZXIgd2FzIG5vdCBiZWluZyBjYWxsZWQgaW4gdGhlIGNh c2Ugb2YgYSBQaW5nTG9hZCBiZWluZyByZWRpcmVjdGVkIHRvCisgICAgICAgIGEgbm9uLUhUVFAo Uykgc2NoZW1lLgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvUGluZ0xvYWQuY3BwOgorICAg ICAgICAoV2ViS2l0OjpQaW5nTG9hZDo6d2lsbFBlcmZvcm1IVFRQUmVkaXJlY3Rpb24pOgorCiAy MDIyLTAyLTIxICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KIAogICAgICAg ICBbbWFjT1NdIFJlbW92ZSByZXNvdXJjZSBhY2Nlc3MgaW4gc2FuZGJveCBmb3Igb2xkZXIgT1Mg dmVyc2lvbnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvUGluZ0xv YWQuY3BwIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9QaW5nTG9hZC5jcHAKaW5kZXgg ZGI5MTQwZjFiNTBmNGQ0NDQ1NjRlNzhhZThlNjA5Mjg1ZTVkZmQ1OS4uYzEzMzdhZjg1ZTc1M2Fk MTAwMzQwN2U3M2MxNDZjOGViMzA2MDc2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3 b3JrUHJvY2Vzcy9QaW5nTG9hZC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vz cy9QaW5nTG9hZC5jcHAKQEAgLTEzNCwxMyArMTM0LDE0IEBAIHZvaWQgUGluZ0xvYWQ6OndpbGxQ ZXJmb3JtSFRUUFJlZGlyZWN0aW9uKFJlc291cmNlUmVzcG9uc2UmJiByZWRpcmVjdFJlc3BvbnNl LCBSCiB7CiAgICAgbV9uZXR3b3JrTG9hZENoZWNrZXItPmNoZWNrUmVkaXJlY3Rpb24oUmVzb3Vy Y2VSZXF1ZXN0IHsgfSwgV1RGTW92ZShyZXF1ZXN0KSwgV1RGTW92ZShyZWRpcmVjdFJlc3BvbnNl KSwgbnVsbHB0ciwgW3RoaXMsIGNvbXBsZXRpb25IYW5kbGVyID0gV1RGTW92ZShjb21wbGV0aW9u SGFuZGxlcildIChhdXRvJiYgcmVzdWx0KSBtdXRhYmxlIHsKICAgICAgICAgaWYgKCFyZXN1bHQu aGFzX3ZhbHVlKCkpIHsKLSAgICAgICAgICAgIGNvbXBsZXRpb25IYW5kbGVyKHsgfSk7CiAgICAg ICAgICAgICB0aGlzLT5kaWRGaW5pc2gocmVzdWx0LmVycm9yKCkpOworICAgICAgICAgICAgY29t cGxldGlvbkhhbmRsZXIoeyB9KTsKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgfQogICAg ICAgICBhdXRvIHJlcXVlc3QgPSBXVEZNb3ZlKHJlc3VsdC0+cmVkaXJlY3RSZXF1ZXN0KTsKICAg ICAgICAgaWYgKCFyZXF1ZXN0LnVybCgpLnByb3RvY29sSXNJbkhUVFBGYW1pbHkoKSkgewogICAg ICAgICAgICAgdGhpcy0+ZGlkRmluaXNoKFJlc291cmNlRXJyb3IgeyBTdHJpbmcgeyB9LCAwLCBy ZXF1ZXN0LnVybCgpLCAiUmVkaXJlY3Rpb24gdG8gVVJMIHdpdGggYSBzY2hlbWUgdGhhdCBpcyBu b3QgSFRUUChTKSJfcywgUmVzb3VyY2VFcnJvcjo6VHlwZTo6QWNjZXNzQ29udHJvbCB9KTsKKyAg ICAgICAgICAgIGNvbXBsZXRpb25IYW5kbGVyKHsgfSk7CiAgICAgICAgICAgICByZXR1cm47CiAg ICAgICAgIH0KIAo=