237056 2022-02-22 13:35:55 -0800 git-webkit pr tried to create another commit from local changes on current branch 2022-03-01 13:36:20 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified ASSIGNED InRadar P2 Normal --- 1 aakash_jain jbedard aakash_jain ap jbedard ryanhaddad webkit-bug-importer oldest_to_newest 1844855 0 aakash_jain 2022-02-22 13:35:55 -0800 I was on a branch, made a commit to it. I also had some local changes in other files. When I run git-webkit pr command, it automatically tried to create another commit from local changes. This might be unexpected for users, especially when they explicitly committed what they wanted to commit/push. Coupled with the fact that git-webkit pr doesn't show any preview before creating the PR, this might not be a good idea. git-webkit pr shouldn't try to automatically commit local changes when user is on a branch and there is already a commit by the user on that branch. Either errroring out or asking the user if he/she wants to create a commit from local changes is better. 1844864 1 jbedard 2022-02-22 13:53:44 -0800 This is deliberate behavior, and aligns with what `webkit-patch` does. No particularly hard to change, but we need a larger discussion because my understand is that folks migrating from SVN largely find this behavior desirable. 1847171 2 webkit-bug-importer 2022-03-01 13:36:20 -0800 <rdar://problem/89638850>