237021 2022-02-22 00:00:22 -0800 http/wpt/mediarecorder/mute-tracks.html fails with WebRTCRemoteVideoFrameEnabled=true 2022-02-22 08:07:30 -0800 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 236969 1 youennf youennf eric.carlson ews-watchlist glenn jer.noble kkinnunen philipj sergio webkit-bug-importer youennf oldest_to_newest 1844574 0 youennf 2022-02-22 00:00:22 -0800 http/wpt/mediarecorder/mute-tracks.html fails with WebRTCRemoteVideoFrameEnabled=true 1844576 1 452833 youennf 2022-02-22 00:06:50 -0800 Created attachment 452833 Patch 1844597 2 452833 kkinnunen 2022-02-22 01:27:33 -0800 Comment on attachment 452833 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452833&action=review > Source/WebKit/WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp:99 > // FIXME: We could optimize sending black frames by only sending width/height. I think it'd be the time to address the fixme. Sending dummy pixels of possibly invalid size.. 1844599 3 youennf 2022-02-22 01:38:58 -0800 (In reply to Kimmo Kinnunen from comment #2) > Comment on attachment 452833 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=452833&action=review > > > Source/WebKit/WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp:99 > > // FIXME: We could optimize sending black frames by only sending width/height. > > I think it'd be the time to address the fixme. Sending dummy pixels of > possibly invalid size.. Yes, I have a local patch that does that through a new SharedVideoFrame that will replace RemoteVideoSample. As of the size, when the track is muted, the spec is very light on whether we should respect the size of the frame or not. Currently, we stick to using the same size over and over, which is probably the safest option. 1844709 4 ews-feeder 2022-02-22 08:06:55 -0800 Committed r290307 (247630@main): <https://commits.webkit.org/247630@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452833. 1844711 5 webkit-bug-importer 2022-02-22 08:07:30 -0800 <rdar://problem/89294409> 452833 2022-02-22 00:06:50 -0800 2022-02-22 08:06:57 -0800 Patch bug-237021-20220222090648.patch text/plain 5543 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwMjkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDNkNWY1YTRjYWMzOTgxYmZi MzY1MzViZDg1OGUyNWUwYThjMmM1NzkuLjRkMzgyMDY5YzA4NTMzMGE5OWJjNjI5Y2RhNTE0ZDNl YzlhYjMzYWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMjItMDItMjIgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIGh0dHAvd3B0L21lZGlhcmVjb3Jk ZXIvbXV0ZS10cmFja3MuaHRtbCBmYWlscyB3aXRoIFdlYlJUQ1JlbW90ZVZpZGVvRnJhbWVFbmFi bGVkPXRydWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIzNzAyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFdlIHdlcmUgcHJldmlvdXNseSBjcmVhdGluZyB0aGUgYmxhY2sgZnJhbWUgYnV0IHN0aWxsIHNl bmRpbmcgdGhlIHJlbW90ZSByZWFkIHJlZmVyZW5jZS4KKyAgICAgICAgT24gR1BVUHJvY2VzcyBz aWRlLCB3ZSB3ZXJlIHRoZW4gZW5jb2RpbmcgdGhlIHJlYWwgZnJhbWUgaW5zdGVhZCBvZiB0aGUg YmxhY2svbXV0ZWQgZnJhbWUuCisgICAgICAgIEFkZCBhIHNwZWNpZmljIG11dGVkIGNvZGUgcGF0 aCB0byBmaXggdGhlIGlzc3VlLgorCisgICAgICAgIENvdmVyZWQgYnkgdXBkYXRlZCB0ZXN0Lgor CisgICAgICAgICogV2ViUHJvY2Vzcy9HUFUvd2VicnRjL01lZGlhUmVjb3JkZXJQcml2YXRlLmNw cDoKKyAgICAgICAgKFdlYktpdDo6TWVkaWFSZWNvcmRlclByaXZhdGU6OnZpZGVvU2FtcGxlQXZh aWxhYmxlKToKKyAgICAgICAgKiBXZWJQcm9jZXNzL0dQVS93ZWJydGMvU2hhcmVkVmlkZW9GcmFt ZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OlNoYXJlZFZpZGVvRnJhbWVSZWFkZXI6OnJlYWQpOgor CiAyMDIyLTAyLTIxICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgQWxsb3cgYWRhdHRyaWJ1dGlvbmQgdG8gc3RhcnQgb24gaU9TIGRldmljZXMK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9HUFUvd2VicnRjL01lZGlhUmVj b3JkZXJQcml2YXRlLmNwcCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9HUFUvd2VicnRjL01l ZGlhUmVjb3JkZXJQcml2YXRlLmNwcAppbmRleCBlYTQxNDI1NmJmMGJlY2ExNzExYTE1ZjQwZDQx YTZkNWZjNmMyODMwLi40M2RkNGZjZjEyOTg2NzZiMWYyYjZmZjIwNTIzYWM3ZTQ5ZjQyZGNlIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvR1BVL3dlYnJ0Yy9NZWRpYVJlY29y ZGVyUHJpdmF0ZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0dQVS93ZWJydGMv TWVkaWFSZWNvcmRlclByaXZhdGUuY3BwCkBAIC05NSwzMSArOTUsMzMgQEAgTWVkaWFSZWNvcmRl clByaXZhdGU6On5NZWRpYVJlY29yZGVyUHJpdmF0ZSgpCiAKIHZvaWQgTWVkaWFSZWNvcmRlclBy aXZhdGU6OnZpZGVvU2FtcGxlQXZhaWxhYmxlKE1lZGlhU2FtcGxlJiBzYW1wbGUsIFZpZGVvU2Ft cGxlTWV0YWRhdGEpCiB7Ci0gICAgc3RkOjpvcHRpb25hbDxSZW1vdGVWaWRlb0ZyYW1lUmVhZFJl ZmVyZW5jZT4gcmVtb3RlVmlkZW9GcmFtZVJlYWRSZWZlcmVuY2U7Ci0gICAgc3RkOjp1bmlxdWVf cHRyPFJlbW90ZVZpZGVvU2FtcGxlPiByZW1vdGVTYW1wbGU7CiAgICAgaWYgKHNob3VsZE11dGVW aWRlbygpKSB7CiAgICAgICAgIC8vIEZJWE1FOiBXZSBjb3VsZCBvcHRpbWl6ZSBzZW5kaW5nIGJs YWNrIGZyYW1lcyBieSBvbmx5IHNlbmRpbmcgd2lkdGgvaGVpZ2h0LgogICAgICAgICBpZiAoIW1f YmxhY2tGcmFtZSkgewogICAgICAgICAgICAgYXV0byBzaXplID0gc2FtcGxlLnByZXNlbnRhdGlv blNpemUoKTsKICAgICAgICAgICAgIG1fYmxhY2tGcmFtZSA9IGNyZWF0ZUJsYWNrUGl4ZWxCdWZm ZXIoc3RhdGljX2Nhc3Q8c2l6ZV90PihzaXplLndpZHRoKCkpLCBzdGF0aWNfY2FzdDxzaXplX3Q+ KHNpemUuaGVpZ2h0KCkpKTsKICAgICAgICAgfQotICAgICAgICByZW1vdGVTYW1wbGUgPSBSZW1v dGVWaWRlb1NhbXBsZTo6Y3JlYXRlKG1fYmxhY2tGcmFtZS5nZXQoKSwgc2FtcGxlLnByZXNlbnRh dGlvblRpbWUoKSwgc2FtcGxlLnZpZGVvUm90YXRpb24oKSwgUmVtb3RlVmlkZW9TYW1wbGU6OlNo b3VsZENoZWNrRm9ySU9TdXJmYWNlOjpObyk7Ci0gICAgfSBlbHNlIHsKLSAgICAgICAgbV9ibGFj a0ZyYW1lID0gbnVsbHB0cjsKLQotICAgICAgICBpZiAoaXM8UmVtb3RlVmlkZW9GcmFtZVByb3h5 PihzYW1wbGUpKSB7Ci0gICAgICAgICAgICByZW1vdGVWaWRlb0ZyYW1lUmVhZFJlZmVyZW5jZSA9 IGRvd25jYXN0PFJlbW90ZVZpZGVvRnJhbWVQcm94eT4oc2FtcGxlKS5yZWFkKCk7Ci0gICAgICAg ICAgICByZW1vdGVTYW1wbGUgPSBSZW1vdGVWaWRlb1NhbXBsZTo6Y3JlYXRlKG51bGxwdHIsIHNh bXBsZS5wcmVzZW50YXRpb25UaW1lKCksIHNhbXBsZS52aWRlb1JvdGF0aW9uKCksIFJlbW90ZVZp ZGVvU2FtcGxlOjpTaG91bGRDaGVja0ZvcklPU3VyZmFjZTo6Tm8pOwotICAgICAgICB9IGVsc2UK LSAgICAgICAgICAgIHJlbW90ZVNhbXBsZSA9IFJlbW90ZVZpZGVvU2FtcGxlOjpjcmVhdGUoc2Ft cGxlLCBSZW1vdGVWaWRlb1NhbXBsZTo6U2hvdWxkQ2hlY2tGb3JJT1N1cmZhY2U6Ok5vKTsKKyAg ICAgICAgYXV0byByZW1vdGVTYW1wbGUgPSBSZW1vdGVWaWRlb1NhbXBsZTo6Y3JlYXRlKG1fYmxh Y2tGcmFtZS5nZXQoKSwgc2FtcGxlLnByZXNlbnRhdGlvblRpbWUoKSwgc2FtcGxlLnZpZGVvUm90 YXRpb24oKSwgUmVtb3RlVmlkZW9TYW1wbGU6OlNob3VsZENoZWNrRm9ySU9TdXJmYWNlOjpObyk7 CisgICAgICAgIGlmICghY29weVNoYXJlZFZpZGVvRnJhbWUocmVtb3RlU2FtcGxlLT5pbWFnZUJ1 ZmZlcigpKSkKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgbV9jb25uZWN0aW9uLT5zZW5k KE1lc3NhZ2VzOjpSZW1vdGVNZWRpYVJlY29yZGVyOjpWaWRlb1NhbXBsZUF2YWlsYWJsZSB7IFdU Rk1vdmUoKnJlbW90ZVNhbXBsZSksIHsgfSB9LCBtX2lkZW50aWZpZXIpOworICAgICAgICByZXR1 cm47CiAgICAgfQogCi0gICAgaWYgKGlzPFJlbW90ZVZpZGVvRnJhbWVQcm94eT4oc2FtcGxlKSkK KyAgICBtX2JsYWNrRnJhbWUgPSBudWxscHRyOworCisgICAgc3RkOjpvcHRpb25hbDxSZW1vdGVW aWRlb0ZyYW1lUmVhZFJlZmVyZW5jZT4gcmVtb3RlVmlkZW9GcmFtZVJlYWRSZWZlcmVuY2U7Cisg ICAgc3RkOjp1bmlxdWVfcHRyPFJlbW90ZVZpZGVvU2FtcGxlPiByZW1vdGVTYW1wbGU7CisgICAg aWYgKGlzPFJlbW90ZVZpZGVvRnJhbWVQcm94eT4oc2FtcGxlKSkgewogICAgICAgICByZW1vdGVW aWRlb0ZyYW1lUmVhZFJlZmVyZW5jZSA9IGRvd25jYXN0PFJlbW90ZVZpZGVvRnJhbWVQcm94eT4o c2FtcGxlKS5yZWFkKCk7Ci0gICAgZWxzZSBpZiAoIXJlbW90ZVNhbXBsZS0+c3VyZmFjZSgpKSB7 Ci0gICAgICAgIC8vIGJ1ZmZlciBpcyBub3QgSU9TdXJmYWNlLCB3ZSBuZWVkIHRvIGNvcHkgdG8g c2hhcmVkIHZpZGVvIGZyYW1lLgotICAgICAgICBpZiAoIWNvcHlTaGFyZWRWaWRlb0ZyYW1lKHJl bW90ZVNhbXBsZS0+aW1hZ2VCdWZmZXIoKSkpCi0gICAgICAgICAgICByZXR1cm47CisgICAgICAg IHJlbW90ZVNhbXBsZSA9IFJlbW90ZVZpZGVvU2FtcGxlOjpjcmVhdGUobnVsbHB0ciwgc2FtcGxl LnByZXNlbnRhdGlvblRpbWUoKSwgc2FtcGxlLnZpZGVvUm90YXRpb24oKSwgUmVtb3RlVmlkZW9T YW1wbGU6OlNob3VsZENoZWNrRm9ySU9TdXJmYWNlOjpObyk7CisgICAgfSBlbHNlIHsKKyAgICAg ICAgcmVtb3RlU2FtcGxlID0gUmVtb3RlVmlkZW9TYW1wbGU6OmNyZWF0ZShzYW1wbGUsIFJlbW90 ZVZpZGVvU2FtcGxlOjpTaG91bGRDaGVja0ZvcklPU3VyZmFjZTo6Tm8pOworICAgICAgICBpZiAo IXJlbW90ZVNhbXBsZS0+c3VyZmFjZSgpKSB7CisgICAgICAgICAgICAvLyBidWZmZXIgaXMgbm90 IElPU3VyZmFjZSwgd2UgbmVlZCB0byBjb3B5IHRvIHNoYXJlZCB2aWRlbyBmcmFtZS4KKyAgICAg ICAgICAgIGlmICghY29weVNoYXJlZFZpZGVvRnJhbWUocmVtb3RlU2FtcGxlLT5pbWFnZUJ1ZmZl cigpKSkKKyAgICAgICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0KICAgICB9CiAKICAgICBt X2Nvbm5lY3Rpb24tPnNlbmQoTWVzc2FnZXM6OlJlbW90ZU1lZGlhUmVjb3JkZXI6OlZpZGVvU2Ft cGxlQXZhaWxhYmxlIHsgV1RGTW92ZSgqcmVtb3RlU2FtcGxlKSwgcmVtb3RlVmlkZW9GcmFtZVJl YWRSZWZlcmVuY2UgfSwgbV9pZGVudGlmaWVyKTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0No YW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBiYjFmMTkxNjVmMWMyYzFiYzE3 MDIwZGYwMTBhNDdiNjVlYmZlY2VjLi41YTM2NjgzZjI1NTZjMzBlMzQxZjFiMTg1MjNjMDU4Mzc0 YjhhYTEzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMjItMDItMjIgIFlvdWVubiBGYWJsZXQg IDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIGh0dHAvd3B0L21lZGlhcmVjb3JkZXIvbXV0 ZS10cmFja3MuaHRtbCBmYWlscyB3aXRoIFdlYlJUQ1JlbW90ZVZpZGVvRnJhbWVFbmFibGVkPXRy dWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNzAy MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaHR0 cC93cHQvbWVkaWFyZWNvcmRlci9tdXRlLXRyYWNrcy5odG1sOgorCiAyMDIyLTAyLTIxICBDYW1l cm9uIE1jQ29ybWFjayAgPGhleWNhbUBhcHBsZS5jb20+CiAKICAgICAgICAgTWFrZSBpbnB1dCBl bGVtZW50IFVBIHNoYWRvdyB0cmVlIGNyZWF0aW9uIGxhenkKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL2h0dHAvd3B0L21lZGlhcmVjb3JkZXIvbXV0ZS10cmFja3MuaHRtbCBiL0xheW91dFRlc3Rz L2h0dHAvd3B0L21lZGlhcmVjb3JkZXIvbXV0ZS10cmFja3MuaHRtbAppbmRleCBlOWM3MGQzNzgy ZWIzZGZiMjEyZGIwNjkxZThkOGMwMmIxM2ZhOTE0Li43MTk0NjRhNmQ2MWUzMGNmMjdhY2MyMjdl MDQ3NGJjYWFlZGY0NjllIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9odHRwL3dwdC9tZWRpYXJl Y29yZGVyL211dGUtdHJhY2tzLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC93cHQvbWVkaWFy ZWNvcmRlci9tdXRlLXRyYWNrcy5odG1sCkBAIC0xLDQgKzEsNCBAQAotPCFET0NUWVBFIGh0bWw+ Cis8IWRvY3R5cGUgaHRtbD48IS0tIHdlYmtpdC10ZXN0LXJ1bm5lciBbIFdlYlJUQ1JlbW90ZVZp ZGVvRnJhbWVFbmFibGVkPXRydWUgXSAtLT4KIDxodG1sPgogPGhlYWQ+CiAgICAgPG1ldGEgY2hh cnNldD0idXRmLTgiPgo=