23701 2009-02-02 20:40:12 -0800 wxWebKit build script gets incomplete arguments 2009-02-03 16:39:43 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 mr.diggilin webkit-unassigned oldest_to_newest 108079 0 mr.diggilin 2009-02-02 20:40:12 -0800 Not all needed arguments are passed on to the wxWebKit build script. The method of passing arguments is also not very intuitive. 108081 1 27275 mr.diggilin 2009-02-02 20:44:39 -0800 Created attachment 27275 Fixes bug In order to fix this bug, a slight adjustment was made to the checkForArgumentAndRemoveFromARGV() function in webkitdirs.pm. See changelog for details. 108125 2 27275 darin 2009-02-03 09:29:27 -0800 Comment on attachment 27275 Fixes bug Looks fine, r=me 108203 3 kevino 2009-02-03 16:39:43 -0800 Landed in r40556, thanks! 27275 2009-02-02 20:44:39 -0800 2009-02-03 09:29:27 -0800 Fixes bug wx-args.diff text/plain 2527 mr.diggilin SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDQwNTE2KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMDItMDIgIG1pZ2dpbGluICA8bXIuZGln Z2lsaW5AZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIENoYW5nZSB0aGUgd2F5IHd4V2lkZ2V0cyBidWlsZCBnZXRzIGFyZ3VtZW50cy4K KyAgICAgICAgQ2hhbmdlICJjaGVja0ZvckFyZ3VtZW50QW5kUmVtb3ZlRnJvbUFSR1YiIGluIGJ1 aWxkLXdlYmtpdCB0byBjaGVjayBpZiB0aGUKKyAgICAgICAgYXJndW1lbnQgcGFzc2VkIG1hdGNo ZXMgb25lIGluIEFSR1YgZXhhY3RseSAoYWxsb3dzLCBpZSwgLS13eC1hcmdzIG5vdCB0byBiZQor ICAgICAgICByZW1vdmVkIHdoZW4gLS13eCBpcyBjaGVja2VkIGZvcikuCisKKyAgICAgICAgKiBT Y3JpcHRzL2J1aWxkLXdlYmtpdDoKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdGRpcnMucG06CisK IDIwMDktMDEtMzAgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBPbGl2ZXIgSHVudC4KSW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMv YnVpbGQtd2Via2l0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL1NjcmlwdHMvYnVpbGQtd2Vi a2l0CShyZXZpc2lvbiA0MDE5NikKKysrIFdlYktpdFRvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0 CSh3b3JraW5nIGNvcHkpCkBAIC0xMjUsMTMgKzEyNSwxMCBAQAogCiAjIEZJWE1FOiBNaWdyYXRl IGJ1aWxkLXd4d2Via2l0IGNvbW1hbmRzIGludG8gYnVpbGQtd2Via2l0LgogaWYgKGlzV3goKSkg ewotICAgIG15IEBvcHRzID0gKCk7CiAgICAgJEVOVnsiV0VCS0lUT1VUUFVURElSIn0gPSBwcm9k dWN0RGlyKCk7Ci0gICAgZm9yZWFjaCAoQEFSR1YpIHsKLSAgICAgICAgaWYgKCRfIGVxICJ3eGdj IiB8fCAkXyBlcSAid3hweXRob24iKSB7Ci0gICAgICAgICAgICBwdXNoKEBvcHRzLCAkXyk7Ci0g ICAgICAgIH0KLSAgICB9CisKKyAgICBteSBAb3B0cyA9IGdldFd4QXJncygpOworCiAgICAgaWYg KCRjbGVhbikgewogICAgICAgICBwdXNoKEBvcHRzLCAiY2xlYW4iKTsKICAgICB9CkluZGV4OiBX ZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0VG9v bHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCShyZXZpc2lvbiA0MDE5NikKKysrIFdlYktpdFRvb2xz L1NjcmlwdHMvd2Via2l0ZGlycy5wbQkod29ya2luZyBjb3B5KQpAQCAtNTYsNiArNTYsNyBAQAog bXkgJGlzUXQ7CiBteSAkaXNHdGs7CiBteSAkaXNXeDsKK215IEB3eEFyZ3M7CiBteSAkaXNDaHJv bWl1bTsKIG15ICRmb3JjZVJ1bjY0Qml0OwogCkBAIC01MjUsOCArNTI2LDggQEAKIHsKICAgICBt eSAkYXJnVG9DaGVjayA9IHNoaWZ0OwogICAgIGZvcmVhY2ggbXkgJG9wdCAoQEFSR1YpIHsKLSAg ICAgICAgaWYgKCRvcHQgPX4gL14kYXJnVG9DaGVjay9pICkgewotICAgICAgICAgICAgQEFSR1Yg PSBncmVwKCEvXiRhcmdUb0NoZWNrL2ksIEBBUkdWKTsKKyAgICAgICAgaWYgKCRvcHQgPX4gL14k YXJnVG9DaGVjayQvaSApIHsKKyAgICAgICAgICAgIEBBUkdWID0gZ3JlcCghL14kYXJnVG9DaGVj ayQvaSwgQEFSR1YpOwogICAgICAgICAgICAgcmV0dXJuIDE7CiAgICAgICAgIH0KICAgICB9CkBA IC01NzYsNiArNTc3LDIzIEBACiAgICAgJGlzV3ggPSBjaGVja0ZvckFyZ3VtZW50QW5kUmVtb3Zl RnJvbUFSR1YoIi0td3giKTsKIH0KIAorc3ViIGdldFd4QXJncygpCit7CisgICAgaWYgKCFAd3hB cmdzKSB7CisgICAgICAgIEB3eEFyZ3MgPSAoIiIpOworICAgICAgICBteSAkcmF3V3hBcmdzID0g IiI7CisgICAgICAgIGZvcmVhY2ggbXkgJG9wdCAoQEFSR1YpIHsKKyAgICAgICAgICAgIGlmICgk b3B0ID1+IC9eLS13eC1hcmdzL2kgKSB7CisgICAgICAgICAgICAgICAgQEFSR1YgPSBncmVwKCEv Xi0td3gtYXJncy9pLCBAQVJHVik7CisgICAgICAgICAgICAgICAgJHJhd1d4QXJncyA9ICRvcHQ7 CisgICAgICAgICAgICAgICAgJHJhd1d4QXJncyA9fiBzLy0td3gtYXJncz0vL2k7CisgICAgICAg ICAgICB9CisgICAgICAgIH0KKyAgICAgICAgQHd4QXJncyA9IHNwbGl0KC8sLywgJHJhd1d4QXJn cyk7CisgICAgfQorICAgIHJldHVybiBAd3hBcmdzOworfQorCiAjIERldGVybWluZSBpZiB0aGlz IGlzIGRlYmlhbiwgdWJ1bnR1LCBsaW5zcGlyZSwgb3Igc29tZXRoaW5nIHNpbWlsYXIuCiBzdWIg aXNEZWJpYW5CYXNlZCgpCiB7Cg==